scripty: Look for helper scripts in the current script's parent directory
Needs RevisionPublic

Authored by aspotashev on Nov 16 2019, 5:58 AM.

Details

Summary

Should allow us to move update_translations and its helper scripts to another directory.

Test Plan

Partially tested locally.

After this is merged and Scripty nightly run is complete, we should check the logs at https://logs.l10n.kde.org/ for potential errors.

Diff Detail

Repository
R883 Subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped
aspotashev requested review of this revision.Nov 16 2019, 5:58 AM
aspotashev created this revision.
aspotashev added a comment.EditedNov 16 2019, 6:28 AM

There is still a problem with referencing the subdirs file from non-standard directories. I will fix that in another iteration because SVN reviews are nightmare, let me merge this one first.

I think we.may.want to.move scripty to git first and start using proper branches, maybe unifying at least the various kf5 code. @nalvarez, did yiu have some time to look at T4803?

I would like to merge this before migrating to Git to minimize the transition period, see https://phabricator.kde.org/T4803#208462

I disagree with this approach (see the other task).

I think we.may.want to.move scripty to git first and start using proper branches, maybe unifying at least the various kf5 code. @nalvarez, did yiu have some time to look at T4803?

Migration to git is still not moving forward. Can I please commit this patch to SVN?

It only means that we need to plan the migration ourselves.

pino requested changes to this revision.Dec 8 2019, 4:48 PM
pino added a subscriber: pino.

There are various issues here:

  • we are touching even branches that are dead or in maintenance mode, which means an high risk of issues
  • the same 4 lines of patterns is repeated over and over
  • the way to get the directory of a script is overly verbose, using realpath is way easier/faster...

Even considered the above, what is the actual use case for these intrusive changes?
All the scripts assume that there is a structure like:

  • l10n
    • templates
    • scripts
    • lang1
    • lang2
    • langN

so even if scripts is moved away from SVN, the simple way to move this work again is to symlink the directory with the scripts as new scripts subdirectory.

This revision now requires changes to proceed.Dec 8 2019, 4:48 PM