[KPropertiesDialog] Only show volume-related info for volumes
Needs RevisionPublic

Authored by ngraham on Oct 7 2019, 7:59 PM.

Details

Reviewers
broulik
ndavis
Group Reviewers
VDG
Frameworks
Summary

Right now volume-related information is shown on the General page for all folders that
are inside a volume. This is confusing because everything else on that page is
contextually-relevant to the actual item whose properties you're looking at.

With this patch, volume-related properties will only be shown when looking at the
properties of the root level of a mounted volume.

BUG: 412671
FIXED-IN: 5.64

Test Plan

Diff Detail

Repository
R241 KIO
Branch
only-show-volume-info-for-volumes (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17416
Build 17434: arc lint + arc unit
ngraham created this revision.Oct 7 2019, 7:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 7 2019, 7:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 7 2019, 7:59 PM

Having the free space info bar on folders was always very useful imho

It's not very accurate though. The free space is a property of the underlying volume, not the folder you happen to be looking at.

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Don't you already have the free space information in the status bar though?

Ping.

VDG opinions?

Don't you already have the free space information in the status bar though?

Isn't that supposed to be removed by default in that ominous Dolphin redesign?

ngraham added a subscriber: Zren.Oct 25 2019, 2:09 PM

Don't you already have the free space information in the status bar though?

Isn't that supposed to be removed by default in that ominous Dolphin redesign?

No, I don't think so. Also, we have open patched to add the capacity display to disk/volume items in the places panel (D21312) and in the view (D10453). @Zren, any progress on those?

ndavis accepted this revision.EditedOct 25 2019, 8:01 PM
ndavis added a subscriber: ndavis.

I agree with this change as long as there is some other way to see the used/free space for the partition that contains the folder the user is browsing through. In this case, it's the capacity bar at the bottom.

This revision is now accepted and ready to land.Oct 25 2019, 8:01 PM
pino added a subscriber: pino.Oct 25 2019, 10:08 PM

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Don't you already have the free space information in the status bar though?

In the status bar of what?

Please remember that the properties dialog is a general dialog offered by the KIO framework, and it can be used perfectly outside of dolphin. Removing pieces of information just because "dolphin has them" is not a good option, especially if you want to make KDE frameworks really friendly outside of the KDE project.

This is confusing because everything else on that page is
contextually-relevant to the actual item whose properties you're looking at.

The free space is contextually-relevant to the actual item: it is the free space available to add any content in that directory.

-1 for me, which I happen to use that from time to time.

ndavis requested changes to this revision.EditedOct 25 2019, 10:46 PM
In D24476#554110, @pino wrote:

Please remember that the properties dialog is a general dialog offered by the KIO framework, and it can be used perfectly outside of dolphin. Removing pieces of information just because "dolphin has them" is not a good option, especially if you want to make KDE frameworks really friendly outside of the KDE project.

That's a good point. Another app using KIO isn't necessarily going to have a different way to show the current amount of free space. I can see now that the KDialog file picker doesn't have another way to show the amount of free/used space.

This revision now requires changes to proceed.Oct 25 2019, 10:46 PM