[KPropertiesDialog] Only show volume-related info for volumes
Needs ReviewPublic

Authored by ngraham on Mon, Oct 7, 7:59 PM.

Details

Reviewers
broulik
Group Reviewers
VDG
Frameworks
Summary

Right now volume-related information is shown on the General page for all folders that
are inside a volume. This is confusing because everything else on that page is
contextually-relevant to the actual item whose properties you're looking at.

With this patch, volume-related properties will only be shown when looking at the
properties of the root level of a mounted volume.

BUG: 412671
FIXED-IN: 5.64

Test Plan

Diff Detail

Repository
R241 KIO
Branch
only-show-volume-info-for-volumes (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17416
Build 17434: arc lint + arc unit
ngraham created this revision.Mon, Oct 7, 7:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Oct 7, 7:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Oct 7, 7:59 PM

Having the free space info bar on folders was always very useful imho

It's not very accurate though. The free space is a property of the underlying volume, not the folder you happen to be looking at.

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount.

Don't you already have the free space information in the status bar though?