stefanocrocco (Stefano Crocco)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 19 2017, 7:46 AM (117 w, 12 h)
Availability
Available

Recent Activity

Aug 24 2019

stefanocrocco committed R226:6bfc135d063b: Fix importing cookies from KCookieServer at startup (authored by stefanocrocco).
Fix importing cookies from KCookieServer at startup
Aug 24 2019, 5:22 PM
stefanocrocco closed D23376: Fix importing cookies from KCookieServer at startup.
Aug 24 2019, 5:22 PM
stefanocrocco updated the diff for D23376: Fix importing cookies from KCookieServer at startup.

Made the requested changes. I also replaced QList with QVector for CookieUrlList.

Aug 24 2019, 2:37 PM
stefanocrocco added a comment to D23376: Fix importing cookies from KCookieServer at startup.

OK, then it's not just normalizing, but translating from the HTTP header to the internal representation. That can indeed only happens once.

Aug 24 2019, 2:34 PM
stefanocrocco added a comment to D23376: Fix importing cookies from KCookieServer at startup.

"if the domain is not empty, add a leading dot to it if it's not there" << that's a weird thing to do, if the spec says leading dots are just superfluous.

Aug 24 2019, 11:42 AM
stefanocrocco added a comment to D23376: Fix importing cookies from KCookieServer at startup.

I admit that I'm quite lost between the Qt/KDE differences, what normalization does, and what a dot in front means. Something sounds fishy if normalizing twice isn't a no-op, indeed.

Aug 24 2019, 10:21 AM
stefanocrocco committed R226:4693187a1f9a: Don't install a scheme handler for the "about" protocol (authored by stefanocrocco).
Don't install a scheme handler for the "about" protocol
Aug 24 2019, 8:33 AM
stefanocrocco closed D23370: Don't install a scheme handler for the "about" protocol.
Aug 24 2019, 8:33 AM

Aug 23 2019

stefanocrocco requested review of D23376: Fix importing cookies from KCookieServer at startup.
Aug 23 2019, 1:32 PM
stefanocrocco requested review of D23370: Don't install a scheme handler for the "about" protocol.
Aug 23 2019, 8:00 AM
stefanocrocco committed R226:9606fcd4a399: Fix detection of window ID (authored by stefanocrocco).
Fix detection of window ID
Aug 23 2019, 7:20 AM
stefanocrocco closed D23353: Fix detection of window ID.
Aug 23 2019, 7:20 AM

Aug 22 2019

stefanocrocco updated the diff for D23353: Fix detection of window ID.

Use QFlags::testFlag

Aug 22 2019, 4:01 PM
stefanocrocco requested review of D23353: Fix detection of window ID.
Aug 22 2019, 3:45 PM

Aug 7 2019

stefanocrocco requested review of D22985: Use origin from filterCookie as cookie URL if possible.
Aug 7 2019, 10:00 AM

Jul 26 2019

stefanocrocco committed R226:f9bc950d257f: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 (authored by stefanocrocco).
Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12
Jul 26 2019, 8:03 AM
stefanocrocco closed D22736: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 When compiling Konqueror on versions of Qt before 5.12, the WebEnginePartHtmlEmbedder class is needed to embed local contents in pages generated by....
Jul 26 2019, 8:03 AM

Jul 25 2019

stefanocrocco requested review of D22736: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 When compiling Konqueror on versions of Qt before 5.12, the WebEnginePartHtmlEmbedder class is needed to embed local contents in pages generated by....
Jul 25 2019, 9:47 AM

Jul 14 2019

stefanocrocco committed R226:2877586b0c13: Fix removal of cookies without a Domain field (authored by stefanocrocco).
Fix removal of cookies without a Domain field
Jul 14 2019, 7:21 AM
stefanocrocco closed D22366: Fix removal of cookies without a Domain field.
Jul 14 2019, 7:21 AM

Jul 13 2019

stefanocrocco updated the diff for D22366: Fix removal of cookies without a Domain field.
  • Test both if path is empty and if path is /
Jul 13 2019, 11:56 AM
stefanocrocco added inline comments to D22366: Fix removal of cookies without a Domain field.
Jul 13 2019, 11:48 AM

Jul 12 2019

stefanocrocco added inline comments to D22366: Fix removal of cookies without a Domain field.
Jul 12 2019, 8:20 AM
stefanocrocco abandoned D8768: Share cookies with KIO and improve downloads.
Jul 12 2019, 7:40 AM

Jul 10 2019

stefanocrocco requested review of D22366: Fix removal of cookies without a Domain field.
Jul 10 2019, 8:45 AM

Jul 5 2019

stefanocrocco committed R226:30995139e517: Use QWebEngineDownloadItem::page() if possible (authored by stefanocrocco).
Use QWebEngineDownloadItem::page() if possible
Jul 5 2019, 7:51 AM
stefanocrocco closed D22272: Use QWebEngineDownloadItem::page() if possible.
Jul 5 2019, 7:51 AM

Jul 4 2019

stefanocrocco requested review of D22272: Use QWebEngineDownloadItem::page() if possible.
Jul 4 2019, 2:02 PM

Jun 23 2019

stefanocrocco committed R226:9552130e654d: Register custom protocols using QWebEngineUrlScheme (authored by stefanocrocco).
Register custom protocols using QWebEngineUrlScheme
Jun 23 2019, 2:59 PM
stefanocrocco closed D21741: Register custom protocols using QWebEngineUrlScheme.
Jun 23 2019, 2:59 PM

Jun 22 2019

stefanocrocco updated the diff for D21741: Register custom protocols using QWebEngineUrlScheme.

Fixed spaces and replaced foreach with range-for as requested

Jun 22 2019, 9:29 AM

Jun 13 2019

stefanocrocco updated the diff for D21741: Register custom protocols using QWebEngineUrlScheme.
Use KProtocolInfo::defaultMimeType if availlable
Jun 13 2019, 4:07 PM

Jun 11 2019

stefanocrocco accepted D21742: Add KProtocolInfo::defaultMimetype.
Jun 11 2019, 8:28 AM · Frameworks
stefanocrocco requested review of D21741: Register custom protocols using QWebEngineUrlScheme.
Jun 11 2019, 6:21 AM

Feb 3 2019

stefanocrocco committed R226:4ff9f87b5167: Add test to check that cookies are imported from KCookieServer at creation (authored by stefanocrocco).
Add test to check that cookies are imported from KCookieServer at creation
Feb 3 2019, 6:13 PM
stefanocrocco closed D16407: Add test to check that cookies are imported from KCookieServer at creation.
Feb 3 2019, 6:13 PM

Jan 13 2019

stefanocrocco committed R226:6a024431e9aa: Fix license (authored by stefanocrocco).
Fix license
Jan 13 2019, 7:49 PM
stefanocrocco closed D18227: Fix license.
Jan 13 2019, 7:49 PM
stefanocrocco added a comment to D14233: Restore ability to view help pages from Konqueror.

I just submitted review D18227 with the license fixes. I believe I copied the license from some other Konqueror source file which uses GPL and didn't notice that WebEnginePart files use LGPL instead.

Jan 13 2019, 4:01 PM
stefanocrocco requested review of D18227: Fix license.
Jan 13 2019, 3:57 PM

Nov 11 2018

stefanocrocco updated the diff for D16407: Add test to check that cookies are imported from KCookieServer at creation.

Move currentDateTime to webenginepartcookiejar_test.cpp as requested

Nov 11 2018, 9:08 AM
stefanocrocco updated the diff for D16407: Add test to check that cookies are imported from KCookieServer at creation.
Made requested changes
Nov 11 2018, 9:01 AM
stefanocrocco added a comment to D16407: Add test to check that cookies are imported from KCookieServer at creation.

Thinking again about it, it should be easier than that: m_testCookies can be cleared from WebEnginePartCookieJar::addCookie, without even needing a conditional. addCookie is called in response to the QWebEngineCookieStore::cookieAdded signal which in tests, for reasons I haven't exactly figured out (but I believe are related to QWebEngineCookieStore::setCookie being asynchronous) is never emitted, so m_testCookies is never cleared in tests but it's cleared when using Konqueror as soon as a new cookie is received.

Nov 11 2018, 8:57 AM

Nov 4 2018

stefanocrocco added inline comments to D16407: Add test to check that cookies are imported from KCookieServer at creation.
Nov 4 2018, 10:50 AM
stefanocrocco committed R226:011fdc2e42b7: Ask the user what to do in case of a SSL certificate error (authored by stefanocrocco).
Ask the user what to do in case of a SSL certificate error
Nov 4 2018, 10:16 AM
stefanocrocco closed D16355: Ask the user what to do in case of a SSL certificate error.
Nov 4 2018, 10:16 AM

Oct 25 2018

stefanocrocco updated the diff for D16407: Add test to check that cookies are imported from KCookieServer at creation.

Fix failing tests

Oct 25 2018, 5:21 PM

Oct 24 2018

stefanocrocco requested review of D16407: Add test to check that cookies are imported from KCookieServer at creation.
Oct 24 2018, 5:23 PM

Oct 22 2018

stefanocrocco closed D16139: Fix handling of cookies without a domain.
Oct 22 2018, 1:02 PM
stefanocrocco committed R226:fb461808387d: Fix handling of cookies without a domain (authored by stefanocrocco).
Fix handling of cookies without a domain
Oct 22 2018, 1:02 PM

Oct 21 2018

stefanocrocco requested review of D16355: Ask the user what to do in case of a SSL certificate error.
Oct 21 2018, 3:14 PM

Oct 20 2018

stefanocrocco added a comment to D16139: Fix handling of cookies without a domain.

Any news about this?

Oct 20 2018, 5:14 PM

Oct 12 2018

stefanocrocco updated the diff for D16139: Fix handling of cookies without a domain.

Made corrections as requested

Oct 12 2018, 11:30 AM

Oct 11 2018

stefanocrocco requested review of D16139: Fix handling of cookies without a domain.
Oct 11 2018, 7:08 PM

Oct 4 2018

stefanocrocco committed R226:b8fc3d625998: Fix removing cookies from KCookieServer (authored by stefanocrocco).
Fix removing cookies from KCookieServer
Oct 4 2018, 6:48 PM
stefanocrocco closed D15753: Fix removing cookies from KCookieServer.
Oct 4 2018, 6:48 PM

Sep 25 2018

stefanocrocco updated the diff for D15753: Fix removing cookies from KCookieServer.

Enable removing cookies created by autotests

Sep 25 2018, 8:34 PM
stefanocrocco requested review of D15753: Fix removing cookies from KCookieServer.
Sep 25 2018, 8:32 PM

Sep 23 2018

stefanocrocco committed R226:fac5b7802d80: Add basic tests for WebEnginePartCookieJar (authored by stefanocrocco).
Add basic tests for WebEnginePartCookieJar
Sep 23 2018, 9:57 AM
stefanocrocco closed D15381: Add basic tests for WebEnginePartCookieJar.
Sep 23 2018, 9:57 AM

Sep 17 2018

stefanocrocco updated the diff for D15381: Add basic tests for WebEnginePartCookieJar.

Made some other variables const and fixed style

Sep 17 2018, 12:21 PM
stefanocrocco added inline comments to D15381: Add basic tests for WebEnginePartCookieJar.
Sep 17 2018, 12:20 PM

Sep 16 2018

stefanocrocco updated the diff for D15381: Add basic tests for WebEnginePartCookieJar.
Made local variables const whenever possible and added a test for cookies without
the secure attribute.
Sep 16 2018, 7:02 PM

Sep 11 2018

stefanocrocco updated the diff for D15381: Add basic tests for WebEnginePartCookieJar.

Attempt to avoid polluting the user's cookies. To achieve this, all cookies
created by the tests have a name starting with webenginepartcookiejartest. In
the cleanup phase, all the cookies in the KCookieServer which start with this
name are deleted.

Sep 11 2018, 12:39 PM

Sep 9 2018

stefanocrocco requested review of D15381: Add basic tests for WebEnginePartCookieJar.
Sep 9 2018, 4:23 PM

Sep 1 2018

stefanocrocco committed R226:734947aaa6b7: Replace KStatusBar with QStatusBar (authored by stefanocrocco).
Replace KStatusBar with QStatusBar
Sep 1 2018, 10:01 AM
stefanocrocco closed D15126: Replace KStatusBar with QStatusBar.
Sep 1 2018, 10:01 AM

Aug 28 2018

stefanocrocco requested review of D15126: Replace KStatusBar with QStatusBar.
Aug 28 2018, 3:01 PM

Aug 27 2018

stefanocrocco committed R226:081e99282e93: Remove KIcon from plugins (authored by stefanocrocco).
Remove KIcon from plugins
Aug 27 2018, 12:42 PM
stefanocrocco closed D15077: Remove KIcon from plugins.
Aug 27 2018, 12:42 PM

Aug 25 2018

stefanocrocco updated the diff for D15077: Remove KIcon from plugins.

Use QIcon::fromTheme instead of QIcon()

Aug 25 2018, 12:34 PM
stefanocrocco added a reviewer for D15077: Remove KIcon from plugins: dfaure.
Aug 25 2018, 11:48 AM
stefanocrocco updated the diff for D15077: Remove KIcon from plugins.

Update for latest master

Aug 25 2018, 11:46 AM
stefanocrocco requested review of D15077: Remove KIcon from plugins.
Aug 25 2018, 11:45 AM
stefanocrocco committed R226:ef847eb93b11: Remove call to hasSubUrl (authored by stefanocrocco).
Remove call to hasSubUrl
Aug 25 2018, 11:33 AM
stefanocrocco closed D15060: Remove call to hasSubUrl.
Aug 25 2018, 11:33 AM

Aug 24 2018

stefanocrocco requested review of D15060: Remove call to hasSubUrl.
Aug 24 2018, 3:30 PM
stefanocrocco committed R226:a466726fc307: Remove KUrl from autorefresh, dirfilter, domtreeview and fsview plugins (authored by stefanocrocco).
Remove KUrl from autorefresh, dirfilter, domtreeview and fsview plugins
Aug 24 2018, 7:33 AM
stefanocrocco closed D14979: Remove KUrl from autorefresh, dirfilter, domtreeview and fsview plugins.
Aug 24 2018, 7:33 AM
stefanocrocco updated the diff for D14979: Remove KUrl from autorefresh, dirfilter, domtreeview and fsview plugins.

Replace QUrl() with QUrl::fromLocalFile()

Aug 24 2018, 6:31 AM

Aug 22 2018

stefanocrocco updated the diff for D14979: Remove KUrl from autorefresh, dirfilter, domtreeview and fsview plugins.

Made the requested changes

Aug 22 2018, 9:33 AM
stefanocrocco added inline comments to D14979: Remove KUrl from autorefresh, dirfilter, domtreeview and fsview plugins.
Aug 22 2018, 9:27 AM

Aug 21 2018

stefanocrocco requested review of D14979: Remove KUrl from autorefresh, dirfilter, domtreeview and fsview plugins.
Aug 21 2018, 7:03 PM

Aug 20 2018

stefanocrocco committed R226:d784b8bb01dd: Fix the workaround for cookie expiration date in WebEnginePart (authored by stefanocrocco).
Fix the workaround for cookie expiration date in WebEnginePart
Aug 20 2018, 3:46 PM
stefanocrocco closed D14951: Fix the workaround for cookie expiration date in WebEnginePart.
Aug 20 2018, 3:46 PM
stefanocrocco requested review of D14951: Fix the workaround for cookie expiration date in WebEnginePart.
Aug 20 2018, 2:27 PM

Aug 9 2018

stefanocrocco committed R226:eed46bd49aec: Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt (authored by stefanocrocco).
Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt
Aug 9 2018, 10:18 AM
stefanocrocco closed D14704: Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt.
Aug 9 2018, 10:17 AM
stefanocrocco updated the test plan for D14704: Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt.
Aug 9 2018, 10:05 AM
stefanocrocco requested review of D14704: Don't define WebEnginePartCookieJar::filterCookie for old versions of Qt.
Aug 9 2018, 10:03 AM

Aug 7 2018

stefanocrocco committed R226:b10baef59a01: Synchronize cookies between QWebEngine and KCookieServer (authored by stefanocrocco).
Synchronize cookies between QWebEngine and KCookieServer
Aug 7 2018, 7:31 AM
stefanocrocco closed D14379: Synchronize cookies between QWebEngine and KCookieServer.
Aug 7 2018, 7:31 AM

Aug 6 2018

stefanocrocco updated the diff for D14379: Synchronize cookies between QWebEngine and KCookieServer.

Exclude dialogs when looking for a toplevel window

Aug 6 2018, 1:12 PM
stefanocrocco added inline comments to D14379: Synchronize cookies between QWebEngine and KCookieServer.
Aug 6 2018, 9:26 AM
stefanocrocco updated the diff for D14379: Synchronize cookies between QWebEngine and KCookieServer.

Fix indentation

Aug 6 2018, 9:20 AM
stefanocrocco updated the diff for D14379: Synchronize cookies between QWebEngine and KCookieServer.
  • Made the requested changes
Aug 6 2018, 9:18 AM
stefanocrocco accepted D14627: KCookieJar: fix wrong timezone conversion..
Aug 6 2018, 6:54 AM · Frameworks

Aug 5 2018

stefanocrocco committed R226:9878ba8ffef9: Fix issue with info protocol and refresh (authored by stefanocrocco).
Fix issue with info protocol and refresh
Aug 5 2018, 4:18 AM
stefanocrocco closed D14614: Fix issue with info protocol and refresh.
Aug 5 2018, 4:18 AM

Aug 4 2018

stefanocrocco added a reviewer for D14614: Fix issue with info protocol and refresh: dfaure.
Aug 4 2018, 9:19 PM