stefanocrocco (Stefano Crocco)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 19 2017, 7:46 AM (167 w, 1 d)
Availability
Available

Recent Activity

Aug 28 2020

stefanocrocco added a comment to T13545: Resurrect the Web Archiver.

I think it would be worth to put it back. I think QtWebEngine already provides support for doing something like it using QWebEnginePage::save() (even if I never tried using it), however a solution which didn't rely on a specific part would be, in my opinion, even better. I remember that when I ported the webarchiver plugin to KF5 (before switching to QtWebEngine) I wondered why it didn't use wget instead of doing all the work manually. Of course, this requires having wget installed, but I don't think it would be an issue.

Aug 28 2020, 12:45 PM · Konqueror

Jun 14 2020

stefanocrocco closed D29066: Ensure that WebEnginePart uses proxy settings from KCM.
Jun 14 2020, 1:07 PM
stefanocrocco added a comment to D29066: Ensure that WebEnginePart uses proxy settings from KCM.

@stefanocrocco Can you please confirm you have uploaded your SSH Keys to https://invent.kde.org/?
This has to be done separately to the upload on Identity (which no longer has any effect)

Jun 14 2020, 9:55 AM
stefanocrocco added a comment to D29066: Ensure that WebEnginePart uses proxy settings from KCM.

In the repo where your git push fails, what does git remote -v say?

Jun 14 2020, 9:47 AM
stefanocrocco added a comment to D29066: Ensure that WebEnginePart uses proxy settings from KCM.

David, sorry to disturb you but I'm having trouble while pushing this. I think it's related to the GitLab migration. I had to run git kclone in my local clone to pull the latest changes. Now, I can't use arc land because it complains that

Jun 14 2020, 8:46 AM

Jun 13 2020

stefanocrocco requested review of D29066: Ensure that WebEnginePart uses proxy settings from KCM.
Jun 13 2020, 4:32 PM
stefanocrocco updated the diff for D29066: Ensure that WebEnginePart uses proxy settings from KCM.
  • Improve the message text
  • Only ask about invalid proxy settings for QtWebEngine if it's the default engine
Jun 13 2020, 4:30 PM
stefanocrocco added a comment to D26253: Port the About page to QtWebEngine.

Anyway, as David says, you could just align Konqueror's Qt requirement with the stricter one from its KF5 dependencies. There is little point not to, after all. Rather spend your time getting rid of the inappropriate errors about a missing konq slave. David already explained why the konq: stuff cannot be implemented upstream from the kparts in Konqueror itself (invoking binaries), but maybe an actual KIO slave could do everything you want too while still serving standard HTML to the kparts doing the rendering?

I'll ping you if I do decide to implement konq: support in kwebkit_part and run into something similar there.
Jun 13 2020, 2:55 PM
stefanocrocco added a comment to D26253: Port the About page to QtWebEngine.
I can't really reproduce this issue. Which Qt version are you using?

I don't really expect you did a full build of Qt, the frameworks etc. into a parallel prefix like I do, or did you?

Hum, yes, I did backport the code so it builds against Qt 5.9 but

The way Konqueror has QWebEngine handle local resources has changed radically from Qt 5.12 onwards.

just how would that explain that the generated html code opens just fine when I save it to a .html file first?
I can understand you need to intercept links that require actions not implemented by the engine but why would you need to do that for CSS and image resources?

Does this radical change depend on new QtWebEngine APIs not in 5.9? I do have a Qt 5.12 build installed with a wrapper script causing my KDE builds to use that Qt version. I get the same issue then, which would be expected if my backport shoehorning missed something crucial.

BTW, when I run against Qt 5.12 I see this additional output on the terminal when I switch to the WebEngine mode:

Please register the custom scheme 'error' via QWebEngineUrlScheme::registerScheme() before installing the custom scheme handler.
Please register the custom scheme 'konq' via QWebEngineUrlScheme::registerScheme() before installing the custom scheme handler.
Please register the custom scheme 'help' via QWebEngineUrlScheme::registerScheme() before installing the custom scheme handler.
Jun 13 2020, 1:37 PM
stefanocrocco added a comment to D29066: Ensure that WebEnginePart uses proxy settings from KCM.

David, have you had time to check the changes I made to this?

Jun 13 2020, 9:23 AM
stefanocrocco added a comment to D26253: Port the About page to QtWebEngine.

This is exactly what I do:

I tried setting the default engine to WebKit, restarting Konqueror, then, from the strarting page, switching to WebEngine using the View Mode menu.

No need to do anything else. Here's the full output when I launch konqueror (with WebKit as the default engine) and then switch it to WebEngine (after the slave error message):

org.kde.kwindowsystem: Loaded plugin "/opt/local/share/qt5/plugins/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemX11Plugin.so" for platform "xcb"
kf5.kio.core: couldn't create slave: "klauncher said: Unknown protocol 'konq'.\n"
[12814:12972:0612/220936.807589:ERROR:nss_util.cc(808)] After loading Root Certs, loaded==false: NSS error code: -8018
QFSFileEngine::open: No file name specified
js: Not allowed to load local resource: file:///opt/local/share/kf5/infopage/kde_infopage.css
js: Not allowed to load local resource: file:///opt/local/share/konqueror/about/konq.css
QFSFileEngine::open: No file name specified
js: Not allowed to load local resource: file:///usr/share/icons/Ciment/32x32/places/user-home.png
js: Not allowed to load local resource: file:///usr/share/icons/osx/places/48/user-trash-full.png
js: Not allowed to load local resource: file:///usr/share/icons/osx/places/32/folder-remote.png
js: Not allowed to load local resource: file:///usr/share/icons/oxygen/32x32/places/bookmarks.png
js: Not allowed to load local resource: file:///usr/share/icons/Ciment/16x16/actions/go-next.png
QFSFileEngine::open: No file name specified
Jun 13 2020, 9:09 AM

Jun 12 2020

stefanocrocco added a comment to D26253: Port the About page to QtWebEngine.

It took me way too long to figure out that this is the source of the regression below, and not a missing "konq:" kioslave ...

For me, the main interest in Konqueror lies in its ability to use WebKit2 (with the rebooted QtWebKit version, evidently), so I can use it in a more or less modern browser interface. (There's just no need for yet another grass-roots wrapper around Chromium IMHO but that's a different issue.)

When I do activate the WebEngine backend I see this on the terminal:

js: Not allowed to load local resource: file:///opt/local/share/kf5/infopage/kde_infopage.css
js: Not allowed to load local resource: file:///opt/local/share/konqueror/about/konq.css
js: Not allowed to load local resource: file:///opt/local/share/icons/Ciment/22x22/places/user-home.png
js: Not allowed to load local resource: file:///opt/local/share/icons/osx/places/48/user-trash-full.png
js: Not allowed to load local resource: file:///opt/local/share/icons/osx/places/22/folder-remote.png
js: Not allowed to load local resource: file:///opt/local/share/icons/oxygen/base/22x22/actions/bookmarks.png
js: Not allowed to load local resource: file:///opt/local/share/icons/Ciment/16x16/actions/go-next.png

but pasting the URL into the konqueror address bar opens the files just fine.

Jun 12 2020, 5:17 PM

Apr 23 2020

stefanocrocco requested review of D29066: Ensure that WebEnginePart uses proxy settings from KCM.
Apr 23 2020, 11:43 AM
stefanocrocco updated the diff for D29066: Ensure that WebEnginePart uses proxy settings from KCM.
  • Don't attempt to use WPAD or PAC proxies
  • Offer the user the ability to immediately display the proxy settins dialog
Apr 23 2020, 11:43 AM

Apr 22 2020

stefanocrocco added a comment to D29066: Ensure that WebEnginePart uses proxy settings from KCM.

Note that KProtocolManager also supports per-host proxies (via KPAC which runs javascript). This obviously won't work here.

Apr 22 2020, 5:11 PM

Apr 21 2020

stefanocrocco requested review of D29066: Ensure that WebEnginePart uses proxy settings from KCM.
Apr 21 2020, 5:26 PM

Apr 16 2020

stefanocrocco added a comment to D19622: Use a searchbar similar to the one in okular using the webenginepart.

@stefanocrocco do you want to test this and integrate it if it works? Looks like it got rather forgotten over time.

Apr 16 2020, 6:41 PM

Apr 14 2020

stefanocrocco committed R226:b61086cfece0: Fix crash due to changes in KBookmarkMenu (authored by stefanocrocco).
Fix crash due to changes in KBookmarkMenu
Apr 14 2020, 8:54 AM
stefanocrocco closed D28789: Fix crash due to changes in KBookmarkMenu.
Apr 14 2020, 8:54 AM
stefanocrocco requested review of D28789: Fix crash due to changes in KBookmarkMenu.
Apr 14 2020, 8:25 AM
stefanocrocco updated the diff for D28789: Fix crash due to changes in KBookmarkMenu.

Only create the action collection when using KBookmarks 5.69.0

Apr 14 2020, 8:25 AM
stefanocrocco reopened D28789: Fix crash due to changes in KBookmarkMenu.
Apr 14 2020, 8:25 AM

Apr 13 2020

stefanocrocco added a comment to D28789: Fix crash due to changes in KBookmarkMenu.

git checkout release/20.04
git cherry-pick -x 078f357bc
git push
git checkout master

Apr 13 2020, 5:09 PM
stefanocrocco committed R226:ad4d6f4a2600: Fix crash due to changes in KBookmarkMenu (authored by stefanocrocco).
Fix crash due to changes in KBookmarkMenu
Apr 13 2020, 5:08 PM
stefanocrocco added a comment to D28789: Fix crash due to changes in KBookmarkMenu.

Can you push this to 20.04 too please?

Apr 13 2020, 4:42 PM
stefanocrocco committed R226:078f357bc7f3: Fix crash due to changes in KBookmarkMenu (authored by stefanocrocco).
Fix crash due to changes in KBookmarkMenu
Apr 13 2020, 12:52 PM
stefanocrocco closed D28789: Fix crash due to changes in KBookmarkMenu.
Apr 13 2020, 12:51 PM
stefanocrocco updated the diff for D28789: Fix crash due to changes in KBookmarkMenu.
  • Remove empty line
Apr 13 2020, 9:23 AM
stefanocrocco requested review of D28789: Fix crash due to changes in KBookmarkMenu.
Apr 13 2020, 9:17 AM

Feb 2 2020

stefanocrocco added a comment to D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.

I could help you with progress notifications (see KJob), but "download the file to a temporary location" is a big no no. Think of a 4GB video file...

I think I'm missing something here. Isn't this how things usually work, both in Konqueror and in other browsers? When I click on a link to a PDF file in Konqueror, the file is downloaded to a file in /tmp which is then opened. When I clicked on a link to a MPG video in Firefox, it downloaded it to a file in /tmp, then opened it with another program.

Possibly correct about Firefox, because it doesn't know better.
Wrong about Konqueror and okular. When you click on a link to a PDF in konqueror, it first determines the mimetype (application/pdf), then looks up the associated application (okularApplication_pdf.desktop), and then KRun looks into that and notices that it says Exec=okular %U, which means it supports URLs. So konqueror calls okular with the URL as argument, and okular decides how to handle this. Usually this allows the receiving application to download into memory rather than using a temp file. For apps that can edit files, like kate, this even allows saving back onto the actualy remote location (which would be unknown if the app was called with a temp file as argument). The kioexec hack (download + start app + wait for it to finish + offer to upload) is only used for apps that don't support URLs (no %u/%U in the exec line).
This isn't KDE specific, it's the freedesktop standard for application desktop files. With the problem of the supported schemes not being 100% the same, but I'm going offtopic.
For instance, xine says Exec=xine %U because it can stream from HTTP, you definitely don't want to download a huge video to a temp file before looking at the first few seconds of it.

Feb 2 2020, 4:41 PM
stefanocrocco added a comment to D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.

I could help you with progress notifications (see KJob), but "download the file to a temporary location" is a big no no. Think of a 4GB video file...

Feb 2 2020, 10:22 AM
stefanocrocco added a comment to D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.

There is one major drawback with this plan though. There were talks about deprecating kio_http for security reasons... Adding Volker as reviewer.

Wasn't the last thing we discussed rebasing kio_http on QNAM, so we can keep the unified KIO interface as well? IMHO the problem is our aging HTTP implementation, not so much the outside interface. In that case this doesn't sound incompatible to me.

The thing I find much more worrying here is the suggestion to decrypt TLS traffic in a proxy :) Does Webengine have an interface to inject custom CA certs? If not, you'd need to install this as a system CA cert, and that's a total no-go.

I'll investigate this as soon as I have some free time. Unfortunately, this week I'm quite busy, so I won't be able to do it at least until Sunday

Feb 2 2020, 10:17 AM

Jan 8 2020

stefanocrocco added a comment to D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.

There is one major drawback with this plan though. There were talks about deprecating kio_http for security reasons... Adding Volker as reviewer.

Wasn't the last thing we discussed rebasing kio_http on QNAM, so we can keep the unified KIO interface as well? IMHO the problem is our aging HTTP implementation, not so much the outside interface. In that case this doesn't sound incompatible to me.

The thing I find much more worrying here is the suggestion to decrypt TLS traffic in a proxy :) Does Webengine have an interface to inject custom CA certs? If not, you'd need to install this as a system CA cert, and that's a total no-go.

Jan 8 2020, 7:22 PM

Jan 6 2020

stefanocrocco added a comment to D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.

Thinking about how to force QtWebEngine to integrate with KIO, the only idea which comes to me is a crazy one: implement an HTTP proxy inside Konqueror and configure QtWebEngine to use it (QtWebEngine will use a proxy set with QNetworkProxy::setApplicationProxy). The proxy could retrieve the requested URL using KIO and examine the reply before passing it back to QtWebEngine. I believe it should work, even if there are several drawbacks:

  • it requires to write an HTTP proxy from scratch. I've never done anything similar, but I think it's not easy
  • I think it requires some changes in KIO. I didn't test it, but I believe currently KIO::get only returns the body of the request and not the headers. Maybe it would be possibile to add a signal which is emitted when the headers have been read, like it already does with the mimetype
  • it has to decrypt HTTPS requests coming to QtWebEngine and encrypt the replies before passing them back, but I think it could be done. I've seen the mitmproxy proxy (https://mitmproxy.org/) do it using custom certificates which you need to install manually. However, I think that in our case, since the proxy and the client really are the same program, I believe there shouldn't be the need to install the certificate.
Jan 6 2020, 9:24 AM
stefanocrocco updated the diff for D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.
  • Check whether the default HTML engine is QtWebEngine
Jan 6 2020, 9:08 AM
stefanocrocco added a comment to D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.

I have no solution for issue number 2. It's the main reason why I'm unhappy with QtWebkit being deprecated and why I'm demotivated to maintain konqueror. The ability to integrate with KIO completely disappeared.

Jan 6 2020, 9:05 AM

Jan 5 2020

stefanocrocco requested review of D26428: Rely on QtWebEngine to determine the mimetype of http(s) URLs.
Jan 5 2020, 7:52 AM

Jan 4 2020

stefanocrocco committed R226:b165ee390646: Avoid automatically displaying local URLs in WebEnginePart (authored by stefanocrocco).
Avoid automatically displaying local URLs in WebEnginePart
Jan 4 2020, 7:48 PM
stefanocrocco closed D26417: Avoid automatically displaying local URLs in WebEnginePart.
Jan 4 2020, 7:48 PM
stefanocrocco requested review of D26417: Avoid automatically displaying local URLs in WebEnginePart.
Jan 4 2020, 11:51 AM
stefanocrocco committed R226:c9fe1ffddcae: Give focus to location bar on startup (authored by stefanocrocco).
Give focus to location bar on startup
Jan 4 2020, 10:14 AM
stefanocrocco closed D26414: Give focus to location bar on startup.
Jan 4 2020, 10:14 AM
stefanocrocco requested review of D26414: Give focus to location bar on startup.
Jan 4 2020, 10:07 AM

Jan 3 2020

stefanocrocco committed R226:64f94b6b7831: Port the About page to QtWebEngine (authored by stefanocrocco).
Port the About page to QtWebEngine
Jan 3 2020, 11:52 AM
stefanocrocco closed D26253: Port the About page to QtWebEngine.
Jan 3 2020, 11:52 AM

Jan 2 2020

stefanocrocco added a comment to D26253: Port the About page to QtWebEngine.

I noticed a problem: at startup, when the konq:blank page is displayed, the focus is given to the view rather than to the location bar as it used to be. This doesn't happen if you create new tabs. It seems that KMainWindowFactory::createNewWindow gives indeed focus to the location bar, but the focus is then moved to WebEngineView. I can't find out why. Do you have any idea?

Jan 2 2020, 12:57 PM
stefanocrocco updated the diff for D26253: Port the About page to QtWebEngine.
  • Add KonqUrl::scheme function and other small fixes
Jan 2 2020, 12:50 PM

Jan 1 2020

stefanocrocco updated the diff for D26253: Port the About page to QtWebEngine.
  • Remove commented out lines
  • Centralize management of konq URLs
  • Fix the value of the StartURL option in the user's config file
Jan 1 2020, 6:16 PM
stefanocrocco added a comment to D26253: Port the About page to QtWebEngine.
The first is that if the user's konquerorrc file contains old default value for the StartURL entry, that value will be used instead of the new one, which will result in an error message.

How about this? http://www.davidfaure.fr/2020/replace_about_with_konq.diff

[rebase your changes to master first, I just pushed some cleanups]

Jan 1 2020, 6:12 PM
stefanocrocco added inline comments to D26253: Port the About page to QtWebEngine.
Jan 1 2020, 5:04 PM
stefanocrocco updated the diff for D26253: Port the About page to QtWebEngine.
  • Remove commented out lines
  • Centralize management of konq URLs
Jan 1 2020, 5:00 PM

Dec 28 2019

stefanocrocco requested review of D26253: Port the About page to QtWebEngine.
Dec 28 2019, 9:20 AM

Dec 1 2019

stefanocrocco committed R226:919076fa77a2: Restore ability to close tab by clicking on close button (authored by stefanocrocco).
Restore ability to close tab by clicking on close button
Dec 1 2019, 7:53 PM
stefanocrocco closed D25662: Restore ability to close tab by clicking on close button.
Dec 1 2019, 7:53 PM
stefanocrocco requested review of D25662: Restore ability to close tab by clicking on close button.
Dec 1 2019, 5:42 PM

Nov 3 2019

stefanocrocco committed R226:6b43d97c1cf9: Add option to enable or disable internal PDF viewer from Qt 5.13 (authored by stefanocrocco).
Add option to enable or disable internal PDF viewer from Qt 5.13
Nov 3 2019, 8:20 PM
stefanocrocco closed D25131: Add option to enable or disable internal PDF viewer from Qt 5.13.
Nov 3 2019, 8:20 PM
stefanocrocco updated the diff for D25131: Add option to enable or disable internal PDF viewer from Qt 5.13.

Keep compatibility with older versions of CMake

Nov 3 2019, 8:19 PM
stefanocrocco updated the diff for D25131: Add option to enable or disable internal PDF viewer from Qt 5.13.
  • Fix compilation with Qt before 5.13
Nov 3 2019, 6:27 PM
stefanocrocco requested review of D25131: Add option to enable or disable internal PDF viewer from Qt 5.13.
Nov 3 2019, 5:19 PM

Oct 20 2019

stefanocrocco added a comment to D24195: WebEnginePart: A new tab requested by user is not a popup.

Reindenting is fine, if needed :-)

I'm not sure what the "no part" bit is about, maybe stefanocrocco knows.

Oct 20 2019, 6:21 PM

Aug 24 2019

stefanocrocco committed R226:6bfc135d063b: Fix importing cookies from KCookieServer at startup (authored by stefanocrocco).
Fix importing cookies from KCookieServer at startup
Aug 24 2019, 5:22 PM
stefanocrocco closed D23376: Fix importing cookies from KCookieServer at startup.
Aug 24 2019, 5:22 PM
stefanocrocco updated the diff for D23376: Fix importing cookies from KCookieServer at startup.

Made the requested changes. I also replaced QList with QVector for CookieUrlList.

Aug 24 2019, 2:37 PM
stefanocrocco added a comment to D23376: Fix importing cookies from KCookieServer at startup.

OK, then it's not just normalizing, but translating from the HTTP header to the internal representation. That can indeed only happens once.

Aug 24 2019, 2:34 PM
stefanocrocco added a comment to D23376: Fix importing cookies from KCookieServer at startup.

"if the domain is not empty, add a leading dot to it if it's not there" << that's a weird thing to do, if the spec says leading dots are just superfluous.

Aug 24 2019, 11:42 AM
stefanocrocco added a comment to D23376: Fix importing cookies from KCookieServer at startup.

I admit that I'm quite lost between the Qt/KDE differences, what normalization does, and what a dot in front means. Something sounds fishy if normalizing twice isn't a no-op, indeed.

Aug 24 2019, 10:21 AM
stefanocrocco committed R226:4693187a1f9a: Don't install a scheme handler for the "about" protocol (authored by stefanocrocco).
Don't install a scheme handler for the "about" protocol
Aug 24 2019, 8:33 AM
stefanocrocco closed D23370: Don't install a scheme handler for the "about" protocol.
Aug 24 2019, 8:33 AM

Aug 23 2019

stefanocrocco requested review of D23376: Fix importing cookies from KCookieServer at startup.
Aug 23 2019, 1:32 PM
stefanocrocco requested review of D23370: Don't install a scheme handler for the "about" protocol.
Aug 23 2019, 8:00 AM
stefanocrocco committed R226:9606fcd4a399: Fix detection of window ID (authored by stefanocrocco).
Fix detection of window ID
Aug 23 2019, 7:20 AM
stefanocrocco closed D23353: Fix detection of window ID.
Aug 23 2019, 7:20 AM

Aug 22 2019

stefanocrocco updated the diff for D23353: Fix detection of window ID.

Use QFlags::testFlag

Aug 22 2019, 4:01 PM
stefanocrocco requested review of D23353: Fix detection of window ID.
Aug 22 2019, 3:45 PM

Aug 7 2019

stefanocrocco requested review of D22985: Use origin from filterCookie as cookie URL if possible.
Aug 7 2019, 10:00 AM

Jul 26 2019

stefanocrocco committed R226:f9bc950d257f: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 (authored by stefanocrocco).
Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12
Jul 26 2019, 8:03 AM
stefanocrocco closed D22736: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 When compiling Konqueror on versions of Qt before 5.12, the WebEnginePartHtmlEmbedder class is needed to embed local contents in pages generated by....
Jul 26 2019, 8:03 AM

Jul 25 2019

stefanocrocco requested review of D22736: Fix CMakeLists.txt to compile WebEnginePartHtmlEmbedder on Qt before Qt-5.12 When compiling Konqueror on versions of Qt before 5.12, the WebEnginePartHtmlEmbedder class is needed to embed local contents in pages generated by....
Jul 25 2019, 9:47 AM

Jul 14 2019

stefanocrocco committed R226:2877586b0c13: Fix removal of cookies without a Domain field (authored by stefanocrocco).
Fix removal of cookies without a Domain field
Jul 14 2019, 7:21 AM
stefanocrocco closed D22366: Fix removal of cookies without a Domain field.
Jul 14 2019, 7:21 AM

Jul 13 2019

stefanocrocco updated the diff for D22366: Fix removal of cookies without a Domain field.
  • Test both if path is empty and if path is /
Jul 13 2019, 11:56 AM
stefanocrocco added inline comments to D22366: Fix removal of cookies without a Domain field.
Jul 13 2019, 11:48 AM

Jul 12 2019

stefanocrocco added inline comments to D22366: Fix removal of cookies without a Domain field.
Jul 12 2019, 8:20 AM
stefanocrocco abandoned D8768: Share cookies with KIO and improve downloads.
Jul 12 2019, 7:40 AM

Jul 10 2019

stefanocrocco requested review of D22366: Fix removal of cookies without a Domain field.
Jul 10 2019, 8:45 AM

Jul 5 2019

stefanocrocco committed R226:30995139e517: Use QWebEngineDownloadItem::page() if possible (authored by stefanocrocco).
Use QWebEngineDownloadItem::page() if possible
Jul 5 2019, 7:51 AM
stefanocrocco closed D22272: Use QWebEngineDownloadItem::page() if possible.
Jul 5 2019, 7:51 AM

Jul 4 2019

stefanocrocco requested review of D22272: Use QWebEngineDownloadItem::page() if possible.
Jul 4 2019, 2:02 PM

Jun 23 2019

stefanocrocco committed R226:9552130e654d: Register custom protocols using QWebEngineUrlScheme (authored by stefanocrocco).
Register custom protocols using QWebEngineUrlScheme
Jun 23 2019, 2:59 PM
stefanocrocco closed D21741: Register custom protocols using QWebEngineUrlScheme.
Jun 23 2019, 2:59 PM

Jun 22 2019

stefanocrocco updated the diff for D21741: Register custom protocols using QWebEngineUrlScheme.

Fixed spaces and replaced foreach with range-for as requested

Jun 22 2019, 9:29 AM

Jun 13 2019

stefanocrocco updated the diff for D21741: Register custom protocols using QWebEngineUrlScheme.
Use KProtocolInfo::defaultMimeType if availlable
Jun 13 2019, 4:07 PM

Jun 11 2019

stefanocrocco accepted D21742: Add KProtocolInfo::defaultMimetype.
Jun 11 2019, 8:28 AM · Frameworks
stefanocrocco requested review of D21741: Register custom protocols using QWebEngineUrlScheme.
Jun 11 2019, 6:21 AM

Feb 3 2019

stefanocrocco committed R226:4ff9f87b5167: Add test to check that cookies are imported from KCookieServer at creation (authored by stefanocrocco).
Add test to check that cookies are imported from KCookieServer at creation
Feb 3 2019, 6:13 PM
stefanocrocco closed D16407: Add test to check that cookies are imported from KCookieServer at creation.
Feb 3 2019, 6:13 PM

Jan 13 2019

stefanocrocco committed R226:6a024431e9aa: Fix license (authored by stefanocrocco).
Fix license
Jan 13 2019, 7:49 PM
stefanocrocco closed D18227: Fix license.
Jan 13 2019, 7:49 PM
stefanocrocco added a comment to D14233: Restore ability to view help pages from Konqueror.

I just submitted review D18227 with the license fixes. I believe I copied the license from some other Konqueror source file which uses GPL and didn't notice that WebEnginePart files use LGPL instead.

Jan 13 2019, 4:01 PM