@davidre said something about that we don't show small thumbnails anymore anyway or something

In D29487#673803, @davidre wrote:

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

In T13145#230815, @davidre wrote:

Well right now you have that problem too that you can select both. Even worse both settings are on different sub pages. I would also happy to remove Copy file location to clipboard after saving but I'm not sure if it's an extensive used feature. To me seems unnecessary when we have automatic copy.

Works, but the notification is empty and the file doesn't get saved at all:

In D29282#673363, @abetts wrote:

In the current implementation of this, the cursor turns to the selector for the screen. The cursor does not draw a squared selection of screen where there is black outside the selection. The app crashes or closes after the screenshot is taken. This behavior happens on Fedora 32/Plasma 5.18

In the current implementation of this, the cursor turns to the selector for the screen. The cursor does not draw a squared selection of screen where there is black outside the selection. The app crashes or closes after the screenshot is taken. This behavior happens on Fedora 32/Plasma 5.18

I assume that you mean:

Action after taking a screenshot: [] Save image to default folder location
                                  [] Copy image to clipboard

What about Copy file location to clipboard after saving, would that stay in the Save settings tab?
If yes - we'd have a problem if a users sets both of the checkboxes above and has Copy file location to clipboard after saving also set.

In D29596#672772, @aprcela wrote:

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

@davidre ping :)

Spacing

I had another thought on it and think having all the functionality for both cases in one class is probably a bit too big and both use cases are actually too different. The common part that can be shared between both cases is the selectable rectangle + the magnifier. I think all other functionality / logic should go into QuickEditor and KSImageWidget respectively. I am wondering if that is an option, i.e. refactor a selection primitive to select a rectangular area (possibly implemented as QGraphicsObject). I assume that's what you need as well, right? i.e. you want a rectangular selection rather than a region? We could make this new selection class customizable with an isValidSelection hook / lambda so that in your case you can reject selections that are invalid. (correct me if you need something different, I am still not 100% sure if I understood your problem right, if you have a screenshot of a distorted / problematic screen that would be great!)

I didn't review the entire code yet but seems much cleaner. A very welcome refactor!
I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Any news on this?

It would be nicer to not disable all other actions when in annotator mode, but rather just save the image then continue with the action.

I will note that exactly what I was worried about happening did in fact happen: @bgupta disappeared again and the new code style is annoying and irritates other contributors.

In T13145#230250, @davidre wrote:

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

In D29550#669814, @czeidler wrote:

Do you see fundamental problems combining both patches? e.g. in the KSImageWidget the mScreenRegion could simply be a single rectangle of the size of the screenshot pixmap?

Fundamentally no, the other patch essentially rewrites QuickEditor::paintEvent to support Wayland per-screen scaling/dpr.
The full screen rectangular selection and the in-KSImageWidget would need to have separate paint functions essentially.

Do you see fundamental problems combining both patches? e.g. in the KSImageWidget the mScreenRegion could simply be a single rectangle of the size of the screenshot pixmap?

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

That's a nice feature.

Patch is ready for review.

Move SpectacleCore on the stack to avoid crashes, small refactoring

In D29282#668027, @davidre wrote:

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

Add --new-instance option, clean deletion of app

Wayland was not concerned since screenshot replies are handled through file Desrcriptors.

In D29487#668034, @davidre wrote:

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

I guess on app start you would check if there is an instance on the bus already and then do the right thing?

• Fix KSImageWidget cursor when there is no selection
• Send out a selectionChanged event when selection is cleared

In D29408#668033, @davidre wrote:

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

Yes thats correct. That makes it possible to save multiple different selections from the same screenshot... Maybe I should make it more clear that only the selection is saved, or is that clear? However, when dragging the selection only the selected part is visible in the drag image.

Ah I see, the select button will change the pixmap what is saved/copied but not the displayed one?

There should be a 'Select' button on the right side of the window (see below). Once you click it you can start a selection. During the time of the first selection the button is disabled. Happy to get feedback for the button location, label or better position.

In D29596#668032, @davidre wrote:

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

So I have to check this box and it is under the "When spectacle is running" section. But the image will be autosaved regardless whether the other checkbox is saved or not. I think the problem is no easy but I will try again to think of something.

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

Very cool! However I can't seem to figure out a way to select a selection.
How do you think does this relate to D22074? Maybe we can integrate both patches somehow?

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

Let me know @davidre if I can ease your review ;)

This patch currently implies removing the option to have multipe instances of spectacle, and we have a setting to have this upon pressing the Print key.
So should I keep the multiple instance mode ? @davidre @ngraham
It is feasible.
Any time the commandline with the background option or with the setting "Open a new Spectacle window" is set I would start a new Gui instance.

Just a heads up you don't need to use the weird lvariable, theParam code style. See discussion in https://phabricator.kde.org/D21042

Store QApplication on the stack

I don't see why qApp is not deleted here
https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kdbusaddons/html/kdbusservice_8cpp_source.html#l00099
Probably because it can be allocated on stack.

Spectacle must have its executable in its desktop entry Exec field.
To manage this, spectacle must use KDBusService::Unique instead of Multiple.
This requires some refactoring.

In D28395#653949, @ngraham wrote:

Nah, I think for these new ones, just putting it on the clipboard is fine. The point after all is just to quickly paste an image into like a chat window or something.

Move deleteLater out of if

Add a deleteLater

one super minor change

Schedule an update instead of repaint in QuickEditor::onScreenConfigurationReceived

Rename dpr and dprI to devicePixelRatio and devicePixelRatio to differenciate to dpr variable that is per-screen, fix stroke color around selection

Can you add some more explanation what the code does in the summary?

Bonus points for moving items so that they are in the right order before committing (I know that the spacer was not in the right place before )

Removed hints

I think those appeared accidentally when I was testing how it would look like if the label text was shown as a tooltip for the Compression Quality label, I'll remove those and test it.

Everyone agree?