pedroarthurp (Pedro Arthur P. R. Duarte)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 2 2016, 9:16 PM (187 w, 14 h)
Availability
Available

Recent Activity

Sat, May 23

pedroarthurp requested review of D29828: Respect Settings::copyImageToClipboard when StartMode is DBus.
Sat, May 23, 5:31 AM · Spectacle

Dec 11 2019

pedroarthurp added a comment to D16138: Create the default profile if it doesn't exist.

What's the ping? Should Konsole ship a default profile? and if so which one? or fix this code?

Dec 11 2019, 12:25 PM · Konsole

Mar 29 2019

pedroarthurp abandoned D5682: Creates keyboard shortcuts for Present Windows Effects actions.
Mar 29 2019, 6:49 PM · KWin
pedroarthurp abandoned D5673: Add option to reload a file without user confirmation after the execution of a external script.
Mar 29 2019, 6:47 PM
pedroarthurp abandoned D5656: Adds method to force the reloading of a document.
Mar 29 2019, 6:47 PM · Kate, Frameworks

Mar 28 2019

pedroarthurp requested review of D20084: Put sudo config in its own file.
Mar 28 2019, 12:11 AM

Mar 27 2019

pedroarthurp updated the diff for D16138: Create the default profile if it doesn't exist.

Rebased

Mar 27 2019, 9:23 PM · Konsole

Feb 26 2019

pedroarthurp updated the diff for D16138: Create the default profile if it doesn't exist.

I figure out that the previous patch was backward-incompatible.

Feb 26 2019, 2:34 PM · Konsole
pedroarthurp added a comment to D16138: Create the default profile if it doesn't exist.

Testing this and a few concerns right off the start

  1. manage profiles doesn't show any of my profiles (should be 5)
Feb 26 2019, 2:30 PM · Konsole

Feb 24 2019

pedroarthurp added a comment to D16138: Create the default profile if it doesn't exist.

This fix looks wrong anyways, shouldn't clutter up the home directory of users just because we run (IMHO).

Feb 24 2019, 6:43 AM · Konsole
pedroarthurp updated the diff for D16138: Create the default profile if it doesn't exist.

Hi, everyone! Sorry for the delay.

Feb 24 2019, 6:34 AM · Konsole

Oct 23 2018

pedroarthurp added a comment to D16138: Create the default profile if it doesn't exist.

Without this patch, when you change any profile settings, it creates a 'Profile 1.profile'. This is my understanding of how it is suppose to work.

Oct 23 2018, 12:19 PM · Konsole

Oct 21 2018

pedroarthurp updated the diff for D16138: Create the default profile if it doesn't exist.
Oct 21 2018, 10:37 PM · Konsole

Oct 12 2018

pedroarthurp added a comment to D16138: Create the default profile if it doesn't exist.

I don't recall off-hand what happens w/o these 2 files - most distros include profiles

Oct 12 2018, 1:39 PM · Konsole

Oct 11 2018

pedroarthurp requested review of D16138: Create the default profile if it doesn't exist.
Oct 11 2018, 6:29 PM · Konsole

May 21 2018

pedroarthurp added inline comments to D12967: Remove unnecessary forward-calls.
May 21 2018, 5:43 PM · Konsole
pedroarthurp added inline comments to D12964: Remove StackedViewContainer class.
May 21 2018, 4:54 PM · Konsole

Apr 8 2018

pedroarthurp added a member for LaKademy: pedroarthurp.
Apr 8 2018, 2:40 PM

Feb 28 2018

pedroarthurp abandoned D10731: Fix the quick tiling of maximized windows.

Commit 8a2796d280dd7e891724cb6e6d873a57e2ae8c52 fixed this issue in 5.12.0. I was working on previous kwin version and, although I have fixed the issue for myself while ago, I was waiting for a better timing to port to HEAD and to compile/test. It is unnecessary now.

Feb 28 2018, 1:45 AM · KWin

Feb 22 2018

pedroarthurp requested review of D10731: Fix the quick tiling of maximized windows.
Feb 22 2018, 12:54 AM · KWin

May 6 2017

pedroarthurp added a comment to D5644: Adds option to pass cursor line and column to external scripts.

do you have commit rights?

May 6 2017, 10:03 AM

May 4 2017

pedroarthurp added a comment to D5682: Creates keyboard shortcuts for Present Windows Effects actions.

The desktop grid seeems more suited to handle the windows VD.

May 4 2017, 5:20 PM · KWin
pedroarthurp added a comment to D5682: Creates keyboard shortcuts for Present Windows Effects actions.

KWin *has* global shortcuts for minimizing and stickyness. Those should either be forwarded or picked up from KGlobalAccel, rather than adding some randonmly hardcoded strings where the user might have entirely different expectation on what they do.

May 4 2017, 3:57 PM · KWin

May 3 2017

pedroarthurp added a comment to D5682: Creates keyboard shortcuts for Present Windows Effects actions.

That would also be "magic". How would a user know about it? That is my main concern. We cannot just add key handling and not tell users about it. If we accept this review - or the idea of global shortcuts - we would have a workflow suited for you and nobody else.
Nobody would be able to use this unless reading the source code.

May 3 2017, 6:33 PM · KWin
pedroarthurp added a comment to D5682: Creates keyboard shortcuts for Present Windows Effects actions.

How are users supposed to know about this? I'm strictly against adding further "magic" to PW or to implement personal features.

May 3 2017, 3:25 PM · KWin

May 2 2017

pedroarthurp added a comment to D5682: Creates keyboard shortcuts for Present Windows Effects actions.

I have no commit rights. Someone must commit in my behalf.

May 2 2017, 12:40 PM · KWin
pedroarthurp added a comment to D5656: Adds method to force the reloading of a document.

I'm pretty sure this breaks ABI by adding a new virtual function... If an application was compiled against a previous version of KTextEditor and calls documentSave(), when run with a newer KTextEditor version (with this patch) it may end up calling the new documentReload(ReloadDocument). With garbage in the first argument.

May 2 2017, 11:54 AM · Kate, Frameworks

May 1 2017

pedroarthurp created D5682: Creates keyboard shortcuts for Present Windows Effects actions.
May 1 2017, 3:24 PM · KWin

Apr 30 2017

pedroarthurp added a comment to D5656: Adds method to force the reloading of a document.

D5673 shows a use-case for this feature.

Apr 30 2017, 8:21 PM · Kate, Frameworks
pedroarthurp added reviewers for D5673: Add option to reload a file without user confirmation after the execution of a external script: dfaure, brauch, dhaumann, cullmann.
Apr 30 2017, 8:20 PM
pedroarthurp created D5673: Add option to reload a file without user confirmation after the execution of a external script.
Apr 30 2017, 8:19 PM
pedroarthurp added a dependent revision for D5656: Adds method to force the reloading of a document: D5673: Add option to reload a file without user confirmation after the execution of a external script.
Apr 30 2017, 8:19 PM · Kate, Frameworks

Apr 29 2017

pedroarthurp added reviewers for D5656: Adds method to force the reloading of a document: dfaure, brauch, dhaumann, cullmann.
Apr 29 2017, 5:11 PM · Kate, Frameworks
pedroarthurp created D5656: Adds method to force the reloading of a document.
Apr 29 2017, 3:54 PM · Kate, Frameworks

Apr 28 2017

pedroarthurp created D5644: Adds option to pass cursor line and column to external scripts.
Apr 28 2017, 8:12 PM

Dec 22 2016

pedroarthurp added a comment to D3602: Cycle between windows of the same desktop on switch.

Do you have commit rights or should I push the change for you?

Dec 22 2016, 8:05 PM · KWin

Dec 20 2016

pedroarthurp updated the diff for D3602: Cycle between windows of the same desktop on switch.
Dec 20 2016, 7:07 PM · KWin
pedroarthurp added inline comments to D3602: Cycle between windows of the same desktop on switch.
Dec 20 2016, 5:21 PM · KWin

Dec 14 2016

pedroarthurp added inline comments to D3602: Cycle between windows of the same desktop on switch.
Dec 14 2016, 8:18 PM · KWin
pedroarthurp set the repository for D3602: Cycle between windows of the same desktop on switch to R108 KWin.
Dec 14 2016, 4:33 PM · KWin
pedroarthurp updated the diff for D3602: Cycle between windows of the same desktop on switch.

Changes the design to remove the recursion and the tryOpposite boolean flag.

Dec 14 2016, 4:31 PM · KWin

Dec 6 2016

pedroarthurp added a comment to D3602: Cycle between windows of the same desktop on switch.
In D3602#67538, @subdiff wrote:

I don't use directional shortcuts for switching between windows, but in general I like your idea very much and if Thomas gives his ok, it would improve the user experience in usecases like your one. You described it very well.

Dec 6 2016, 7:34 PM · KWin

Dec 5 2016

pedroarthurp added a comment to D3602: Cycle between windows of the same desktop on switch.

Conceptually I'm not sure about it. If I click switch to window on left, I expect it to do that and not to switch to a window right of it. What does a user expect and is your changed behavior still in accordance to what the user expects?

I'm not going to decide on that, this needs input from the usability experts.

Dec 5 2016, 10:52 PM · KWin
pedroarthurp retitled D3602: Cycle between windows of the same desktop on switch from to Cycle between windows of the same desktop on switch.
Dec 5 2016, 6:06 PM · KWin

Nov 2 2016

pedroarthurp retitled D3236: Enables grouping and sorting settings in Icons Only Task Manager from to Enables grouping and sorting settings in Icons Only Task Manager.
Nov 2 2016, 9:25 PM · Plasma