bgupta (Boudhayan Gupta)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 5 2015, 1:17 PM (211 w, 3 h)
Roles
Administrator
Availability
Available

Recent Activity

Jun 11 2019

bgupta committed R166:b526b333bed6: Add comment to desktop file (authored by bgupta).
Add comment to desktop file
Jun 11 2019, 11:56 PM

Jun 10 2019

bgupta added a comment to M113: KDE USB creator.

I have one comment: ISO files are supposed to be burned to optical media. The fact that one can create hybrid ISOs which can also be written to USB drives doesn't mean that all ISOs can be written to USB drives. Most Linux distros generate hybrid ISOs, but some do not, and other operating systems (Windows, for example) do not.

Jun 10 2019, 8:24 PM · KDE Applications, Neon

May 6 2019

bgupta committed R166:4fb5f57786f9: Drop CMake requirement to 3.5 (authored by bgupta).
Drop CMake requirement to 3.5
May 6 2019, 9:15 PM
bgupta updated subscribers of D21042: Refactor Spectacle's platform backends.

Thanks, the crash is fixed now.

I'm still not really on board with some of the style changes though. I understand how this makes hacking on the project easier for you, but it makes it harder for everyone else in the KDE community who isn't you or doesn't work at your company and doesn't follow the same style guide 8 hours a day. I'd be a hard "No" if anyone else proposed this, but you're the author and maintainer, so ultimately it's your call. However I'll note that you disappeared for a few years and left Spectacle to be community-maintained. During this time, I fended off an attempt to incubate yet another screenshot app (KSnip), which would have left Spectacle to die. Spectacle benefited from the fact that the coding style was more coupled to the general KDE style, so it was easier for people to quickly get acquainted with the code and contribute. As a result, Spectacle didn't die during this challenging time for it. I'm happy you're back now, but what happens if and when you leave again? We want for KDE apps to be as accessible as possible to all contributors, not just you. This refactor is generally very welcome, but it also has other changes within it that I think have the potential to the codebase less accessible to other members of the KDE community as well as casual contributors. There's always a balance to be struck here, and I can see that there's not an easy answer.

It's your call, but I encourage you to consider the implications for Spectacle as KDE project, not just as a Boudhayan Gupta project. :)

May 6 2019, 8:29 PM · Spectacle, KDE Applications
bgupta committed R166:e199a218ca21: QuickEditor: Fix crash in release-to-capture mode (authored by bgupta).
QuickEditor: Fix crash in release-to-capture mode
May 6 2019, 4:17 PM
bgupta updated the diff for D21042: Refactor Spectacle's platform backends.

Fix crash in release-to-capture, address minor comments

May 6 2019, 4:17 PM · Spectacle, KDE Applications
bgupta added inline comments to D21042: Refactor Spectacle's platform backends.
May 6 2019, 9:22 AM · Spectacle, KDE Applications
bgupta added a comment to D21042: Refactor Spectacle's platform backends.

Have to agree with Nate regarding the naming convention you are using - feels odd to me. I don't think lConfigMgr is more readable than configManager. Also following a style guide which you can't make public is a strange move in a community like KDE.

May 6 2019, 9:14 AM · Spectacle, KDE Applications
bgupta added a comment to D21042: Refactor Spectacle's platform backends.

In general +1, very nice. I haven't tested the now-working Wayland Rectangular Region mode yes, but I will.

I have to say I don't really like how the proposed new the prefixing style works for boolean variables. It leads to awkwardness like if (theNotifyOnGrab) {. Making the name a noun makes me think it's some object, not a boolean. Compare that to the status quo: if (notifyOnGrab) {, which I think is more readable.

Also prepending l to local variables makes conceptual sense but I admit it looks a bit odd to me given that's not used anywhere else in the KDE style guide. It may be more consistent for you to code Spectacle the way you would at work, but it's less consistent for everyone else in the KDE community who doesn't work there. Ultimately you're the maintainer but KDE has its own set of coding style guidelines and in general I think it might be best to stick with it, or at least not deviate from it too much. :) I won't make hay about it though.

May 6 2019, 9:01 AM · Spectacle, KDE Applications
bgupta updated the summary of D21042: Refactor Spectacle's platform backends.
May 6 2019, 12:45 AM · Spectacle, KDE Applications
bgupta committed R166:4818924c228c: Fix CMakeLists comment (authored by bgupta).
Fix CMakeLists comment
May 6 2019, 12:11 AM
bgupta added inline comments to D21042: Refactor Spectacle's platform backends.
May 6 2019, 12:10 AM · Spectacle, KDE Applications

May 5 2019

bgupta added a comment to D21042: Refactor Spectacle's platform backends.

I don't know how Phab works with submitting patches directly from the web interface or through arc, but please don't merge this - the way to submit this change is to merge the bgupta/platform-backend-refactor branch to master.

May 5 2019, 10:40 PM · Spectacle, KDE Applications
bgupta updated the summary of D21042: Refactor Spectacle's platform backends.
May 5 2019, 10:34 PM · Spectacle, KDE Applications
bgupta requested review of D21042: Refactor Spectacle's platform backends.
May 5 2019, 10:33 PM · Spectacle, KDE Applications
bgupta committed R166:2cdeccc7f8dc: Reenable tests (authored by bgupta).
Reenable tests
May 5 2019, 10:22 PM
bgupta committed R166:f87c6ef6ce41: Drop language version to C++14 (authored by bgupta).
Drop language version to C++14
May 5 2019, 10:15 PM
bgupta committed R166:d64af3fde09d: PlatformXcb: hook up support for reporting window title (authored by bgupta).
PlatformXcb: hook up support for reporting window title
May 5 2019, 10:09 PM
bgupta committed R166:130bb6611944: Handle cancelling rectangular region more correctly (authored by bgupta).
Handle cancelling rectangular region more correctly
May 5 2019, 9:36 PM
bgupta committed R166:3ea3ac587874: Hook the QtQuick Editor back into SpectacleCore (authored by bgupta).
Hook the QtQuick Editor back into SpectacleCore
May 5 2019, 9:32 PM
bgupta committed R166:6da5cf720422: Merge remote-tracking branch 'origin/master' into bgupta/platform-backend… (authored by bgupta).
Merge remote-tracking branch 'origin/master' into bgupta/platform-backend…
May 5 2019, 7:33 PM
bgupta committed R166:0a6c3bda5f4c: Make everything except rectangular crop work again (authored by bgupta).
Make everything except rectangular crop work again
May 5 2019, 7:28 PM
bgupta committed R166:52bc56883956: Refactor Platforms: No images yet (authored by bgupta).
Refactor Platforms: No images yet
May 5 2019, 2:19 AM

May 3 2019

bgupta committed R166:99e0faa93712: Minor cleanups: buildsystem and licensing (authored by bgupta).
Minor cleanups: buildsystem and licensing
May 3 2019, 11:50 AM

Aug 29 2018

bgupta committed R897:497e5b18d24f: Update key of my Latitude laptop, after SSD upgrade and reinstall (authored by bgupta).
Update key of my Latitude laptop, after SSD upgrade and reinstall
Aug 29 2018, 9:06 PM

Aug 18 2018

bgupta committed R897:e87859aaab31: Add my SSH keys and give me access to all servers (authored by bgupta).
Add my SSH keys and give me access to all servers
Aug 18 2018, 12:04 AM

Dec 16 2017

bgupta changed the edit policy for Websites.
Dec 16 2017, 12:41 PM

Aug 18 2017

bgupta abandoned D1976: Image of the Day wallpaper plugin.
Aug 18 2017, 12:26 AM · Plasma

Jul 23 2017

bgupta committed R498:5cc71f985e7f: Add the CWG telegram channel to the bridge (authored by bgupta).
Add the CWG telegram channel to the bridge
Jul 23 2017, 9:48 AM

Apr 14 2017

bgupta accepted D5432: Update Spectacle docbook.

LGTM

Apr 14 2017, 11:17 AM

Mar 13 2017

bgupta committed R166:ed35c62e9f62: Disable mismatched tags errors with clang (authored by bgupta).
Disable mismatched tags errors with clang
Mar 13 2017, 5:59 PM
bgupta committed R166:6a48dc6133c6: change codename for 17.04 (authored by bgupta).
change codename for 17.04
Mar 13 2017, 5:58 PM

Feb 24 2017

bgupta committed R357:60ee55bb9151: add gitignore file (authored by bgupta).
add gitignore file
Feb 24 2017, 1:03 PM
bgupta committed R357:347fb40c9d10: coding style fixes for main.cpp (authored by bgupta).
coding style fixes for main.cpp
Feb 24 2017, 1:03 PM

Feb 20 2017

bgupta committed R166:c09e2a574d02: Allow use of alternative user-configured image format when auto-saving. (authored by bgupta).
Allow use of alternative user-configured image format when auto-saving.
Feb 20 2017, 6:22 PM
bgupta closed T5051: Some git repositories not syncing to Github as Resolved.
Feb 20 2017, 8:48 AM · Sysadmin
bgupta added a comment to T5051: Some git repositories not syncing to Github.

This should now be sorted.

Feb 20 2017, 8:48 AM · Sysadmin

Feb 19 2017

bgupta committed R248:b4e8677cdf21: Revert "correct force sync script" (authored by bgupta).
Revert "correct force sync script"
Feb 19 2017, 2:31 PM
bgupta committed R248:18f66295a887: exec perms on scripts (authored by bgupta).
exec perms on scripts
Feb 19 2017, 2:31 PM
bgupta committed R248:0cedfebb0591: restore some older github sync scripts (authored by bgupta).
restore some older github sync scripts
Feb 19 2017, 2:31 PM
bgupta committed R248:ce4601be026b: correct force sync script (authored by bgupta).
correct force sync script
Feb 19 2017, 2:31 PM
bgupta added a reverting change for R248:ce4601be026b: correct force sync script: R248:b4e8677cdf21: Revert "correct force sync script".
Feb 19 2017, 2:31 PM

Feb 13 2017

bgupta added a comment to T5242: Display user information so that others can land/amend a patch.

There's no way in hell we can make email addresses public without the user's explicit consent. It has to be opt-in. Literally everyone on this thread except Ben lives in Europe. The law of the land is very protective of personal data, which most certainly includes email addresses. Refer to Directive 95/46/EC, and to the Bundesdatenschutzgesetz, Sections 4, 4a and 5. I'm sure Spain and Italy and other EU countries have implementations of the EC directive. I could well sue KDE e.V. for making my email address public, if I haven't consented to it.

Feb 13 2017, 10:33 AM · Phabricator

Jan 12 2017

bgupta added a comment to T5051: Some git repositories not syncing to Github.

That won't really help, since Propagator uses the exact same logic, adjusted for GitPython's API.

Jan 12 2017, 11:24 PM · Sysadmin

Dec 9 2016

bgupta committed R166:b9ffdb0a6d4c: Change codename seeing impending maintainership transfer (authored by bgupta).
Change codename seeing impending maintainership transfer
Dec 9 2016, 3:20 AM
bgupta committed R166:343e3464dc03: Merge KWin/Wayland support into 16.12 (authored by bgupta).
Merge KWin/Wayland support into 16.12
Dec 9 2016, 3:13 AM

Nov 24 2016

bgupta added a comment to D3476: Support screenshot current screen and fullscreen on KWin/Wayland.

Good point. This is going to need more insidious changes in Spectacle. Alright, ship this for now.

Nov 24 2016, 6:58 PM · Plasma on Wayland
bgupta added a comment to D3475: Add interactive position selection to screenshot screen under cursor.

Yeah, I was planning on each plugin returning a list of supported grab modes and ancillary features (on click, timeouts, etc), and modifying the UI based on that information.

Nov 24 2016, 6:57 PM · KWin, Plasma on Wayland
bgupta resigned from D2659: Reorganize calligra-related projects.
Nov 24 2016, 5:23 PM · Sysadmin
bgupta accepted D3475: Add interactive position selection to screenshot screen under cursor.

Hmm, so "On Click" mode is always selected.

Nov 24 2016, 5:22 PM · KWin, Plasma on Wayland

Nov 23 2016

bgupta accepted D3476: Support screenshot current screen and fullscreen on KWin/Wayland.

Looks lovely. I just have one nitpick, which is in an inline comment below.

Nov 23 2016, 6:48 PM · Plasma on Wayland
bgupta added a comment to D3475: Add interactive position selection to screenshot screen under cursor.

Does this mean taking a full screen screenshot also requires a click anywhere on the screen from the user? Or is the click optional?

Nov 23 2016, 6:45 PM · KWin, Plasma on Wayland

Nov 19 2016

bgupta accepted D3405: Use KWindowSystem::isPlatformX11.

Sorry, didn't notice this earlier. Good to go.

Nov 19 2016, 9:52 PM

Nov 18 2016

bgupta accepted D3413: Introduce a KWin/Wayland image grabber.

This is lovely.

Nov 18 2016, 5:41 PM · Plasma on Wayland

Oct 24 2016

bgupta committed R137:109a87a8a9dc: update version to 1.9.96 (authored by bgupta).
update version to 1.9.96
Oct 24 2016, 11:23 AM
bgupta committed R137:b48aaf4e0d89: correct exceptions handling (authored by bgupta).
correct exceptions handling
Oct 24 2016, 11:18 AM
bgupta committed R137:2be5db6db606: add example circus config to build off (authored by bgupta).
add example circus config to build off
Oct 24 2016, 11:01 AM
bgupta committed R137:0ffa598e87e0: stop dummy from raising exceptions (authored by bgupta).
stop dummy from raising exceptions
Oct 24 2016, 9:58 AM
bgupta committed R137:230582f5d320: add the mirrorctl utility (authored by bgupta).
add the mirrorctl utility
Oct 24 2016, 9:50 AM

Oct 23 2016

bgupta committed R137:1b409e17fb04: github remote is possibly fixed up (authored by bgupta).
github remote is possibly fixed up
Oct 23 2016, 2:57 PM
bgupta committed R137:2f3567c32bb6: fix niggling bugs (authored by bgupta).
fix niggling bugs
Oct 23 2016, 1:33 PM

Oct 21 2016

bgupta committed R166:609c0ec03d22: Remove line about me being maintainer from README (authored by bgupta).
Remove line about me being maintainer from README
Oct 21 2016, 5:30 PM

Oct 11 2016

bgupta closed D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme.

Committed in rPLASMAWORKSPACEaafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds.

Oct 11 2016, 2:46 PM · Plasma
bgupta removed 1 commit(s) for D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme: R120:aafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds.
Oct 11 2016, 2:45 PM · Plasma
bgupta removed an edge from R120:aafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds: D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme.
Oct 11 2016, 2:44 PM
bgupta added 1 commit(s) for D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme: R120:aafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds.
Oct 11 2016, 2:44 PM · Plasma
bgupta added an edge to R120:aafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds: D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme.
Oct 11 2016, 2:44 PM
bgupta committed R120:aafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds (authored by bgupta).
sddm-theme: support configurable solid colour and image backgrounds
Oct 11 2016, 2:41 PM

Oct 10 2016

bgupta added a comment to D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme.

This patch modifies an existing file. Removing the original copyright is illegal! If you want your new code to be under a different license (which is fine), you need to rework the header to state: "Originally based on XY by XY under the following conditions XYZ" or something like that, although I personally think changing the license adds to much confusion for too little gain. With the original license intact, just a second copyright line is needed.

Oct 10 2016, 12:48 AM · Plasma

Oct 7 2016

bgupta retitled D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme from to Support solid colour and image backgrounds with a configurable background colour in the SDDM theme.
Oct 7 2016, 6:00 PM · Plasma

Sep 21 2016

bgupta added a member for Community Admins: ltoscano.
Sep 21 2016, 9:01 PM

Sep 10 2016

bgupta committed R166:b80d84af6631: Bump version to 2.0.0 (authored by bgupta).
Bump version to 2.0.0
Sep 10 2016, 4:25 AM
bgupta committed R166:03cfb7d475ef: Merge branch 'master' into editor (authored by bgupta).
Merge branch 'master' into editor
Sep 10 2016, 4:25 AM
bgupta committed R166:916ec089036c: Do not show decimal points if delay is integer value (authored by bgupta).
Do not show decimal points if delay is integer value
Sep 10 2016, 4:24 AM
bgupta committed R166:7022c064447c: Checkpoint (authored by bgupta).
Checkpoint
Sep 10 2016, 4:24 AM
bgupta committed R166:fb45d5ec64a3: First iteration of line tool (authored by bgupta).
First iteration of line tool
Sep 10 2016, 4:24 AM
bgupta committed R166:4f80cbc89dec: Fix crop area, right click to reset selection (authored by bgupta).
Fix crop area, right click to reset selection
Sep 10 2016, 4:24 AM
bgupta committed R166:bb1c13cfbc45: Fix up editor object hierarchy (authored by bgupta).
Fix up editor object hierarchy
Sep 10 2016, 4:24 AM
bgupta committed R166:c5e3f3ff8f36: Reorganize the editor UI (authored by bgupta).
Reorganize the editor UI
Sep 10 2016, 4:24 AM
bgupta committed R166:889d4efb58cb: Correct licensing headers (authored by bgupta).
Correct licensing headers
Sep 10 2016, 4:24 AM
bgupta committed R166:7da84e9f274e: Preliminary cropping support (authored by bgupta).
Preliminary cropping support
Sep 10 2016, 4:24 AM
bgupta committed R166:7de845ea69c3: Initial editor - can draw rectangles and stuff (authored by bgupta).
Initial editor - can draw rectangles and stuff
Sep 10 2016, 4:24 AM
bgupta committed R166:91038f6de76d: checkpoint - do not build (authored by bgupta).
checkpoint - do not build
Sep 10 2016, 4:24 AM

Sep 6 2016

bgupta added a member for Community Admins: knauss.
Sep 6 2016, 12:13 AM

Aug 21 2016

bgupta committed R166:cd93958300b7: make capture asynchronous, this makes things *seem* faster, also gets rid of… (authored by bgupta).
make capture asynchronous, this makes things *seem* faster, also gets rid of…
Aug 21 2016, 3:34 PM
bgupta committed R166:d274a65fbd0c: need for speed: two seconds (authored by bgupta).
need for speed: two seconds
Aug 21 2016, 3:21 PM
bgupta committed R166:cf806c5b5da0: capture drawn image from canvas and compose into drawn image (authored by bgupta).
capture drawn image from canvas and compose into drawn image
Aug 21 2016, 3:12 PM
bgupta committed R166:3629be3302b7: minor fixes, license headers (authored by bgupta).
minor fixes, license headers
Aug 21 2016, 1:45 AM
bgupta committed R166:5dfddbbca458: update codename (authored by bgupta).
update codename
Aug 21 2016, 1:45 AM
bgupta committed R166:c5a85e3b5b55: update codename (authored by bgupta).
update codename
Aug 21 2016, 12:59 AM

Jul 28 2016

bgupta committed R137:7afe4058b1d2: add the mirrorsync utility (authored by bgupta).
add the mirrorsync utility
Jul 28 2016, 12:35 PM
bgupta committed R137:8be5d3e58e31: intermediate: prepare for mirrorsync utility (authored by bgupta).
intermediate: prepare for mirrorsync utility
Jul 28 2016, 10:47 AM

Jul 27 2016

bgupta committed R137:84013d447d95: refactor common code into driver (authored by bgupta).
refactor common code into driver
Jul 27 2016, 5:58 PM
bgupta closed T3192: Move Mediacentre to Extragear as Resolved.

Done. It has been moved to extragear/multimedia/

Jul 27 2016, 2:35 PM · Plasma
bgupta committed R137:432b0fbb3df6: start using the new propagator-remoteslave driver (authored by bgupta).
start using the new propagator-remoteslave driver
Jul 27 2016, 2:19 PM

Jul 25 2016

bgupta added a comment to T3306: Git hook to ensure serial number of DNS zones is changed.

I've forgotten this just once in the past, but the changes propagated just fine.

Jul 25 2016, 4:03 PM · Sysadmin

Jul 21 2016

bgupta committed R137:69dd871613eb: add remote plugins and github remote (authored by bgupta).
add remote plugins and github remote
Jul 21 2016, 7:41 PM

Jul 19 2016

bgupta committed R137:106a91008b18: add classifiers and drop version number (authored by bgupta).
add classifiers and drop version number
Jul 19 2016, 7:35 AM
bgupta committed R137:e6b518c49368: changed string (authored by bgupta).
changed string
Jul 19 2016, 7:35 AM
bgupta committed R137:b3eaaf15a9a0: re-write begin (authored by bgupta).
re-write begin
Jul 19 2016, 7:35 AM