aprcela (Antonio Prcela)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 12 2019, 10:06 PM (46 w, 5 d)
Availability
Available

Recent Activity

Sat, May 23

aprcela added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

Well right now you have that problem too that you can select both. Even worse both settings are on different sub pages. I would also happy to remove Copy file location to clipboard after saving but I'm not sure if it's an extensive used feature. To me seems unnecessary when we have automatic copy.

Sat, May 23, 5:28 PM · Spectacle
aprcela updated subscribers of D29828: Respect Settings::copyImageToClipboard when StartMode is DBus.

Works, but the notification is empty and the file doesn't get saved at all:

Sat, May 23, 10:39 AM · Spectacle

Mon, May 18

aprcela added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

Mon, May 18, 9:37 PM · Spectacle
aprcela added a comment to D29589: Remove unused variable.

@davidre ping :)

Mon, May 18, 9:33 PM · Spectacle

Thu, May 14

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Done :)

Thu, May 14, 10:15 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Renaming of functions
Thu, May 14, 10:14 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Nice feature. I would rename the menu items a bit:
"Move to inactive split view"
"Copy to inactive split view"

No need to mention "the selection" because it's implicit. And I would mention that this is about the split view, or else when not using the split view feature, it's not clear how to enable the menu items. If you mention splits in the name though, it's advertising the split view feature for whose who haven't found it yet.

Thu, May 14, 9:21 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Minor renaming of text and the according variables
  • Merge remote-tracking branch 'origin' into arcpatch-D29006
Thu, May 14, 9:19 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Rather than merging master into your branches, I would recommend you rebasing ;)

Thu, May 14, 7:21 AM · Documentation, Dolphin

Wed, May 13

aprcela added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

Wed, May 13, 8:10 AM · Spectacle

Tue, May 12

aprcela renamed T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab from Spectacle - rearrange settings and maybe add more? to Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.
Tue, May 12, 8:49 PM · Spectacle
aprcela lowered the priority of T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab from Low to Wishlist.
Tue, May 12, 8:30 PM · Spectacle
aprcela triaged T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab as Low priority.
Tue, May 12, 8:29 PM · Spectacle
aprcela added inline comments to D29006: Allow to copy or move selection to the other split view.
Tue, May 12, 7:15 AM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Renamed to destinationUrl
Tue, May 12, 7:14 AM · Documentation, Dolphin

Mon, May 11

aprcela added inline comments to D29006: Allow to copy or move selection to the other split view.
Mon, May 11, 9:13 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
Mon, May 11, 9:12 PM · Documentation, Dolphin
aprcela added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

So I have to check this box and it is under the "When spectacle is running" section. But the image will be autosaved regardless whether the other checkbox is saved or not. I think the problem is no easy but I will try again to think of something.

Mon, May 11, 8:25 AM · Spectacle

Sun, May 10

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

It sounds to me like you found bugs in some kioslaves. Fixing that is out of scope for this change request. Certainly a good idea to do that, but IMHO not a blocker for this to go in.

I don't think this is a bug in any ioslave : dolphin view doesn't have this issue when copy/pasting files in , and for instance recentlyused:/ has "writing=false" and "moving=false" in its json file.
So I would guess this is not a bug there but somewhere else along the call chain. One can compare this code to DolphinContextMenu::createPasteAction that uses KIO::pasteActionText

I agree this should not keep this bug from landing.
But it would be great to have a look as to where the issue comes from...

One approval from @ngraham or @elvisangelaccio and we should land this.

Sun, May 10, 5:34 PM · Documentation, Dolphin
aprcela added reviewers for D29589: Remove unused variable: Spectacle, davidre, ngraham.
Sun, May 10, 12:46 PM · Spectacle
aprcela updated the test plan for D29596: Copy image to clipboard using hotkeys while spectacle is not running.
Sun, May 10, 12:40 PM · Spectacle
aprcela added reviewers for D29596: Copy image to clipboard using hotkeys while spectacle is not running: Spectacle, ngraham, davidre.
Sun, May 10, 12:40 PM · Spectacle
aprcela requested review of D29596: Copy image to clipboard using hotkeys while spectacle is not running.
Sun, May 10, 12:36 PM · Spectacle
aprcela requested review of D29589: Remove unused variable.
Sun, May 10, 11:36 AM · Spectacle

Thu, May 7

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

@meven
These seem to be 'special-cases' locations.
The call to capabilitiesDestination.isWritable() :

Thu, May 7, 8:16 AM · Documentation, Dolphin

May 4 2020

aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Rewrite so it's obvious that it is copying/moving to the inactive view
May 4 2020, 11:07 AM · Documentation, Dolphin
aprcela updated the summary of D29006: Allow to copy or move selection to the other split view.
May 4 2020, 10:22 AM · Documentation, Dolphin
aprcela updated the summary of D29006: Allow to copy or move selection to the other split view.
May 4 2020, 10:22 AM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
May 4 2020, 9:33 AM · Documentation, Dolphin
aprcela added inline comments to D29006: Allow to copy or move selection to the other split view.
May 4 2020, 9:23 AM · Documentation, Dolphin
aprcela updated the diff for D29399: Replace the list with the simplified list, instead of concatenate..
May 4 2020, 9:22 AM · Dolphin
aprcela requested review of D29399: Replace the list with the simplified list, instead of concatenate..
May 4 2020, 9:21 AM · Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Revert "Instead of append, change the value to a simplifiedUrlList"
May 4 2020, 9:16 AM · Documentation, Dolphin
aprcela added inline comments to D29006: Allow to copy or move selection to the other split view.
May 4 2020, 9:15 AM · Documentation, Dolphin

May 3 2020

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

@elvisangelaccio
copySelectedItems() is already used to copy to clipboard. See L365.

May 3 2020, 8:23 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Add check if destination is writable for copy
  • Move copy/move logic to DolphinTabWidget
  • Set Shift+F5/F6 instead of CTRL+F5/F6 as keyboard shortcut
May 3 2020, 8:16 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Just a check to add.

May 3 2020, 12:58 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Looks good to me.

Did you test copying and moving directories as well? Should work, but just to make sure.

I'll let the Dolphin developers/maintainers decide on whether the shortcuts are OK, and land this.

May 3 2020, 10:22 AM · Documentation, Dolphin

May 2 2020

aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Connect to copyingDone to update m_selectedUrls
May 2 2020, 9:39 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Instead of append, change the value to a simplifiedUrlList
  • Remove 'selected' from text
May 2 2020, 8:12 PM · Documentation, Dolphin

May 1 2020

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Done :)

May 1 2020, 8:47 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Rename slotPasteJobResult to more generic slotJobResult
  • Added error check when copying to other view
May 1 2020, 8:47 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

@dfaure is it good now? Anyone found anything else to fix and/or improve?

May 1 2020, 5:32 PM · Documentation, Dolphin

Apr 30 2020

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

You can compare with what happens when doing the same invalid move using Cut / Paste for instance.

The job gives the error "A folder cannot be moved into itself" and dolphin displays this in the view.

You want to connect to the job's result() signal and emit errorMessage from the slot, like DolphinView::slotPasteJobResult does.

Apr 30 2020, 10:25 AM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Update docbook
Apr 30 2020, 10:25 AM · Documentation, Dolphin

Apr 29 2020

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

One more fix and update.
Is it ok that nothing happens if a user wants to move a folder into one of it's subfolders?
If dolphin is launched from bash, one can see "Could not rename file /tmp/subfolder copy." if one tries to move /tmp/subfolder to /tmp/subfolder/subsub/

Apr 29 2020, 1:37 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
  • Make moving only available if file is movable.
  • Update docbook
Apr 29 2020, 1:32 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Increase the version number at the top of dolphinui.rc
Otherwise, any user who made local changes (e.g. shortcuts) isn't getting that new version of the ui.rc file

Apr 29 2020, 1:13 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.

Add functions into the Edit menu

Apr 29 2020, 1:10 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Yes I'd say those should be actions in the menus otherwise the feature is too hidden.

Apr 29 2020, 12:18 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.

Fix wrong naming

Apr 29 2020, 10:19 AM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Changed to use KIO::copy and ::move - thanks @dfaure !
One thing, I almost forgot, what about the predefined keyboard shortcuts I've set? Keep as CTRL+F5/F6 or change to something else?

Apr 29 2020, 7:43 AM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.

Use KIO copy and move instead of going trough the clipboard

Apr 29 2020, 7:40 AM · Documentation, Dolphin

Apr 24 2020

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Also what kind of file do you copy, only local right ?

Yes, local files on local ssd that are in my home directory.

Apr 24 2020, 11:44 AM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Do I have to invoke thread apply all bt in gdb before or after I copy/move to the other view?
Tried it before, but couldn't get any info in gdb while dolphin stopped responding..

I forgot to mention : once dolphin is blocked, then type CTRL+C in your gdb terminal and them you can thread apply all bt
A step by step:

gdb dolphin

type run // will launch dolphin, do your think until things hang

type CTRL + C in your gdb terminal // to stop dolphin and switch back to gdb

type thread apply all bt

Apr 24 2020, 10:40 AM · Documentation, Dolphin

Apr 21 2020

aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Do I have to invoke thread apply all bt in gdb before or after I copy/move to the other view?
Tried it before, but couldn't get any info in gdb while dolphin stopped responding..

Apr 21 2020, 8:30 PM · Documentation, Dolphin
aprcela updated the diff for D29006: Allow to copy or move selection to the other split view.
Apr 21 2020, 8:27 PM · Documentation, Dolphin
aprcela added a comment to D29006: Allow to copy or move selection to the other split view.

Thanks for the feedback and help!

Apr 21 2020, 7:07 PM · Documentation, Dolphin
aprcela added a comment to D23366: [Spectacle] Implement Tasks feature (WiP).
In D23366#653823, @alex wrote:

First of all this feature sounds great!

I am just a bit confused about how we define "tasks" now:
In your current implementation it looks like they should be executed after the file gets saved.

And after capture a new window appears with a bunch of options

This seems like an action gets executed after the screenshot is taken.

Apr 21 2020, 6:24 PM · Spectacle
aprcela added a comment to D23366: [Spectacle] Implement Tasks feature (WiP).

I love the idea. However is it likely that the user will always want to run the same task on every screenshot? It feels more like this should be a list of tasks, and the user should be able to choose which one to run, optionally marking one as an overridable default task.

Thoughts?

Apr 21 2020, 9:34 AM · Spectacle

Apr 20 2020

aprcela updated the test plan for D23366: [Spectacle] Implement Tasks feature (WiP).
Apr 20 2020, 9:54 PM · Spectacle
aprcela updated the diff for D23366: [Spectacle] Implement Tasks feature (WiP).

Merge and fix conflicts

Apr 20 2020, 9:46 PM · Spectacle
aprcela added a comment to D23366: [Spectacle] Implement Tasks feature (WiP).

Oh gosh, how did this get missed? Sorry about that.

Apr 20 2020, 1:28 PM · Spectacle
aprcela added a comment to T11422: Spectacle - Tasks after screenshot has been taken/saved.

I highly doubt it.
And thanks for reminding me. Will work on it in this week.

Apr 20 2020, 1:26 PM · Spectacle
aprcela updated the summary of D29006: Allow to copy or move selection to the other split view.
Apr 20 2020, 9:49 AM · Documentation, Dolphin
aprcela updated the summary of D29006: Allow to copy or move selection to the other split view.
Apr 20 2020, 9:48 AM · Documentation, Dolphin
aprcela requested review of D29006: Allow to copy or move selection to the other split view.
Apr 20 2020, 9:47 AM · Documentation, Dolphin
aprcela added a watcher for Dolphin: aprcela.
Apr 20 2020, 9:42 AM

Apr 15 2020

aprcela updated the summary of D28857: Do not display full path in the title of the tab.
Apr 15 2020, 3:22 PM · Dolphin
aprcela requested review of D28857: Do not display full path in the title of the tab.
Apr 15 2020, 3:20 PM · Dolphin

Apr 14 2020

aprcela added reviewers for D28815: Display readable titlebar text while using search and full paths in titlebar: Dolphin, iasensio, elvisangelaccio, ngraham.
Apr 14 2020, 10:12 AM · Dolphin
aprcela abandoned D28790: Add option to separate full path visibility for tab and window..

So I can disregard this and maybe change the current option "Show full path in titlebar" to only switch the full path On/Off for the window title instead of both window and tab?

Yep, makes sense to me!

Apr 14 2020, 10:04 AM · Dolphin
aprcela requested review of D28815: Display readable titlebar text while using search and full paths in titlebar.
Apr 14 2020, 9:53 AM · Dolphin

Apr 13 2020

aprcela added a comment to D28790: Add option to separate full path visibility for tab and window..

Yeah, but we're trying to move away from that and toward having good defaults and offering only options that make sense. :)

Apr 13 2020, 5:49 PM · Dolphin
aprcela added a comment to D28790: Add option to separate full path visibility for tab and window..

I wonder... might it make sense to just always display the full path in the titlebar? And as for tab titles, does it ever make sense to display the full path there? The amount of horizontal space is very small so the path will almost always be elided away into uselessness.

Apr 13 2020, 4:19 PM · Dolphin
aprcela updated the summary of D28790: Add option to separate full path visibility for tab and window..
Apr 13 2020, 11:27 AM · Dolphin
aprcela updated the summary of D28790: Add option to separate full path visibility for tab and window..
Apr 13 2020, 11:27 AM · Dolphin
aprcela requested review of D28790: Add option to separate full path visibility for tab and window..
Apr 13 2020, 11:25 AM · Dolphin

Oct 18 2019

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Searching and debugging and I just can't find the reason why.
So currently the counter works fine when the first image of a folder is opened and THEN one goes into fullscreen. But if one goes directly into fullscreen with the first image loaded, than it sets the counter to 0.

Oct 18 2019, 10:44 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Removed comment that was used for the timer

Oct 18 2019, 10:38 PM · Gwenview

Oct 16 2019

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Did you mean to remove the timer in this patch?

Oct 16 2019, 5:48 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Remove timer. Use simple method call instead.

Oct 16 2019, 5:46 PM · Gwenview
aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Reverted the timer to 0.
Now it works when switching to fullscreen. Next step: make the counter work properly when -f for fullscreen is used.

Oct 16 2019, 10:57 AM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Revert timer and add additional updateDocumentCountLabel call

Oct 16 2019, 10:55 AM · Gwenview

Oct 15 2019

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Probably, I can't get to that case where it's so slow. But I am aware that it can happen.

Oct 15 2019, 8:17 PM · Gwenview

Oct 13 2019

aprcela requested review of D24622: Proper numbering on first image in folder when using Fullscreen mode.
Oct 13 2019, 10:38 PM · Gwenview
aprcela added a watcher for Gwenview: aprcela.
Oct 13 2019, 9:45 PM

Oct 9 2019

aprcela added a comment to D24508: Make all buttons in the main window activatable with enter.

Works fine. All buttons get proper focus on TAB now.

Oct 9 2019, 9:49 AM · Spectacle

Sep 24 2019

aprcela added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I can build it, but when I run spectacle - I get a segmentation fault. Has anyone else such a problem?
The problem seems to be in the setupShortcuts().

ofc, i commented it out just to see if it would run at all.

I'm also not experiencing this issue. Do you have the problem if you put "setupShortcuts()" to it's old position? And perhaps you could find out where execactly the setupShortcuts() method causes the problem? Maybe this gives us some hint, what might be wrong.
Obviously, if anybody else can confirm the problem that would be super helpful.

Sep 24 2019, 8:21 PM · Spectacle
aprcela added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

Anyone, who can review this?

Sep 24 2019, 4:14 PM · Spectacle

Sep 12 2019

aprcela added a comment to D23891: CMD arguments and CaptureMode was mixed up.

Did you test this? I think the way it was was correct. A transient window is for example a popup . Only the popup is transientOnly (capturemode window under cursor) and everything is transientwithparent. See also the help text

-u, --windowundercursor    Capture the window currently under the cursor,
                             including parents of pop-up menus
  -t, --transientonly        Capture the window currently under the cursor,
                             excluding parents of pop-up menus

and the gui version
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSWidget.cpp#n217

Please revert this

Sep 12 2019, 11:48 AM · Spectacle

Sep 11 2019

aprcela requested review of D23891: CMD arguments and CaptureMode was mixed up.
Sep 11 2019, 10:36 PM · Spectacle

Sep 5 2019

aprcela added a comment to D23723: Save image to clipboard if --nonotify is used.

This also applies the delay of 250 ms when saving the picture not only copying. To make this better we could move this either inside the if-else above or have another test if we copied to clipboard - can't get around a bit of duplication. However this piece of code is all over the place already and I don't like the design of forceNotify and quitting through the main window. So this if fine with me if we could avoid the extra wait when saving to a file.

Sep 5 2019, 3:01 PM · Spectacle
aprcela updated the diff for D23723: Save image to clipboard if --nonotify is used.

Edit if and add else if

Sep 5 2019, 2:50 PM · Spectacle

Sep 4 2019

aprcela added a reviewer for D23724: Cleanup source code of minor annoyances: Spectacle.
Sep 4 2019, 9:15 PM · Spectacle
aprcela requested review of D23724: Cleanup source code of minor annoyances.
Sep 4 2019, 9:14 PM · Spectacle
aprcela added reviewers for D23723: Save image to clipboard if --nonotify is used: Spectacle, davidre.
Sep 4 2019, 9:03 PM · Spectacle
aprcela added a comment to D23723: Save image to clipboard if --nonotify is used.

Same solution as here:
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n399

Sep 4 2019, 9:02 PM · Spectacle
aprcela requested review of D23723: Save image to clipboard if --nonotify is used.
Sep 4 2019, 8:59 PM · Spectacle

Sep 3 2019

aprcela added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

I plan on fixing this before the beta release, or at least the full release. Anyone have any ideas what might be causing this?

Sep 3 2019, 12:37 PM · Spectacle