- User Since
- Jul 12 2019, 10:06 PM (13 w, 4 d)
Remove timer. Use simple method call instead.
Reverted the timer to 0.
Now it works when switching to fullscreen. Next step: make the counter work properly when -f for fullscreen is used.
Revert timer and add additional updateDocumentCountLabel call
Probably, I can't get to that case where it's so slow. But I am aware that it can happen.
Sun, Oct 13
Wed, Oct 9
Works fine. All buttons get proper focus on TAB now.
Tue, Sep 24
Sep 12 2019
Sep 11 2019
Sep 5 2019
Edit if and add else if
Sep 4 2019
Same solution as here:
Sep 3 2019
Sep 2 2019
- Revert connect and change if condition inside it
Sep 1 2019
Aug 29 2019
Revert back to QMimeData. Removed toImage() sine QT converts internally
Aug 28 2019
Apparently, this is slower than setImage() because:
Remove include of QMimeData
- Remove redundant check and redundant connect
Looks good, nothing to change. :)
Move connect outside of the else
Aug 26 2019
Removed the unnecessary variables.
Tested & working.
- Remove unnecessary variables
Aug 24 2019
- proper rebase. hopefully
Done , tested & working :)
- Reduce code duplication
Aug 23 2019
- Reduce code duplication
- Fix git branch mashup
And still including more than it should..
Can someone help me out with this one?
Hm, looks like I borked my branches..
Now it shows the diff from the last two patches :/
- Use OR instead of AND
Aug 22 2019
- Check if the file is valid
Did some changes. Please check now.
Also: see the hint for doCopyToClipboard:
- Renameing and reordering
- Add new AutoSave related methods.
Update it to not use enum. Don't worry, it wasn't useless. I learned more :)
- Rewrite to not use enum
Aug 21 2019
- Resolved merge conflicts
- Fix end of line
- Setting variable renamed, remove commented code
I hope that's it :)
- Setting variable renamed
All done. I hope the names a re better now. Any recommendation for kde-dev best-practices?
- Rename variables, methods and enum. Remove unnecessary logic
Done. Tested & it's working.
- Move showInlineMessage() and MessageDuration to public
- Remove unnecessary check
Changed to enum and reverted the connect in L348 of SpectacleCore.cpp so spectacle -b -c works again.
- Use enum for copyToClipboard
- Revert connect to fix
Just gonna leave this here, so I don't forget about it :D
Aug 20 2019
Got me into thinking:
The user sets a Shortcut and connects it to a Task.
What if, this would require quite a lot to do, we make an Task creator panel. Where a User can create his own Task and give it a name. Then, in the Schortcut settings, the user chooses which Task gets called for a specific Shortcut.
Creating a Task could include all of Spectacles functionality: After screenshot has been taken, save/edit/clipboard/... it, upload it, close Spectacle, etc.
Whereas the User sets the desired actions for a task with Checkboxes and Radiobuttons, and can have multiple tasks.
Similar to Message Filters in Thunderbird. I hope i described it well enough.