aprcela (Antonio Prcela)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 12 2019, 10:06 PM (21 w, 4 d)
Availability
Available

Recent Activity

Oct 18 2019

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Searching and debugging and I just can't find the reason why.
So currently the counter works fine when the first image of a folder is opened and THEN one goes into fullscreen. But if one goes directly into fullscreen with the first image loaded, than it sets the counter to 0.

Oct 18 2019, 10:44 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Removed comment that was used for the timer

Oct 18 2019, 10:38 PM · Gwenview

Oct 16 2019

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Did you mean to remove the timer in this patch?

Oct 16 2019, 5:48 PM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Remove timer. Use simple method call instead.

Oct 16 2019, 5:46 PM · Gwenview
aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

Reverted the timer to 0.
Now it works when switching to fullscreen. Next step: make the counter work properly when -f for fullscreen is used.

Oct 16 2019, 10:57 AM · Gwenview
aprcela updated the diff for D24622: Proper numbering on first image in folder when using Fullscreen mode.

Revert timer and add additional updateDocumentCountLabel call

Oct 16 2019, 10:55 AM · Gwenview

Oct 15 2019

aprcela added a comment to D24622: Proper numbering on first image in folder when using Fullscreen mode.

And if updating the current index takes longer than 250 msec it would fail again, wouldn't it?

Probably, I can't get to that case where it's so slow. But I am aware that it can happen.

Oct 15 2019, 8:17 PM · Gwenview

Oct 13 2019

aprcela requested review of D24622: Proper numbering on first image in folder when using Fullscreen mode.
Oct 13 2019, 10:38 PM · Gwenview
aprcela added a watcher for Gwenview: aprcela.
Oct 13 2019, 9:45 PM

Oct 9 2019

aprcela added a comment to D24508: Make all buttons in the main window activatable with enter.

Works fine. All buttons get proper focus on TAB now.

Oct 9 2019, 9:49 AM · Spectacle

Sep 24 2019

aprcela added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

I can build it, but when I run spectacle - I get a segmentation fault. Has anyone else such a problem?
The problem seems to be in the setupShortcuts().

ofc, i commented it out just to see if it would run at all.

I'm also not experiencing this issue. Do you have the problem if you put "setupShortcuts()" to it's old position? And perhaps you could find out where execactly the setupShortcuts() method causes the problem? Maybe this gives us some hint, what might be wrong.
Obviously, if anybody else can confirm the problem that would be super helpful.

Sep 24 2019, 8:21 PM · Spectacle
aprcela added a comment to D23446: Shortcuts displayed in capture mode ComboBox.

Anyone, who can review this?

Sep 24 2019, 4:14 PM · Spectacle

Sep 12 2019

aprcela added a comment to D23891: CMD arguments and CaptureMode was mixed up.

Did you test this? I think the way it was was correct. A transient window is for example a popup . Only the popup is transientOnly (capturemode window under cursor) and everything is transientwithparent. See also the help text

-u, --windowundercursor    Capture the window currently under the cursor,
                             including parents of pop-up menus
  -t, --transientonly        Capture the window currently under the cursor,
                             excluding parents of pop-up menus

and the gui version
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSWidget.cpp#n217

Please revert this

Sep 12 2019, 11:48 AM · Spectacle

Sep 11 2019

aprcela requested review of D23891: CMD arguments and CaptureMode was mixed up.
Sep 11 2019, 10:36 PM · Spectacle

Sep 5 2019

aprcela added a comment to D23723: Save image to clipboard if --nonotify is used.

This also applies the delay of 250 ms when saving the picture not only copying. To make this better we could move this either inside the if-else above or have another test if we copied to clipboard - can't get around a bit of duplication. However this piece of code is all over the place already and I don't like the design of forceNotify and quitting through the main window. So this if fine with me if we could avoid the extra wait when saving to a file.

Sep 5 2019, 3:01 PM · Spectacle
aprcela updated the diff for D23723: Save image to clipboard if --nonotify is used.

Edit if and add else if

Sep 5 2019, 2:50 PM · Spectacle

Sep 4 2019

aprcela added a reviewer for D23724: Cleanup source code of minor annoyances: Spectacle.
Sep 4 2019, 9:15 PM · Spectacle
aprcela requested review of D23724: Cleanup source code of minor annoyances.
Sep 4 2019, 9:14 PM · Spectacle
aprcela added reviewers for D23723: Save image to clipboard if --nonotify is used: Spectacle, davidre.
Sep 4 2019, 9:03 PM · Spectacle
aprcela added a comment to D23723: Save image to clipboard if --nonotify is used.

Same solution as here:
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n399

Sep 4 2019, 9:02 PM · Spectacle
aprcela requested review of D23723: Save image to clipboard if --nonotify is used.
Sep 4 2019, 8:59 PM · Spectacle

Sep 3 2019

aprcela added a comment to D19715: Add option to copy screenshot to clipboard in background mode.

I plan on fixing this before the beta release, or at least the full release. Anyone have any ideas what might be causing this?

Sep 3 2019, 12:37 PM · Spectacle
aprcela added a comment to D23534: FIX: Properly close spectacle after Save As.

Ok!

Sep 3 2019, 10:57 AM · Spectacle

Sep 2 2019

aprcela added a comment to D23534: FIX: Properly close spectacle after Save As.

I talked with Kai and we need the connection in line 341 for not plasma implementations of notifications. So best to restore it and also update the condition there.

Sep 2 2019, 7:12 PM · Spectacle
aprcela updated the diff for D23534: FIX: Properly close spectacle after Save As.
  • Revert connect and change if condition inside it
Sep 2 2019, 7:11 PM · Spectacle

Sep 1 2019

aprcela added a comment to D23534: FIX: Properly close spectacle after Save As.

Curious that it seems to work without it. @broulik is setting the URL enough for clicking it to open the image? Is this handled by KNotification then? Also will this only work in Plasma or would the connect still be needed for when not under Plasma?

I tested only on plasma. If Spectacle is launched this way: `spectacle -b' , than it saves the image to the default location and shows the notification. The thumbnail in the notification appears after a very short time tho (less than half a sec) .

It's about opening the picture by clicking on the notification.

Sep 1 2019, 7:46 PM · Spectacle
aprcela added a comment to D23534: FIX: Properly close spectacle after Save As.

Curious that it seems to work without it. @broulik is setting the URL enough for clicking it to open the image? Is this handled by KNotification then? Also will this only work in Plasma or would the connect still be needed for when not under Plasma?

Sep 1 2019, 6:58 PM · Spectacle

Aug 29 2019

aprcela updated the summary of D23548: Simplify copying to clipboard removing one method call.
Aug 29 2019, 8:38 AM · Spectacle
aprcela added a comment to D23548: Simplify copying to clipboard removing one method call.

setPixmap does exactly the same thing, from Qt's source code:

void QClipboard::setPixmap(const QPixmap &pixmap, Mode mode)
{
    QMimeData *data = new QMimeData;
    data->setImageData(pixmap);
    setMimeData(data, mode);
}

and you lost the x-kde-force-image-copy hint, so I don't think this patch is neccessary.

What you can try is just not converting toImage() first because it seems Qt can do that internally/implicitly.

From qmimedata.cpp

// images and pixmaps are interchangeable
if ((type == QVariant::Pixmap && data.type() == QVariant::Image)
    || (type == QVariant::Image && data.type() == QVariant::Pixmap))
    return data;
Aug 29 2019, 8:30 AM · Spectacle
aprcela updated the diff for D23548: Simplify copying to clipboard removing one method call.

Revert back to QMimeData. Removed toImage() sine QT converts internally

Aug 29 2019, 8:22 AM · Spectacle

Aug 28 2019

aprcela added a comment to D23548: Simplify copying to clipboard removing one method call.

Apparently, this is slower than setImage() because:

Aug 28 2019, 10:09 PM · Spectacle
aprcela updated the test plan for D23548: Simplify copying to clipboard removing one method call.
Aug 28 2019, 9:57 PM · Spectacle
aprcela added a reviewer for D23548: Simplify copying to clipboard removing one method call: davidre.
Aug 28 2019, 9:56 PM · Spectacle
aprcela updated the diff for D23548: Simplify copying to clipboard removing one method call.

Remove include of QMimeData

Aug 28 2019, 9:55 PM · Spectacle
aprcela requested review of D23548: Simplify copying to clipboard removing one method call.
Aug 28 2019, 9:54 PM · Spectacle
aprcela added a comment to D23534: FIX: Properly close spectacle after Save As.

BUG: 389694

I don't know if this fixes the bug completely. If you read the comments there are multiple ways described to cause spectacle to stay open.
Maybe rather CCBUG?

Aug 28 2019, 7:32 PM · Spectacle
aprcela updated the diff for D23534: FIX: Properly close spectacle after Save As.
  • Remove redundant check and redundant connect
Aug 28 2019, 7:28 PM · Spectacle
aprcela removed a watcher for Dolphin: aprcela.
Aug 28 2019, 6:59 PM
aprcela added a reviewer for D23534: FIX: Properly close spectacle after Save As: davidre.
Aug 28 2019, 1:20 PM · Spectacle
aprcela added a comment to D23467: Unify how image export is reported.

Looks good, nothing to change. :)

Aug 28 2019, 1:09 PM · Spectacle
aprcela requested review of D23536: Rename mCopySaveLocationToClipboard to mCopyToClipboard.
Aug 28 2019, 12:52 PM · Spectacle
aprcela updated the diff for D23522: FIX: Close spectacle if it's started with: -b -c.

Move connect outside of the else

Aug 28 2019, 12:18 PM · Spectacle
aprcela added a comment to D23522: FIX: Close spectacle if it's started with: -b -c.

Looking at this the connect should be outside the if instead of just adding it outside the if.
When I added this in c6ad1d6ae9291685b2767ab70bdeaaadb7783658 there was no if. I think that's because of the cherry-pick in 7f30ee858368695a10ebbe628aabf0ef688f60cf?

Aug 28 2019, 12:14 PM · Spectacle
aprcela requested review of D23534: FIX: Properly close spectacle after Save As.
Aug 28 2019, 11:44 AM · Spectacle
aprcela updated the summary of D23522: FIX: Close spectacle if it's started with: -b -c.
Aug 28 2019, 10:34 AM · Spectacle
aprcela updated the test plan for D23522: FIX: Close spectacle if it's started with: -b -c.
Aug 28 2019, 10:33 AM · Spectacle
aprcela added a reviewer for D23522: FIX: Close spectacle if it's started with: -b -c: davidre.
Aug 28 2019, 10:33 AM · Spectacle
aprcela requested review of D23522: FIX: Close spectacle if it's started with: -b -c.
Aug 28 2019, 10:28 AM · Spectacle

Aug 26 2019

aprcela added a comment to D23210: Add autosave feature.

Removed the unnecessary variables.
Tested & working.

Aug 26 2019, 8:49 AM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Remove unnecessary variables
Aug 26 2019, 8:47 AM · Spectacle

Aug 24 2019

aprcela added a dependent revision for D23210: Add autosave feature: D23366: [Spectacle] Implement Tasks feature (WiP).
Aug 24 2019, 10:44 PM · Spectacle
aprcela added a dependency for D23366: [Spectacle] Implement Tasks feature (WiP): D23210: Add autosave feature.
Aug 24 2019, 10:44 PM · Spectacle
aprcela updated the diff for D23366: [Spectacle] Implement Tasks feature (WiP).
  • proper rebase. hopefully
Aug 24 2019, 10:39 PM · Spectacle
aprcela added a comment to D23210: Add autosave feature.

Done , tested & working :)

Aug 24 2019, 9:49 PM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Reduce code duplication
Aug 24 2019, 9:48 PM · Spectacle
aprcela added inline comments to D23210: Add autosave feature.
Aug 24 2019, 2:50 PM · Spectacle

Aug 23 2019

aprcela added inline comments to D23210: Add autosave feature.
Aug 23 2019, 9:55 AM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Reduce code duplication
Aug 23 2019, 9:54 AM · Spectacle
aprcela updated the diff for D23366: [Spectacle] Implement Tasks feature (WiP).
  • Fix git branch mashup

And still including more than it should..
Can someone help me out with this one?

Aug 23 2019, 8:51 AM · Spectacle
aprcela added a comment to D23366: [Spectacle] Implement Tasks feature (WiP).

Hm, looks like I borked my branches..
Now it shows the diff from the last two patches :/

Aug 23 2019, 8:50 AM · Spectacle
aprcela updated the diff for D23366: [Spectacle] Implement Tasks feature (WiP).
  • Use OR instead of AND
Aug 23 2019, 8:46 AM · Spectacle
aprcela added a watcher for Spectacle: aprcela.
Aug 23 2019, 8:33 AM

Aug 22 2019

aprcela updated the diff for D23366: [Spectacle] Implement Tasks feature (WiP).
  • Check if the file is valid
Aug 22 2019, 10:43 PM · Spectacle
aprcela updated the test plan for D23366: [Spectacle] Implement Tasks feature (WiP).
Aug 22 2019, 10:41 PM · Spectacle
aprcela updated the task description for T11422: Spectacle - Tasks after screenshot has been taken/saved.
Aug 22 2019, 10:34 PM · Spectacle
aprcela requested review of D23366: [Spectacle] Implement Tasks feature (WiP).
Aug 22 2019, 10:33 PM · Spectacle
aprcela added a revision to T11422: Spectacle - Tasks after screenshot has been taken/saved: D23366: [Spectacle] Implement Tasks feature (WiP).
Aug 22 2019, 10:33 PM · Spectacle
aprcela added a comment to D23210: Add autosave feature.

Will look at the code later but with that I meant using the same code structure for copying to the clipboard in a follow up patch. Emitting a signal in export manager and connecting to that in the window. Just to make the control flow consistent.

Aug 22 2019, 6:46 PM · Spectacle
aprcela added a comment to D23210: Add autosave feature.

Did some changes. Please check now.
Also: see the hint for doCopyToClipboard:

Aug 22 2019, 3:22 PM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Renameing and reordering
Aug 22 2019, 3:17 PM · Spectacle
aprcela added a comment to D23210: Add autosave feature.

Great! Now we also have to set the windowTitle and modification status like in KSMainWindow::imageSaved. Maybe instead of the showFeedback method we could do a imageCopiedAndSaved method inside KSMainWindow and connect that to the signal of the ExportManager. Like the imageSaved.
I think that would be cleaner. Do you agree? And after that one of us could do the same for just copying so that everything is consistent.

Aug 22 2019, 2:56 PM · Spectacle
aprcela added a comment to D23210: Add autosave feature.

Or we create an ExportManager::doSaveAndCopy method which emits a new signal which then we connect to a new KSMainWindow::showSavedAndCopiedFeedback.

Aug 22 2019, 1:41 PM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Add new AutoSave related methods.
Aug 22 2019, 1:39 PM · Spectacle
aprcela added a comment to D23210: Add autosave feature.

Update it to not use enum. Don't worry, it wasn't useless. I learned more :)

Aug 22 2019, 9:53 AM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Rewrite to not use enum
Aug 22 2019, 9:41 AM · Spectacle

Aug 21 2019

aprcela added a comment to D23210: Add autosave feature.

Works great.

However, now that I see the three radio buttons, I realize that it might be nice to be able to auto-save as well as copy to clipboard, which seems to be what https://bugs.kde.org/show_bug.cgi?id=390415 is asking for. I wouldn't use it, but I guess the reporter would.

So instead of three radio buttons ("do nothing", "copy to clipboard", "auto save"), maybe we could actually simplify the UI to two checkboxes ("copy to clipboard", "auto save"), with both being unchecked implying "do nothing".

Thoughts?

Aug 21 2019, 10:01 PM · Spectacle
aprcela updated subscribers of D23210: Add autosave feature.

Needs a rebase

Aug 21 2019, 9:47 PM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Resolved merge conflicts
Aug 21 2019, 9:45 PM · Spectacle
aprcela updated the diff for D23210: Add autosave feature.
  • Merge with D23162 and update config layouts
  • Rebase with D23162 and modify to use enum
Aug 21 2019, 9:37 PM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

Looks like you have some non-UNIX line endings that our commit hookscript complains about when I try to land the patch:

remote: Audit failure - Commit 10a29ef1849c50547c13adc2416a02dfb82b4378 - End of Line Style (non-Unix): src/Gui/SettingsDialog/SaveOptionsPage.cpp
remote: Push declined - commits failed audit

Can you fix it?

Aug 21 2019, 2:26 PM · Spectacle
aprcela updated the diff for D23162: Add option to additionally save screenshot to clipboard.
  • Fix end of line
Aug 21 2019, 2:24 PM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

To push to KDE repositories you need to have a developer account. If you don't have one I can commit for you.

Aug 21 2019, 2:08 PM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

Sorry for being annoying but I had a last look :)

Do you have commit access?

Aug 21 2019, 2:01 PM · Spectacle
aprcela updated the diff for D23162: Add option to additionally save screenshot to clipboard.
  • Setting variable renamed, remove commented code
Aug 21 2019, 2:00 PM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

I hope that's it :)

Aug 21 2019, 1:52 PM · Spectacle
aprcela updated the diff for D23162: Add option to additionally save screenshot to clipboard.
  • Setting variable renamed
Aug 21 2019, 1:51 PM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

All done. I hope the names a re better now. Any recommendation for kde-dev best-practices?

Aug 21 2019, 1:46 PM · Spectacle
aprcela updated the diff for D23162: Add option to additionally save screenshot to clipboard.
  • Rename variables, methods and enum. Remove unnecessary logic
Aug 21 2019, 1:42 PM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

Last nitpicks:

  • Since with your other patch this setting will control what happens after a Screenshot is taken and does not control what to copy to the clipboard, could you rename some variables accordingly?
Aug 21 2019, 1:31 PM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

Done. Tested & it's working.

Aug 21 2019, 12:38 PM · Spectacle
aprcela updated the diff for D23162: Add option to additionally save screenshot to clipboard.
  • Move showInlineMessage() and MessageDuration to public
Aug 21 2019, 12:37 PM · Spectacle
aprcela added inline comments to D23162: Add option to additionally save screenshot to clipboard.
Aug 21 2019, 10:26 AM · Spectacle
aprcela updated the diff for D23162: Add option to additionally save screenshot to clipboard.
  • Remove unnecessary check
Aug 21 2019, 10:24 AM · Spectacle
aprcela added a comment to D23162: Add option to additionally save screenshot to clipboard.

Changed to enum and reverted the connect in L348 of SpectacleCore.cpp so spectacle -b -c works again.

Aug 21 2019, 10:05 AM · Spectacle
aprcela updated the diff for D23162: Add option to additionally save screenshot to clipboard.
  • Use enum for copyToClipboard
  • Revert connect to fix
Aug 21 2019, 9:57 AM · Spectacle
aprcela added a comment to T11422: Spectacle - Tasks after screenshot has been taken/saved.

Just gonna leave this here, so I don't forget about it :D

Aug 21 2019, 7:46 AM · Spectacle

Aug 20 2019

ognarb awarded T11422: Spectacle - Tasks after screenshot has been taken/saved a Love token.
Aug 20 2019, 4:55 PM · Spectacle
aprcela added a comment to T11418: DBus mode settings.

Got me into thinking:
The user sets a Shortcut and connects it to a Task.
What if, this would require quite a lot to do, we make an Task creator panel. Where a User can create his own Task and give it a name. Then, in the Schortcut settings, the user chooses which Task gets called for a specific Shortcut.
Creating a Task could include all of Spectacles functionality: After screenshot has been taken, save/edit/clipboard/... it, upload it, close Spectacle, etc.
Whereas the User sets the desired actions for a task with Checkboxes and Radiobuttons, and can have multiple tasks.
Similar to Message Filters in Thunderbird. I hope i described it well enough.

Aug 20 2019, 10:24 AM · Spectacle
aprcela updated the task description for T11422: Spectacle - Tasks after screenshot has been taken/saved.
Aug 20 2019, 10:12 AM · Spectacle
aprcela updated the task description for T11422: Spectacle - Tasks after screenshot has been taken/saved.
Aug 20 2019, 9:31 AM · Spectacle