Differential D29113

Change position of label in SaveOptions.ui
ClosedPublic
Actions

Authored by thiagosueto on Apr 23 2020, 12:04 AM.

Details

Reviewers
ngraham
davidre
Group Reviewers
Spectacle
VDG
Commits
R166:426d625a8812: Change position of label in SaveOptions.ui
Summary

Changed position of message to change image quality.
I think the label is better read before the compression quality bar.
I used Qt Designer for this.

Before:

After:

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thiagosueto requested review of this revision.Apr 23 2020, 12:04 AM
thiagosueto created this revision.
thiagosueto edited the summary of this revision. (Show Details)Apr 23 2020, 2:19 AM
ngraham accepted this revision.Apr 23 2020, 2:43 AM
ngraham added a subscriber: ngraham.

Everyone agree?

This revision is now accepted and ready to land.Apr 23 2020, 2:43 AM
davidre added a subscriber: davidre.Apr 23 2020, 7:29 AM
davidre added inline comments.
src/Gui/SettingsDialog/SaveOptions.ui
180

I don't think we need these hints

thiagosueto added a comment.Apr 23 2020, 12:40 PM

I think those appeared accidentally when I was testing how it would look like if the label text was shown as a tooltip for the Compression Quality label, I'll remove those and test it.

thiagosueto updated this revision to Diff 80991.Apr 23 2020, 12:46 PM

Removed hints

davidre accepted this revision.Apr 23 2020, 1:19 PM

Bonus points for moving items so that they are in the right order before committing (I know that the spacer was not in the right place before )

Closed by commit R166:426d625a8812: Change position of label in SaveOptions.ui (authored by thiagosueto, committed by davidre). · Explain WhyApr 23 2020, 1:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81000

View Options

src/Gui/SettingsDialog/SaveOptions.ui

Loading...