Feed Advanced Search

Today

broulik abandoned D10035: Sanitize alpha channel only if actually broken.

@davidre said something about that we don't show small thumbnails anymore anyway or something

Fri, May 29, 7:07 AM · Spectacle

Mon, May 25

meven added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Mon, May 25, 10:34 AM · Spectacle
davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Mon, May 25, 9:34 AM · Spectacle

Sat, May 23

aprcela added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

Well right now you have that problem too that you can select both. Even worse both settings are on different sub pages. I would also happy to remove Copy file location to clipboard after saving but I'm not sure if it's an extensive used feature. To me seems unnecessary when we have automatic copy.

Sat, May 23, 5:28 PM · Spectacle
aprcela updated subscribers of D29828: Respect Settings::copyImageToClipboard when StartMode is DBus.

Works, but the notification is empty and the file doesn't get saved at all:

Sat, May 23, 10:39 AM · Spectacle
pedroarthurp requested review of D29828: Respect Settings::copyImageToClipboard when StartMode is DBus.
Sat, May 23, 5:31 AM · Spectacle

Fri, May 22

meven added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

In the current implementation of this, the cursor turns to the selector for the screen. The cursor does not draw a squared selection of screen where there is black outside the selection. The app crashes or closes after the screenshot is taken. This behavior happens on Fedora 32/Plasma 5.18

Fri, May 22, 2:31 PM · Spectacle

Thu, May 21

abetts added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

In the current implementation of this, the cursor turns to the selector for the screen. The cursor does not draw a squared selection of screen where there is black outside the selection. The app crashes or closes after the screenshot is taken. This behavior happens on Fedora 32/Plasma 5.18

Thu, May 21, 10:41 PM · Spectacle

Tue, May 19

davidre added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

I assume that you mean:

Action after taking a screenshot: [] Save image to default folder location
                                  [] Copy image to clipboard

What about Copy file location to clipboard after saving, would that stay in the Save settings tab?
If yes - we'd have a problem if a users sets both of the checkboxes above and has Copy file location to clipboard after saving also set.

Tue, May 19, 3:24 PM · Spectacle
ngraham closed D29589: Remove unused variable.
Tue, May 19, 3:14 PM · Spectacle
davidre accepted D29589: Remove unused variable.
Tue, May 19, 7:32 AM · Spectacle
davidre added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

Tue, May 19, 7:32 AM · Spectacle

Mon, May 18

aprcela added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

Mon, May 18, 9:37 PM · Spectacle
aprcela added a comment to D29589: Remove unused variable.

@davidre ping :)

Mon, May 18, 9:33 PM · Spectacle

Sat, May 16

meven updated the summary of D29282: QuickEditor: Allow to take screen region screenshot under Wayland.
Sat, May 16, 9:07 AM · Spectacle

Fri, May 15

meven updated the diff for D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Spacing

Fri, May 15, 9:55 AM · Spectacle
czeidler added a comment to D29550: Add selection support for already taken screenshots.

I had another thought on it and think having all the functionality for both cases in one class is probably a bit too big and both use cases are actually too different. The common part that can be shared between both cases is the selectable rectangle + the magnifier. I think all other functionality / logic should go into QuickEditor and KSImageWidget respectively. I am wondering if that is an option, i.e. refactor a selection primitive to select a rectangular area (possibly implemented as QGraphicsObject). I assume that's what you need as well, right? i.e. you want a rectangular selection rather than a region? We could make this new selection class customizable with an isValidSelection hook / lambda so that in your case you can reject selections that are invalid. (correct me if you need something different, I am still not 100% sure if I understood your problem right, if you have a screenshot of a distorted / problematic screen that would be great!)

Fri, May 15, 12:11 AM · Spectacle

Thu, May 14

davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I didn't review the entire code yet but seems much cleaner. A very welcome refactor!
I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Thu, May 14, 8:03 AM · Spectacle
achauvel added a comment to T10574: Make shortcuts consistent.

Any news on this?

Thu, May 14, 2:04 AM · Spectacle
lephuong added a comment to D22074: Add image annotation via libKImageAnnotator.

It would be nicer to not disable all other actions when in annotator mode, but rather just save the image then continue with the action.

Thu, May 14, 1:55 AM · Spectacle

Wed, May 13

ngraham added a comment to D21042: Refactor Spectacle's platform backends.

I will note that exactly what I was worried about happening did in fact happen: @bgupta disappeared again and the new code style is annoying and irritates other contributors.

Wed, May 13, 1:43 PM · Spectacle, KDE Applications
aprcela added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

Wed, May 13, 8:10 AM · Spectacle
meven added a comment to D29550: Add selection support for already taken screenshots.

Do you see fundamental problems combining both patches? e.g. in the KSImageWidget the mScreenRegion could simply be a single rectangle of the size of the screenshot pixmap?

Fundamentally no, the other patch essentially rewrites QuickEditor::paintEvent to support Wayland per-screen scaling/dpr.
The full screen rectangular selection and the in-KSImageWidget would need to have separate paint functions essentially.

Wed, May 13, 7:47 AM · Spectacle
czeidler added a comment to D29550: Add selection support for already taken screenshots.

Do you see fundamental problems combining both patches? e.g. in the KSImageWidget the mScreenRegion could simply be a single rectangle of the size of the screenshot pixmap?

Wed, May 13, 7:20 AM · Spectacle
davidre added a comment to T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

Wed, May 13, 7:10 AM · Spectacle

Tue, May 12

aprcela renamed T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab from Spectacle - rearrange settings and maybe add more? to Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab.
Tue, May 12, 8:49 PM · Spectacle
aprcela lowered the priority of T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab from Low to Wishlist.
Tue, May 12, 8:30 PM · Spectacle
aprcela triaged T13145: Rearrange settings and depending on rearrangement maybe add more setting in Shortcut settings tab as Low priority.
Tue, May 12, 8:29 PM · Spectacle
meven added a comment to D29550: Add selection support for already taken screenshots.

That's a nice feature.

Tue, May 12, 6:13 PM · Spectacle
ngraham edited reviewers for D29550: Add selection support for already taken screenshots, added: Spectacle, meven; removed: bgupta.
Tue, May 12, 4:22 PM · Spectacle
meven updated the summary of D29408: Wayland: allow to take immediate and delayed screenshots.
Tue, May 12, 3:15 PM · Spectacle
meven added inline comments to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.
Tue, May 12, 3:09 PM · Spectacle
meven updated the test plan for D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Tue, May 12, 2:44 PM · Spectacle
meven added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Patch is ready for review.

Tue, May 12, 2:43 PM · Spectacle
meven updated the diff for D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Move SpectacleCore on the stack to avoid crashes, small refactoring

Tue, May 12, 1:45 PM · Spectacle
meven added a dependency for D29282: QuickEditor: Allow to take screen region screenshot under Wayland: D29122: ScreenShotEffect: Add a shouldReturnNativeSize argument to screenshotFullscreen.
Tue, May 12, 5:40 AM · Spectacle
meven added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

Tue, May 12, 5:38 AM · Spectacle

Mon, May 11

meven updated the diff for D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Add --new-instance option, clean deletion of app

Mon, May 11, 3:15 PM · Spectacle
davidre closed D29620: Disconnect after receiving screenshot signal.
Mon, May 11, 1:29 PM · Spectacle
meven accepted D29620: Disconnect after receiving screenshot signal.

Wayland was not concerned since screenshot replies are handled through file Desrcriptors.

Mon, May 11, 12:58 PM · Spectacle
meven updated the summary of D29620: Disconnect after receiving screenshot signal.
Mon, May 11, 12:54 PM · Spectacle
meven added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

I guess on app start you would check if there is an instance on the bus already and then do the right thing?

Mon, May 11, 9:24 AM · Spectacle
czeidler updated the diff for D29550: Add selection support for already taken screenshots.
  • Fix KSImageWidget cursor when there is no selection
  • Send out a selectionChanged event when selection is cleared
Mon, May 11, 9:19 AM · Spectacle
meven added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

Mon, May 11, 9:07 AM · Spectacle
czeidler added a comment to D29550: Add selection support for already taken screenshots.

Yes thats correct. That makes it possible to save multiple different selections from the same screenshot... Maybe I should make it more clear that only the selection is saved, or is that clear? However, when dragging the selection only the selected part is visible in the drag image.

Mon, May 11, 8:56 AM · Spectacle
davidre added a comment to D29550: Add selection support for already taken screenshots.

Ah I see, the select button will change the pixmap what is saved/copied but not the displayed one?

Mon, May 11, 8:40 AM · Spectacle
davidre requested review of D29620: Disconnect after receiving screenshot signal.
Mon, May 11, 8:38 AM · Spectacle
czeidler added a comment to D29550: Add selection support for already taken screenshots.

There should be a 'Select' button on the right side of the window (see below). Once you click it you can start a selection. During the time of the first selection the button is disabled. Happy to get feedback for the button location, label or better position.

Mon, May 11, 8:36 AM · Spectacle
aprcela added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

So I have to check this box and it is under the "When spectacle is running" section. But the image will be autosaved regardless whether the other checkbox is saved or not. I think the problem is no easy but I will try again to think of something.

Mon, May 11, 8:25 AM · Spectacle
davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I would like to keep the option. We currently just start a new `Qprocess with "spectacle" would that still work?

Mon, May 11, 8:19 AM · Spectacle
davidre added a comment to D29408: Wayland: allow to take immediate and delayed screenshots.

Why do we introduce the distinction between delayed and immediate? Is there a difference between delayed with 0 seconds and immediate? Also every screenshot triggered by the gui arrives at spectacle core with delay <= 0 because ksmainwindow waits the delay for the taskmanager animation and animating the button.

Mon, May 11, 8:16 AM · Spectacle
davidre added a comment to D29596: Copy image to clipboard using hotkeys while spectacle is not running.

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

Mon, May 11, 8:12 AM · Spectacle
davidre added a comment to D29550: Add selection support for already taken screenshots.

Very cool! However I can't seem to figure out a way to select a selection.
How do you think does this relate to D22074? Maybe we can integrate both patches somehow?

Mon, May 11, 8:07 AM · Spectacle
davidre added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

So on screen we have the non rectangular pixel perfect pixmap but we return a rectangular pixmap? Which size will that have?

Mon, May 11, 8:00 AM · Spectacle

Sun, May 10

meven added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Let me know @davidre if I can ease your review ;)

Sun, May 10, 1:49 PM · Spectacle
aprcela added reviewers for D29589: Remove unused variable: Spectacle, davidre, ngraham.
Sun, May 10, 12:46 PM · Spectacle
aprcela updated the test plan for D29596: Copy image to clipboard using hotkeys while spectacle is not running.
Sun, May 10, 12:40 PM · Spectacle
aprcela added reviewers for D29596: Copy image to clipboard using hotkeys while spectacle is not running: Spectacle, ngraham, davidre.
Sun, May 10, 12:40 PM · Spectacle
aprcela requested review of D29596: Copy image to clipboard using hotkeys while spectacle is not running.
Sun, May 10, 12:36 PM · Spectacle
aprcela requested review of D29589: Remove unused variable.
Sun, May 10, 11:36 AM · Spectacle

Sat, May 9

czeidler added reviewers for D29550: Add selection support for already taken screenshots: bgupta, davidre.
Sat, May 9, 10:03 AM · Spectacle
czeidler requested review of D29550: Add selection support for already taken screenshots.
Sat, May 9, 9:50 AM · Spectacle

Thu, May 7

meven planned changes to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

This patch currently implies removing the option to have multipe instances of spectacle, and we have a setting to have this upon pressing the Print key.
So should I keep the multiple instance mode ? @davidre @ngraham
It is feasible.
Any time the commandline with the background option or with the setting "Open a new Spectacle window" is set I would start a new Gui instance.

Thu, May 7, 10:54 AM · Spectacle
anthonyfieroni added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Thu, May 7, 10:46 AM · Spectacle
davidre added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Just a heads up you don't need to use the weird lvariable, theParam code style. See discussion in https://phabricator.kde.org/D21042

Thu, May 7, 9:45 AM · Spectacle
broulik added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Thu, May 7, 9:23 AM · Spectacle
meven updated the diff for D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

Store QApplication on the stack

Thu, May 7, 7:55 AM · Spectacle
meven updated the summary of D29408: Wayland: allow to take immediate and delayed screenshots.
Thu, May 7, 7:28 AM · Spectacle
meven updated the summary of D29282: QuickEditor: Allow to take screen region screenshot under Wayland.
Thu, May 7, 7:28 AM · Spectacle

Wed, May 6

anthonyfieroni added a comment to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.

I don't see why qApp is not deleted here
https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kdbusaddons/html/kdbusservice_8cpp_source.html#l00099

Wed, May 6, 5:37 PM · Spectacle
anthonyfieroni added inline comments to D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Wed, May 6, 5:33 PM · Spectacle
meven added reviewers for D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique: bport, davidedmundson, apol.
Wed, May 6, 5:25 PM · Spectacle
meven requested review of D29487: Refactor Spectacle to run in single instance mode with KDBusService::Unique.
Wed, May 6, 5:24 PM · Spectacle
meven updated the summary of D29282: QuickEditor: Allow to take screen region screenshot under Wayland.
Wed, May 6, 2:38 PM · Spectacle

Tue, May 5

ngraham added a dependency for D29408: Wayland: allow to take immediate and delayed screenshots: D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
Tue, May 5, 4:36 PM · Spectacle
meven planned changes to D29408: Wayland: allow to take immediate and delayed screenshots.

Spectacle must have its executable in its desktop entry Exec field.
To manage this, spectacle must use KDBusService::Unique instead of Multiple.
This requires some refactoring.

Tue, May 5, 4:21 PM · Spectacle
meven added a reviewer for D29408: Wayland: allow to take immediate and delayed screenshots: ngraham.
Tue, May 5, 5:37 AM · Spectacle

Mon, May 4

meven requested review of D29408: Wayland: allow to take immediate and delayed screenshots.
Mon, May 4, 1:53 PM · Spectacle

Sun, May 3

aleasto added a comment to D28395: Added CopyToClipboard parameter to dbus RectangularRegion and set up shortcut keys.

Nah, I think for these new ones, just putting it on the clipboard is fine. The point after all is just to quickly paste an image into like a chat window or something.

Sun, May 3, 2:38 PM · Spectacle

Fri, May 1

meven closed D29305: PlatformKWinWayland: Print an error in console when DBus call fails.
Fri, May 1, 2:04 PM · Spectacle
davidedmundson accepted D29305: PlatformKWinWayland: Print an error in console when DBus call fails.
Fri, May 1, 1:54 PM · Spectacle
meven updated the diff for D29305: PlatformKWinWayland: Print an error in console when DBus call fails.

Move deleteLater out of if

Fri, May 1, 1:21 PM · Spectacle

Thu, Apr 30

davidedmundson added inline comments to D29305: PlatformKWinWayland: Print an error in console when DBus call fails.
Thu, Apr 30, 7:12 PM · Spectacle
meven updated the diff for D29305: PlatformKWinWayland: Print an error in console when DBus call fails.

Add a deleteLater

Thu, Apr 30, 4:41 PM · Spectacle
davidedmundson added a comment to D29305: PlatformKWinWayland: Print an error in console when DBus call fails.

one super minor change

Thu, Apr 30, 4:37 PM · Spectacle
meven requested review of D29305: PlatformKWinWayland: Print an error in console when DBus call fails.
Thu, Apr 30, 4:33 PM · Spectacle
meven updated the diff for D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Schedule an update instead of repaint in QuickEditor::onScreenConfigurationReceived

Thu, Apr 30, 9:13 AM · Spectacle
meven updated the test plan for D29282: QuickEditor: Allow to take screen region screenshot under Wayland.
Thu, Apr 30, 9:11 AM · Spectacle
meven updated the diff for D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Rename dpr and dprI to devicePixelRatio and devicePixelRatio to differenciate to dpr variable that is per-screen, fix stroke color around selection

Thu, Apr 30, 7:07 AM · Spectacle

Wed, Apr 29

davidre added a comment to D29282: QuickEditor: Allow to take screen region screenshot under Wayland.

Can you add some more explanation what the code does in the summary?

Wed, Apr 29, 6:00 PM · Spectacle
meven added a reviewer for D29282: QuickEditor: Allow to take screen region screenshot under Wayland: bport.
Wed, Apr 29, 5:22 PM · Spectacle
meven requested review of D29282: QuickEditor: Allow to take screen region screenshot under Wayland.
Wed, Apr 29, 5:21 PM · Spectacle

Apr 23 2020

davidre closed D29113: Change position of label in SaveOptions.ui.
Apr 23 2020, 1:56 PM · Spectacle
davidre accepted D29113: Change position of label in SaveOptions.ui.

Bonus points for moving items so that they are in the right order before committing (I know that the spacer was not in the right place before )

Apr 23 2020, 1:19 PM · Spectacle
meven added a reviewer for D29113: Change position of label in SaveOptions.ui: davidre.
Apr 23 2020, 1:04 PM · Spectacle
thiagosueto updated the diff for D29113: Change position of label in SaveOptions.ui.

Removed hints

Apr 23 2020, 12:46 PM · Spectacle
thiagosueto added a comment to D29113: Change position of label in SaveOptions.ui.

I think those appeared accidentally when I was testing how it would look like if the label text was shown as a tooltip for the Compression Quality label, I'll remove those and test it.

Apr 23 2020, 12:40 PM · Spectacle
davidre added inline comments to D29113: Change position of label in SaveOptions.ui.
Apr 23 2020, 7:29 AM · Spectacle
ngraham accepted D29113: Change position of label in SaveOptions.ui.

Everyone agree?

Apr 23 2020, 2:43 AM · Spectacle
thiagosueto updated the summary of D29113: Change position of label in SaveOptions.ui.
Apr 23 2020, 2:19 AM · Spectacle