Awesome.

I am continuing work on this feature here: https://invent.kde.org/graphics/spectacle/-/merge_requests/129 (My code is loosely based on Leon's. I wasn't able to help with pushing this MR over the finish line back then but I always wanted to see this actually get merged.)

perfect.

This is in progress with https://invent.kde.org/graphics/spectacle/-/merge_requests/119

Hi @acrouthamel ! Do you have any further information about the kwin functionality? was it in any way used? Or is anybody working on this?

Resolved by adding an option in https://invent.kde.org/graphics/spectacle/-/merge_requests/71.

Done in Spectacle 20.08 IIRC.

Sweet!

Awesome feature!

Thanks for the feedback. Totally understand that the rectangular region capture mode is a desirable feature and that it is not an option to drop it.

It doesn't work when trying to capture open menus. At least on X11, menus close when doing the capture.

In D29282#676586, @czeidler wrote:

I am the author of D29550 which adds supports for a post capture selection option for already taken screenshots. D29550 is currently blocked by this patch.

After giving it a good thought, I see the following general problems with the existing rectangular region capture mode:

1. It doesn't work when trying to capture open menus. At least on X11, menus close when doing the capture.
2. By supporting different screen scales, the QuickEditor code becomes very complex. I wouldn't feel comfortable applying a patch while keeping all the screen scaling in mind. I would have to invest quite some time to get a deep understanding of the scaling problem and even then I doubt I could make changes without introducing any new issues, which brings me to the next point.
3. Testing, how do we test any changes? With X11, Wayland, scaling factors, monitor positions and X QuickEditor features there seem to be too many combinations to test properly. Especially, I don't see a reliable and easy way to automate these kind of tests.
4. All the hard bits of translating real screen position to window positions which is already done by the display server needs to be redone in QuickEditor (more or less). Not really a problem but also not a nice thing to do.
   
   For this reason I suggest the following approach: a) Compose the screen capture(s) into a single pixmap as it is done already. b) Drop support for rectangular region capture mode in favour of the post selection mode in D29550 which operates on this pixmap.
   
   This has the advantage that a) and b) are completely decoupled. How the pixmap is composed can easily be changed and screen scales can be applied as desired. QuickEditor stays relatively simple and straightforward to modify.

Replaced by https://invent.kde.org/graphics/spectacle/-/merge_requests/29

I am the author of D29550 which adds supports for a post capture selection option for already taken screenshots. D29550 is currently blocked by this patch.

Yaayy!

Merging this as discussed in the VDG chat

Can this be moved over to invent.kde.org and merged?

For now this patch is blocked until we can get the screen scale factor from somewhere else than libkscreen.

In D29282#676011, @meven wrote:

In D29282#676008, @ngraham wrote:

Tried this out and Rectangular Region mode disappeared from the combobox.

I think this is because there is a now check in spectacle that plasma is > 5.20 for the shuttermode.

Should check for > 5.19.80 then

In D29282#676008, @ngraham wrote:

Tried this out and Rectangular Region mode disappeared from the combobox.

I think this is because there is a now check in spectacle that plasma is > 5.20 for the shuttermode.
You can edit the PlatformKWinWayland::supportedShutterModes to work locally.
The patch needs adjustment.

Would be really nice to finally get this in.

Tried this out and Rectangular Region mode disappeared from the combobox.

Rebased on master

Ah, that sounds like a sensible idea.

In D29282#675339, @ngraham wrote:

Needs a rebase.

Needs a rebase.

Not really needed now that the notification has a hamburger menu on it.

Needs https://invent.kde.org/graphics/spectacle/-/merge_requests/5 after latest D29408 changes

Check Plasma major version, use splitRef

Make raw DBus call

In D29408#674966, @meven wrote:

In D29408#674962, @davidre wrote:

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

The alternative is just less documented AFAICT.
IRC the alternative is about adding xml files that generate code.

In D29408#674962, @davidre wrote:

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

I think we shouldn't use QDBUsInterface but given that we already do this is probably ok

Very short nice!

I am abandonning https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs.

Check only once the plasma version when needed

Avoid adding the dependency to spectacle

This adds a dependency on https://invent.kde.org/frameworks/kdbusaddons/-/merge_requests/1/diffs

Use KDBusAddon' PlasmaVersion

https://invent.kde.org/graphics/spectacle/-/merge_requests/3 was merged

Removed .arcconfig, rebased

This is ready to land except I need either to :

• wait after 20.08 is released since this fix is dependent on KWin D29407 that won't be available before Plasma 5.20.
• or add a runtime plasma version check

Clean up delayed shutterMode

Fix build

Maybe that https://phabricator.kde.org/D23932 would come in handy?

Is there a way we can make it a runtime dependency rather than a build-time dependency? I'm just worried about people trying to install Spectacle on a non-Plasma platform and then getting half of Plasma dragged in, which would also complicate packaging for Snap, Flatpak, and AppImage.

All right, maybe it was a local config issue on my side. I'll make noise if it stays broken. :)

In D29487#673809, @meven wrote:

In D29487#673803, @davidre wrote:

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Well it is not a flaw, it is by design.
--new-instance launches an instance without dbus connection and unique instance.
The first one without --new-instance will be the dbus unique instance.

Alright I guess. Should we maybe even hide it from the user visible options then?

In D29487#674322, @ngraham wrote:

Hmm, for me this breaks the option to open a new instance when the PrintScreen key is pressed and an existing instance is already running. It only works if I launch Spectacle manually using the --new-instance flag. The feature should work regardless of how the app is launched.

In D29282#674390, @ngraham wrote:

Hmm, that's unfortunate. Is there really no cross-compositor screenshot API in Wayland? Every compositor needs to re-invent the wheel?

Hmm, that's unfortunate. Is there really no cross-compositor screenshot API in Wayland? Every compositor needs to re-invent the wheel?

In D29282#674318, @ngraham wrote:

I don't think making KScreen a mandatory dependency is going to work. If we do that, then installing Spectacle on a platform other than Plasma is going to try to pull in all of KScreen and its dependencies. It would be half of the Plasma stack.

Hmm, for me this breaks the option to open a new instance when the PrintScreen key is pressed and an existing instance is already running. It only works if I launch Spectacle manually using the --new-instance flag. The feature should work regardless of how the app is launched.

I don't think making KScreen a mandatory dependency is going to work. If we do that, then installing Spectacle on a platform other than Plasma is going to try to pull in all of KScreen and its dependencies. It would be half of the Plasma stack.

@davidre said something about that we don't show small thumbnails anymore anyway or something

In D29487#673803, @davidre wrote:

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Ping. Did you have time to look into

I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

In T13145#230815, @davidre wrote:

Well right now you have that problem too that you can select both. Even worse both settings are on different sub pages. I would also happy to remove Copy file location to clipboard after saving but I'm not sure if it's an extensive used feature. To me seems unnecessary when we have automatic copy.

Works, but the notification is empty and the file doesn't get saved at all:

In D29282#673363, @abetts wrote:

In the current implementation of this, the cursor turns to the selector for the screen. The cursor does not draw a squared selection of screen where there is black outside the selection. The app crashes or closes after the screenshot is taken. This behavior happens on Fedora 32/Plasma 5.18

In the current implementation of this, the cursor turns to the selector for the screen. The cursor does not draw a squared selection of screen where there is black outside the selection. The app crashes or closes after the screenshot is taken. This behavior happens on Fedora 32/Plasma 5.18

I assume that you mean:

Action after taking a screenshot: [] Save image to default folder location
                                  [] Copy image to clipboard

What about Copy file location to clipboard after saving, would that stay in the Save settings tab?
If yes - we'd have a problem if a users sets both of the checkboxes above and has Copy file location to clipboard after saving also set.

In D29596#672772, @aprcela wrote:

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

@davidre ping :)

Spacing

I had another thought on it and think having all the functionality for both cases in one class is probably a bit too big and both use cases are actually too different. The common part that can be shared between both cases is the selectable rectangle + the magnifier. I think all other functionality / logic should go into QuickEditor and KSImageWidget respectively. I am wondering if that is an option, i.e. refactor a selection primitive to select a rectangular area (possibly implemented as QGraphicsObject). I assume that's what you need as well, right? i.e. you want a rectangular selection rather than a region? We could make this new selection class customizable with an isValidSelection hook / lambda so that in your case you can reject selections that are invalid. (correct me if you need something different, I am still not 100% sure if I understood your problem right, if you have a screenshot of a distorted / problematic screen that would be great!)

I didn't review the entire code yet but seems much cleaner. A very welcome refactor!
I noticed a flaw however in the current code if the first instance of spectacle is started with --new-instance a second one will always be started when the shortcut is pressed regardless of the setting.

Any news on this?

It would be nicer to not disable all other actions when in annotator mode, but rather just save the image then continue with the action.

I will note that exactly what I was worried about happening did in fact happen: @bgupta disappeared again and the new code style is annoying and irritates other contributors.

In T13145#230250, @davidre wrote:

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

In D29550#669814, @czeidler wrote:

Do you see fundamental problems combining both patches? e.g. in the KSImageWidget the mScreenRegion could simply be a single rectangle of the size of the screenshot pixmap?

Fundamentally no, the other patch essentially rewrites QuickEditor::paintEvent to support Wayland per-screen scaling/dpr.
The full screen rectangular selection and the in-KSImageWidget would need to have separate paint functions essentially.

Do you see fundamental problems combining both patches? e.g. in the KSImageWidget the mScreenRegion could simply be a single rectangle of the size of the screenshot pixmap?

My idea would be:

Action after taking a screenshot: [] Save
                                  [] Copy

You can select one or both but not none. (Can we do that in a self explanatory way)?
Probably in general settings? And then we could add another checkbox [] Also do that when Spectacle is running

That's a nice feature.