- Group Reviewers
- Maniphest Tasks
- T6321: [WISH] Create a quick image editor for Spectacle
This is really nice. I love that it's not even a huge amount of code either. Also +1 for making it conditional on finding the lib. Unfortunately, the lib is not yet distributed with KDE Frameworks, and it also depends on another widget that currently lives in a private github repo: https://github.com/DamirPorobic/kColorPicker. We'll need to upstream that so that libkimageannotator will even build cleanly, which seems important anyway considering that it's a KDE project.
Do you think we should wait until all the bits are in KDE first, or get this in sooner so that the feature magically works once the supporting libs are available?
That's true, but I'm not sure that the external KColorPicker library is widely packaged given that it was created especially for KSnip. But maybe I'm wrong (it's just a guess after all). And I'm of course quite interested in getting this landed sooner rather than later. :)
BTW, the KDE Applications 19.08 dependency freeze is in 11 days: https://community.kde.org/Schedules/Applications/19.08_Release_Schedule#Thursday.2C_July_11.2C_2019:_KDE_Applications_19.08_Dependency_Freeze
So if we want to get this into 19.08.0, we'll need to figure out what we want to do about the dependencies before then. And if we plan to upstream KColorPicker into KWidgetsAddons, that needs to happen in time for KDE Frameworks 5.60, which is tagged in 6 days.
Hmm I can only get libkimageannotator to build when kcolorpicker is installed to /usr/local not into my prefix. Otherwise cmake finds it but the headers aren't found during the build. Maybe we would have to invest time into bringing it's cmake files up to par?
It seems to me that KColorPicker has not been pushed into KWidgetsAddons until now. Maybe it would also help to port KImageAnnotator to make use of KColorButton instead which is already included in the widgets?
As I am no developer I am not sure if this could help but it seems to me that this dependency/build problem is the last piece left before it could be shipped, right?
All commits for kColorPicker:
Meanwhile there have been some updates to kImageAnnotator, maybe you want to add them too, even tough some unit tests are currently broken, I need to fix them, so potentially more commits coming.
If you had plans to to fix the libkimageannotator build failure, you might want to just commit it yourself. I don't think the author is paying attention to the version on KDE infrastructure as I see it's developed on GitHub again at https://github.com/ksnip/kImageAnnotator.
...For that matter maybe it makes sense to just link against that library rather than the old version on KDE infra.
It would be nicer to not disable all other actions when in annotator mode, but rather just save the image then continue with the action.
- That's one step less for the users, and a lot of steps less if they are making a lot of screenshot and annotating them before saving or sharing.
- It's the same behavior with many popular screenshot tools. They don't require user to turn off the annotation mode to be able to save/share the screenshot.
Since this change didn't make it to 20.04, We should have more time to put more effort in coding the above UX until the next Application release.