Copy image to clipboard using hotkeys while spectacle is not running
Needs ReviewPublic

Authored by aprcela on Sun, May 10, 12:36 PM.

Details

Reviewers
ngraham
davidre
Group Reviewers
Spectacle
Summary
Test Plan

Currently:

  1. Set Copy image to clipboard as enabled in the General settings of spectacle.
  2. Don't have spectacle running.
  3. Use any of the configured global hotkeys to take a screenshot (for example the default: Shift+Meta).
  4. Screenshot doesn't end up in clipboard.

With this:

  1. Set Copy image to clipboard as enabled in the General settings of spectacle.
  2. Don't have spectacle running.
  3. Use any of the configured global hotkeys to take a screenshot (for example the default: Shift+Meta).
  4. Screenshot ends up in clipboard as expected.

Diff Detail

Repository
R166 Spectacle
Branch
bug_420477
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26650
Build 26668: arc lint + arc unit
aprcela created this revision.Sun, May 10, 12:36 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptSun, May 10, 12:36 PM
Restricted Application added a subscriber: Spectacle. · View Herald Transcript
aprcela requested review of this revision.Sun, May 10, 12:36 PM
aprcela edited the summary of this revision. (Show Details)Sun, May 10, 12:40 PM
aprcela edited the test plan for this revision. (Show Details)
aprcela added reviewers: Spectacle, ngraham, davidre.
aprcela edited the test plan for this revision. (Show Details)

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

So I have to check this box and it is under the "When spectacle is running" section. But the image will be autosaved regardless whether the other checkbox is saved or not. I think the problem is no easy but I will try again to think of something.

aprcela added a comment.EditedMon, May 11, 8:25 AM

I had a similar idea to have a setting that controls what happens on shortcut press and when gui is running because currently the ui does not work for this. What we have is

So I have to check this box and it is under the "When spectacle is running" section. But the image will be autosaved regardless whether the other checkbox is saved or not. I think the problem is no easy but I will try again to think of something.

Yeah, noticed that one .. When the first checkbox is checked, it will always save to clipboard (either using GUI or DBUS/Hotkey).
Maybe add settings like "save to clipboard" etc. in the "Shortcuts". OR add another checkbox "use same settings for hotkey launches"?

To not miss this new bug that would be introduced with this patch: https://bugs.kde.org/show_bug.cgi?id=420477#c13

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

@davidre One other thing I noticed: launch Spectacle with any shortcut (except 'Print' key standalone), for example Shift+Print. Spectacle saves the picture instantaneously but no window of Spectacle opens up, only a notification shows up. Is this also "works as designed" or do/should we change some behavior regarding this one?

Yes that's intentional