abrahams (Michael Abrahams)
Krita dev

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 21 2015, 5:51 PM (199 w, 4 d)
Availability
Available

Recent Activity

Jan 10 2019

abrahams added a task to R37:abb8f88e47be: Update tooltips to include keyboard shortcut.: Unknown Object (Maniphest Task).
Jan 10 2019, 8:43 PM

Jun 30 2018

abrahams requested review of D13806: Store icons with correct devicePixelRatio.
Jun 30 2018, 4:33 AM · Dolphin

Jun 27 2018

abrahams awarded T8734: Implement Circular Gauss Mask Optim AVX a Burninate token.
Jun 27 2018, 12:29 AM · Krita

Jun 15 2018

abrahams added a watcher for Baloo: abrahams.
Jun 15 2018, 3:29 AM

Jun 14 2018

abrahams added a member for Dolphin: abrahams.
Jun 14 2018, 6:16 PM

May 22 2018

abrahams awarded T8628: Optimize multithreading in Krita's Tile Manager a 100 token.
May 22 2018, 9:48 AM · Krita

Apr 24 2018

abrahams updated the task description for T556: Magnetic lasso tool.
Apr 24 2018, 4:59 AM · Krita: Abyss

Apr 13 2018

abrahams added a comment to T8396: Article about Krita's architecture.

The plugin architecture looks a bit magical at first, I was certainly surprised myself the first time I saw it. So here's my understanding having gone through this before.

Apr 13 2018, 4:30 PM · Krita

Aug 22 2017

abrahams added a comment to D7454: Tells you which preset you have chosen via shortcut.

Correct i18n for the floating message should be something like i18n("Current preset changed to: %1\n", preset->name())

Aug 22 2017, 8:22 PM · Krita

Aug 5 2017

abrahams awarded D7121: Refactored the "Hello" Python script and added excessive documentation a Evil Spooky Haunted Tree token.
Aug 5 2017, 3:03 AM · Krita

Jul 24 2017

abrahams removed a member for Krita: Stable: abrahams.
Jul 24 2017, 3:10 PM
abrahams removed a member for Calligra: 3.0: abrahams.
Jul 24 2017, 3:09 PM

Jul 8 2017

abrahams added a comment to D6522: [Experiment] [Hack] Remove heap allocation in KisPaintInformation.

If the goal is to prevent heap allocation, wouldn't it be easier to simply get rid of the PIMPL idiom for this class entirely and move the contents of KisPaintInformation::Private out into KisPaintInformation?

I believe the original intention was to keep binary compatibility whenever the internal data fields are changed. Though it also increases the recompilation speed by a lot. But tbh how often are these fields changed?
I'm not sure if binary compatibility is really needed. I don't think there are any third-party plugins for Krita written in C++, are there? And we are moving to Python scripting anyway.

Jul 8 2017, 8:24 PM · Krita
abrahams added a comment to T3970: Tablet specific page..

I went through a quick proofread and edit of this manual page. I think it looks good and could be considered a complete first edition.

Jul 8 2017, 1:37 PM · Krita: Manual

Jul 7 2017

abrahams added a comment to D6522: [Experiment] [Hack] Remove heap allocation in KisPaintInformation.

If the goal is to prevent heap allocation, wouldn't it be easier to simply get rid of the PIMPL idiom for this class entirely and move the contents of KisPaintInformation::Private out into KisPaintInformation?

Jul 7 2017, 9:04 PM · Krita
abrahams added a comment to T5251: Smoothing options are slow to change.

Fixed by 9be24287419794ed1fd1a44195bbc88382df9bb5 ?

Jul 7 2017, 7:31 PM · Krita: Stable bug fixes
abrahams added a comment to T4090: Recover finger painting.

Is this closed by a1863a8?

Jul 7 2017, 7:16 PM · Krita: Stable bug fixes
abrahams added a comment to T1267: Crashes and bugs with macros..

The macro system has been removed in favor of python scripting right?

Jul 7 2017, 7:13 PM · Krita: Stable bug fixes
abrahams added a comment to T6440: Investigate stabilizer and stabilizer delayed paint helper timing issues.

It seems strange that getStabilizedPaintInfo would be some sort of choke point. If that's really the case, I wonder if it would be worth pushing the implementation of getStabilizedPaintInfo into KisPaintInformation using a function with signature like
KisPaintInformation::mixQueue(QQueue<KisPaintInformation> queue, bool stabilizeSensors).

Jul 7 2017, 6:54 PM · Krita: Stable bug fixes

Sep 8 2016

abrahams added a comment to R37:47c0d27be7f6: Refactored shader system.

Instead of doing multiple string comparisons every redraw, why not make an enum for the different shaders?

Sep 8 2016, 12:49 PM

Sep 6 2016

abrahams awarded R37:93ef7c8ef97e: Merge in new internal color picker dialog! a Like token.
Sep 6 2016, 4:46 PM

Aug 20 2016

abrahams awarded R37:4d1a7afa8540: Implement the first kind of working version of Lazy Brush tool! a Yellow Medal token.
Aug 20 2016, 8:27 AM

Aug 17 2016

abrahams abandoned D1073: Solving problem when opening resources folder.
Aug 17 2016, 10:32 AM
abrahams removed a reviewer for D1073: Solving problem when opening resources folder: dimitril.
Aug 17 2016, 10:32 AM
abrahams reclaimed D1073: Solving problem when opening resources folder.
Aug 17 2016, 10:31 AM
abrahams abandoned D1073: Solving problem when opening resources folder.
Aug 17 2016, 10:31 AM
abrahams commandeered D1073: Solving problem when opening resources folder.

Hi Dmitry - yes I believe this was pushed but the revision was not closed. I'll take care of that.

Aug 17 2016, 10:31 AM

Jul 25 2016

abrahams added a comment to R37:65fa65a97d56: A HUGE refactoring of KisPaintOpBox.

When I began working on the eraser I realized this really REALLY needed to be done. Awesome.

Jul 25 2016, 8:45 PM
abrahams awarded R37:65fa65a97d56: A HUGE refactoring of KisPaintOpBox a Love token.
Jul 25 2016, 8:45 PM

Jul 10 2016

abrahams closed T2523: eraser flip switch as Resolved.

Apparently this has been resolved.

Jul 10 2016, 2:02 AM · Krita: Stable bug fixes
abrahams closed T2522: win+wacom+sidebuttons-recognition as Resolved.

The bug seems to have been resolved at some point. Maybe good to remind users to restart Krita after changing their Wintab driver settings.

Jul 10 2016, 2:01 AM · Krita: Stable bug fixes
abrahams closed T958: Fix tablet handling issues for Krita 3.0 as Resolved.

Well, krita 3.0 has been released, so hopefully the release-blocking regressions are gone!

Jul 10 2016, 1:28 AM · Krita: Longterm Features
abrahams added a member for Krita: Stable bug fixes: abrahams.
Jul 10 2016, 12:13 AM
abrahams added a member for Krita: Next Regressions: abrahams.
Jul 10 2016, 12:13 AM
abrahams added a member for Krita: Next Features: abrahams.
Jul 10 2016, 12:13 AM

Jul 7 2016

abrahams committed R37:d78edfd404d5: Configure shift key = snap to axis in all tools (authored by abrahams).
Configure shift key = snap to axis in all tools
Jul 7 2016, 4:35 AM
abrahams closed D2004: Configure shift key = snap to axis in all tools by committing R37:d78edfd404d5: Configure shift key = snap to axis in all tools.
Jul 7 2016, 4:35 AM
abrahams added a comment to D2004: Configure shift key = snap to axis in all tools.

No big deal, just was away for the holiday weekend in the US and would have pushed a little while earlier!

Jul 7 2016, 4:30 AM

Jun 29 2016

abrahams added a comment to D2004: Configure shift key = snap to axis in all tools.

Is this acceptable?

Jun 29 2016, 3:40 PM

Jun 28 2016

abrahams awarded R37:0807eeb01d02: Merge in softproofing and ocio looks. a Like token.
Jun 28 2016, 4:21 PM
abrahams added a comment to D2004: Configure shift key = snap to axis in all tools.

Okay, now the tool doesn't just ignore shift then click.

Jun 28 2016, 4:16 PM
abrahams updated the diff for D2004: Configure shift key = snap to axis in all tools.

Fix Shift+Click for move tool.

Jun 28 2016, 4:10 PM

Jun 27 2016

abrahams updated the diff for D2004: Configure shift key = snap to axis in all tools.

Fix typos and restore some comments

Jun 27 2016, 6:17 PM

Jun 25 2016

abrahams added a comment to T3001: Paste into Simple source dialog UI improvements.

Nevermind, I like how you wrote it Scott

Jun 25 2016, 1:27 PM · Krita
abrahams retitled D2004: Configure shift key = snap to axis in all tools from to Configure shift key = snap to axis in all tools.
Jun 25 2016, 1:02 PM
abrahams committed R37:cd45a874b8a8: Set rotation precision for transform tool to 2 decimals (authored by abrahams).
Set rotation precision for transform tool to 2 decimals
Jun 25 2016, 12:56 PM

Jun 23 2016

abrahams committed R37:f5f105d6b6e9: Clean up duplicated code in selection tools (authored by abrahams).
Clean up duplicated code in selection tools
Jun 23 2016, 9:25 PM
abrahams committed R37:d850ff238bd6: Share selection options across tools (authored by abrahams).
Share selection options across tools
Jun 23 2016, 9:25 PM
abrahams committed R37:ac2d5a06f6c9: Restore fullscreen on Windows (authored by abrahams).
Restore fullscreen on Windows
Jun 23 2016, 2:56 PM
abrahams closed D1977: Restore fullscreen on Windows by committing R37:ac2d5a06f6c9: Restore fullscreen on Windows.
Jun 23 2016, 2:56 PM
abrahams committed R37:76255392e018: Snap free transform with shift key (authored by abrahams).
Snap free transform with shift key
Jun 23 2016, 1:14 AM

Jun 22 2016

abrahams updated the diff for D1977: Restore fullscreen on Windows.

Add Qt patch for fullscreen without 1px border, write path with forward slash, bump Qt version

Jun 22 2016, 10:14 PM
abrahams added a comment to D1977: Restore fullscreen on Windows.

I noticed we've been adding patches to the Krita repository. I'm not sure how to test such changes since I'm still using Emerge but I could upload the patch to Phabricator here.

Jun 22 2016, 7:22 PM
abrahams retitled D1977: Restore fullscreen on Windows from to Restore fullscreen on Windows.
Jun 22 2016, 7:20 PM
abrahams committed R37:7dc551d986d7: Bug 363373: Fix scaling for KoPathTool visuals (authored by abrahams).
Bug 363373: Fix scaling for KoPathTool visuals
Jun 22 2016, 1:23 PM
abrahams closed D1970: Bug 363373: Fix scaling for KoPathTool visuals by committing R37:7dc551d986d7: Bug 363373: Fix scaling for KoPathTool visuals.
Jun 22 2016, 1:23 PM

Jun 21 2016

abrahams retitled D1970: Bug 363373: Fix scaling for KoPathTool visuals from to Bug 363373: Fix scaling for KoPathTool visuals.
Jun 21 2016, 10:06 PM

Jun 16 2016

abrahams updated the task description for T556: Magnetic lasso tool.
Jun 16 2016, 8:57 PM · Krita: Abyss

Jun 4 2016

abrahams abandoned D1451: Drop TabletMove events following TabletPress with repeated coordinates..
Jun 4 2016, 2:23 PM

Jun 2 2016

abrahams closed T2445: Create a page for shortcuts. as Resolved.

https://docs.krita.org/Shortcuts

Jun 2 2016, 12:57 AM · Krita: Stable
abrahams placed T2759: NTRIG rightclick not working properly up for grabs.
Jun 2 2016, 12:55 AM · Krita: Next Features

May 29 2016

abrahams added a comment to T2758: Shortcuts reset after configuring krita.

This seems fixed for me now.

May 29 2016, 12:38 AM · Krita: 3.0 bugs sprint
abrahams committed R37:0a80ed14a249: Don't reset shortcuts to default when pressing "Cancel" (authored by abrahams).
Don't reset shortcuts to default when pressing "Cancel"
May 29 2016, 12:23 AM

May 28 2016

abrahams closed T2393: Some weird stuff with tablet configuration dialog as Resolved.

Closed by rKRITAc7621d2d80c8

May 28 2016, 9:28 PM · Krita: 3.0 bugs sprint
abrahams added a comment to T2759: NTRIG rightclick not working properly.

This has never been implemented. Right click events are not registered at all. Implementing this would either require asking Microsoft to update its drivers or switching from Wintab to the Windows Ink API.

May 28 2016, 9:19 PM · Krita: Next Features

May 26 2016

abrahams committed R37:c7621d2d80c8: Port Wintab screen size dialog (authored by abrahams).
Port Wintab screen size dialog
May 26 2016, 8:27 AM
abrahams closed D1602: Port Wintab screen size dialog by committing R37:c7621d2d80c8: Port Wintab screen size dialog.
May 26 2016, 8:27 AM
abrahams added a comment to D1602: Port Wintab screen size dialog.

Can I land this right now and replace it in the settings window some other time?

May 26 2016, 8:21 AM

May 16 2016

abrahams added a comment to T958: Fix tablet handling issues for Krita 3.0.

I'll look into this tomorrow.

May 16 2016, 12:13 AM · Krita: Longterm Features

May 13 2016

abrahams added a comment to D1602: Port Wintab screen size dialog.

The Qt and Wintab resolutions always match on my machines, which I suppose is a good thing.

May 13 2016, 3:49 AM
abrahams added a comment to T2393: Some weird stuff with tablet configuration dialog.

I didn't realize this was still causing problems. D1602

May 13 2016, 3:49 AM · Krita: 3.0 bugs sprint
abrahams retitled D1602: Port Wintab screen size dialog from to Port Wintab screen size dialog.
May 13 2016, 3:45 AM
abrahams added a revision to T2393: Some weird stuff with tablet configuration dialog: D1602: Port Wintab screen size dialog.
May 13 2016, 3:45 AM · Krita: 3.0 bugs sprint

May 11 2016

abrahams added a comment to T2393: Some weird stuff with tablet configuration dialog.

The tablet screen mapping menu was removed. It should really be possible for our code to always do the right thing. Qt5 puts in a lot of additional support for carefully handling DPI scaling. I believe restoring the dialog will not be difficult but I would want users to report it to us if they find it's necessary to use it.

May 11 2016, 6:28 PM · Krita: 3.0 bugs sprint

May 9 2016

abrahams committed R37:30f57cd806c3: Correctly scale splash screen for High DPI screens (authored by abrahams).
Correctly scale splash screen for High DPI screens
May 9 2016, 10:32 PM
abrahams closed D1577: Correctly scale splash screen for High DPI screens by committing R37:30f57cd806c3: Correctly scale splash screen for High DPI screens.
May 9 2016, 10:31 PM
abrahams updated D1577: Correctly scale splash screen for High DPI screens.
May 9 2016, 4:23 PM
abrahams retitled D1577: Correctly scale splash screen for High DPI screens from to Correctly scale splash screen for High DPI screens.
May 9 2016, 4:22 PM
abrahams closed T2439: Reassign shortcut button doesn't work as Resolved.

Bug 362743 actually brings up another issue, which is that tool-specific shortcuts like "convert to path" might duplicate global shortcuts but we should be OK with that happening. The current behavior is not majorly broken as long as nobody is reassigning these tool-specific shortcuts.

May 9 2016, 2:58 PM · Krita: 3.0 bugs sprint
abrahams committed R37:8b2567b4d186: Handle two different "no custom shortcut" states (authored by abrahams).
Handle two different "no custom shortcut" states
May 9 2016, 2:55 PM
abrahams lowered the priority of T556: Magnetic lasso tool from Normal to Wishlist.
May 9 2016, 1:22 PM · Krita: Abyss
abrahams raised the priority of T556: Magnetic lasso tool from Wishlist to Normal.
May 9 2016, 1:22 PM · Krita: Abyss

May 7 2016

abrahams claimed T2445: Create a page for shortcuts..
May 7 2016, 6:06 PM · Krita: Stable

May 5 2016

abrahams added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).

For the untranslated animation strings, it looks like there are a number of untranslated user-facing strings in plugins\dockers\animation\, under addAction() setToolTip() and maybe others.

May 5 2016, 12:53 PM · Krita: Stable
abrahams closed T946: Revamp shortcut system as Resolved.
May 5 2016, 12:35 PM · Krita
abrahams removed a subtask for T946: Revamp shortcut system: T526: Update keymap cheatsheet for 2.9/3.0.
May 5 2016, 12:34 PM · Krita
abrahams removed a parent task for T526: Update keymap cheatsheet for 2.9/3.0: T946: Revamp shortcut system.
May 5 2016, 12:34 PM · Krita: Manual
abrahams updated subscribers of T2418: Shortcuts bugs.
May 5 2016, 6:17 AM · Krita: 3.0 bugs sprint
abrahams placed T2418: Shortcuts bugs up for grabs.

Bug 361578 is fixed by rKRITA37389d5353ec
Bug 362341 is fixed by rKRITA932bcb70669e

May 5 2016, 6:17 AM · Krita: 3.0 bugs sprint
abrahams closed T1244: Weirdness with the current shortcut system. as Resolved.
May 5 2016, 6:14 AM · Krita
abrahams closed T1244: Weirdness with the current shortcut system., a subtask of T946: Revamp shortcut system, as Resolved.
May 5 2016, 6:14 AM · Krita
abrahams committed R37:37389d5353ec: Correctly categorize Window and Settings shortcuts (authored by abrahams).
Correctly categorize Window and Settings shortcuts
May 5 2016, 6:14 AM

May 3 2016

abrahams claimed T2418: Shortcuts bugs.
May 3 2016, 2:16 PM · Krita: 3.0 bugs sprint

May 2 2016

abrahams committed R37:932bcb70669e: Fix saving shortcuts (authored by abrahams).
Fix saving shortcuts
May 2 2016, 6:55 PM
abrahams committed R37:91f9ef12c611: Fix duplicate F4 shortcut (authored by abrahams).
Fix duplicate F4 shortcut
May 2 2016, 5:23 PM
abrahams added a comment to D1451: Drop TabletMove events following TabletPress with repeated coordinates..

Hi Dmitry: yes, I was replicating this bug on my Surface Pro 3, but my custom builds have been broken for a while, so I can't replicate it on my machine reliably anymore. It would be good if you took this over.

May 2 2016, 4:39 PM
abrahams added a comment to R37:c07d3b740024: Make the timer in KisSignalCompressor be a part of QObject hierarchy.

Why did this require converting to a pointer? Couldn't this have been done by simply adding m_timer(this) to the initializer list?

May 2 2016, 4:33 PM

Apr 26 2016

abrahams added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).

I tried out the fallback patch and my Japanese UI continues to work fine.

Apr 26 2016, 8:36 PM · Krita: Stable
abrahams added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).
In T2333#31099, @rempt wrote:

Hm, I just made beta builds, and there even more is untranslated, apparently because some translations do not have a context. I'm experimenting a bit now.

Apr 26 2016, 8:02 PM · Krita: Stable
abrahams added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).

Hi Boud: changing the call to i18nc context "action" seems to fix the problem.

Apr 26 2016, 7:17 AM · Krita: Stable