michaelh (Michael Heidelbach)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 31 2017, 4:13 PM (32 w, 6 d)
Availability
Available

Recent Activity

Apr 19 2018

michaelh added a comment to D12320: add ability to read embedded cover files.

Too bad ffmpegthumbs is for videos only.

Apr 19 2018, 7:16 PM · Baloo, Frameworks
michaelh added a comment to D12320: add ability to read embedded cover files.

-2
https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though.

Apr 19 2018, 7:01 PM · Baloo, Frameworks
michaelh added a comment to D12156: implement reading of rating tag.

It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable?

It will be used as a fallback when there is no xattr rating set or available (e.g. on Windows) so that users who have rated their music with other players can still see their previous ratings.
It will also useful for managing ratings on other platforms when writing support is added.

Apr 19 2018, 6:53 PM · Baloo, Frameworks
michaelh updated the diff for D12233: Avoid manipulation of lists with quadratic complexity.
  • Indent
Apr 19 2018, 6:43 PM · Baloo, Frameworks
michaelh added a comment to D12156: implement reading of rating tag.

It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable?

Apr 19 2018, 6:30 PM · Baloo, Frameworks
michaelh added inline comments to D10694: epubextractor: Handle multiple subjects better.
Apr 19 2018, 6:15 PM · Frameworks, Dolphin, Baloo
michaelh added a reviewer for D12342: Update CMakeLists.txt: elvisangelaccio.
Apr 19 2018, 5:38 PM · Baloo
michaelh added a comment to D12222: baloodb: Use complete access filtering for all outputs.

I'm sorry for making so much noise with all those stupid mistakes. It's probably best for me to let this rest for a few days, relax a little and gain some distance.

Apr 19 2018, 5:35 PM · Baloo, Frameworks
michaelh updated the diff for D12222: baloodb: Use complete access filtering for all outputs.
  • That was no typo
Apr 19 2018, 5:22 PM · Baloo, Frameworks
michaelh updated the diff for D12222: baloodb: Use complete access filtering for all outputs.
  • Correct typo
Apr 19 2018, 5:19 PM · Baloo, Frameworks
michaelh updated the diff for D12222: baloodb: Use complete access filtering for all outputs.
  • Revert most previous changes
  • Use isMounted() and isObscured()
  • Remove documents recursively
Apr 19 2018, 5:14 PM · Baloo, Frameworks
michaelh committed R293:675d989823ec: baloodb: Add clean command (authored by michaelh).
baloodb: Add clean command
Apr 19 2018, 1:51 PM
michaelh closed D11753: baloodb: Add clean command.
Apr 19 2018, 1:51 PM · Baloo, Frameworks
michaelh requested review of D12197: autotests: Test for multiple values.
Apr 19 2018, 12:47 PM · Baloo, Frameworks
michaelh added a reviewer for D12197: autotests: Test for multiple values: bruns.
Apr 19 2018, 12:46 PM · Baloo, Frameworks
michaelh updated the diff for D12197: autotests: Test for multiple values.
  • Rebase
  • Apply some suggested changes
Apr 19 2018, 12:41 PM · Baloo, Frameworks
michaelh committed R286:c30204f7b9c0: Make concatenated strings wrappable (authored by michaelh).
Make concatenated strings wrappable
Apr 19 2018, 11:45 AM
michaelh closed D11489: Make concatenated strings wrappable.
Apr 19 2018, 11:44 AM · Baloo, Frameworks
michaelh committed R286:037208a787e0: ffmpegextractor: Silence deprecation warnings (authored by michaelh).
ffmpegextractor: Silence deprecation warnings
Apr 19 2018, 11:39 AM
michaelh closed D12108: ffmpegextractor: Silence deprecation warnings.
Apr 19 2018, 11:39 AM · Baloo, Frameworks
michaelh updated the diff for D12108: ffmpegextractor: Silence deprecation warnings.

-Rebase

Apr 19 2018, 11:38 AM · Baloo, Frameworks
michaelh added a comment to D12108: ffmpegextractor: Silence deprecation warnings.

Thanks.

I did try to fix it some months ago but did not finished however I noticed that there is no automatic tests for it. Do you have time to work on some ?

Apr 19 2018, 11:37 AM · Baloo, Frameworks
michaelh updated the summary of D11245: infopanel: Add choice of date display formats.
Apr 19 2018, 11:30 AM · KDE Applications, Dolphin
michaelh updated the diff for D11245: infopanel: Add choice of date display formats.
  • Bump minimum required version of baloo-widgets
Apr 19 2018, 11:29 AM · KDE Applications, Dolphin
michaelh added inline comments to D12342: Update CMakeLists.txt.
Apr 19 2018, 11:25 AM · Baloo
michaelh added a dependent revision for D12342: Update CMakeLists.txt: D11245: infopanel: Add choice of date display formats.
Apr 19 2018, 11:20 AM · Baloo
michaelh added a dependency for D11245: infopanel: Add choice of date display formats: D12342: Update CMakeLists.txt.
Apr 19 2018, 11:20 AM · KDE Applications, Dolphin
michaelh requested review of D12342: Update CMakeLists.txt.
Apr 19 2018, 11:19 AM · Baloo

Apr 17 2018

michaelh added inline comments to D12222: baloodb: Use complete access filtering for all outputs.
Apr 17 2018, 8:51 PM · Baloo, Frameworks
michaelh updated the diff for D12222: baloodb: Use complete access filtering for all outputs.
  • Filter by device id
Apr 17 2018, 8:47 PM · Baloo, Frameworks
michaelh added a comment to D12222: baloodb: Use complete access filtering for all outputs.

I went I little overboard with remove_if and had to repair.
Device filtering is also broken see inline comment.

Apr 17 2018, 7:43 PM · Baloo, Frameworks
michaelh updated the diff for D12222: baloodb: Use complete access filtering for all outputs.
  • Apply suggested changes
  • Repair cleaning
  • Comment some decisions
Apr 17 2018, 7:39 PM · Baloo, Frameworks

Apr 16 2018

michaelh updated the diff for D12233: Avoid manipulation of lists with quadratic complexity.
  • Apply suggested change
Apr 16 2018, 7:28 PM · Baloo, Frameworks
michaelh added inline comments to D12222: baloodb: Use complete access filtering for all outputs.
Apr 16 2018, 7:19 PM · Baloo, Frameworks
michaelh updated the diff for D12222: baloodb: Use complete access filtering for all outputs.
  • Use remove_if
Apr 16 2018, 7:16 PM · Baloo, Frameworks
michaelh added inline comments to D12222: baloodb: Use complete access filtering for all outputs.
Apr 16 2018, 7:15 PM · Baloo, Frameworks
michaelh added inline comments to D11753: baloodb: Add clean command.
Apr 16 2018, 7:13 PM · Baloo, Frameworks
michaelh updated the diff for D11753: baloodb: Add clean command.
  • Apply suggested changes
Apr 16 2018, 7:11 PM · Baloo, Frameworks
michaelh added a comment to D11245: infopanel: Add choice of date display formats.

This patch should have bumped the minimum required version of baloo-widgets.

Apr 16 2018, 2:32 PM · KDE Applications, Dolphin
michaelh added inline comments to D12233: Avoid manipulation of lists with quadratic complexity.
Apr 16 2018, 1:42 PM · Baloo, Frameworks
michaelh updated the diff for D12233: Avoid manipulation of lists with quadratic complexity.
  • Include omissions
  • Const!
Apr 16 2018, 1:37 PM · Baloo, Frameworks
michaelh committed R293:094d6e90d4c0: balooshow: Colorize only when attached to terminal (authored by michaelh).
balooshow: Colorize only when attached to terminal
Apr 16 2018, 8:42 AM
michaelh closed D12226: balooshow: Colorize only when attached to terminal.
Apr 16 2018, 8:42 AM · Baloo, Frameworks
michaelh updated the diff for D12226: balooshow: Colorize only when attached to terminal.
  • Rebase
Apr 16 2018, 8:41 AM · Baloo, Frameworks
michaelh added inline comments to D11753: baloodb: Add clean command.
Apr 16 2018, 8:28 AM · Baloo, Frameworks
michaelh updated the diff for D11753: baloodb: Add clean command.
  • Wrap transaction operations
Apr 16 2018, 8:27 AM · Baloo, Frameworks
michaelh updated the diff for D11753: baloodb: Add clean command.
  • Remove unrelated whitespace change
Apr 16 2018, 8:05 AM · Baloo, Frameworks

Apr 15 2018

michaelh added a comment to D12233: Avoid manipulation of lists with quadratic complexity.

If this is correct, I can extend.

Apr 15 2018, 8:45 PM · Baloo, Frameworks
michaelh added a task to D12233: Avoid manipulation of lists with quadratic complexity: T8502: Avoid manipulation of lists with quadratic complexity.
Apr 15 2018, 8:44 PM · Baloo, Frameworks
michaelh added a revision to T8502: Avoid manipulation of lists with quadratic complexity: D12233: Avoid manipulation of lists with quadratic complexity.
Apr 15 2018, 8:44 PM · Baloo
michaelh requested review of D12233: Avoid manipulation of lists with quadratic complexity.
Apr 15 2018, 8:43 PM · Baloo, Frameworks
michaelh added a comment to D12135: Allow disabling of CoW to fail when not supported by filesystem.

If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed

Apr 15 2018, 8:27 PM · Baloo, Frameworks
michaelh added a comment to D12135: Allow disabling of CoW to fail when not supported by filesystem.

The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff.

Apr 15 2018, 7:36 PM · Baloo, Frameworks
michaelh edited dependencies for D12044: baloodb: Improve interface, added: 1; removed: 1.
Apr 15 2018, 7:28 PM · Baloo, Frameworks
michaelh added a dependent revision for D12222: baloodb: Use complete access filtering for all outputs: D12044: baloodb: Improve interface.
Apr 15 2018, 7:28 PM · Baloo, Frameworks
michaelh removed a dependent revision for D11753: baloodb: Add clean command: D12044: baloodb: Improve interface.
Apr 15 2018, 7:28 PM · Baloo, Frameworks
michaelh updated the diff for D12044: baloodb: Improve interface.
Apr 15 2018, 7:27 PM · Baloo, Frameworks
michaelh updated the diff for D11753: baloodb: Add clean command.
  • Rebase
Apr 15 2018, 5:07 PM · Baloo, Frameworks
michaelh added a comment to D11820: Handle properties with multiple values.

Surprising!
master


patch

Apr 15 2018, 5:03 PM · Baloo
michaelh added a comment to D12047: Avoid crash when reading corrupt data from document terms db.

Corrupt the database

As described in BUG: 392877?

Apr 15 2018, 4:05 PM · Baloo, Frameworks
michaelh requested review of D12226: balooshow: Colorize only when attached to terminal.
Apr 15 2018, 3:42 PM · Baloo, Frameworks
michaelh planned changes to D12114: Revive 'Description' property.

Create cross extractor test

Apr 15 2018, 1:57 PM · Baloo, Frameworks
michaelh added a comment to D11882: autotests: Use built executable instead of installed.

Maybe we can add a trivial dummy extractor which is used in unittests, but not anywhere else. It could e.g. return the current date, compilation timestamp (i.e. DATE), and the KF version.

Apr 15 2018, 1:51 PM · Baloo
michaelh added inline comments to D12222: baloodb: Use complete access filtering for all outputs.
Apr 15 2018, 12:52 PM · Baloo, Frameworks
michaelh updated subscribers of D11820: Handle properties with multiple values.
Apr 15 2018, 12:46 PM · Baloo
michaelh accepted D12135: Allow disabling of CoW to fail when not supported by filesystem.

Of course, but what's the logic here? Does it have to be accepted by a member of Baloo other than you? If I had known ....

Apr 15 2018, 12:43 PM · Baloo, Frameworks
michaelh added a comment to D12192: Decode more documentUrls.

Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after?

Apr 15 2018, 12:38 PM · Baloo, Frameworks
michaelh updated the summary of D12192: Decode more documentUrls.
Apr 15 2018, 12:37 PM · Baloo, Frameworks
michaelh added a comment to D11820: Handle properties with multiple values.

Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-widgets, only with baloo itself.

Have you tried autotests/samplefiles/multi/*.* of D12197? For me baloo-widgets mostly displays only one author or keyword. Also...

A QMap can store multiple values for one key, and a client reading the Map can use QMap::values() to get a list of all matching properties. If a client naively uses value() instead, it just gets the first value for the key, but so be it.

Apr 15 2018, 12:22 PM · Baloo
michaelh updated the summary of D12197: autotests: Test for multiple values.
Apr 15 2018, 12:15 PM · Baloo, Frameworks
michaelh planned changes to D11820: Handle properties with multiple values.

Due to a bug in calligra test.odt file is broken. see D11971.

Apr 15 2018, 12:05 PM · Baloo
michaelh added a revision to T8250: Sanitize the database: D12222: baloodb: Use complete access filtering for all outputs.
Apr 15 2018, 11:58 AM · Baloo
michaelh added a task to D12222: baloodb: Use complete access filtering for all outputs: T8250: Sanitize the database.
Apr 15 2018, 11:58 AM · Baloo, Frameworks
michaelh committed R293:6fb268be2c42: databasesanitizer: Use flags for filtering (authored by michaelh).
databasesanitizer: Use flags for filtering
Apr 15 2018, 11:57 AM
michaelh closed D11745: databasesanitizer: Use flags for filtering.
Apr 15 2018, 11:57 AM · Baloo, Frameworks
michaelh added inline comments to D11753: baloodb: Add clean command.
Apr 15 2018, 11:54 AM · Baloo, Frameworks
michaelh updated the summary of D12222: baloodb: Use complete access filtering for all outputs.
Apr 15 2018, 11:53 AM · Baloo, Frameworks
michaelh added a dependency for D12222: baloodb: Use complete access filtering for all outputs: D11753: baloodb: Add clean command.
Apr 15 2018, 11:52 AM · Baloo, Frameworks
michaelh added a dependent revision for D11753: baloodb: Add clean command: D12222: baloodb: Use complete access filtering for all outputs.
Apr 15 2018, 11:52 AM · Baloo, Frameworks
michaelh requested review of D12222: baloodb: Use complete access filtering for all outputs.
Apr 15 2018, 11:52 AM · Baloo, Frameworks
michaelh added inline comments to D11745: databasesanitizer: Use flags for filtering.
Apr 15 2018, 11:43 AM · Baloo, Frameworks
michaelh updated the diff for D11753: baloodb: Add clean command.
  • Improve access filtering
Apr 15 2018, 11:42 AM · Baloo, Frameworks

Apr 14 2018

michaelh updated the diff for D11745: databasesanitizer: Use flags for filtering.
  • Ignore tmpfs devices
Apr 14 2018, 8:29 PM · Baloo, Frameworks
michaelh added a comment to D12206: Don't show top "Open With" app for folders; only for files.

"Open with VLC" is of course nonsense.

Huh? Not sure I understand.

The default app for folders is dolphin. So the entry above "Open with..." should be dropped.

Apr 14 2018, 8:05 PM · Frameworks
michaelh added a comment to D12206: Don't show top "Open With" app for folders; only for files.

I find "Open with..." for folders useful.

What apps do you typically open folders in? What's the use case?

  • Watching Image galleries
  • Watching video series
  • Filelight/KDirstat
  • KdeSvn
Apr 14 2018, 8:02 PM · Frameworks
michaelh added a comment to D12206: Don't show top "Open With" app for folders; only for files.

I find "Open with..." for folders useful. "Open with VLC" is of course nonsense.

Apr 14 2018, 7:57 PM · Frameworks
michaelh abandoned D12017: taglibextractortest: Test for multiple values.

Superseded by D12197

Apr 14 2018, 4:18 PM · Baloo, Frameworks
michaelh updated the summary of D10694: epubextractor: Handle multiple subjects better.
Apr 14 2018, 4:16 PM · Frameworks, Dolphin, Baloo
michaelh added a dependency for D10694: epubextractor: Handle multiple subjects better: D12197: autotests: Test for multiple values.
Apr 14 2018, 4:15 PM · Frameworks, Dolphin, Baloo
michaelh added a dependent revision for D12197: autotests: Test for multiple values: D10694: epubextractor: Handle multiple subjects better.
Apr 14 2018, 4:15 PM · Baloo, Frameworks
michaelh updated the diff for D10694: epubextractor: Handle multiple subjects better.

Remove tests from epubextractortest use multivaluetest instead
Make it depend on D12197

Apr 14 2018, 4:15 PM · Frameworks, Dolphin, Baloo
michaelh added inline comments to D12197: autotests: Test for multiple values.
Apr 14 2018, 4:07 PM · Baloo, Frameworks
michaelh requested review of D12197: autotests: Test for multiple values.
Apr 14 2018, 4:01 PM · Baloo, Frameworks
michaelh updated subscribers of D11587: [WIP] autotests: Introduce TermGeneratorTestUTF.

@bruns: autotests/unit/engine/queryparsertest.cpp and autotests/unit/engine/termgeneratortest.cpp are encoded with iso-8859-15. Maybe you're able to convert them to utf-8. Even with a lot of help I couldn't.
Please give it a try, because it's better to extend the existing test files. But currently they do not accept chinese characters.

Apr 14 2018, 12:07 PM · Baloo, Frameworks
michaelh updated the summary of D11587: [WIP] autotests: Introduce TermGeneratorTestUTF.
Apr 14 2018, 12:06 PM · Baloo, Frameworks
michaelh added inline comments to D12192: Decode more documentUrls.
Apr 14 2018, 11:49 AM · Baloo, Frameworks
michaelh requested review of D12192: Decode more documentUrls.
Apr 14 2018, 11:46 AM · Baloo, Frameworks
michaelh planned changes to D12044: baloodb: Improve interface.
Apr 14 2018, 11:15 AM · Baloo, Frameworks
michaelh updated the diff for D11753: baloodb: Add clean command.
  • Adapt to upstream changes
Apr 14 2018, 11:13 AM · Baloo, Frameworks
michaelh updated the diff for D11745: databasesanitizer: Use flags for filtering.
  • Adapt to upstream changes
Apr 14 2018, 11:06 AM · Baloo, Frameworks