sourabhboss (Sourabh Sharma)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 2 2018, 5:32 AM (62 w, 1 d)
Availability
Available

Recent Activity

Mar 8 2019

sourabhboss updated the summary of D19592: Added Support For libheif in 3rdparty.
Mar 8 2019, 12:08 PM · Krita
sourabhboss updated the diff for D19592: Added Support For libheif in 3rdparty.
  • Changes done
Mar 8 2019, 12:04 PM · Krita

Mar 7 2019

sourabhboss updated the diff for D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

All Changes done

Mar 7 2019, 3:50 PM · Krita
sourabhboss added a reviewer for D19592: Added Support For libheif in 3rdparty: dkazakov.
Mar 7 2019, 1:54 PM · Krita
sourabhboss added a reviewer for D19592: Added Support For libheif in 3rdparty: rempt.
Mar 7 2019, 1:53 PM · Krita
sourabhboss updated subscribers of D19592: Added Support For libheif in 3rdparty.
Mar 7 2019, 1:50 PM · Krita
sourabhboss requested review of D19592: Added Support For libheif in 3rdparty.
Mar 7 2019, 1:49 PM · Krita

Mar 4 2019

sourabhboss removed a watcher for Android: sourabhboss.
Mar 4 2019, 11:22 AM
sourabhboss added a watcher for Android: sourabhboss.
Mar 4 2019, 11:20 AM

Feb 28 2019

sourabhboss added a comment to D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

Which one is remaining in Selection Tools or I have to make for every tools at once.

Feb 28 2019, 3:12 PM · Krita
sourabhboss updated the diff for D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

Updated diff

Feb 28 2019, 2:51 PM · Krita
sourabhboss updated the diff for D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

Changes done

Feb 28 2019, 1:00 PM · Krita
sourabhboss added a reviewer for D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools: rempt.
Feb 28 2019, 12:22 PM · Krita
sourabhboss requested review of D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.
Feb 28 2019, 12:20 PM · Krita
sourabhboss added a revision to T7503: Port all Q_ASSERTS to KIS_SAFE_ASSERT: D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.
Feb 28 2019, 12:20 PM · Krita

Jan 5 2019

sourabhboss removed a watcher for Dolphin: sourabhboss.
Jan 5 2019, 3:29 AM

Oct 25 2018

sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

@elvisangelaccio i have used

KColorScheme::Window

instead of ::Selection then on NormalBackground color appears to be white

Oct 25 2018, 10:40 AM · Dolphin

Oct 24 2018

sourabhboss added a watcher for Dolphin: sourabhboss.
Oct 24 2018, 10:59 AM
sourabhboss removed a watcher for Dolphin: sourabhboss.
Oct 24 2018, 10:59 AM
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Minor Changes done
It is reverting back on increasing the storage to 90% on current window (tested)

Oct 24 2018, 10:47 AM · Dolphin

Oct 23 2018

sourabhboss updated the summary of D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Oct 23 2018, 2:16 PM · Dolphin
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Instead of hardcoded colors, ColorScheme is used

Oct 23 2018, 2:14 PM · Dolphin

Oct 22 2018

sourabhboss added a member for Dolphin: sourabhboss.
Oct 22 2018, 3:50 PM
sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Thanks. But this is still using a hardcoded color instead of the Negative color from the color scheme.

Oct 22 2018, 1:59 PM · Dolphin
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

this-> code removed
if used space reduce it revert back

Oct 22 2018, 12:46 PM · Dolphin
sourabhboss updated the summary of D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Oct 22 2018, 2:10 AM · Dolphin

Oct 21 2018

sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
In D16353#346792, @pino wrote:

Not sure why I was added as reviewer... anyway:

  • no need to use this-> to call own class members, unless there is a conflict (which does not look like)
  • please never hardcode colors! use KColorScheme instead
  • it does not seem that the palette is reverted back when the space changes to less than the threshold
Oct 21 2018, 4:08 PM · Dolphin
sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Screenshot - when used storage is below threshold
Screenshot - when used storage is above threshold

Oct 21 2018, 4:06 PM · Dolphin
sourabhboss updated the diff for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

Threshold set to 90%

Oct 21 2018, 3:55 PM · Dolphin
sourabhboss added reviewers for D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%: pino, elvisangelaccio.
Oct 21 2018, 2:39 PM · Dolphin
sourabhboss added a comment to D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.

My First Contribution

Oct 21 2018, 2:14 PM · Dolphin
sourabhboss requested review of D16353: Change color(NegativeBackground) of status bar in space info when storage exceeds 90%.
Oct 21 2018, 2:12 PM · Dolphin

Oct 20 2018

sourabhboss added a watcher for Dolphin: sourabhboss.
Oct 20 2018, 6:33 AM

Oct 4 2018

sourabhboss added a watcher for Elisa: sourabhboss.
Oct 4 2018, 10:08 AM

Oct 2 2018

sourabhboss added a comment to D15809: Add Zoom scroll wheel option.

good job

Oct 2 2018, 5:41 AM · Gwenview