DolphinProject
ActivePublic

Recent Activity

Today

ngraham added a comment to T12349: "Last <day>" in condensed dates is unclear in English.

+1, that's fine with me too.

Tue, Dec 10, 8:30 PM · VDG, Dolphin, Localization
ndavis added a comment to T12349: "Last <day>" in condensed dates is unclear in English.

I agree, I hate this kind of ambiguous language.

Tue, Dec 10, 6:03 PM · VDG, Dolphin, Localization
davidedmundson added a comment to T12349: "Last <day>" in condensed dates is unclear in English.

Relavant code is KFormat::formatRelativeDate

Tue, Dec 10, 5:53 PM · VDG, Dolphin, Localization
chehrlic added inline comments to D7700: Show list of tags in PlacesView.
Tue, Dec 10, 5:48 PM · Frameworks, Dolphin
ngraham created T12349: "Last <day>" in condensed dates is unclear in English.
Tue, Dec 10, 5:17 PM · VDG, Dolphin, Localization

Yesterday

arojas closed D25783: Fix build with Qt 5.14 RC.
Mon, Dec 9, 10:23 PM · Dolphin
broulik added a comment to D15763: Set correct image attributes on directory thumbnail.

@dfaure Ping

Mon, Dec 9, 5:31 PM · Frameworks, Dolphin
ngraham updated the summary of D19190: Improve scroll wheel speed by basing it on label height, not icon height.
Mon, Dec 9, 4:34 PM · Dolphin
ngraham added a reverted change for D19190: Improve scroll wheel speed by basing it on label height, not icon height: R318:90beb4a5e37b: Fix slow scrolling in dock panels.
Mon, Dec 9, 4:33 PM · Dolphin
ngraham updated the diff for D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Also revert 90beb4a5e37b887caad1e767046a42dad0af1ab3 which is no longer needed

Mon, Dec 9, 4:32 PM · Dolphin
sitter updated the diff for D25682: [WIP] add initial wsdiscovery support.

various fixes suggested by dfaure

Mon, Dec 9, 3:35 PM · Frameworks, Dolphin
sitter added a comment to D25682: [WIP] add initial wsdiscovery support.

Yep, still looking for primarily design input.

Mon, Dec 9, 3:34 PM · Frameworks, Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.
  • Fix indentation
Mon, Dec 9, 5:52 AM · Dolphin
iasensio updated the diff for D25130: [dolphin/search] Search by (multiple) tags.

Address comments

Mon, Dec 9, 5:49 AM · Dolphin

Sun, Dec 8

ngraham added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

I dont think that's wise. It's an integral part of this change, since users have to know which settings are logically connected to this new mode and which ones are not.

Sun, Dec 8, 10:58 PM · Dolphin
iasensio added a comment to D25416: fix(search): Correctly parse filename and/or content search.

Friendly ping

Sun, Dec 8, 10:36 PM · Dolphin
elvisangelaccio requested changes to D19190: Improve scroll wheel speed by basing it on label height, not icon height.

Please see 90beb4a5e37b887caad1e767046a42dad0af1ab3

Sun, Dec 8, 8:45 PM · Dolphin
elvisangelaccio added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

Would you mind splitting the re-design of the Startup settings page to a different commit?

Sun, Dec 8, 8:21 PM · Dolphin
elvisangelaccio requested changes to D25130: [dolphin/search] Search by (multiple) tags.
Sun, Dec 8, 6:14 PM · Dolphin
joricke added a comment to T11663: Move URL Navigator into toolbar.

"Keep a single URL Navigator in the toolbar, but change it dynamically to show the path for the active split view" is probably the best option

The issue with that approach is that you can never be 100% sure you're in the right directory on your inactive split view. A minor issue, yes, but an issue nonetheless.

Sun, Dec 8, 5:50 PM · VDG, Dolphin
ngraham closed T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent as Resolved by committing R40:4fec9bf8a828: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.
Sun, Dec 8, 4:50 PM · Goal: Consistency, Dolphin, Kate
elvisangelaccio accepted D25783: Fix build with Qt 5.14 RC.

Please push to release/19.12

Sun, Dec 8, 1:01 PM · Dolphin
elvisangelaccio accepted D25665: Port away from deprecated KBookmarksmenu API.
Sun, Dec 8, 12:53 PM · Dolphin
manueljlin added a comment to T11663: Move URL Navigator into toolbar.

+1 to tabs having a minimum width size
I kind of like that tab location but it probably shouldn't extend to the sidebar too.

Sun, Dec 8, 10:47 AM · VDG, Dolphin

Sat, Dec 7

ngraham moved T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent from Reported to Apps Implementation on the Goal: Consistency board.
Sat, Dec 7, 10:40 PM · Goal: Consistency, Dolphin, Kate
ngraham claimed T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
Sat, Dec 7, 10:39 PM · Goal: Consistency, Dolphin, Kate
ngraham added a revision to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: D25805: Open/close and focus/defocus terminal using the same shortcuts as Dolphin.
Sat, Dec 7, 10:38 PM · Goal: Consistency, Dolphin, Kate
bcooksley added a comment to D25682: [WIP] add initial wsdiscovery support.

With regards to the Docker/Gitlab CI part, please use the images under kdeorg/ on Dockerhub rather than personally maintained images as the wider community has no access to your namespace on Gitlab.com

Sat, Dec 7, 12:39 AM · Frameworks, Dolphin
dfaure requested changes to D25682: [WIP] add initial wsdiscovery support.

I guess you were expecting a higher-level review, but I don't know anything about these protocols.

Sat, Dec 7, 12:27 AM · Frameworks, Dolphin

Fri, Dec 6

dfaure accepted D25783: Fix build with Qt 5.14 RC.
Fri, Dec 6, 9:22 PM · Dolphin
ngraham changed the status of T5970: NaturalSorting option needs a place in system settings from Resolved to Wontfix.
Fri, Dec 6, 5:04 PM · Dolphin, Frameworks
ngraham closed T8136: Investigate relocating content in General > Confirmations tab as Wontfix.

We decided not to do this. There are now quite a few items in here and it seems like they're fine there.

Fri, Dec 6, 5:04 PM · Dolphin
ngraham added a project to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: Goal: Consistency.

I just landed an old patch of mine that adds a dedicated "focus/de-focus terminal panel" action to Dolphin: D10959

Fri, Dec 6, 5:03 PM · Goal: Consistency, Dolphin, Kate
ngraham added a task to D10959: Add action for focusing Terminal Panel: T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent.
Fri, Dec 6, 5:00 PM · Dolphin
ngraham added a revision to T12318: Make Dolphin's and Kate's terminal shortcuts and behaviour consistent: D10959: Add action for focusing Terminal Panel.
Fri, Dec 6, 5:00 PM · Goal: Consistency, Dolphin, Kate
ngraham closed T9932: [ConfirmationsSettingsPage] behaviourOnLaunch setting needs a tri-state as Resolved.

Should be fully completed with D24247.

Fri, Dec 6, 5:00 PM · Dolphin
ngraham closed T5970: NaturalSorting option needs a place in system settings as Resolved.

Yeah, let's keep this the way it is. I think it's plenty comprehensible, and we never managed to come up with a good place to move them anyway.

Fri, Dec 6, 4:59 PM · Dolphin, Frameworks
ngraham closed T11600: Cleanup ReviewBoard as Resolved.

ReviewBoard has been closed down now.

Fri, Dec 6, 4:58 PM · Dolphin
ngraham closed T10262: Integrate KIO Slaves into file system using FUSE gateway as Resolved.

This is currently in progress and I don't think we need this task open anymore. The patches are scattered across various bits of infrastructure so it won't be useful for linking them here.

Fri, Dec 6, 4:55 PM · Dolphin
arojas added a comment to D25783: Fix build with Qt 5.14 RC.

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

Fri, Dec 6, 2:28 PM · Dolphin
mlaurent added a comment to D25783: Fix build with Qt 5.14 RC.

see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.

Fri, Dec 6, 2:16 PM · Dolphin
arojas requested review of D25783: Fix build with Qt 5.14 RC.
Fri, Dec 6, 2:04 PM · Dolphin
ngraham added reviewers for D25682: [WIP] add initial wsdiscovery support: dfaure, Frameworks, Dolphin.
Fri, Dec 6, 2:00 PM · Frameworks, Dolphin
hoffmannrobert added a comment to D25732: Add only canonical paths to dirWatcher.

This should go into KDirWatch itself then, to avoid the risk of other callers falling into that trap.

Fri, Dec 6, 11:01 AM · Dolphin
caspermeijn added a comment to D25682: [WIP] add initial wsdiscovery support.

Why do we need to mirror this dsoap-ws-discovery-client lib that seems to be copied from somewhere?

Testing convenience until @caspermeijn makes a release mostly. The library was,or maybe even still is, in flux as API was being shuffled up to kdsoap.

Fri, Dec 6, 10:01 AM · Frameworks, Dolphin
dfaure requested changes to D25732: Add only canonical paths to dirWatcher.

See also commit 6be886bafae463ba in kcoreaddons (which was wrong, it would seem -- there are better ways to prevent infinite loops than to say "let's not follow symlinks at all").

Fri, Dec 6, 8:11 AM · Dolphin
dfaure added a comment to D25732: Add only canonical paths to dirWatcher.

This should go into KDirWatch itself then, to avoid the risk of other callers falling into that trap.

Fri, Dec 6, 8:06 AM · Dolphin

Thu, Dec 5

ngraham closed D10959: Add action for focusing Terminal Panel.
Thu, Dec 5, 10:53 PM · Dolphin
ngraham updated the summary of D10959: Add action for focusing Terminal Panel.
Thu, Dec 5, 10:50 PM · Dolphin
ngraham added a comment to D10959: Add action for focusing Terminal Panel.

I think what was not working before was in fact a Konsole bug that has since been fixed in https://bugs.kde.org/show_bug.cgi?id=411181. Landing this now.

Thu, Dec 5, 10:49 PM · Dolphin