DolphinProject
ActivePublic

Recent Activity

Today

meven updated the diff for D22144: Add kio recentlyused:/ to access KActivityStats data.

Fix date parameter passing

Fri, Aug 23, 9:59 AM · Frameworks, Dolphin
meven added inline comments to D22144: Add kio recentlyused:/ to access KActivityStats data.
Fri, Aug 23, 9:31 AM · Frameworks, Dolphin
meven updated the diff for D22144: Add kio recentlyused:/ to access KActivityStats data.

Fix documentation, CMakeLists.txt, a couple of code fix

Fri, Aug 23, 9:27 AM · Frameworks, Dolphin

Yesterday

dfaure requested changes to D22144: Add kio recentlyused:/ to access KActivityStats data.

You asked for it :-)

Thu, Aug 22, 9:10 PM · Frameworks, Dolphin
ngraham added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.
In D22144#514633, @ivan wrote:

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Thu, Aug 22, 8:20 PM · Frameworks, Dolphin
meven updated the diff for D22144: Add kio recentlyused:/ to access KActivityStats data.

Add date and date range filtering after D22775

Thu, Aug 22, 6:30 PM · Frameworks, Dolphin

Tue, Aug 20

broulik retitled D23295: [Tab Bar] Resolve tab icon only if visible from [Tab Bar] Resolve tab icon lazily to [Tab Bar] Resolve tab icon only if visible.
Tue, Aug 20, 3:30 PM · Dolphin
broulik updated the test plan for D23295: [Tab Bar] Resolve tab icon only if visible.
Tue, Aug 20, 3:28 PM · Dolphin
broulik requested review of D23295: [Tab Bar] Resolve tab icon only if visible.
Tue, Aug 20, 3:27 PM · Dolphin
meven added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.

I'v added @dfaure as reviewer.

Tue, Aug 20, 7:55 AM · Frameworks, Dolphin
meven added a reviewer for D22144: Add kio recentlyused:/ to access KActivityStats data: dfaure.
Tue, Aug 20, 7:54 AM · Frameworks, Dolphin
meven added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.
In D22144#514633, @ivan wrote:

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Tue, Aug 20, 6:00 AM · Frameworks, Dolphin

Mon, Aug 19

ivan added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.

Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?

Mon, Aug 19, 6:26 PM · Frameworks, Dolphin
ngraham accepted D23232: [dolphin] Add an action to toggle the searchbar.

Nice. you even differentiated the names that show up in the toolbar configuratin window! Looks great from my perspective. Let's wait for @elvisangelaccio now.

Mon, Aug 19, 5:06 PM · Dolphin
ngraham added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.

Mon, Aug 19, 4:58 PM · Dolphin
ngraham closed D23264: Fix a typo.
Mon, Aug 19, 4:27 PM · Dolphin
ngraham added a comment to D23264: Fix a typo.

Nice job. May it be the first of many! :)

Mon, Aug 19, 3:57 PM · Dolphin
nazark added a comment to D23264: Fix a typo.

Thanks,

Mon, Aug 19, 3:01 PM · Dolphin
ngraham accepted D23264: Fix a typo.

Thank you very much!

Mon, Aug 19, 2:53 PM · Dolphin
ngraham added a reviewer for D23264: Fix a typo: Dolphin.
Mon, Aug 19, 2:52 PM · Dolphin
nazark requested review of D23264: Fix a typo.
Mon, Aug 19, 2:24 PM · Dolphin
ngraham added a comment to D23255: Change warning dialog box to a question dialog box.

If the question starts with "Are you sure you want to..." that's probably a good sign it should be a warning since the wording implies that if you go through with it, something undesirable might happen.

Mon, Aug 19, 1:38 PM · Dolphin
ndavis added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.

Mon, Aug 19, 1:38 PM · Dolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Set toggle_search as default toolbar action
Mon, Aug 19, 11:34 AM · Dolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Set toggle_search as default toolbar action (on top of D23075)
Mon, Aug 19, 11:15 AM · Dolphin
feverfew added inline comments to D11382: Add an option to show tabs from last time when Dolphin starts.
Mon, Aug 19, 10:46 AM · Dolphin
broulik added a comment to D23255: Change warning dialog box to a question dialog box.

I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.

Mon, Aug 19, 8:39 AM · Dolphin
shubham updated the summary of D23255: Change warning dialog box to a question dialog box.
Mon, Aug 19, 6:08 AM · Dolphin
shubham added a reviewer for D23255: Change warning dialog box to a question dialog box: elvisangelaccio.
Mon, Aug 19, 6:07 AM · Dolphin
shubham requested review of D23255: Change warning dialog box to a question dialog box.
Mon, Aug 19, 6:06 AM · Dolphin
sredman added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

Mon, Aug 19, 3:08 AM · Frameworks, Dolphin
iasensio added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

Looks like you incorporated changes in D23075 rather than rebasing on top of it.

Mon, Aug 19, 2:12 AM · Dolphin
ngraham added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

Thanks for the comments, @feverfew. Your assistance is definitely appreciated given that you wrote a lot of the code I'm mangling here.

Mon, Aug 19, 2:07 AM · Dolphin
ngraham added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

Looks like you incorporated changes in D23075 rather than rebasing on top of it.

Mon, Aug 19, 2:02 AM · Dolphin
ngraham added a dependent revision for D23075: Change default Dolphin toolbar layout: D23232: [dolphin] Add an action to toggle the searchbar.
Mon, Aug 19, 2:01 AM · VDG, Dolphin
ngraham added a dependency for D23232: [dolphin] Add an action to toggle the searchbar: D23075: Change default Dolphin toolbar layout.
Mon, Aug 19, 2:01 AM · Dolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Update dolphinui.rc to use toggle_search instead of edit_find
Mon, Aug 19, 12:30 AM · Dolphin
feverfew added a comment to D11382: Add an option to show tabs from last time when Dolphin starts.

This is ready for re-review, with one specific thing I could use help debugging: when you enable the new option, launching Dolphin and opening new windows becomes interminably slow, probably due to some extra DBus overhead that's still a bit beyond my comprehension. See the FIXME in the code.

Mon, Aug 19, 12:19 AM · Dolphin

Sun, Aug 18

ngraham added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

Hmm, now that I give it more thought, you might be right. All right, let's give it a try. @iasensio we'll need for dolphinrc.ui to have the new toggle_search action on the default toolbar, rather than the old edit_find one. And don't forget to bump the version number at the top of that file. :)

Sun, Aug 18, 9:31 PM · Dolphin
felixernst added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

I think it is fine having two actions that both open the Search/Findbar. The new 'toggle-search' would replace 'open-search' in the Toolbar and 'open-search' would still be associated with Ctrl+F.
This is similar to having two actions for typing a new location:


Making the names of the two actions more distinct might be enough to keep the users from getting super confused.

Sun, Aug 18, 8:25 PM · Dolphin
dfaure added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

Sun, Aug 18, 7:08 AM · Frameworks, Dolphin
sredman added a comment to D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes.

But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't make any sense to me.

(*) this comes from KIO::put, which takes unix permissions on unix, not sure what it takes on Windows...

This doesn't match: unix permissions are octal (e.g. group read is 040 in octal), QFileDevice enum is hex (0x040).

Okay. I'm still unable to understand where/ how sftp::put() is called, or I would change everywhere it is called, to Qt way of permission extraction.

Sun, Aug 18, 3:47 AM · Frameworks, Dolphin
ngraham added a reviewer for D23232: [dolphin] Add an action to toggle the searchbar: VDG.

Giving choice to the user isn't really the best solution here IMO. The fact that these toolbars are customizable at all is not widely known, and allowing people to choose between multiple actions that both do the same thing except for one slightly different close/focus behavior is likely to be super confusing to everyone who's not a Dolphin developer. :) Adding VDG for more opinions and comments.

Sun, Aug 18, 1:52 AM · Dolphin
ngraham added a comment to D22144: Add kio recentlyused:/ to access KActivityStats data.

@ivan?

Sun, Aug 18, 1:47 AM · Frameworks, Dolphin
ngraham accepted D23075: Change default Dolphin toolbar layout.
Sun, Aug 18, 1:36 AM · VDG, Dolphin
iasensio updated the test plan for D23232: [dolphin] Add an action to toggle the searchbar.
Sun, Aug 18, 12:37 AM · Dolphin
iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Add an independent toggle_search action
Sun, Aug 18, 12:30 AM · Dolphin

Sat, Aug 17

iasensio updated the diff for D23232: [dolphin] Add an action to toggle the searchbar.
  • Update search action on view changes
Sat, Aug 17, 11:14 PM · Dolphin
iasensio added a comment to D23232: [dolphin] Add an action to toggle the searchbar.

Wow, I did a little search through the bug tracker but I didn't find that it had been already addresed.
Those other two patches seem more detailed, as I haven't dealt with the filter bar, only the search bar. I have already seen some inconsistencies in mine when using tabs or split view.

Sat, Aug 17, 11:02 PM · Dolphin
ngraham added a revision to T8473: Dolphin 'Find' button behavior: D23232: [dolphin] Add an action to toggle the searchbar.
Sat, Aug 17, 10:31 PM · Dolphin