Fix date parameter passing
Fix documentation, CMakeLists.txt, a couple of code fix
You asked for it :-)
Add date and date range filtering after D22775
Tue, Aug 20
I'v added @dfaure as reviewer.
Mon, Aug 19
Looks OK to me, I guess some of our resident KIO experts should review it. What do you think?
Nice. you even differentiated the names that show up in the toolbar configuratin window! Looks great from my perspective. Let's wait for @elvisangelaccio now.
Nice job. May it be the first of many! :)
If the question starts with "Are you sure you want to..." that's probably a good sign it should be a warning since the wording implies that if you go through with it, something undesirable might happen.
I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.
- Set toggle_search as default toolbar action
- Set toggle_search as default toolbar action (on top of D23075)
I think a warning is appropriate as opening a gazillion applications could lead to an unresponsive system.
Thanks for the comments, @feverfew. Your assistance is definitely appreciated given that you wrote a lot of the code I'm mangling here.
Looks like you incorporated changes in D23075 rather than rebasing on top of it.
- Update dolphinui.rc to use toggle_search instead of edit_find
Sun, Aug 18
Hmm, now that I give it more thought, you might be right. All right, let's give it a try. @iasensio we'll need for dolphinrc.ui to have the new toggle_search action on the default toolbar, rather than the old edit_find one. And don't forget to bump the version number at the top of that file. :)
I think it is fine having two actions that both open the Search/Findbar. The new 'toggle-search' would replace 'open-search' in the Toolbar and 'open-search' would still be associated with Ctrl+F.
This is similar to having two actions for typing a new location:
Making the names of the two actions more distinct might be enough to keep the users from getting super confused.
The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.
Giving choice to the user isn't really the best solution here IMO. The fact that these toolbars are customizable at all is not widely known, and allowing people to choose between multiple actions that both do the same thing except for one slightly different close/focus behavior is likely to be super confusing to everyone who's not a Dolphin developer. :) Adding VDG for more opinions and comments.
- Add an independent toggle_search action
Sat, Aug 17
- Update search action on view changes
Wow, I did a little search through the bug tracker but I didn't find that it had been already addresed.
Those other two patches seem more detailed, as I haven't dealt with the filter bar, only the search bar. I have already seen some inconsistencies in mine when using tabs or split view.