+1, that's fine with me too.
I agree, I hate this kind of ambiguous language.
Relavant code is KFormat::formatRelativeDate
Also revert 90beb4a5e37b887caad1e767046a42dad0af1ab3 which is no longer needed
various fixes suggested by dfaure
Yep, still looking for primarily design input.
- Fix indentation
Sun, Dec 8
I dont think that's wise. It's an integral part of this change, since users have to know which settings are logically connected to this new mode and which ones are not.
Please see 90beb4a5e37b887caad1e767046a42dad0af1ab3
Would you mind splitting the re-design of the Startup settings page to a different commit?
The issue with that approach is that you can never be 100% sure you're in the right directory on your inactive split view. A minor issue, yes, but an issue nonetheless.
Please push to release/19.12
+1 to tabs having a minimum width size
I kind of like that tab location but it probably shouldn't extend to the sidebar too.
Sat, Dec 7
With regards to the Docker/Gitlab CI part, please use the images under kdeorg/ on Dockerhub rather than personally maintained images as the wider community has no access to your namespace on Gitlab.com
I guess you were expecting a higher-level review, but I don't know anything about these protocols.
Fri, Dec 6
We decided not to do this. There are now quite a few items in here and it seems like they're fine there.
I just landed an old patch of mine that adds a dedicated "focus/de-focus terminal panel" action to Dolphin: D10959
Should be fully completed with D24247.
Yeah, let's keep this the way it is. I think it's plenty comprehensible, and we never managed to come up with a good place to move them anyway.
ReviewBoard has been closed down now.
This is currently in progress and I don't think we need this task open anymore. The patches are scattered across various bits of infrastructure so it won't be useful for linking them here.
see https://bugs.kde.org/show_bug.cgi?id=414492 user already created patch.
See also commit 6be886bafae463ba in kcoreaddons (which was wrong, it would seem -- there are better ways to prevent infinite loops than to say "let's not follow symlinks at all").
This should go into KDirWatch itself then, to avoid the risk of other callers falling into that trap.