DolphinProject
ActivePublic

Recent Activity

Yesterday

ngraham added projects to T11627: Improve KIO asynchronicity: Frameworks, Dolphin.
Fri, Oct 18, 5:27 PM · Dolphin, Frameworks
meven accepted D19989: Unmounting busy device doesn't tell who is blocking.

Looks good to me, let's wait for @elvisangelaccio review

Fri, Oct 18, 4:17 PM · Dolphin
meven planned changes to D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

Wait for KF 5.64 release and bump dependency if not already done.

Fri, Oct 18, 1:29 PM · Dolphin
ngraham added a comment to D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

This does depend now on KF5 5.64.
So should I wait for the dependency bump or do it myself ?
https://phabricator.kde.org/D19989#inline-139775 mentions doing also.

Fri, Oct 18, 1:07 PM · Dolphin
meven added a comment to D23668: [Information Panel] Allows to refresh icon and metadata for urls such as trash:/.

This does depend now on KF5 5.64.
So should I wait for the dependency bump or do it myself ?
https://phabricator.kde.org/D19989#inline-139775 mentions doing also.

Fri, Oct 18, 9:35 AM · Dolphin
hallas added inline comments to D19989: Unmounting busy device doesn't tell who is blocking.
Fri, Oct 18, 6:38 AM · Dolphin
hallas updated the diff for D19989: Unmounting busy device doesn't tell who is blocking.

Updated to use KListOpenFilesJob

Fri, Oct 18, 6:36 AM · Dolphin

Thu, Oct 17

ngraham accepted D24422: [dolphin] Improve parsing of Baloo query searchString.

LGTM now. @elvisangelaccio and @bruns?

Thu, Oct 17, 4:39 PM · Dolphin
iasensio added a comment to D24422: [dolphin] Improve parsing of Baloo query searchString.

I just saw a new bug reporting on something this should fix, namely the double quotes around the search terms (https://bugs.kde.org/show_bug.cgi?id=412952), so updating the summary.
Since now the search box reloads its contents on URL changes, this kind of bugs are more exposed to the users.

Thu, Oct 17, 10:39 AM · Dolphin
iasensio updated the summary of D24422: [dolphin] Improve parsing of Baloo query searchString.
Thu, Oct 17, 10:35 AM · Dolphin
sitter closed D24487: fix password error condition handling of smb mount.
Thu, Oct 17, 9:05 AM · Frameworks, Dolphin

Wed, Oct 16

meven accepted D24690: Fix a bug where "Add to Places" remains disabled.

I think you can land this.

Wed, Oct 16, 10:29 AM · Dolphin
meven added a reviewer for D24690: Fix a bug where "Add to Places" remains disabled: elvisangelaccio.
Wed, Oct 16, 10:27 AM · Dolphin
alexmi requested review of D24690: Fix a bug where "Add to Places" remains disabled.
Wed, Oct 16, 10:04 AM · Dolphin
meven requested review of D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue.
Wed, Oct 16, 7:48 AM · Frameworks, Dolphin

Tue, Oct 15

ngraham added a comment to D24602: New design for extended search options.

This is so nice!

Tue, Oct 15, 10:30 PM · Dolphin
broulik planned changes to D24431: Restore cursor thumbnailer.
Tue, Oct 15, 1:44 PM · Frameworks, Dolphin

Mon, Oct 14

meven added inline comments to D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.
Mon, Oct 14, 6:25 AM · Dolphin
meven updated the diff for D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.

Move comment to header

Mon, Oct 14, 6:25 AM · Dolphin

Sun, Oct 13

iasensio updated the diff for D24450: [dolphin/search] Reset search options when needed.
  • Use changedEvent() instead of overriding
Sun, Oct 13, 6:26 PM · Dolphin
iasensio abandoned D24619: [dolphin/search] Reset search options when needed.

Bad arcanist foo, sorry

Sun, Oct 13, 6:21 PM · Dolphin
iasensio requested review of D24619: [dolphin/search] Reset search options when needed.
Sun, Oct 13, 6:19 PM · Dolphin
iasensio added a comment to D24577: [dolphin/search] Fix search behavior when selecting "Your Files".

@elvisangelaccio, about your question, reviewing the code, there are four places (apart from setter and getter) where m_searchPath is used:

  1. For baloo search (l.502), it is only used if m_everywhere is not checked, so it would cancel the condition in the getter, returning m_searchPath anyway
  2. For regular search (l.135), there is a similar condition as in searchPath().
  3. Menu action to call an external tool (KFind) (l.423)
  4. In the entry point fromUrlSearch(), introduced in this patch to reset it on certain paths
Sun, Oct 13, 5:57 PM · Dolphin
iasensio updated the diff for D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
  • Rebase to master
  • Fix non-indexed corner case
  • Make use of searchPath()
Sun, Oct 13, 5:57 PM · Dolphin
elvisangelaccio added inline comments to D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
Sun, Oct 13, 3:51 PM · Dolphin
elvisangelaccio requested changes to D24450: [dolphin/search] Reset search options when needed.
Sun, Oct 13, 3:42 PM · Dolphin
elvisangelaccio closed D24446: Hide search extra options when not available.
Sun, Oct 13, 3:25 PM · Dolphin
elvisangelaccio accepted D24446: Hide search extra options when not available.
Sun, Oct 13, 3:25 PM · Dolphin
elvisangelaccio requested changes to D22594: [Dolphin] Open Preferred Search Tool action.

Almost there!

Sun, Oct 13, 3:19 PM · Documentation, Dolphin
elvisangelaccio closed D24353: Add actions for switching to a specific tab.
Sun, Oct 13, 3:03 PM · Dolphin
elvisangelaccio accepted D24353: Add actions for switching to a specific tab.
Sun, Oct 13, 2:43 PM · Dolphin
elvisangelaccio requested changes to D24505: Avoid emitting twice twice selectionChanged when keyboard changes the selection.

I still don't understand if we are fixing an issue or if this is just a removal of a redundant signal. AFAICS we are only removing a selectionChanged() instance called by clearSelection() in "search mode", but this signal is also emitted in many other places (e.g. is emitted 3 times if I change selection with the mouse).

Sun, Oct 13, 2:08 PM · Dolphin
iasensio added a comment to D24602: New design for extended search options.

Why do the comboboxes look so thin in the video?

Sun, Oct 13, 12:34 PM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Fix combos' height
Sun, Oct 13, 12:28 PM · Dolphin
iasensio added a comment to D24602: New design for extended search options.

I think we could even get rid of the More Options/Fewer Options toggle button and just always show the search options now that they don't take up much space.

Sun, Oct 13, 11:54 AM · Dolphin
astippich closed T8196: KFileMetadata: String lists. How do clients cope? as Resolved.

Baloo now only outputs multiple entries in the property map instead of stringlist as of D19088 and clients all handle this since Applications 19.08

Sun, Oct 13, 11:41 AM · Dolphin, Elisa, Frameworks, Baloo
ndavis added a comment to D24602: New design for extended search options.

Why do the comboboxes look so thin in the video?

Sun, Oct 13, 6:13 AM · Dolphin
ngraham added a comment to D24602: New design for extended search options.

This is a lot nicer. I think we could even get rid of the More Options/Fewer Options toggle button and just always show the search options now that they don't take up much space.

Sun, Oct 13, 2:39 AM · Dolphin
iasensio updated the diff for D24602: New design for extended search options.
  • Validate terms before applying
Sun, Oct 13, 12:29 AM · Dolphin

Sat, Oct 12

iasensio requested review of D24602: New design for extended search options.
Sat, Oct 12, 11:13 PM · Dolphin
dfaure accepted D24487: fix password error condition handling of smb mount.
Sat, Oct 12, 6:01 PM · Frameworks, Dolphin
iasensio updated the summary of D24422: [dolphin] Improve parsing of Baloo query searchString.
Sat, Oct 12, 12:38 AM · Dolphin

Fri, Oct 11

iasensio requested review of D24577: [dolphin/search] Fix search behavior when selecting "Your Files".
Fri, Oct 11, 11:50 PM · Dolphin
adridg added inline comments to D24431: Restore cursor thumbnailer.
Fri, Oct 11, 12:32 PM · Frameworks, Dolphin
mthw added a comment to D23926: Move "Details" tab to second place in Properties dialog.

Any progress on this?

Fri, Oct 11, 8:55 AM · VDG, Dolphin, Frameworks

Thu, Oct 10

iasensio updated the diff for D24446: Hide search extra options when not available.
  • Fix typo and correct i18n markers
Thu, Oct 10, 9:12 PM · Dolphin
elvisangelaccio requested changes to D24446: Hide search extra options when not available.

More info on the i18n markers here: https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt

Thu, Oct 10, 7:57 PM · Dolphin
meven added inline comments to D23716: When the selection is deselected, restart the keyboard search from the beginning.
Thu, Oct 10, 7:30 AM · Dolphin
meven updated the diff for D23716: When the selection is deselected, restart the keyboard search from the beginning.

Rebasing

Thu, Oct 10, 7:28 AM · Dolphin

Wed, Oct 9

iasensio updated the diff for D24446: Hide search extra options when not available.
  • Add setFacetsVisible() method
  • Update toggle button on showEvent
Wed, Oct 9, 11:31 PM · Dolphin