Use HiDPI icons when scaling is used
Details
Details
Diff Detail
Diff Detail
- Repository
- R374 KolourPaint
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Testing plan needs to be more detailed than just the main window.
This flag can be "dangerous" in the sense that Qt will return pixmaps twice the size the application requests.
Please ensure you open every dialog you can find and do a tiny bit of editing/saving/printing.
Also, can you apply for a developer account. You should a button on identity.kde.org, then put my name as someone who supports your request.
Comment Actions
At a glance the editing options seem to work. There's an off-by-one error in the pixel grid that is also present without this patch, though.
Zoom in, enable grid, start painting with a white pencil. You can see that where you paint the grid turns thinner.
Comment Actions
The only thing I found that was out of place was the action menu icons.
They don't seem to honor the Qt attribute.
Comment Actions
The only thing I found that was out of place was the action menu icons.
They don't seem to honor the Qt attribute.
Ok, it turns out that this is an unrelated bug in the appmenu in the titlebar, and it is present in every app.
Comment Actions
Hm, doesn't that also affect the main painting view? In other words, if I have a 1.5 scaling factor, I can no longer use KolourPaint as a pixel-perfect painting tool?
Comment Actions
Hm, doesn't that also affect the main painting view? In other words, if I have a 1.5 scaling factor, I can no longer use KolourPaint as a pixel-perfect painting tool?
This attribute will have no impact on that. It only affects QIcon::fromTheme, QtSVG::toPixmap and some other places like that.
The main canvas may be scaled up (which I don't think is a bad thing, you can still mod every pixel) but it's unrelated to this.