Differential D15880

Khelpcenter menu does not work (some parts of TreeView not expanded)
AbandonedPublic
Actions

Authored by pavelmos on Oct 1 2018, 2:48 PM.

Details

Reviewers
yurchor
mlaurent
lueck
ltoscano
anemeth
Summary

Khelpcenter menu does not work (some parts of TreeView not expanded)

Package: khelpcenter version 5.7.3
KDE Frameworks Version 5.51.0
Qt Version 5.11.1

KDE Plasma Version 5.13.90
Kernel Version 4.15.0-34-generic
OS Type: 64-bit

NAME="KDE neon"
VERSION="Developer Edition"
ID=neon
ID_LIKE="ubuntu debian"
PRETTY_NAME="KDE neon Developer Edition"
VERSION_ID="18.04"
HOME_URL="http://neon.kde.org/"
SUPPORT_URL="http://neon.kde.org/"
BUG_REPORT_URL="http://bugs.kde.org/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic

On 2018.09.26, an upgrade was made by command dist-upgrade.
Incorrect to works the contents index tree on left half of application window (TreeWidget) khelpcenter.

STEPS TO REPRODUCE BUG

0. Open «System Settings» (systemsettings5) → Input Devices → Mouse → General → Choose «Double-click to open files and folders» (!!!)

  1. Start khelpcenter (in any way).
  2. Choose menu item - "Kinfocenter Modules" - in the left half of the application window.
  3. Choose "Memory" in the right half of the application window.
  4. Look on the left half of the application window.
  5. Choose «KinfoCenter» menu item in the left half of the application window.
  6. The corresponding help is not displayed in the right half of the application window.
  7. Similarly with other submenus of «KinfoCenter Modules» -> ... .

OBSERVED RESULT

  1. User uses - Double-click to open files and folders.
  2. Start khelpcenter.
  3. Pressing some of the menu items does not produce any results (the corresponding help information is not displayed in the right half of the application window). For example - look at "STEPS TO REPRODUCE BUG".

EXPECTED RESULT
Menu should work correctly:

  • all menu items should be displayed,
  • subparagraphs should open and disclose subtrees,
  • the corresponding help is displayed in the right half of the application window.
Test Plan

STEPS TO REPRODUCE

  1. Open «System Settings» (systemsettings5) → Input Devices → Mouse → General → Choose «Double-click to open files and folders»
  2. Start khelpcenter (in any way).
  3. Choose menu item - "Kinfocenter Modules" - in the left half of the application window.
  4. Choose "Memory" in the right half of the application window.
  5. Choose «KinfoCenter» menu item in the left half of the application window.
  6. Choose any submenu item of «KinfoCenter» menu in the left half of the application window.
  7. Now the corresponding help is displayed in the right half of the application window.

Diff Detail

Repository
R125 KHelpCenter
Lint
Lint Skipped
Unit
Unit Tests Skipped
pavelmos created this revision.Oct 1 2018, 2:48 PM
Restricted Application added a project: Documentation. · View Herald TranscriptOct 1 2018, 2:48 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
pavelmos requested review of this revision.Oct 1 2018, 2:48 PM
pavelmos edited the test plan for this revision. (Show Details)Oct 1 2018, 2:59 PM
pavelmos added reviewers: yurchor, mlaurent, anemeth, lueck.
pavelmos edited the summary of this revision. (Show Details)Oct 2 2018, 8:23 AM
pavelmos edited the test plan for this revision. (Show Details)
pavelmos edited the summary of this revision. (Show Details)Oct 2 2018, 8:25 AM
yurchor accepted this revision.Oct 2 2018, 9:05 AM

Tested to work as explained above.

This revision is now accepted and ready to land.Oct 2 2018, 9:05 AM
ltoscano requested changes to this revision.Oct 2 2018, 9:11 AM
ltoscano added a subscriber: ltoscano.

I could not test it yet, but at least the commit message should be changed. Right now it is a copy of the bug report.

This revision now requires changes to proceed.Oct 2 2018, 9:11 AM
anemeth resigned from this revision.Oct 2 2018, 3:50 PM
ltoscano added a comment.Oct 2 2018, 10:30 PM

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)

pavelmos added a comment.Oct 5 2018, 8:17 AM
In D15880#335630, @ltoscano wrote:

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)

Thank you.
Unfortunately, I can't use Arcanist as it is not included in AltLinux.

ltoscano added a comment.Oct 5 2018, 8:19 AM
In D15880#337020, @pavelmos wrote:
In D15880#335630, @ltoscano wrote:

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)

Thank you.
Unfortunately, I can't use Arcanist as it is not included in AltLinux.

But that's not a blocker for not using Arcanist. The "installation" is just "get few files":
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

I guess we need to link that inside https://community.kde.org/Infrastructure/Phabricator#Installing_Arcanist

yurchor added a comment.Oct 5 2018, 8:29 AM

But that's not a blocker for not using Arcanist. The "installation" is just "get few files":
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

Actually, it is easy to avoid using this overengineered software for mages. ;) Just use

git diff > mypatch.patch

in the main folder of khelpcenter checkout, then upload the diff via the web interface.

ltoscano added a comment.Oct 5 2018, 8:46 AM
In D15880#337032, @yurchor wrote:

But that's not a blocker for not using Arcanist. The "installation" is just "get few files":
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

Actually, it is easy to avoid using this overengineered software for mages. ;) Just use

git diff > mypatch.patch

in the main folder of khelpcenter checkout, then upload the diff via the web interface.

No, I'd prefer to avoid that. This workflow does not provide the autorship information inside the patch, which needs to be requested separately later.

yurchor added a comment.Oct 5 2018, 8:53 AM
In D15880#337037, @ltoscano wrote:
In D15880#337032, @yurchor wrote:

But that's not a blocker for not using Arcanist. The "installation" is just "get few files":
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

Actually, it is easy to avoid using this overengineered software for mages. ;) Just use

git diff > mypatch.patch

in the main folder of khelpcenter checkout, then upload the diff via the web interface.

No, I'd prefer to avoid that. This workflow does not provide the autorship information inside the patch, which needs to be requested separately later.

Ok. I failed to install Arcanist in Mageia properly as well (its dependencies required more space than was free on my root partition). Will my patches be excluded from now on?

ltoscano added a comment.Oct 5 2018, 8:59 AM
In D15880#337038, @yurchor wrote:

Ok. I failed to install Arcanist in Mageia properly as well (its dependencies required more space than was free on my root partition). Will my patches be excluded from now on?

You have a commit account and you can land your own patch. But that means that they will lack the metadata information (who reviewed it and so on) unless you spend time manually copying the commit message from phabricator.

That said, you don't need to "install" arcanist in your root partition. If you check the generic instruction, you basically need to clone two repositories and point the PATH to one of them. That's what I have been doing for almost two years.

yurchor added a comment.Oct 5 2018, 9:06 AM
In D15880#337039, @ltoscano wrote:
In D15880#337038, @yurchor wrote:

Ok. I failed to install Arcanist in Mageia properly as well (its dependencies required more space than was free on my root partition). Will my patches be excluded from now on?

You have a commit account and you can land your own patch. But that means that they will lack the metadata information (who reviewed it and so on) unless you spend time manually copying the commit message from phabricator.

That said, you don't need to "install" arcanist in your root partition. If you check the generic instruction, you basically need to clone two repositories and point the PATH to one of them. That's what I have been doing for almost two years.

I guess I understand better why we have not that many developers these days. Those who prefer the pure command line, full-fledged PHP on a workstation and vim would never use KDE.

ltoscano added a comment.Oct 5 2018, 9:16 AM
In D15880#337040, @yurchor wrote:
In D15880#337039, @ltoscano wrote:
In D15880#337038, @yurchor wrote:

Ok. I failed to install Arcanist in Mageia properly as well (its dependencies required more space than was free on my root partition). Will my patches be excluded from now on?

You have a commit account and you can land your own patch. But that means that they will lack the metadata information (who reviewed it and so on) unless you spend time manually copying the commit message from phabricator.

That said, you don't need to "install" arcanist in your root partition. If you check the generic instruction, you basically need to clone two repositories and point the PATH to one of them. That's what I have been doing for almost two years.

I guess I understand better why we have not that many developers these days. Those who prefer the pure command line, full-fledged PHP on a workstation and vim would never use KDE.

I'm not sure about this statement and I'm not sure about the implication. There is nothing about vim here.
You mentioned git diff, which is a command line tool.
If I need to talk about stereotypes, hardcore vim+pure command line user are said to be allergic to PHP, so that category of people that you mentioned should not really exist.
And non-hardcore vim and command line users, which seems to be the category you think may contribute to KDE stuff, do not probably care about another interpreter installed locally. At least, this was not a problem when people asked on IRC about how to send patches. If the problem is the PHP dependency we can team up with other phabricator user and make git-phab (in python) working again, but no one seemed to find this an high priority.

Anyway, we are going off topic, but I invite you to reconsider how much this is a real problem.

pavelmos added a comment.Oct 8 2018, 3:00 PM
In D15880#337021, @ltoscano wrote:
In D15880#337020, @pavelmos wrote:
In D15880#335630, @ltoscano wrote:

Also, the patch does not apply cleanly when applied with arc patch D15880. Can you please use arcanist to generate the patch? (see the link that I pasted in the previous comment.)

Thank you.
Unfortunately, I can't use Arcanist as it is not included in AltLinux.

But that's not a blocker for not using Arcanist. The "installation" is just "get few files":
https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

I guess we need to link that inside https://community.kde.org/Infrastructure/Phabricator#Installing_Arcanist

I've done what you asked me to do.
But it is here D16047.

pavelmos abandoned this revision.Oct 19 2018, 2:23 PM

Revision Contents
Changeset List

PathPackages
Mkhelpcenter/navigatorappitem.cpp (2 lines)

Diff 42666

View Options

khelpcenter/navigatorappitem.cpp

Loading...