[RFC] Change drawer header image
AbandonedPublic

Authored by nicolasfella on Apr 17 2018, 4:29 PM.

Details

Reviewers
None
Group Reviewers
KDE Connect
VDG
Summary

The current drawer header does not really fit into the proposed dark theme. Using Konqui gives some nice branding. However I'm open for input.

Test Plan

Current:

Current with dark theme:

Proposed:

On dark theme:

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
arcpatch-D12285
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4325
Build 4343: arc lint + arc unit
nicolasfella created this revision.Apr 17 2018, 4:29 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 17 2018, 4:29 PM
nicolasfella requested review of this revision.Apr 17 2018, 4:29 PM
nicolasfella edited the summary of this revision. (Show Details)Apr 17 2018, 4:33 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella edited the summary of this revision. (Show Details)

Maybe the images can be combined? Or a background color? It looks a bit empty with this change.

  • Merge branch 'master' into arcpatch-D12285
  • Adapt to moved dark theme switch
Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptOct 29 2018, 2:36 PM
nicolasfella edited the test plan for this revision. (Show Details)Oct 29 2018, 2:38 PM
nicolasfella edited the test plan for this revision. (Show Details)Oct 29 2018, 2:41 PM
abetts added a subscriber: abetts.Oct 29 2018, 2:46 PM

I would probably resize Konqui to be as tall as the two labels to the left. It will seem more balanced.

I'm not a big fan of having Konqui there (or anything that's not an abstract image or a solid color). I don't have any arguments other than personal preference.

If you want to change it because the current image is from an old Plasma wallpaper, I would be happy to update it to the latest wallpaper as long as it's still abstract. Actually, my original idea was to change it with each release of Plasma (which I never did). Maybe we can make updating it a GCI task?

You put an image there for the sake of an image being there.
It is completely irrelevant to the menu.
How about putting there something relevant, like a png image of a phone and tablet and computer there showing connections?

I'm thinking on something loosely similar to these, maybe some KDE branding (a Konqi on the screen of the phone and pc display, etc.):

Discover gets a lot of criticism for the header image too. Same complaint: it's a pointless waste of space, an image there for the sake of being there. I really don't think this pattern works at all and would advocate removing it from Kirigami entirely. These images are just wasted space, and no matter how pretty they are, that won't change.

I love the new Konquis - all of them -- but this use is not good in my opinion. Distracting and somewhat pointless. I would rather see a solid color or gradient. Simple and elegant.

apol added a subscriber: apol.Nov 7 2018, 2:43 PM

@nicolasfella let's close the review and find another, better, approach?

How about removing the "drawer header" UI concept from Kirigami entirely? ;)

nicolasfella abandoned this revision.Nov 7 2018, 2:59 PM

How about removing the "drawer header" UI concept from Kirigami entirely? ;)

In this case it's not a Kirigami app but a native Android app that follows Material guidelines.

abetts removed a subscriber: abetts.Nov 7 2018, 3:01 PM

[spam comment removed by sysadmin]