Differential D12700

Fix blur on Wayland when scaling is used
ClosedPublic
Actions

Authored by anemeth on May 4 2018, 6:53 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:b3b691a25074: Fix blur on Wayland when scaling is used
R108:37f4c54d17f9: Fix blur on Wayland when scaling is used
Summary

Blur should now work on Wayland when scaling is used.
This does not affect X11 as GLRenderTarget::virtualScreenScale() is always 1 on X11

BUG: 391387
Depends on D12678

Test Plan
  • log in in a Wayland session
  • turn display scaling to 2x
  • open a transparent window (for example: Konsole with transparent and blur enabled profile)
  • blurs the content under the window corretly

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anemeth created this revision.May 4 2018, 6:53 PM
Restricted Application added a project: KWin. · View Herald TranscriptMay 4 2018, 6:53 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
anemeth requested review of this revision.May 4 2018, 6:53 PM
anemeth edited the summary of this revision. (Show Details)May 4 2018, 6:56 PM
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: davidedmundson, KWin.
anemeth added a dependency: D12678: Fix multimonitor blur.
anemeth edited the test plan for this revision. (Show Details)
zzag added a subscriber: zzag.May 4 2018, 10:56 PM

It fixes 391387, right?

davidedmundson accepted this revision.May 5 2018, 3:48 AM

Good stuff. Thanks for looking into it. Seems to work nicely.

This revision is now accepted and ready to land.May 5 2018, 3:48 AM
anemeth edited the summary of this revision. (Show Details)May 5 2018, 10:03 AM
In D12700#258365, @zzag wrote:

It fixes 391387, right?

Yes, added it to summary, thanks.

apol added a subscriber: apol.May 7 2018, 5:48 PM

I just tested this, it definitely looks like a step forward but I'm afraid it's not everything that is needed.

I

anemeth added a comment.May 7 2018, 7:12 PM

@apol what config do you use?
single monitor?
2x scaling?
wayland?
have you tried relogging or restarting?
did you use "arc patch D12700" to apply the 2 dependent revisions too?
any specific steps or unique setup to reproduce this?

apol added a comment.May 7 2018, 8:20 PM
In D12700#259298, @anemeth wrote:

@apol what config do you use?
single monitor?
2x scaling?
wayland?
have you tried relogging or restarting?
did you use "arc patch D12700" to apply the 2 dependent revisions too?
any specific steps or unique setup to reproduce this?

This was wayland, 2x scaling, single monitor.

And I wasn't able to use arc patch, because of the dependencies I guess. Applying the other two patches work.

Sorry about that and thanks a lot for fixing!

anemeth added a comment.May 31 2018, 12:23 PM

Could someone please land this revision?
My arcanist has a problem with this patch.

romangg added a subscriber: romangg.May 31 2018, 12:25 PM
In D12700#271389, @anemeth wrote:

Could someone please land this revision?
My arcanist has a problem with this patch.

You can just download the patch as raw diff, reapply to current master and copy the description text from Phab in a new commit message (copy the scheme from earlier commits).

anemeth added a comment.May 31 2018, 12:26 PM
In D12700#271390, @romangg wrote:

You can just download the patch as raw diff, reapply to current master and copy the description text from Phab in a new commit message (copy the scheme from earlier commits).

thanks, I'll try that

Closed by commit R108:b3b691a25074: Fix blur on Wayland when scaling is used (authored by anemeth). · Explain WhyMay 31 2018, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/blur/blur.cpp (8 lines)

Diff 35248

View Options

effects/blur/blur.cpp

Loading...