As mentioned in the task:

In T8552#139581, @rkflx wrote:

In T8552#139578, @anemeth wrote:

Could we have the same icon zoom slider as in Dolphin?

• Predefined sizes only, no arbitary icon sizes

Hm, OTOH if we keep the buttons, having predefined sizes in the slider is not needed anymore… Better keep the fine-grained control for those that want and need it. Removing that could be disliked by some.

if we keep the buttons, having predefined sizes in the slider is not needed anymore…

I would vote for removing the buttons, you can also click the slider left or right of its handle to move it one step at a time. However, since it's in the toolbar and not status bar like in Dolphin, might be hard to tell it's a "zoom slider" without the icons.

Removing that could be disliked by some.

I'm not aware of people complaining about Dolphin not supporting arbitrary sizes.

+1 overall

In D12848#262008, @broulik wrote:

I would vote for removing the buttons

We already discussed this and decided to keep the buttons.

IMHO what we really need is a standard size slider widget so that each app doesn't need to reinvent the wheel. Right now Gwenview, Dolphin, and the file dialogs each implement their own, and they're all subtly (or very) different from each other.

That said, I find myself agreeing with Kai and Alex here. Arbitrary zoom levels aren't really needed in the file dialog like they are in Gwenview. Dolphin's slider has discrete sizes and I don't think it causes problems there.

Edit: train wifi resumed so I was actually able to watch the video. :)

In the open/save dialog use the same fixed icon sizes for the zoom slider as Dolphin.

So we could also change Dolphin to support continuous zoom instead? As the summary is quite sparse, I'm not sure what the patch is about: Is it about consistency, or is there a fundamental reason why fixed sizes are better for users?

Note that we allow arbitrary window sizes, sidebar sizes and so on. Targeting a specific icon size can still easily be done by clicking on the button, or by dragging the slider while observing the tooltip showing the pixel size.

Personally I prefer smooth zooming (which Dolphin is doing, too) instead of having big jumps between steps. Nevertheless, if you can find more +1's and better reasons for the change itself, I'm not going to block this patch. However, "nobody complained for Dolphin" is not good enough of a reason.

Could you research why for Dolphin there are discrete sizes? Maybe this stems from pre-SVG times, where only certain pixel sizes had sharp rendering of icons. If this is the case, with today's SVGs we could easily support all in-between sizes without much loss of rendering quality.

In D12848#262303, @ngraham wrote:

IMHO what we really need is a standard size slider widget so that each app doesn't need to reinvent the wheel. Right now Gwenview, Dolphin, and the file dialogs each implement their own, and they're all subtly (or very) different from each other.

That said, I find myself agreeing with Kai and Alex here. Arbitrary zoom levels aren't really needed in the file dialog like they are in Gwenview. Dolphin's slider has discrete sizes and I don't think it causes problems there.

I'm confused: First you propose a common widget, and then you say Gwenview needs arbitrary zoom levels?

Edit: One more thing: With previews on by default, discrete steps make even less sense. Discrete steps were fine for regular mimetype icons, but for previews I'd imagine people want more control over the exact size (at least that's why in Gwenview you can set arbitrary sizes in Browse mode).

I'd also prefer adding continuous zooming in Dolphin rather than removing it here.

In D12848#262776, @rkflx wrote:

I'm confused: First you propose a common widget, and then you say Gwenview needs arbitrary zoom levels?

A common widget could easily support both steps and continuous zooming

But the more I think about it, the more I'm starting to agree with you that continuous zooming is fine as long as we have buttons that implement a sort of step mode for people who want that. If I think about the reasons why I'd want step mode, it's to be able to set the icons to a known, integer value size, mostly because of OCD tendencies. :-)