Create Task
Maniphest T16059

Delete /po folder of docs-kdenlive-org repository.
Closed, ResolvedPublic
Actions

Description

I like to remove the po folder from https://invent.kde.org/documentation/docs-kdenlive-org since translations are already mirrored to the locale by StaticMessage.sh.

The po folder has already been added to .gitignore with https://invent.kde.org/documentation/docs-kdenlive-org/-/commit/67b66acf7b6a5256f7b1e7734ae6a7ed05122e6d

Recently the same changes were done to docs-krita-org. Please see this mailing list discussion: https://mail.kde.org/pipermail/kde-devel/2022-October/001402.html

The reason I am filling this ticket is, that changes to the po folder are protected by the hooks.

Thanks in advance,
Julius

Related Objects

jlskuz created this task.Dec 12 2022, 6:53 PM
Restricted Application added a subscriber: sysadmin. · View Herald TranscriptDec 12 2022, 6:53 PM
bcooksley moved this task from External: Active to External: Awaiting Response on the Sysadmin board.Dec 13 2022, 7:46 AM
bcooksley added subscribers: aacid, ltoscano, bcooksley.

It's a bit frustrating that Sphinx wants to do things it's way, as well as the amount of noise being generated by Kdenlive/Krita folks over the fact that they go in po/ instead of locale/.
There is no point in me removing those even with an exception because scripty is still adding those files regardless of .gitignore.

ltoscano added a comment.Dec 13 2022, 9:53 AM

That discussion mentioned the renaming of the files (see also https://invent.kde.org/sysadmin/l10n-scripty/-/issues/2 ) but I don't remember any final decision about that - maybe we should follow up up on that instead?

aacid added a comment.Dec 13 2022, 9:53 PM

Yes, https://invent.kde.org/sysadmin/l10n-scripty/-/issues/2 is the solution that makes sense to me (but on the other hand i made that issue so that's not a surprise)

bcooksley added a comment.Dec 14 2022, 9:57 AM

That seems reasonable to me as well, as it would be preferrable to not have additional custom scripts in each repository for this....

bcooksley closed this task as Resolved.Dec 29 2022, 6:04 PM
bcooksley claimed this task.

Given this is waiting on a solution within scripty, not sure there is much for us to do here...

jlskuz added a comment.Dec 29 2022, 9:54 PM

Sorry I didn't answer and thanks for taking a look. Based on the info I linked to above, I thought the .gitignore solution works and hence it is an easy thing. However having the po dir around is not a big issue and its totaly fine to wait until there is a proper solution.

bcooksley changed the visibility from "Custom Policy" to "Public (No Login Required)".Jan 3 2023, 8:40 PM
bcooksley changed the edit policy from "Custom Policy" to "All Users".
phunh added a subscriber: phunh.EditedJan 4 2023, 3:31 PM

For docs-kdenlive-org (as well as digikam-doc), I think removing the po folder would help. We are still seeing updates made to that po folder because files already in that folder before it's added to .gitignore are already tracked by Git, so Git continues tracking them. No new files have been added after the folder was added to .gitignore. So if the folder is removed, Git will not add any file in that folder.

For docs-krita-org, it's a bit different. Its branch for i18n is krita/5.1 but po was only added to .gitignore on master branch, not on krita/5.1. So only removing po folder won't help here, we need to add po to .gitignore on krita/5.1 branch, too.

To summarize: po folder needs to be added to .gitignore before Scripty can create the folder, otherwise everyone is unhappy.