Add "Cig Waste No. 2" theme
ClosedPublic

Authored by gregormi on May 18 2019, 8:32 PM.

Details

Reviewers
aacid
Group Reviewers
KDE Games
Summary

Add a new theme to put poisonous garbage into its proper location: the trash bin.
It is build upon the default Oxygen theme with a green base color.

Test Plan

Installed theme. Works fine.

Diff Detail

Repository
R404 KMines
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27163
Build 27181: arc lint + arc unit
gregormi created this revision.May 18 2019, 8:32 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptMay 18 2019, 8:32 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
gregormi requested review of this revision.May 18 2019, 8:32 PM
gregormi edited the summary of this revision. (Show Details)May 18 2019, 8:39 PM

Screenshots ?:)

gregormi edited the summary of this revision. (Show Details)May 19 2019, 8:57 AM
aacid added a subscriber: aacid.May 19 2019, 10:19 PM

If we're going to be so concerned about what we expain to kids, i'd rather use something else than a cigarrette to represent trash

themes/kmines_waste.info.md
8 ↗(On Diff #58264)

These licenses don't really seem valid according to https://community.kde.org/Policies/Licensing_Policy

If we're going to be so concerned about what we expain to kids, i'd rather use something else than a cigarrette to represent trash

At this age, in my experience, children are already taught that smoking is a bad thing. They see people smoking cigarettes, "smoking prohibited" signs and cigarette stump waste all over the place. So, there is nothing new for me to explain. I want to give something already known to connect with easily.

something else than a cigarrette to represent trash

Where I live, the single most found item when collecting garbage are cigarette stumps (especially on waiting places like train or bus stations; even where trash cans are in in short reach). Thus, for me this is a very good representation of pointless waste which also pollutes the environment with chemicals. The theme might also serve as a funny reminder for some grown-ups that it is possible to care more. ;-)

What item would you choose for trash representation? I could create just another theme to have a greater variety of "bad things"(TM). :-)

gregormi added inline comments.May 20 2019, 6:27 PM
themes/kmines_waste.info.md
8 ↗(On Diff #58264)

"Media files such as images may be licensed under the CC-BY-SA-4.0 or compatible licence." --> This license looks compatible but I am not a licensing expert :(

aacid added inline comments.May 21 2019, 8:56 PM
themes/kmines_waste.info.md
8 ↗(On Diff #58264)

Creative Commons (Attribution 3.0 Unported) is not CC-BY-SA-4.0

https://creativecommons.org/licenses/by/3.0/
https://creativecommons.org/licenses/by-sa/4.0/

on the other hand seems cc-by 3.0 is less restrictive than CC-BY-SA-4.0

😕

gregormi added inline comments.Sep 8 2019, 9:48 AM
themes/kmines_waste.info.md
8 ↗(On Diff #58264)

I need some clarification here:

the above icon = "Attribution 3.0 Unported (CC BY 3.0)"

KDE requirements = "CC-BY-SA-4.0 or compatible"

The license of the icon is less restrictive than the KDE requirements. Which means, we are allowed to add the icon, aren't we?

gregormi retitled this revision from Add new "Waste" theme to Add a "Cigarette Waste" theme.Sep 8 2019, 9:49 AM
aacid added a subscriber: jriddell.Sep 9 2019, 3:04 PM
aacid added inline comments.
themes/kmines_waste.info.md
8 ↗(On Diff #58264)

@jriddell you seem to be the last person that can be probably counted as "maintainer" of the Licensing policy. Could you weight in here?

aacid added inline comments.Sep 9 2019, 4:23 PM
themes/kmines_waste.info.md
8 ↗(On Diff #58264)

I asked @jriddell on real life and he seems to agree that cc/by/3.0 is also good if we accept cc/by-sa/4.0

So i guess all that is left is agreeing if this is a theme we want or not.

Anyone disagrees with having it?

jtamate added a subscriber: jtamate.Sep 9 2019, 5:40 PM

I'm not totally sure this theme is legal in Spain:
https://www.boe.es/buscar/act.php?id=BOE-A-2005-21261

Article 9. Limitations on advertising, promotion and sponsorship of tobacco products
...

  1. It is prohibited in all media, including information society services, the broadcast of programs or images in which presenters, collaborators or guests:

a) Appear smoking.
b) Mention or show, directly or indirectly, trademarks, trade names, logos or other signs identifying or associated with tobacco products.

Hi @jtamate, thanks for raising this legal concern. I only can read the English translation you provided. It seems only images and videos of _people_ using or promoting tobacco products are disallowed.

Apart from the fact that regarding this theme, no people are involved, I hope it is clear that it rather discourages the use of tobacco products. The goal of the game when using this theme is to avoid all of the cigarette fields. Already one wrong field makes you instantly lose the game (like in the real world). ;-)

Otherwise, I am not sure how Spanish health organizations can conduct educational campaigns.

Sorry, bad Copy/Paste. In the same article:

  1. Sponsorship of tobacco products, as well as all forms of advertising and promotion of such products in all media and media, including vending machines and information society services, is prohibited, with the following exceptions:

a) Publications intended exclusively for professionals involved in the tobacco trade.
b) Presentations of tobacco products to professionals in the sector ...

I do not know if this can be considered promotion of such products.

Otherwise, I am not sure how Spanish health organizations can conduct educational campaigns.

They have reserved their right to do so in Article

Article 11. Actions and programmes.

The competent public administrations shall promote directly and in collaboration with scientific societies, social agents and non-governmental organisations, actions and programmes of health education, health information and smoking prevention.

Perhaps this theme can fit in article 11.

In any case, I'm not a lawyer, so I'll stop commenting on this.

gregormi updated this revision to Diff 83310.Jun 23 2020, 7:22 PM

Rework theme to fix licensing issues

gregormi retitled this revision from Add a "Cigarette Waste" theme to Add "Cig Waste No. 2" theme.Jun 23 2020, 7:26 PM
gregormi edited the summary of this revision. (Show Details)
gregormi edited the test plan for this revision. (Show Details)
gregormi marked 4 inline comments as done.Jun 23 2020, 7:34 PM

@aacid: I just saw that you confirmed that CC BY 3.0 would also have been fine. Anyway, now it is CC BY-SA 4.0. :-)
Can we land this now? I see no further comments.

aacid accepted this revision.Jun 24 2020, 8:16 AM

Ok, i guess you can commit it.

Any special reason it's called "No. 2"? Is there a No 1 somewhere?

This revision is now accepted and ready to land.Jun 24 2020, 8:16 AM
gregormi added a comment.EditedJun 24 2020, 8:35 PM

Ok, i guess you can commit it.

Any special reason it's called "No. 2"? Is there a No 1 somewhere?

Yes :) - No. 1 is a slightly modified version of my original proposal, which I uploaded here: https://www.pling.com/p/1397003/. Actually, I would like it to appear in the KDE Store (https://store.kde.org/) but it does not show up (yet?).

aacid added a comment.Jun 24 2020, 8:40 PM

Any special reason it's called "No. 2"? Is there a No 1 somewhere?

Yes :) - No. 1 is a slightly modified version of my original proposal, which I uploaded here: https://www.pling.com/p/1397003/.

Ah i see :)

Hmm, arc land says...

FETCH  Fetching origin/master...
fatal: unable to update url base from redirection:
  asked for: https://git@invent.kde.org/kmines/info/refs?service=git-upload-pack
   redirect: https://invent.kde.org/users/sign_in
Usage Exception: Fetch failed! Fix the error and run "arc land" again.

What can I do now? Except a new merge request on https://invent.kde.org/games/kmines?

aacid added a comment.Jun 24 2020, 9:07 PM

Hmm, arc land says...

FETCH  Fetching origin/master...
fatal: unable to update url base from redirection:
  asked for: https://git@invent.kde.org/kmines/info/refs?service=git-upload-pack
   redirect: https://invent.kde.org/users/sign_in
Usage Exception: Fetch failed! Fix the error and run "arc land" again.

What can I do now? Except a new merge request on https://invent.kde.org/games/kmines?

Yeah you can't arc land anymore since there's no phabricator to help you.

Either do a MR on invent.k.o or just push the code direcly to the git repo

Hmm, arc land says...

FETCH  Fetching origin/master...
fatal: unable to update url base from redirection:
  asked for: https://git@invent.kde.org/kmines/info/refs?service=git-upload-pack
   redirect: https://invent.kde.org/users/sign_in
Usage Exception: Fetch failed! Fix the error and run "arc land" again.

What can I do now? Except a new merge request on https://invent.kde.org/games/kmines?

Yeah you can't arc land anymore since there's no phabricator to help you.

Not completely correct, you can still land with phabricator/arc. This here fails because possibly the repo url was wrong, at least the error looks like one I got when I had some incorrect url.

But if you have setup your local config to point to a full push url on invent.kde.org, arc land works for me. If the .arcconfig file was already removed, passing "--conduit=https://phabricator.kde.org" to arc makes up for that.

So: no need to move patches over to invent.kde.org just to land them, reviews can be finished here.