Move data files over to the corresponding git repos
Closed, ResolvedPublic

Description

They are not related to .pot files so the only thing we do with them now is host them in svn and inject them to the tarballs on release, they are not at all "scripty" related, so there's nothing to be won from having them in the l10n repo

Need to talk to devels of those repos to make sure they're ok with it since it'll increase the size a bit

Need to talk with sysadmin to figure out if maybe be want to go the LFS way?

Things we have that need moving

  • kdeedu-data (blocked)
  • ktuberling (blocked)
  • klettres
  • khangman
  • autocorrect
  • step
  • kajongg
  • kturtle
  • kstars
  • lokalize
aacid created this task.Sep 13 2020, 10:21 PM
  • autocorrect: we need to find (separate issue) where those files should live (probably the last leftover from the kdelibs split)
  • step files are probably not needed anymore, as the object info messages are now handled through po files (see step_objinfo_files.pot)
aacid updated the task description. (Show Details)Sep 19 2020, 10:37 PM

You're right about the step files, just removed them

kdeedu-data ktuberling khangman are blocked by sr magicly shared cmake file cmake_modules/srDataMacros.cmake

Any idea how to proceed with it?

aacid updated the task description. (Show Details)Sep 19 2020, 10:56 PM

I think we should remember to report all the authors in the commit messages when importing the content.

While extracting the commits and importing them with a full history would be the cleanest solution, maybe we can just list some details about the original svn commits ("imported from svn revision r... first added in r...") and list all the authors with lines like
Co-Authored-By: name <email>

Also, if there is just one author, maybe we could just commit the change using the proper authorship information.

I guess we need to continue with this. I was told LFS works on our repositories, so at least we could resume this when there are no other blockers.

ltoscano updated the task description. (Show Details)Feb 7 2021, 10:50 AM
ltoscano added a subscriber: ilic.EditedFeb 7 2021, 3:29 PM

kdeedu-data ktuberling khangman are blocked by sr magicly shared cmake file cmake_modules/srDataMacros.cmake

Any idea how to proceed with it?

@ilic do you think we can find a way to untangle the dependency?

aacid added a comment.Feb 7 2021, 5:44 PM

The only way i can think of is, make it more generic, make it not use perl and move it to ecm

But it's quite a lot of work :/

ilic added a comment.Feb 7 2021, 7:08 PM

The original solution with srDataMacros was appropriate for the time of single language packs, but in this case (where various maintainers would have to deal with it directly, even if in ecm) I think it would cause too much confusion.

I propose that I locally statically resolve the data files for different sr@* variants, commit them (to both trunk and stable?), and then conversion can go on as usual.

aacid added a comment.Feb 7 2021, 9:35 PM

That's also an option, simply remove the need for it 👍

ilic added a comment.Feb 10 2021, 11:00 PM

Done! (trunk r1592930, branch r1592931)

aacid updated the task description. (Show Details)May 22 2022, 10:39 PM

I've removed the kturtle data, it was all for a very old version of kturtle, the new version of kturtle doesn't support those data files

autocorrect is a PAIN because it's used by both pimcommon and calligra, so were do we put it? Currently we're not putting it anywhere so it's not being even used ^_^

aacid updated the task description. (Show Details)Jun 13 2022, 11:19 PM
aacid updated the task description. (Show Details)Oct 10 2022, 8:46 PM
aacid updated the task description. (Show Details)
aacid updated the task description. (Show Details)Oct 10 2022, 9:14 PM
aacid updated the task description. (Show Details)Oct 10 2022, 9:39 PM
aacid updated the task description. (Show Details)Oct 10 2022, 9:59 PM
huftis added a subscriber: huftis.Oct 11 2022, 7:49 PM

@aacid, I see that khangman is marked as ‘done’, but I can’t find the .kvtml files (e.g., for language ‘nn’) in the khangman Git repository. Only the .txt file containing the list of extra characters in the alphabet has been added. Are the .kvtml files stored somewhere else?

khangman did not have any kvtml file

https://websvn.kde.org/trunk/l10n-kf5/nn/data/khangman/khangman/?pathrev=1605218

You probably mean the kvtml files of kdeedu-data

https://websvn.kde.org/trunk/l10n-kf5/nn/data/kdeedu-data/kdeedu-data/?pathrev=1605218

Those have been moved to kdeedu-data

https://invent.kde.org/education/kdeedu-data/-/tree/master/data/kvtml
aacid updated the task description. (Show Details)Oct 17 2022, 5:17 PM

autocorrect moved to calligra were at least it's being used https://invent.kde.org/office/calligra/commit/c6c6c899a3b640555df551d96d0668bb16ae0042

the pimcommon code is broken, will send emails about it

aacid updated the task description. (Show Details)Oct 18 2022, 10:24 PM
aacid closed this task as Resolved.
aacid claimed this task.