stikonas (Andrius Štikonas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 29 2015, 12:19 PM (212 w, 4 d)
Availability
Available

Recent Activity

Yesterday

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Mon, Jun 24, 8:01 PM · KDE Partition Manager

Sat, Jun 22

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Sat, Jun 22, 9:47 AM · KDE Partition Manager

Sat, Jun 15

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

I think QSignalSpy is in QtTest, not QtWidgets.

Sat, Jun 15, 7:25 PM · KDE Partition Manager

Sun, Jun 9

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

So far rest seems alright.

Sun, Jun 9, 10:08 PM · KDE Partition Manager
stikonas accepted D21696: Create a timer to wait for system to free resources.
Sun, Jun 9, 5:07 PM
stikonas requested changes to D21696: Create a timer to wait for system to free resources.

Can you also mention motivation in commit message

Sun, Jun 9, 4:45 PM

Sat, Jun 8

stikonas committed R883:1543702: Updated Lithuanian translation..
Updated Lithuanian translation.
Sat, Jun 8, 10:12 PM
stikonas accepted D21653: Add Minix Filesystem.
Sat, Jun 8, 6:29 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.

Once issues mentioned above are fixed.

Sat, Jun 8, 6:19 PM · KDE Partition Manager
stikonas accepted D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 6:15 PM · KDE Partition Manager
stikonas requested changes to D21653: Add Minix Filesystem.
Sat, Jun 8, 5:59 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 5:53 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 5:45 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 5:25 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 4:46 PM · KDE Partition Manager
stikonas accepted D21616: Quit application if bus is not connected, interface not registered.
Sat, Jun 8, 10:07 AM · KDE Partition Manager
stikonas added a comment to D21616: Quit application if bus is not connected, interface not registered.

Oh, I see. Sorry for missing that out. Then I guess commit it to master.

Sat, Jun 8, 10:07 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 8:54 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Sat, Jun 8, 8:53 AM · KDE Partition Manager
stikonas requested changes to D21616: Quit application if bus is not connected, interface not registered.

If you want this commit, you can just merge master branch into your branch.

Sat, Jun 8, 8:50 AM · KDE Partition Manager

Fri, Jun 7

stikonas accepted D21652: Add support for Minix(Mini Unix) Filesystem.
Fri, Jun 7, 6:45 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.
Fri, Jun 7, 6:42 PM · KDE Partition Manager
stikonas committed R16:ba48851d34bd: Merge branch '4.0' (authored by stikonas).
Merge branch '4.0'
Fri, Jun 7, 6:14 PM
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.

Looks good, just keep space consistent where I mentioned. Then you can push this to master branch.

Fri, Jun 7, 6:04 PM · KDE Partition Manager
stikonas added a comment to D21617: Handle action authorization inside helper.

I think startHelper() is much better.

Fri, Jun 7, 2:25 PM · KDE Partition Manager

Thu, Jun 6

stikonas added inline comments to D21564: [WIP]: Implement Authentication Agent/Listener.
Thu, Jun 6, 9:01 PM · KDE Partition Manager
stikonas added inline comments to D21564: [WIP]: Implement Authentication Agent/Listener.
Thu, Jun 6, 8:57 PM · KDE Partition Manager

Wed, Jun 5

stikonas committed R16:9b45e25f8172: manually quit kauth's mainloop (authored by sitter).
manually quit kauth's mainloop
Wed, Jun 5, 5:35 PM
stikonas committed R16:6a3b1e02b6bf: smart: obtain disk size in blocks. (authored by stikonas).
smart: obtain disk size in blocks.
Wed, Jun 5, 5:34 PM

Mon, Jun 3

stikonas added inline comments to D21564: [WIP]: Implement Authentication Agent/Listener.
Mon, Jun 3, 7:37 PM · KDE Partition Manager
stikonas requested changes to D21564: [WIP]: Implement Authentication Agent/Listener.
Mon, Jun 3, 7:34 PM · KDE Partition Manager

Sun, Jun 2

stikonas committed R883:1543158: Updated Lithuanian translation..
Updated Lithuanian translation.
Sun, Jun 2, 11:43 AM

Sat, Jun 1

stikonas added a comment to D21145: Make KTorrent work with current GeoIP files.

Hmm, regarding license, I guess it will be fine. KTorrent is GPLv2 or later. So GPLv3 would work.

Sat, Jun 1, 7:44 PM
stikonas added a comment to D21145: Make KTorrent work with current GeoIP files.

Yes, it looks fine to me too. Please fix those issues that wbauer already mentioned and then you can commit (or ask somebody to commit if for you if you don't have commit access).

Sat, Jun 1, 3:37 PM

Fri, May 31

stikonas committed R954:d63229e0e764: Temporarily remove my blog until hardware failure is resolved. (authored by stikonas).
Temporarily remove my blog until hardware failure is resolved.
Fri, May 31, 8:23 AM

Thu, May 30

stikonas accepted D21504: Notify user when they enter non whitelisted command.
Thu, May 30, 5:55 PM · KDE Partition Manager
stikonas accepted D21506: Do not move further if system bus is not connected.
Thu, May 30, 5:55 PM
stikonas requested changes to D21504: Notify user when they enter non whitelisted command.
Thu, May 30, 5:32 PM · KDE Partition Manager

May 25 2019

stikonas added inline comments to D21340: [RFC]Add unit test for RAID.
May 25 2019, 3:21 PM · KDE Partition Manager

May 24 2019

stikonas added a comment to D21340: [RFC]Add unit test for RAID.

There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.

May 24 2019, 5:23 PM · KDE Partition Manager

May 23 2019

stikonas requested changes to D21340: [RFC]Add unit test for RAID.
May 23 2019, 11:16 PM · KDE Partition Manager
stikonas accepted D21340: [RFC]Add unit test for RAID.
May 23 2019, 11:16 PM · KDE Partition Manager

May 21 2019

stikonas added a comment to D21311: Add support for smartmontools 7.0 user_capacity json output.

Maybe push to 4.0 branch?

May 21 2019, 8:15 PM
stikonas accepted D21311: Add support for smartmontools 7.0 user_capacity json output.
May 21 2019, 8:14 PM

May 19 2019

stikonas accepted D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.
May 19 2019, 5:22 PM · KDE Partition Manager

May 18 2019

stikonas committed R16:6f8e6403f880: Remove trailing whitespace. (authored by stikonas).
Remove trailing whitespace.
May 18 2019, 7:35 PM
stikonas accepted D21272: Remove superflous variables.
May 18 2019, 1:20 PM · KDE Partition Manager

May 17 2019

stikonas added a comment to D21261: Prevent resizing read-only mounted file systems.

Also in general, I think we should create a bool variable where we store data, so that we only run this

May 17 2019, 7:37 PM · KDE Partition Manager
stikonas requested changes to D21261: Prevent resizing read-only mounted file systems.
May 17 2019, 7:31 PM · KDE Partition Manager
stikonas added a comment to D21244: Make it a pointer since memory is allocated on heap.

Well, in principle both mean exactly the same thing, so I don't have strong opinion on this. I probably use them interchangeably anyway. Well, it's auto, so we don't care what type it is... So based on that I would say no need to make a commit. Other parts of KDE codebase also don't have unified style here. Just checked kwin, it has both auto and auto *

May 17 2019, 5:52 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

May 17 2019, 5:14 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

May 17 2019, 5:08 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )

May 17 2019, 5:06 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

oh ok, that's fine then.

May 17 2019, 5:06 PM · KDE Partition Manager
stikonas accepted D21251: Remove redundant include.
May 17 2019, 5:04 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

May 17 2019, 5:04 PM · KDE Partition Manager
stikonas requested changes to D21258: Move slot under Q_SLOTS.
May 17 2019, 4:55 PM · KDE Partition Manager
stikonas added a comment to D21258: Move slot under Q_SLOTS.

We also don't need this. Q_SLOTS are needed with old style Qt syntax where SIGNAL and SLOTS are used. With the new Qt5 connect syntax, you can just connect to any function, so no need to involve moc on this function.

May 17 2019, 4:55 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

The other include (#include "externalcommandhelper.h") I think can still go away but please test that it builds in a clean build dir.

May 17 2019, 4:53 PM · KDE Partition Manager
stikonas requested changes to D21251: Remove redundant include.

It is needed by std::unique_ptr and std::unordered_set. We shouldn't rely on header being pulled in by some other header.

May 17 2019, 4:45 PM · KDE Partition Manager

May 16 2019

stikonas accepted D21241: Simplify test conditions.
May 16 2019, 7:23 PM · KDE Partition Manager

May 12 2019

stikonas added a comment to D21162: Don't hardcode dbus policy install dir.

Maybe push to 4.0 branch?

May 12 2019, 5:59 PM
stikonas accepted D21162: Don't hardcode dbus policy install dir.
May 12 2019, 5:56 PM

May 11 2019

stikonas committed R472:b8e50493a93e: Add DHT bootstrapping from well-known nodes (authored by maxxim).
Add DHT bootstrapping from well-known nodes
May 11 2019, 4:24 PM
stikonas closed D20696: Add DHT bootstrapping from well-known nodes.
May 11 2019, 4:24 PM

May 10 2019

stikonas committed R16:4b6a26f0f800: Fix setting partition path when restoring partitions. (authored by stikonas).
Fix setting partition path when restoring partitions.
May 10 2019, 2:07 AM

May 2 2019

stikonas committed R17:7297efe2da7e: Sort dependencies in CMakeLists alphabetically. (authored by stikonas).
Sort dependencies in CMakeLists alphabetically.
May 2 2019, 9:44 PM

May 1 2019

stikonas committed R954:b1eb3be65911: Add stikonas blog. (authored by stikonas).
Add stikonas blog.
May 1 2019, 8:04 PM
stikonas committed R16:e1c2ed7567b0: Update copyright year in about dialog. (authored by stikonas).
Update copyright year in about dialog.
May 1 2019, 1:02 AM
stikonas committed R17:a5652e604eed: Update copyright year in about dialog. (authored by stikonas).
Update copyright year in about dialog.
May 1 2019, 12:22 AM

Apr 30 2019

stikonas committed R883:1540865: Updated Lithuanian translation..
Updated Lithuanian translation.
Apr 30 2019, 11:42 PM
stikonas added a comment to D20917: Add DesktopEntry to notifyrc.

Ship it

Apr 30 2019, 11:18 AM

Apr 27 2019

stikonas committed R883:1540676: Fix an error found by check-kde-tp..
Fix an error found by check-kde-tp.
Apr 27 2019, 11:06 AM

Apr 23 2019

stikonas committed R433:58e8a4fce62d: Port qSort. (authored by stikonas).
Port qSort.
Apr 23 2019, 10:26 PM
stikonas committed R883:1540444: Add new po files for Lithuanian language..
Add new po files for Lithuanian language.
Apr 23 2019, 10:07 PM
stikonas committed R433:04a5de01f566: Port away from KLocale::global()->languageCodeToName(). (authored by stikonas).
Port away from KLocale::global()->languageCodeToName().
Apr 23 2019, 10:04 PM

Apr 22 2019

stikonas committed R433:e2a891ea849f: Move country code generatiion into CountryModel::setupModelData. (authored by stikonas).
Move country code generatiion into CountryModel::setupModelData.
Apr 22 2019, 8:39 AM
stikonas committed R433:e845b93e9c71: Use locale aware sorting for countries and languages. (authored by stikonas).
Use locale aware sorting for countries and languages.
Apr 22 2019, 7:30 AM
stikonas committed R433:b387d3df5fa9: Fix missing include. (authored by stikonas).
Fix missing include.
Apr 22 2019, 7:09 AM

Apr 21 2019

stikonas committed R433:b48d9807bd73: Port KLocale::global()->allCountriesList() to QLocale. (authored by stikonas).
Port KLocale::global()->allCountriesList() to QLocale.
Apr 21 2019, 10:15 PM
stikonas added a comment to D20696: Add DHT bootstrapping from well-known nodes.

If I commit this myself, I need your mail address for git commit --author. Is it the same as in reviewboard (I can't see the one from Phabricator)?

Apr 21 2019, 11:07 AM
stikonas added a comment to D13849: WIP: Add fractional scaling to wayland scaling GUI.

It runtime requires Qt 5.12 for xdg-output which the shell needs for fullscreen, which means we can merge for Plasma 5.16

Apr 21 2019, 8:51 AM · Plasma

Apr 20 2019

stikonas accepted D20696: Add DHT bootstrapping from well-known nodes.
Apr 20 2019, 12:26 PM

Apr 19 2019

stikonas committed R433:501fa0e4aec1: Reduce dependency on KDELibs4Support. (authored by stikonas).
Reduce dependency on KDELibs4Support.
Apr 19 2019, 8:58 PM

Apr 17 2019

stikonas committed R17:8476f707ab54: Bump version to 4.0 in preparation for future release. (authored by stikonas).
Bump version to 4.0 in preparation for future release.
Apr 17 2019, 10:19 AM
stikonas committed R16:fa5937071b27: Bump version to 4.0 in preparation for future release. (authored by stikonas).
Bump version to 4.0 in preparation for future release.
Apr 17 2019, 9:32 AM

Apr 13 2019

stikonas accepted D20487: Add DesktopEntry to notifyrc.

Looks fine.

Apr 13 2019, 9:01 AM

Apr 11 2019

stikonas committed R16:6d272234bbaa: Raise util-linux dependency to 2.33.2. (authored by stikonas).
Raise util-linux dependency to 2.33.2.
Apr 11 2019, 7:27 PM

Apr 6 2019

stikonas committed R16:dd0adbec4258: Remove unused include. (authored by stikonas).
Remove unused include.
Apr 6 2019, 4:37 PM

Apr 5 2019

stikonas added a comment to D20269: Fix typo and constantify arguments.

Looks alright, although I wouldn't call that thing a typo. Variable names in C++ doesn't have to match in function header and implementation, although, it's probably less confusing if they match. But sometimes one can simply omit names in header and just have types.

Apr 5 2019, 11:47 PM · KDE Partition Manager

Mar 29 2019

stikonas added a comment to D20109: Be consistent with rest of coding style.

We also need to adapt this connect KJob to the Qt5 signals and slots syntax.

Mar 29 2019, 6:06 PM · KDE Partition Manager
stikonas requested changes to D20109: Be consistent with rest of coding style.

I don't think we should change other lines too here. We pass that percent to KJob, so keep the type the same as KJob expects.

Mar 29 2019, 6:00 PM · KDE Partition Manager
stikonas accepted D20108: Constantify nonce and some cleanup.
Mar 29 2019, 5:56 PM · KDE Partition Manager
stikonas updated subscribers of D20108: Constantify nonce and some cleanup.

I don't think moving QtCrypto is right. It's not a Qt header, it belongs to QCA.

Mar 29 2019, 10:20 AM · KDE Partition Manager

Mar 27 2019

stikonas added a comment to D20076: Do not use C data type.

Hmm, do we really need this? quint64 is unsigned long long. It's just a typedef, so both can be used interchangeably. And unsigned long long is also C++ data type, not just C... Altgough, obviously this change wouldn't break anything. I guess it's just a question of code style but I didn't find any KDE recommendations. Any other opinions from other reviewers?

Mar 27 2019, 1:22 PM · KDE Partition Manager

Mar 17 2019

stikonas accepted D19772: Follow KDE HIG by using ellipis.
Mar 17 2019, 10:44 PM

Mar 10 2019

stikonas committed R17:f6e22288b9cd: Require Frameworks 5.56 as this is what KPMcore needs anyway. (authored by stikonas).
Require Frameworks 5.56 as this is what KPMcore needs anyway.
Mar 10 2019, 10:32 PM

Feb 28 2019

stikonas committed R16:92065f7a23cf: Add a function to convert QStringList of flag names to flags. (authored by stikonas).
Add a function to convert QStringList of flag names to flags.
Feb 28 2019, 12:22 AM
stikonas committed R17:a6861bf202a6: When importing partition table, pass the flags to Partition class. (authored by stikonas).
When importing partition table, pass the flags to Partition class.
Feb 28 2019, 12:18 AM
stikonas committed R17:cf513b98732b: Use explicit class method overrides. (authored by stikonas).
Use explicit class method overrides.
Feb 28 2019, 12:18 AM