stikonas (Andrius Štikonas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 29 2015, 12:19 PM (235 w, 6 d)
Availability
Available

Recent Activity

Today

stikonas committed R473:51fee6c7b1e9: Merge branch '5.1' (authored by stikonas).
Merge branch '5.1'
Thu, Dec 5, 12:08 AM
stikonas committed R473:509adecc1158: Fix a typo in a comment. (authored by stikonas).
Fix a typo in a comment.
Thu, Dec 5, 12:06 AM
stikonas accepted D25718: Don't display standard groups in Open torrent dialog .

By the way, can you upload patches for review with more context next time. E.g. something like git show -U999

Thu, Dec 5, 12:05 AM

Mon, Dec 2

stikonas committed R16:dfce03942118: Only trigger udev events for block device subsystem. (authored by stikonas).
Only trigger udev events for block device subsystem.
Mon, Dec 2, 11:04 PM
stikonas added inline comments to D25680: Fixes crash, when removing last torrent.BUG: 388803.
Mon, Dec 2, 7:37 PM
stikonas accepted D25674: Port away from KIconLoader's SmallIcon.
Mon, Dec 2, 12:43 AM

Mon, Nov 25

stikonas accepted D25314: Port KTorrent to QWebEngine.
Mon, Nov 25, 12:05 AM

Thu, Nov 21

stikonas added a reviewer for D25314: Port KTorrent to QWebEngine: trufanov.

I'll take a better look later.

Thu, Nov 21, 11:11 PM
stikonas accepted D25453: Context menu for trackers list.
Thu, Nov 21, 11:07 PM

Mon, Nov 18

stikonas committed R16:bb7bf3ca03ed: Make FileSystemFactory::init reentrant. (authored by stikonas).
Make FileSystemFactory::init reentrant.
Mon, Nov 18, 8:47 PM
stikonas committed R16:13beb9931951: Use partx instead of blockdev to update partition table in the kernel. (authored by stikonas).
Use partx instead of blockdev to update partition table in the kernel.
Mon, Nov 18, 7:16 PM
stikonas committed R16:2c7b3f2bfa94: Fix resizing of encrypted partitions. (authored by stikonas).
Fix resizing of encrypted partitions.
Mon, Nov 18, 7:16 PM

Fri, Nov 15

stikonas accepted D25329: Fix KIO errors text formatting.

Looks good

Fri, Nov 15, 3:18 PM

Tue, Nov 12

stikonas accepted D25137: Highlight seeding torrents in case of any problems with trackers.
Tue, Nov 12, 12:46 AM
stikonas accepted D25136: Report TrackersList statuses statistics for torrent highlighting.
Tue, Nov 12, 12:45 AM

Sun, Nov 10

stikonas accepted D25235: Display HTTP error codes instead of "Invalid data from tracker" in tracker status.

Yes, I agree, the new error is better.

Sun, Nov 10, 3:48 PM

Thu, Nov 7

stikonas committed R16:660aa6a55eff: Fix a failing test. (authored by stikonas).
Fix a failing test.
Thu, Nov 7, 10:28 PM
stikonas committed R16:1c771436d45d: Merge branch '4.0' (authored by stikonas).
Merge branch '4.0'
Thu, Nov 7, 10:17 PM
stikonas committed R16:c02d59aa6d31: Stop helper only if formerly started. (authored by hgoebel).
Stop helper only if formerly started.
Thu, Nov 7, 10:17 PM
stikonas closed D25161: Stop helper only if formerly started..
Thu, Nov 7, 10:17 PM · KDE Partition Manager
stikonas committed R16:c9a08a593bac: Remove broken smart unit test. (authored by stikonas).
Remove broken smart unit test.
Thu, Nov 7, 10:12 PM

Tue, Nov 5

stikonas accepted D25161: Stop helper only if formerly started..

Do you have commit rights or do I need to push it for you?

Tue, Nov 5, 8:09 PM · KDE Partition Manager

Nov 3 2019

stikonas committed R883:1555144: Updated Lithuanian translation..
Updated Lithuanian translation.
Nov 3 2019, 11:05 AM

Nov 2 2019

stikonas accepted D13045: Bugfix crash on port change.
I've just tried this with version 5.1.2. The app has crashed. So problem is still exists. Perhaps would be better to apply this patch?
Nov 2 2019, 11:36 PM

Oct 15 2019

stikonas committed R16:59c9ba2f8d64: Set MBR partition type of FAT32 partitions to 0x0c. (authored by stikonas).
Set MBR partition type of FAT32 partitions to 0x0c.
Oct 15 2019, 8:38 PM

Oct 6 2019

stikonas committed R16:d5a9c0ce5f2d: Merge branch 'master' into auth-polkit-backend (authored by stikonas).
Merge branch 'master' into auth-polkit-backend
Oct 6 2019, 7:15 PM
stikonas committed R16:0fafc228ed01: Merge branch 'master' into raid-support (authored by stikonas).
Merge branch 'master' into raid-support
Oct 6 2019, 7:13 PM
stikonas committed R16:ea5962ca7d3f: Merge branch '4.0' (authored by stikonas).
Merge branch '4.0'
Oct 6 2019, 7:13 PM
stikonas committed R473:052d7123c9f4: Merge branch '5.1' (authored by stikonas).
Merge branch '5.1'
Oct 6 2019, 6:16 PM

Oct 5 2019

stikonas committed R499:4095548c04b8: Stable branch for kpmcore is 4.0. (authored by stikonas).
Stable branch for kpmcore is 4.0.
Oct 5 2019, 12:00 PM
stikonas committed R16:8692697cd4e4: Bump kpmcore version to 4.0.1 (authored by stikonas).
Bump kpmcore version to 4.0.1
Oct 5 2019, 11:19 AM
stikonas committed R16:40b65438f060: Do not align partitions if they are mounted. (authored by stikonas).
Do not align partitions if they are mounted.
Oct 5 2019, 11:19 AM
stikonas committed R16:d062cf50fb6b: Including Caio's middle name in aboutData (authored by cjlcarvalho).
Including Caio's middle name in aboutData
Oct 5 2019, 11:19 AM
stikonas committed R16:df235a775177: Make S.M.A.R.T. disk temperature label show only integers. (authored by stikonas).
Make S.M.A.R.T. disk temperature label show only integers.
Oct 5 2019, 11:19 AM
stikonas committed R16:a264a282372b: Reduce temperature's precision from six decimal places to two (authored by shubham).
Reduce temperature's precision from six decimal places to two
Oct 5 2019, 11:19 AM
stikonas committed R16:6f17476b7518: Run udevadm settle once more after udevadm trigger. (authored by stikonas).
Run udevadm settle once more after udevadm trigger.
Oct 5 2019, 11:19 AM
stikonas committed R16:0b5e5040ebb3: Do not align partitions if they are mounted. (authored by stikonas).
Do not align partitions if they are mounted.
Oct 5 2019, 11:19 AM
stikonas committed R17:910de2a772a3: Merge partition manager toolbars into one. (authored by stikonas).
Merge partition manager toolbars into one.
Oct 5 2019, 11:07 AM

Sep 27 2019

stikonas committed R17:dd0df390dad3: Port away from deprecated QTreeWidget::setFirstItemColumnSpanned. (authored by stikonas).
Port away from deprecated QTreeWidget::setFirstItemColumnSpanned.
Sep 27 2019, 10:09 PM
stikonas accepted D24272: Use non-pixmap colorful icons from the icon theme in settings window's sidebar.
Sep 27 2019, 8:37 PM

Sep 26 2019

stikonas committed R472:ae2d878aaa96: Merge branch '2.1' (authored by stikonas).
Merge branch '2.1'
Sep 26 2019, 11:27 PM
stikonas committed R16:fa7d5a200fcf: Merge branch 'master' into raid-support (authored by stikonas).
Merge branch 'master' into raid-support
Sep 26 2019, 10:57 PM
stikonas added a reverting change for R16:2627d476f4a7: Create a timer to wait for system to free resources: R16:76ca72eccd79: Revert "Create a timer to wait for system to free resources".
Sep 26 2019, 10:51 PM
stikonas committed R16:76ca72eccd79: Revert "Create a timer to wait for system to free resources" (authored by stikonas).
Revert "Create a timer to wait for system to free resources"
Sep 26 2019, 10:51 PM

Sep 25 2019

stikonas committed R16:467ea50aeb73: Run udevadm settle once more after udevadm trigger. (authored by stikonas).
Run udevadm settle once more after udevadm trigger.
Sep 25 2019, 10:21 PM

Sep 24 2019

stikonas added a comment to D24149: Cleanup ViewModel a bit and try to fix crash on exit.

Should I land it on master or it seems good enough for the stable branch?

Sep 24 2019, 8:38 PM

Sep 23 2019

stikonas accepted D23628: Replace and remove deprecated methods.
Sep 23 2019, 9:15 PM

Sep 22 2019

stikonas added a comment to D21145: Make KTorrent work with current GeoIP files.

Ping? Any chance to get updated patch with addressed review comments?

Sep 22 2019, 11:57 PM
stikonas accepted D24149: Cleanup ViewModel a bit and try to fix crash on exit.
Sep 22 2019, 9:30 PM

Sep 8 2019

stikonas committed R358:fbca756d107d: Fix compilation with Qt 5.14, QLatin1Literal seems gone (authored by stikonas).
Fix compilation with Qt 5.14, QLatin1Literal seems gone
Sep 8 2019, 3:01 PM

Sep 7 2019

stikonas committed R16:4b0261230de9: Make S.M.A.R.T. disk temperature label show only integers. (authored by stikonas).
Make S.M.A.R.T. disk temperature label show only integers.
Sep 7 2019, 12:15 PM

Sep 1 2019

stikonas committed R473:e5b9fa8afded: Merge branch '5.1' (authored by stikonas).
Merge branch '5.1'
Sep 1 2019, 9:25 PM
stikonas committed R472:a52f20c71a17: Bump version to 2.1.1. (authored by stikonas).
Bump version to 2.1.1.
Sep 1 2019, 7:04 PM
stikonas committed R473:bb3c4d652854: Bump version to 5.1.2. (authored by stikonas).
Bump version to 5.1.2.
Sep 1 2019, 6:37 PM

Aug 29 2019

stikonas accepted D23572: Reduce temperature's precision from six decimal places to two.
Aug 29 2019, 7:53 PM · KDE Partition Manager

Aug 22 2019

stikonas requested changes to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 22 2019, 6:47 PM · KDE Partition Manager

Aug 21 2019

stikonas accepted D23329: Fix crash when doing open recent.
Aug 21 2019, 7:41 PM

Aug 13 2019

stikonas added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 13 2019, 11:15 PM · KDE Partition Manager
stikonas requested changes to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 13 2019, 11:13 PM · KDE Partition Manager
stikonas committed R473:65adeafdae21: Merge branch '5.1' (authored by stikonas).
Merge branch '5.1'
Aug 13 2019, 10:48 PM
stikonas committed R473:54acaff0d9c3: Fix linking to KF5::Crash. (authored by stikonas).
Fix linking to KF5::Crash.
Aug 13 2019, 10:46 PM

Aug 12 2019

stikonas accepted D23110: unbreak http request.
Aug 12 2019, 7:01 PM
stikonas accepted D23111: fix streamsocket write-length calculation.
Aug 12 2019, 7:01 PM

Aug 8 2019

stikonas accepted D21903: RFC: Add support for filesystem-specific features.

Finally, this patchset has been thoroughly tested for ext4 and btrfs filesystems.
If everything is OK, I can add support for fat32 blocksize before merging.

Aug 8 2019, 8:27 PM

Aug 4 2019

stikonas added inline comments to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.
Aug 4 2019, 10:14 AM · KDE Partition Manager

Aug 2 2019

stikonas updated subscribers of D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Yes, and you need to add it to cmake. That part of code is autogenerated.

Aug 2 2019, 4:35 PM · KDE Partition Manager
stikonas added a comment to D22889: Authorize using Polkit backend, compile Helper as standalone application and send progress via QDBus from helper towards application.

Before it's pushed (once it compiles) also refactor code a bit so that
there isn't that much code duplication.

Aug 2 2019, 9:17 AM · KDE Partition Manager

Jul 22 2019

stikonas accepted D22629: Add unit test for Device.

I guesss it's alright to go in for now.

Jul 22 2019, 8:45 PM
stikonas added inline comments to D21903: RFC: Add support for filesystem-specific features.
Jul 22 2019, 7:42 PM

Jul 21 2019

stikonas requested changes to D22629: Add unit test for Device.
Jul 21 2019, 8:12 PM
stikonas added inline comments to D22629: Add unit test for Device.
Jul 21 2019, 8:03 PM
stikonas accepted D22593: Compile helper into standalone application.
Jul 21 2019, 9:45 AM · KDE Partition Manager

Jul 13 2019

stikonas added a comment to D22321: Add unit test for Polkit backend.

Looks alright. I'll try to compile myself and see what are those linking errors when you have those two lines uncommented...

Jul 13 2019, 4:15 PM · KDE Partition Manager

Jul 11 2019

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jul 11 2019, 8:19 PM · KDE Partition Manager

Jul 8 2019

stikonas added a comment to D21903: RFC: Add support for filesystem-specific features.

-i bytes-per-inodeI am a bit worried that this API would be hard to use from GUI clients. Although in general, I think direction is good.

Jul 8 2019, 8:15 PM

Jun 24 2019

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 24 2019, 8:01 PM · KDE Partition Manager

Jun 22 2019

stikonas added inline comments to D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 22 2019, 9:47 AM · KDE Partition Manager

Jun 15 2019

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

I think QSignalSpy is in QtTest, not QtWidgets.

Jun 15 2019, 7:25 PM · KDE Partition Manager

Jun 9 2019

stikonas added a comment to D21564: [WIP]: Implement Authentication Agent/Listener.

So far rest seems alright.

Jun 9 2019, 10:08 PM · KDE Partition Manager
stikonas accepted D21696: Create a timer to wait for system to free resources.
Jun 9 2019, 5:07 PM
stikonas requested changes to D21696: Create a timer to wait for system to free resources.

Can you also mention motivation in commit message

Jun 9 2019, 4:45 PM

Jun 8 2019

stikonas committed R883:1543702: Updated Lithuanian translation..
Updated Lithuanian translation.
Jun 8 2019, 10:12 PM
stikonas accepted D21653: Add Minix Filesystem.
Jun 8 2019, 6:29 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.

Once issues mentioned above are fixed.

Jun 8 2019, 6:19 PM · KDE Partition Manager
stikonas accepted D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 6:15 PM · KDE Partition Manager
stikonas requested changes to D21653: Add Minix Filesystem.
Jun 8 2019, 5:59 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 5:53 PM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 5:45 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 5:25 PM · KDE Partition Manager
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 4:46 PM · KDE Partition Manager
stikonas accepted D21616: Quit application if bus is not connected, interface not registered.
Jun 8 2019, 10:07 AM · KDE Partition Manager
stikonas added a comment to D21616: Quit application if bus is not connected, interface not registered.

Oh, I see. Sorry for missing that out. Then I guess commit it to master.

Jun 8 2019, 10:07 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 8:54 AM · KDE Partition Manager
stikonas added inline comments to D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 8:53 AM · KDE Partition Manager
stikonas requested changes to D21616: Quit application if bus is not connected, interface not registered.

If you want this commit, you can just merge master branch into your branch.

Jun 8 2019, 8:50 AM · KDE Partition Manager

Jun 7 2019

stikonas accepted D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 7 2019, 6:45 PM · KDE Partition Manager
stikonas accepted D21653: Add Minix Filesystem.
Jun 7 2019, 6:42 PM · KDE Partition Manager
stikonas committed R16:ba48851d34bd: Merge branch '4.0' (authored by stikonas).
Merge branch '4.0'
Jun 7 2019, 6:14 PM
stikonas requested changes to D21652: Add support for Minix(Mini Unix) Filesystem.

Looks good, just keep space consistent where I mentioned. Then you can push this to master branch.

Jun 7 2019, 6:04 PM · KDE Partition Manager
stikonas added a comment to D21617: Handle action authorization inside helper.

I think startHelper() is much better.

Jun 7 2019, 2:25 PM · KDE Partition Manager