[weather] envcan: Fix typo in lowercase icon lookup string
ClosedPublic

Authored by Zren on Feb 19 2019, 11:43 PM.

Details

Summary

The capital S breaks the icon match.

It was broken in Plasma 5.6 => Plasma 5.7, so I guess I'll merge 5.12 => 5.14 => 5.15 => master, assuming we still need to backport to 5.14 for Debian?
https://github.com/KDE/plasma-workspace/blob/Plasma/5.12/dataengines/weather/ions/envcan/ion_envcan.cpp#L294

Do I bother putting FIXED-IN: 5.15.2 if there's no bug report?

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Zren created this revision.Feb 19 2019, 11:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 19 2019, 11:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Zren requested review of this revision.Feb 19 2019, 11:43 PM
kossebau accepted this revision.Feb 19 2019, 11:52 PM

Thanks, untested by me, but seems correct by quick read.

Yes, 5.12 => 5.14 => 5.15 => master might still make sense, given that Debian usage, how insane that even is.

This revision is now accepted and ready to land.Feb 19 2019, 11:52 PM
This revision was automatically updated to reflect the committed changes.