style elements without type="text/css" were ignored before, but now they act as
if type was set. Set id and style properly to restore the working behaviour.
BUG: 405548
rooty |
Plasma |
style elements without type="text/css" were ignored before, but now they act as
if type was set. Set id and style properly to restore the working behaviour.
BUG: 405548
Installed new files on a system with Qt 5.12.2, wiped the SVG cache
and it looks fine again.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Apparently tooltips need a fix too https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417
Another option I believe is to keep the <style> tag but add the id="current-color-scheme" type="text/css" attributes. I assume the only difference is plasma replaces the contents of the existing style tag instead of creating a new one, though I'm not sure where the code inserts it.
Yes that works for me (adding both attributes)
This was after modifying both tooltip.svgz files
I believe that src/desktoptheme/breeze/translucent/widgets/tooltip.svgz must be corrected too. It has an <style> node without a type attribute and with a wrong id value.
edit: spelling
There's a special case in ./src/desktoptheme/breeze/icons/audio.svgz and .../battery.svgz: It has color scheme definitions both in a <style id="current-color-scheme" type="text/css"> and a <style type="text/css" id="style5"> element.
It shouldn't have an impact on this bug in particular, but it does still look wrong.
Is anyone able to review this? If there's no review in 24h I'll merge it as it affects users severely and the fix is trivial.
I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework.
I agree - as this touches binary files, applying a patch wouldn't work (unless using git apply).
I just gave this diff a try again and could not find any place with broken SVG colors anymore.