Differential D15321

[Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale
ClosedPublic
Actions

Authored by Zren on Sep 6 2018, 10:46 PM.

Details

Reviewers
broulik
Commits
R242:e5949866bb8f: [Calendar] Expose firstDayOfWeek in MonthView
Summary

Users may want to start the week on a Sunday, Saturday, or Monday without changing their locale's date formatting.

CCBUG: 390330

If accepted, I'll be adding something a cleaned up version of the following patch to DigitalClock, Calendar, ... and the rest I guess.

https://github.com/Zren/plasma-applet-eventcalendar/commit/31c584900f318c8ae148ae9fbcc0ed58eccc5d9d

Test Plan

DigitalClock widget still loaded fine.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Zren created this revision.Sep 6 2018, 10:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 6 2018, 10:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
Zren requested review of this revision.Sep 6 2018, 10:46 PM
broulik accepted this revision.Sep 7 2018, 10:33 AM
broulik added a subscriber: broulik.

Note that Plasma 5.14 depends on 5.50 which is already released, so any change that requires this property can only go in once 5.14 was branched off

This revision is now accepted and ready to land.Sep 7 2018, 10:33 AM
Closed by commit R242:e5949866bb8f: [Calendar] Expose firstDayOfWeek in MonthView (authored by Zren). · Explain WhyJan 3 2019, 10:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48646

View Options

src/declarativeimports/calendar/qml/MonthView.qml

Loading...