Not sure if this has been linked yet: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/305

I have created a Merge Request on GitLab with a a couple new commits.

The plasma-framework patch is D29463

Phab only understands .diff. Phab does not recognize .patch.

There's a few extra spaces at the end of "植樹節 " and "中秋節 補假 " too.

Now you're missing holidays/plan2/holiday_tw_zh which can still be seen here: https://phabricator.kde.org/D28874?id=80260

As in clip: true?

Not sure. Backwards compatibility?

FixedSize 25pt does help, but "2 glyph emojis" will overlap each other.

I used Loader as I didn't want loading glyphs to block scrollbar responsiveness. GridView reuses delegates, but I don't think it's the MouseArea + Label constructor that's slow. I think it's the "rendering the emoji glyph" in the GUI draw that is the root cause.

I don't care if Inactive Blur is upstreamed or not as all my code is GPL. I didn't upstream it since I thought the feature was niche enough I shouldn't burden others with it's maintenance.

Fix implicitWidth error by using Layout.min/maxWidth.
Scale captionRow.spacing by dpi.
Take into account the close button is 30x30.
Use a ColumnLayout for thumbnailGridItems instead of anchoring.
Add Item container for KWin.ThumbnailItem so it's not cliping the bottom of the window thumbnail.
Remove "keybindings don't work" comment that no longer applies.
Use const for function variables.
644 (RW-R--R--) file permission.

I've tried moving the "update space info" code outside of the paint() function. I still need to make the "update space info" async, and have it update when space is freed/consumed.

We don't reuse much code besides it being an "icon button" button. We'd have to wrap most of the minimize/showdesktop code in a conditional. We'd have to disable the drag and drop activation for "present windows" mode.

This widget has 2 looks. Windows TaskView Icon or "Unity desktop pager" look.

That would look like the homerun icon, which looks like the "windows" logo.

Patch fixed the issue for me.

This commit broke the PgUp and PgDn keys for me. They select, but no longer scroll. It also stops scrolling when using the up arrow key before reaching the top.

The widget basically switches to breeze-dark by editing ~/.config/plasmarc, waits a few seconds, then switches back to breeze-alphablack.

I just realized how difficult "drawing a rectangle" outline is in C++ KWin Effects. We're required to have codepaths for OpenGL, XRender, and QPainter... uhg. No clue how to even test QPainter.

In D21312#468223, @cfeck wrote:

We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?

Use KColorScheme's NegativeText color

In D21312#467721, @ndavis wrote:

Can you use the NegativeText color from the colorscheme instead of a custom danger color?

I've personally abandoned attempts to merge KIO's Places view in Dolphin for now. Upstreaming those features to KIO is good code practice in the long term though. I've copied the existing KFilePlacesView from KIO and embeded them in this dolphin branch for easy development:

Another option I believe is to keep the <style> tag but add the id="current-color-scheme" type="text/css" attributes. I assume the only difference is plasma replaces the contents of the existing style tag instead of creating a new one, though I'm not sure where the code inserts it.

After a deeper look into this:

Was skimming the Plasma Scripting API today for something else and found where I saw the "update scripts" before:

Here's a quick and dirty proof of concept. Selecting a place works, but I still need to bind:

i18n("Use locale default") should be in the middle (currentIndex=1). 12h should be currentIndex=0, and 24h should be currentIndex=2

without needing to right-click

Shoot, I accidentally forgot the Phab Rev link in the commit message (though I remembered the bugzilla tags). I've setup a .git/hook/prepare-commit-msg -like thing for Sublime Text to prevent this happening in the future.

In D18961#410792, @kossebau wrote:

we no longer have to install the widget to .../share/plasma/plasmoids/

No experience here, but do we not still need to install the QML extension plugins to have the applet working? Or is there some mechanism to load them also from the build dir now?

Ah, NoticesView.qml in Plasma 5.12 was slightly different.

Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future.

Add Layout.alignment: Qt.AlignHCenter to the PlasmaExtras.Heading

I just noticed that the "Warnings Issued" text is left aligned. Might as well center align it while we're at it.

In T10464#175733, @broulik wrote:

Can we also make KWin smarter and try to fall back to the default theme (which may also be broken, sure, but because of distro not GHNS)?

I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works.

There was a few +1s, but I wasn't exactly sure who specifically "approves" this for a merge to plasma-workspace or digital-clock specifically. My bad, I shouldn't of left this feature to the last minute and felt rushed to get it in. I'll try to avoid the time before the betas when submitting in the future.

Looking at the alternative patch, I've renamed the config key variable to customDateFormat. Most of the differences stem from not using a "variant" data type for DigitalClock.qml's dateFormat variable. The string formatDate(datetime date, variant format) (qt doc link) accepts a variant type.

• Rename config key from dateFormatStr and config TextField dateFormatTextField to customDateFormat.
• Remove the "Color Format Documentation" link.

Translate the "Time Format Documentation" link.
Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated).
Place the 2 links below the text field.

The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a plasmoid.globalConfiguration.dateFormatStr API which all widget instances (on all panels/screens) were bound to, so the user only had to configure it once for all screens. Though a person might have a clock on a vertical panel on one screen, and a thin horizontal panel on the other that might require a different configuration. That's an edge case example though.

In D18019#388829, @ndavis wrote:

Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget?

In D18019#388811, @ndavis wrote:

I'm leaning towards no, but a second link to text formatting documentation might be a good idea.

In D18018#387920, @davidedmundson wrote:

Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide?

That still requires the user to drag a button, which isn't exactly obvious or a normal behaviour, just to discover what it is. It doesn't look like a desktop widget, not that the user would recognize it as one, as KDE by default does not display any desktop widgets the user can compare it with.