Feed Advanced Search

Mon, Dec 10

arojas committed R487:eef6dae58a19: Fix PulseAudio support with Qt 5.12 (authored by arojas).
Fix PulseAudio support with Qt 5.12
Mon, Dec 10, 8:10 PM
arojas closed D17486: Fix PulseAudio support with Qt 5.12.
Mon, Dec 10, 8:10 PM
arojas committed R345:21c7f15a14d1: Merge branch 'Applications/18.12' (authored by arojas).
Merge branch 'Applications/18.12'
Mon, Dec 10, 8:08 PM
arojas closed D17489: Fix PulseAudio support with Qt 5.12.
Mon, Dec 10, 8:08 PM
arojas committed R345:be9fce820cbe: Fix PulseAudio support with Qt 5.12 (authored by arojas).
Fix PulseAudio support with Qt 5.12
Mon, Dec 10, 8:08 PM
arojas added a comment to D17486: Fix PulseAudio support with Qt 5.12.

Only master ot 4.10 too?

Mon, Dec 10, 6:11 PM
arojas requested review of D17489: Fix PulseAudio support with Qt 5.12.
Mon, Dec 10, 4:42 PM
arojas requested review of D17486: Fix PulseAudio support with Qt 5.12.
Mon, Dec 10, 4:30 PM

Wed, Nov 28

arojas abandoned D12761: Allow building kio-nfs against standalone libtirpc.
Wed, Nov 28, 7:43 AM · Frameworks, Dolphin
arojas added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

@asturmlechner can you post that in a new review request? I'll abandon this one.

Wed, Nov 28, 7:07 AM · Frameworks, Dolphin

Nov 2 2018

arojas committed R8:f099b8e143bb: Fix build with poppler 0.71 (authored by arojas).
Fix build with poppler 0.71
Nov 2 2018, 8:27 PM
arojas committed R8:45559a470604: Fix build with poppler<0.64, take 2 (authored by arojas).
Fix build with poppler<0.64, take 2
Nov 2 2018, 8:27 PM
arojas committed R8:82d68cebf870: GBool -> bool (authored by aacid).
GBool -> bool
Nov 2 2018, 8:27 PM
arojas committed R8:fa4c2961b828: Mark the functions as override (authored by aacid).
Mark the functions as override
Nov 2 2018, 8:27 PM
arojas committed R8:fb6bbaf64c60: Fix build with poppler 0.71 (authored by arojas).
Fix build with poppler 0.71
Nov 2 2018, 8:27 PM
arojas closed D16607: Fix build with poppler 0.71.
Nov 2 2018, 8:27 PM · Calligra: 3.0
arojas requested review of D16607: Fix build with poppler 0.71.
Nov 2 2018, 8:46 AM · Calligra: 3.0

Oct 27 2018

arojas committed R8:eb1cfd31fc14: Fix build with poppler<0.64, take 2 (authored by arojas).
Fix build with poppler<0.64, take 2
Oct 27 2018, 11:18 AM
arojas closed D16455: Fix build with poppler<0.64, take 2.
Oct 27 2018, 11:18 AM · Calligra: 3.0
arojas requested review of D16455: Fix build with poppler<0.64, take 2.
Oct 27 2018, 9:27 AM · Calligra: 3.0
arojas committed R115:b9058eb01fed: Merge branch 'Plasma/5.14' (authored by arojas).
Merge branch 'Plasma/5.14'
Oct 27 2018, 7:50 AM
arojas closed D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 27 2018, 7:49 AM · Plasma
arojas committed R115:c255ac792a0d: Fix connecting to PulseAudio with Qt 5.12 beta 3 (authored by arojas).
Fix connecting to PulseAudio with Qt 5.12 beta 3
Oct 27 2018, 7:49 AM

Oct 26 2018

arojas added a comment to D16406: Fix build with poppler<0.64.

When you say "But this one needs to be fixed in the 3.1 branch too" you mean D16406 (i.e. this very same patch) or the compilation error because of the overrides?

Oct 26 2018, 10:38 PM · Calligra: 3.0
arojas committed R8:3760bb301245: Fix build with poppler<0.64 (authored by arojas).
Fix build with poppler<0.64
Oct 26 2018, 10:37 PM
arojas committed R8:9038af136ba6: Merge branch 'master' of git://anongit.kde.org/calligra (authored by arojas).
Merge branch 'master' of git://anongit.kde.org/calligra
Oct 26 2018, 10:36 PM
arojas committed R8:3e832a0950ea: Fix build with poppler<0.64 (authored by arojas).
Fix build with poppler<0.64
Oct 26 2018, 10:36 PM
arojas closed D16406: Fix build with poppler<0.64.
Oct 26 2018, 10:36 PM · Calligra: 3.0
arojas added a comment to D16406: Fix build with poppler<0.64.

Indeed git master doesn't build with 0.55:

Oct 26 2018, 10:25 PM · Calligra: 3.0
arojas updated the summary of D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 26 2018, 9:15 PM · Plasma
arojas requested review of D16443: Fix connecting to PulseAudio with Qt 5.12 beta 3.
Oct 26 2018, 9:15 PM · Plasma
arojas updated the diff for D16406: Fix build with poppler<0.64.

Invert conditional

Oct 26 2018, 7:20 PM · Calligra: 3.0
arojas added a comment to D16406: Fix build with poppler<0.64.

I don't mind either way. In the future this could be changed to VERSION_GREATER_EQUAL when this can depend on cmake 3.7

Oct 26 2018, 8:09 AM · Calligra: 3.0

Oct 25 2018

arojas updated the diff for D16406: Fix build with poppler<0.64.

Check for poppler version at cmake time

Oct 25 2018, 6:50 AM · Calligra: 3.0

Oct 24 2018

arojas requested review of D16406: Fix build with poppler<0.64.
Oct 24 2018, 4:49 PM · Calligra: 3.0
arojas committed R407:3feffd64a7b5: Comment out phonon dependency (authored by arojas).
Comment out phonon dependency
Oct 24 2018, 6:42 AM
arojas committed R407:325a90b70ad1: Merge branch 'master' of git://anongit.kde.org/kolf (authored by arojas).
Merge branch 'master' of git://anongit.kde.org/kolf
Oct 24 2018, 6:42 AM
arojas closed D16074: Comment out phonon dependency until sound is reenabled.
Oct 24 2018, 6:42 AM
arojas committed R407:aaf6f5f33d6a: Merge branch 'Applications/18.08' (authored by arojas).
Merge branch 'Applications/18.08'
Oct 24 2018, 6:42 AM
arojas committed R8:a615718222f8: Fix build with poppler>=0.69 (authored by arojas).
Fix build with poppler>=0.69
Oct 24 2018, 6:32 AM
arojas committed R8:56bd4bab320b: Fix build with poppler>=0.69 (authored by arojas).
Fix build with poppler>=0.69
Oct 24 2018, 6:28 AM
arojas closed D16388: Fix build with poppler 0.69.
Oct 24 2018, 6:28 AM · Calligra: 3.0

Oct 23 2018

arojas requested review of D16388: Fix build with poppler 0.69.
Oct 23 2018, 3:04 PM · Calligra: 3.0

Oct 15 2018

arojas committed R120:9fca6f1fb8aa: Merge branch 'Plasma/5.14' (authored by arojas).
Merge branch 'Plasma/5.14'
Oct 15 2018, 6:15 PM
arojas committed R120:81a0fe6db9ac: Fix build with gpsd 3.18 (authored by arojas).
Fix build with gpsd 3.18
Oct 15 2018, 6:15 PM
arojas closed D16081: Fix build with gpsd 3.18.
Oct 15 2018, 6:15 PM · Plasma

Oct 9 2018

arojas requested review of D16081: Fix build with gpsd 3.18.
Oct 9 2018, 4:26 PM · Plasma
arojas committed R55:a8b397aa18da: Disable --simple-prompt Sage parameter for now (authored by arojas).
Disable --simple-prompt Sage parameter for now
Oct 9 2018, 4:02 PM
arojas committed R55:ee1793fa4681: Disable --simple-prompt Sage parameter for now (authored by arojas).
Disable --simple-prompt Sage parameter for now
Oct 9 2018, 4:02 PM
arojas closed D16052: Disable --simple-promt Sage parameter for now.
Oct 9 2018, 4:02 PM · KDE Edu
arojas requested review of D16074: Comment out phonon dependency until sound is reenabled.
Oct 9 2018, 3:12 PM

Oct 8 2018

arojas updated the summary of D16052: Disable --simple-promt Sage parameter for now.
Oct 8 2018, 8:58 PM · KDE Edu
arojas requested review of D16052: Disable --simple-promt Sage parameter for now.
Oct 8 2018, 8:58 PM · KDE Edu

Sep 30 2018

arojas committed R240:05bd97492704: Compile python bindings with the same sip flags used by PyQt (authored by arojas).
Compile python bindings with the same sip flags used by PyQt
Sep 30 2018, 8:47 PM
arojas closed D15091: Compile python bindings with the same sip flags used by PyQt.
Sep 30 2018, 8:47 PM · Build System, Frameworks
arojas abandoned D15852: Fix doc dir in launcher script.

Already fixed another way

Sep 30 2018, 1:10 PM
arojas updated the diff for D15852: Fix doc dir in launcher script.

Use DOC_INSTALL_DIR

Sep 30 2018, 10:08 AM
arojas requested review of D15852: Fix doc dir in launcher script.
Sep 30 2018, 9:40 AM

Sep 21 2018

arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.

Rebase

Sep 21 2018, 10:35 PM · Build System, Frameworks

Sep 16 2018

arojas committed R425:4d1d989114a0: Fix crash when moving pawn two squares (authored by arojas).
Fix crash when moving pawn two squares
Sep 16 2018, 8:09 PM
arojas closed D15555: Fix crash when moving pawn two squares.
Sep 16 2018, 8:09 PM
arojas requested review of D15555: Fix crash when moving pawn two squares.
Sep 16 2018, 4:17 PM

Sep 12 2018

arojas added a comment to D15148: Fix build with libraw 0.19.

Looks like this was already pushed @ 3b7d0f2cbf66b06e12c57be26b262b71d8030d1a

Sep 12 2018, 5:38 PM · Krita

Sep 8 2018

arojas committed R333:7fe3cd3c6654: Mark phonon as required (authored by arojas).
Mark phonon as required
Sep 8 2018, 10:11 AM
arojas closed D15345: Mark phonon as required.
Sep 8 2018, 10:11 AM · KDE Edu
arojas requested review of D15345: Mark phonon as required.
Sep 8 2018, 10:00 AM · KDE Edu

Sep 7 2018

arojas committed R342:f8fd331b3a0f: Merge branch 'Applications/18.08' (authored by arojas).
Merge branch 'Applications/18.08'
Sep 7 2018, 8:06 PM
arojas committed R342:9aa606bbc4c9: Use the right version of kcmshell (authored by arojas).
Use the right version of kcmshell
Sep 7 2018, 8:06 PM
arojas closed D15336: Use the right version of kcmshell.
Sep 7 2018, 8:06 PM
arojas requested review of D15336: Use the right version of kcmshell.
Sep 7 2018, 5:07 PM

Aug 31 2018

arojas committed R377:ce3d1dc2d1e4: Clarify soversion (authored by arojas).
Clarify soversion
Aug 31 2018, 6:13 PM
arojas closed D15149: Clarify soversion.
Aug 31 2018, 6:13 PM
arojas accepted D14915: Bindings: Check if bindings can be generated for a specific python version.
Aug 31 2018, 1:10 PM · Build System, Frameworks
arojas accepted D14914: Bindings: Use python version matching the found clang python module.
Aug 31 2018, 1:09 PM · Build System, Frameworks
arojas accepted D14912: Bindings: Make generator forward compatible with Python 3.
Aug 31 2018, 1:08 PM · Build System, Frameworks
arojas added a comment to D15149: Clarify soversion.

Adding release managers, not sure who else can review this

Aug 31 2018, 8:20 AM
arojas added reviewers for D15149: Clarify soversion: aacid, cfeck.
Aug 31 2018, 8:20 AM
arojas committed R377:f40ebe30dca1: Fix build with libraw 0.19 (authored by arojas).
Fix build with libraw 0.19
Aug 31 2018, 7:23 AM
arojas closed D15132: Fix build with libraw 0.19.
Aug 31 2018, 7:23 AM

Aug 29 2018

arojas abandoned D15133: Drop functionality that depends on libraw features removed in 0.19.

Alright. IMO it's cleaner to just drop API that is eventually no longer going to work (deprecated != not working), but in practice it won't make any difference since nothing uses this code.

Aug 29 2018, 5:04 PM
arojas requested review of D15149: Clarify soversion.
Aug 29 2018, 5:00 PM
arojas updated the diff for D15132: Fix build with libraw 0.19.

Minor doc fix

Aug 29 2018, 4:49 PM
arojas updated the diff for D15132: Fix build with libraw 0.19.

Add deprecation markers, update DecodingQuality enum

Aug 29 2018, 4:48 PM
arojas added a comment to D15148: Fix build with libraw 0.19.

Does krita use the ifdef'd code at all? If not, it may be simpler to just remove it completely.

Aug 29 2018, 4:03 PM · Krita

Aug 28 2018

arojas updated the summary of D15132: Fix build with libraw 0.19.
Aug 28 2018, 9:38 PM
arojas requested review of D15133: Drop functionality that depends on libraw features removed in 0.19.
Aug 28 2018, 9:37 PM
arojas requested review of D15132: Fix build with libraw 0.19.
Aug 28 2018, 9:30 PM
arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.
Aug 28 2018, 4:58 PM · Build System, Frameworks
arojas planned changes to D15091: Compile python bindings with the same sip flags used by PyQt.
Aug 28 2018, 1:55 PM · Build System, Frameworks
arojas committed R123:1421359002d6: Sync MAX_UID with upstream (authored by arojas).
Sync MAX_UID with upstream
Aug 28 2018, 9:15 AM
arojas closed D13911: Sync MAX_UID with upstream.
Aug 28 2018, 9:15 AM · Plasma
arojas added a comment to D13911: Sync MAX_UID with upstream.

Ping

Aug 28 2018, 8:45 AM · Plasma
arojas added a comment to D15091: Compile python bindings with the same sip flags used by PyQt.

I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them.

Aug 28 2018, 8:39 AM · Build System, Frameworks

Aug 27 2018

arojas added a comment to D15091: Compile python bindings with the same sip flags used by PyQt.

Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]?

Aug 27 2018, 9:54 PM · Build System, Frameworks

Aug 26 2018

arojas added inline comments to D15091: Compile python bindings with the same sip flags used by PyQt.
Aug 26 2018, 8:05 PM · Build System, Frameworks
arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.

Use a regex to account for the case where -n an its arg are not space-separated

Aug 26 2018, 8:04 PM · Build System, Frameworks
arojas requested review of D15091: Compile python bindings with the same sip flags used by PyQt.
Aug 26 2018, 7:00 PM · Build System, Frameworks
arojas added a comment to D14912: Bindings: Make generator forward compatible with Python 3.

Thats on Arch?

Aug 26 2018, 6:59 PM · Build System, Frameworks
arojas added a comment to D14912: Bindings: Make generator forward compatible with Python 3.

With this + D14914 + D14915 I can successfully compile bindings without having any python2 package installed.

Aug 26 2018, 5:34 PM · Build System, Frameworks
arojas added a comment to D14915: Bindings: Check if bindings can be generated for a specific python version.

sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path?

Aug 26 2018, 8:51 AM · Build System, Frameworks