Feed Advanced Search

Tue, May 29

arojas added a comment to D13186: Use HiddenStatus when keyboard indicator is inactive.

Right, I guess if someone disables everything on the config there's no way to reenable them in systray-embedded mode (well, removing and readding the applet will reset the config, but that's not obvoius)

Tue, May 29, 10:08 PM · Plasma
arojas requested review of D13186: Use HiddenStatus when keyboard indicator is inactive.
Tue, May 29, 6:10 AM · Plasma

Sun, May 27

arojas committed R134:8abea81de174: Merge branch 'Plasma/5.13' (authored by arojas).
Merge branch 'Plasma/5.13'
Sun, May 27, 11:11 PM
arojas committed R134:0e851f2b6899: Make .deb and .rpm mime type handling optional at build time (authored by arojas).
Make .deb and .rpm mime type handling optional at build time
Sun, May 27, 11:11 PM
arojas closed D13123: Make .deb and .rpm mime type handling optional at build time.
Sun, May 27, 11:11 PM · Plasma
arojas added a comment to D13123: Make .deb and .rpm mime type handling optional at build time.
In D13123#269385, @mak wrote:

Checking for the dpkg and rpm binaries isn't really foolproof, because you can install rpm on Debian and dpkg on Fedora & Co. easily.
The only issue proof thing that I can imagine would be checking for the distribution name in /etc/os-release, or maybe checking for the presence of /etc/debian_version.

Sun, May 27, 10:38 PM · Plasma
arojas added a comment to D13123: Make .deb and .rpm mime type handling optional at build time.

5.13 or master?

Sun, May 27, 10:17 PM · Plasma

Sat, May 26

arojas updated the diff for D13123: Make .deb and .rpm mime type handling optional at build time.

Check for the presence of the dpkg and rpm binaries to decide whether to install the mime type handlers

Sat, May 26, 7:31 AM · Plasma
arojas committed R134:04b96967c2ab: Merge branch 'Plasma/5.13' (authored by arojas).
Merge branch 'Plasma/5.13'
Sat, May 26, 7:14 AM
arojas committed R134:ee8e49422118: Abort transaction on PackageKit errors (authored by arojas).
Abort transaction on PackageKit errors
Sat, May 26, 7:14 AM
arojas closed D13119: Abort transaction on PK dependency resolution error.
Sat, May 26, 7:14 AM · Plasma

Fri, May 25

arojas requested review of D13123: Make .deb and .rpm mime type handling optional at build time.
Fri, May 25, 10:32 PM · Plasma
arojas updated the diff for D13119: Abort transaction on PK dependency resolution error.

Remove wrong check for !m_proceedFunctions.isEmpty()

Fri, May 25, 9:48 PM · Plasma
arojas updated the diff for D13119: Abort transaction on PK dependency resolution error.

Check for ExitStatus in cleanup() and move setStatus there

Fri, May 25, 7:22 PM · Plasma
arojas requested review of D13119: Abort transaction on PK dependency resolution error.
Fri, May 25, 5:44 PM · Plasma

May 20 2018

arojas committed R114:e0fd192ecec2: Merge branch 'Plasma/5.13' (authored by arojas).
Merge branch 'Plasma/5.13'
May 20 2018, 2:02 PM
arojas committed R114:f54bcde16302: Fix always empty memory bar (authored by arojas).
Fix always empty memory bar
May 20 2018, 2:01 PM
arojas closed D12999: Fix always empty memory bar.
May 20 2018, 2:01 PM · Plasma
arojas requested review of D12999: Fix always empty memory bar.
May 20 2018, 12:54 PM · Plasma

May 16 2018

arojas added reviewers for D12761: Allow building kio-nfs against standalone libtirpc: rdieter, fvogt, asturmlechner.
May 16 2018, 6:54 AM

May 14 2018

arojas committed R468:166f57db638d: Remove X-DBUS-StartupType from desktop file (authored by arojas).
Remove X-DBUS-StartupType from desktop file
May 14 2018, 7:51 AM
arojas closed D8080: Remove X-DBUS-StartupType from desktop file.
May 14 2018, 7:51 AM · Kile

May 13 2018

arojas added a comment to D8080: Remove X-DBUS-StartupType from desktop file.

Ping. This is still an issue in beta 2

May 13 2018, 10:11 AM · Kile

May 8 2018

arojas requested review of D12761: Allow building kio-nfs against standalone libtirpc.
May 8 2018, 4:20 PM

Apr 29 2018

arojas committed R318:05d389c56eb2: Merge branch 'Applications/18.04' (authored by arojas).
Merge branch 'Applications/18.04'
Apr 29 2018, 5:41 PM
arojas committed R318:0c05b992c0db: Don't filter out duplicated entries from places panel (authored by arojas).
Don't filter out duplicated entries from places panel
Apr 29 2018, 5:40 PM
arojas closed D12558: Don't filter out duplicated entries from places panel.
Apr 29 2018, 5:40 PM

Apr 27 2018

arojas added a comment to D12558: Don't filter out duplicated entries from places panel.

I know a bit of the background here: the anti-duplicate code was added to ease the transition from Dolphin-specific entries to global KIO-wide entries when Renato did a bunch of work last year to make the places global. The reasoning was that it would be more humane to remove and/or hide duplicates rather than irritate the user following the migration, which could lead to a lack of confidence that the migration was done correctly.

Apr 27 2018, 5:37 PM
arojas added a comment to D12558: Don't filter out duplicated entries from places panel.

If there is a duplicate entry in user-places.xbel, then either it is intentional (in which case Dolphin shouldn't meddle with it) or it is not, in which case the user should be made aware of it so they can fix it properly instead of sweeping the issue under the rug.

Apr 27 2018, 1:12 PM

Apr 26 2018

arojas added a reverting change for R318:a8a3fa51a064: Fix place item edit after creation: D12558: Don't filter out duplicated entries from places panel.
Apr 26 2018, 10:06 PM
arojas requested review of D12558: Don't filter out duplicated entries from places panel.
Apr 26 2018, 10:06 PM

Apr 15 2018

arojas added a comment to D12216: Don't need to run previous iterations commands again.

Works for me, thanks

Apr 15 2018, 8:02 AM · Frameworks

Apr 12 2018

arojas committed R318:a4f16761fc27: Merge branch 'Applications/18.04' (authored by arojas).
Merge branch 'Applications/18.04'
Apr 12 2018, 8:51 PM
arojas committed R318:ed5102a5fd7a: Fix untranslated places panel entries (authored by arojas).
Fix untranslated places panel entries
Apr 12 2018, 8:50 PM
arojas closed D12119: Fix untranslated places panel entries.
Apr 12 2018, 8:50 PM
arojas committed R486:78503bf5743c: Recommit botan 2 support without making botan mandatory (authored by arojas).
Recommit botan 2 support without making botan mandatory
Apr 12 2018, 8:04 AM
arojas committed R326:c5030e0d2734: Drop unused QtQuick dependency (authored by arojas).
Drop unused QtQuick dependency
Apr 12 2018, 6:15 AM
arojas closed D12122: Drop unused QtQuick dependency.
Apr 12 2018, 6:15 AM · KDE Edu

Apr 11 2018

arojas retitled D12122: Drop unused QtQuick dependency from Drop unused QtQml dependency to Drop unused QtQuick dependency.
Apr 11 2018, 9:25 PM · KDE Edu
arojas requested review of D12122: Drop unused QtQuick dependency.
Apr 11 2018, 9:24 PM · KDE Edu
arojas committed R486:47163784d742: Add botan 2 support (authored by arojas).
Add botan 2 support
Apr 11 2018, 7:45 PM
arojas closed D11997: Add botan 2 support.
Apr 11 2018, 7:45 PM
arojas committed R341:974e2f08ee0b: Drop unused dependencies (authored by arojas).
Drop unused dependencies
Apr 11 2018, 7:39 PM
arojas closed D12107: Drop unused dependencies.
Apr 11 2018, 7:39 PM · KDE Edu
arojas requested review of D12119: Fix untranslated places panel entries.
Apr 11 2018, 5:03 PM
arojas requested review of D12107: Drop unused dependencies.
Apr 11 2018, 10:43 AM · KDE Edu

Apr 7 2018

arojas updated the diff for D11997: Add botan 2 support.

Remove -ansi CFLAGS that conflict with c++11 needed by botan2

Apr 7 2018, 1:34 AM

Apr 6 2018

arojas updated the diff for D11997: Add botan 2 support.

Use unique_ptr's to prevent leaks

Apr 6 2018, 10:33 PM
arojas requested review of D11997: Add botan 2 support.
Apr 6 2018, 9:00 PM

Apr 5 2018

arojas committed R462:6bafedf8976a: Fix build with ICU 61 (authored by arojas).
Fix build with ICU 61
Apr 5 2018, 8:28 PM
arojas committed R462:d6a2a01b56f6: Fix build with ICU 61 (authored by arojas).
Fix build with ICU 61
Apr 5 2018, 8:27 PM
arojas closed D11883: Fix build with ICU 61.
Apr 5 2018, 8:27 PM

Apr 4 2018

arojas committed R434:fcf32a29393d: Merge branch 'Applications/18.04' (authored by arojas).
Merge branch 'Applications/18.04'
Apr 4 2018, 9:18 PM
arojas committed R434:692aaedde7ab: Fix soversion of libkopete_oscar and libkopete_videodevice (authored by arojas).
Fix soversion of libkopete_oscar and libkopete_videodevice
Apr 4 2018, 9:17 PM
arojas closed D11920: Fix soversion of libkopete_oscar and libkopete_videodevice.
Apr 4 2018, 9:17 PM · Kopete
arojas requested review of D11920: Fix soversion of libkopete_oscar and libkopete_videodevice.
Apr 4 2018, 11:03 AM · Kopete

Apr 3 2018

arojas committed R318:eab70b2ac4a8: Merge branch 'Applications/18.04' (authored by arojas).
Merge branch 'Applications/18.04'
Apr 3 2018, 8:50 PM
arojas committed R318:386a862de4e6: Initialize m_konsolePartMissingMessage (authored by arojas).
Initialize m_konsolePartMissingMessage
Apr 3 2018, 8:49 PM
arojas closed D11904: Initialize m_konsolePartMissingMessage.
Apr 3 2018, 8:49 PM
arojas requested review of D11904: Initialize m_konsolePartMissingMessage.
Apr 3 2018, 3:45 PM

Apr 2 2018

arojas requested review of D11883: Fix build with ICU 61.
Apr 2 2018, 11:52 AM

Mar 11 2018

arojas committed R181:cec3c9b3fb14: Fix build with Qt 5.11 (authored by arojas).
Fix build with Qt 5.11
Mar 11 2018, 8:46 PM
arojas closed D11239: Fix build with Qt 5.11.
Mar 11 2018, 8:46 PM · Amarok
arojas requested review of D11239: Fix build with Qt 5.11.
Mar 11 2018, 5:36 PM · Amarok

Mar 5 2018

arojas added a comment to D11055: Pack python bindings into right dirs.

The sip part is distro-specific. At least in Arch we don't have separate sip/sip3 directories (what's the point? sip files are independent of the python version)

Mar 5 2018, 4:55 PM · Build System, Frameworks

Feb 23 2018

arojas committed R489:ea4d78ac3fc0: Fix build with VLC<3 (authored by arojas).
Fix build with VLC<3
Feb 23 2018, 8:52 PM
arojas closed D10775: Fix build with VLC<3.
Feb 23 2018, 8:52 PM
arojas requested review of D10775: Fix build with VLC<3.
Feb 23 2018, 5:11 PM

Feb 21 2018

arojas committed R549:29df2bd0bc9f: Fix build without AppStream (authored by arojas).
Fix build without AppStream
Feb 21 2018, 1:14 PM
arojas closed D10707: Fix build without AppStream.
Feb 21 2018, 1:14 PM
arojas committed R549:448527f765b1: Install apper binary as TARGET instead of PROGRAM (authored by arojas).
Install apper binary as TARGET instead of PROGRAM
Feb 21 2018, 1:12 PM
arojas closed D10706: Install apper binary as TARGET instead of PROGRAM.
Feb 21 2018, 1:12 PM
arojas added a comment to D10706: Install apper binary as TARGET instead of PROGRAM.

Is there a stable branch, or should this go straight to master?

Feb 21 2018, 10:24 AM
arojas added a comment to D10707: Fix build without AppStream.

Thanks, I've been thinking into making this dependency mandatory, could you please tell me why would you like to build without AppStream or are you just fixing the bug? thanks

Feb 21 2018, 10:16 AM
arojas requested review of D10707: Fix build without AppStream.
Feb 21 2018, 9:56 AM
arojas requested review of D10706: Install apper binary as TARGET instead of PROGRAM.
Feb 21 2018, 8:19 AM

Jan 18 2018

arojas committed R134:12576d2fac6e: Merge branch 'Plasma/5.12' (authored by arojas).
Merge branch 'Plasma/5.12'
Jan 18 2018, 3:14 PM
arojas committed R134:2f4f9a48fcb8: Query os-release for distro name (authored by arojas).
Query os-release for distro name
Jan 18 2018, 3:14 PM
arojas closed D9960: Query os-release for distro name.
Jan 18 2018, 3:14 PM · Plasma
arojas added a comment to D9960: Query os-release for distro name.
In D9960#192840, @apol wrote:

Works for me.
Maybe use PRETTY_NAME? It's supposed to be prettier and it's used to display after all.

Jan 18 2018, 12:41 PM · Plasma

Jan 3 2018

arojas added a comment to D9636: Fix displaying RW2 files with shared-mime-info 1.9.
In D9636#185609, @rkflx wrote:
Jan 3 2018, 6:16 PM
arojas committed R260:484a8df5e435: Fix displaying RW2 files with shared-mime-info 1.9 (authored by arojas).
Fix displaying RW2 files with shared-mime-info 1.9
Jan 3 2018, 6:15 PM
arojas committed R260:429748babb7c: Merge branch 'Applications/17.12' (authored by arojas).
Merge branch 'Applications/17.12'
Jan 3 2018, 6:15 PM
arojas closed D9636: Fix displaying RW2 files with shared-mime-info 1.9.
Jan 3 2018, 6:15 PM

Dec 25 2017

arojas committed R482:27e8d931765a: Fix build with openCV 3.4 (authored by arojas).
Fix build with openCV 3.4
Dec 25 2017, 9:35 AM
arojas closed D9501: Fix build with opencv 3.4.
Dec 25 2017, 9:35 AM
arojas edited reviewers for D9501: Fix build with opencv 3.4, added: mqualmann; removed: qmarteen.
Dec 25 2017, 12:06 AM
arojas created D9501: Fix build with opencv 3.4.
Dec 25 2017, 12:05 AM

Dec 22 2017

arojas committed R335:09f6df15b663: Mark Label and LineLabel types as internal (authored by arojas).
Mark Label and LineLabel types as internal
Dec 22 2017, 7:23 AM
arojas closed D9436: Add missing types to qmldir.
Dec 22 2017, 7:23 AM · KDE Edu

Dec 21 2017

arojas updated the diff for D9436: Add missing types to qmldir.

Made Label and LineLabel internal

Dec 21 2017, 1:30 PM · KDE Edu

Dec 20 2017

arojas committed R335:4e90e87e7522: Add missing types to qmldir (authored by arojas).
Add missing types to qmldir
Dec 20 2017, 8:10 PM
arojas closed D9436: Add missing types to qmldir.
Dec 20 2017, 8:10 PM · KDE Edu
arojas created D9436: Add missing types to qmldir.
Dec 20 2017, 5:06 PM · KDE Edu

Dec 2 2017

arojas committed R81:993a350c0268: Merge branch 'Applications/17.12' (authored by arojas).
Merge branch 'Applications/17.12'
Dec 2 2017, 10:53 AM
arojas committed R81:9d4c218b6b23: Adapt to Qt 5.10 rc2 API changes (authored by arojas).
Adapt to Qt 5.10 rc2 API changes
Dec 2 2017, 10:52 AM
arojas committed R210:6aad60a6e4d6: Merge branch 'Applications/17.12' (authored by arojas).
Merge branch 'Applications/17.12'
Dec 2 2017, 10:44 AM
arojas committed R210:a383758d2e55: Adapt to Qt 5.10 rc2 API changes (authored by arojas).
Adapt to Qt 5.10 rc2 API changes
Dec 2 2017, 10:43 AM
arojas committed R208:1a47c3d08183: Merge branch 'Applications/17.12' (authored by arojas).
Merge branch 'Applications/17.12'
Dec 2 2017, 10:31 AM
arojas committed R208:db1a8748824f: Adapt to Qt 5.10 rc2 API changes (authored by arojas).
Adapt to Qt 5.10 rc2 API changes
Dec 2 2017, 10:29 AM