Mon, Dec 10
Only master ot 4.10 too?
Wed, Nov 28
@asturmlechner can you post that in a new review request? I'll abandon this one.
Nov 2 2018
Oct 27 2018
Oct 26 2018
When you say "But this one needs to be fixed in the 3.1 branch too" you mean D16406 (i.e. this very same patch) or the compilation error because of the overrides?
Indeed git master doesn't build with 0.55:
I don't mind either way. In the future this could be changed to VERSION_GREATER_EQUAL when this can depend on cmake 3.7
Oct 25 2018
Check for poppler version at cmake time
Oct 24 2018
Oct 23 2018
Oct 15 2018
Oct 9 2018
Oct 8 2018
Sep 30 2018
Already fixed another way
Sep 21 2018
Sep 16 2018
Sep 12 2018
Looks like this was already pushed @ 3b7d0f2cbf66b06e12c57be26b262b71d8030d1a
Sep 8 2018
Sep 7 2018
Aug 31 2018
Adding release managers, not sure who else can review this
Aug 29 2018
Alright. IMO it's cleaner to just drop API that is eventually no longer going to work (deprecated != not working), but in practice it won't make any difference since nothing uses this code.
Add deprecation markers, update DecodingQuality enum
Does krita use the ifdef'd code at all? If not, it may be simpler to just remove it completely.
Aug 28 2018
I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them.
Aug 27 2018
Aug 26 2018
Use a regex to account for the case where -n an its arg are not space-separated
sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path?