Differential D25972

Support PyQt5 compiled with SIP 5
ClosedPublic
Actions

Authored by arojas on Dec 13 2019, 10:27 PM.

Details

Reviewers
bruns
dfaure
apol
Commits
R240:7c84be59f686: Support PyQt5 compiled with SIP 5
Summary

When PyQt5 is compiled with SIP 5, the sip files are installed to ${python-site-packages}/PyQt5/bindings, so search for them there too.
This doesn't add support for compiling KF5 bindings themselves with sip5, that requires more work.

Test Plan

Python bindings build with PyQt5 compiled with SIP 5

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Dec 13 2019, 10:27 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptDec 13 2019, 10:27 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
arojas requested review of this revision.Dec 13 2019, 10:27 PM
apol added a subscriber: apol.Dec 14 2019, 10:37 PM

LGTM overall

find-modules/FindPythonModuleGeneration.cmake
312

Should probably be HINTS.

arojas updated this revision to Diff 71563.Dec 14 2019, 11:01 PM

Use HINTS

arojas marked an inline comment as done.Dec 14 2019, 11:02 PM
apol accepted this revision.Dec 15 2019, 9:47 AM
This revision is now accepted and ready to land.Dec 15 2019, 9:47 AM
Closed by commit R240:7c84be59f686: Support PyQt5 compiled with SIP 5 (authored by arojas). · Explain WhyDec 15 2019, 10:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 71574

View Options

find-modules/FindPythonModuleGeneration.cmake

Loading...