CMake: Bump min TpQt version to 0.9.8 and use its targets
ClosedPublic

Authored by akulichalexandr on Jan 18 2020, 12:38 PM.

Details

Summary

TelepathyQt 0.9.8 does not export telepathy-qt5 target anymore. It exports TelepathyQt5::Core and TelepathyQt5::Service instead.

Bump the required version and use the new targets to fix possible linking issues.

Test Plan

Compiled, installed. I also checked that ktp-text-ui can be configured/compiled/installed with this version of k-c-i.

Diff Detail

Repository
R145 KDE Telepathy Common Internals
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akulichalexandr requested review of this revision.Jan 18 2020, 12:38 PM
akulichalexandr created this revision.

Re-added an accidentally removed comment.

arojas accepted this revision.Jan 18 2020, 12:46 PM

Works for me. You should probably ping the CI people about the dependency change before committing.

This revision is now accepted and ready to land.Jan 18 2020, 12:46 PM
tcberner accepted this revision.Jan 18 2020, 2:48 PM

Looks good to me. FreeBSD CI already has telepathy-qt5-0.9.8 installed.

heikobecker accepted this revision.Jan 18 2020, 8:02 PM

Fine with me.
If https://repology.org/project/telepathy-qt/versions is correct Fedora and OpenSUSE still don't have 0.9.8 though.

Everyone, thanks for the comments!
Keep in mind that TelepathyQt-0.9.8 is the first version that uses Python 3 instead of Python 2.

So yeah, it seems that there are distros that not updated yet, but they really have to either update or drop this piece of the software.

This revision was automatically updated to reflect the committed changes.