Differential D26486

Fix build with gpsd 3.20
ClosedPublic
Actions

Authored by arojas on Jan 7 2020, 9:22 AM.

Details

Reviewers
aacid
Group Reviewers
Marble
Commits
R34:51e0d9122cf2: Fix build with gpsd 3.20
Summary

gps_data_t.fix.time is a struct timespec in gpsd>=3.20

Test Plan

Builds with gpsd 3.20 and 3.19

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Jan 7 2020, 9:22 AM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptJan 7 2020, 9:22 AM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
arojas requested review of this revision.Jan 7 2020, 9:22 AM
cfeck added a subscriber: cfeck.Jan 7 2020, 6:56 PM
cfeck added inline comments.
src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp
117

tv_nsec is a long, so it is never a NaN.

arojas updated this revision to Diff 73012.Jan 7 2020, 7:39 PM

Remove unnecessary check

arojas marked an inline comment as done.Jan 7 2020, 7:40 PM
aacid accepted this revision.Jan 7 2020, 9:03 PM
aacid added a subscriber: aacid.

Sounds reasonable

This revision is now accepted and ready to land.Jan 7 2020, 9:03 PM
Closed by commit R34:51e0d9122cf2: Fix build with gpsd 3.20 (authored by arojas). · Explain WhyJan 7 2020, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73016

View Options

src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.cpp

Loading...