Fix man page formatting
ClosedPublic

Authored by arojas on Dec 23 2019, 2:40 PM.

Details

Summary

Remove indentation that breaks formatting when compiling with namespaced stylesheets.

BUG: 415468

Test Plan

Build with namespaced docbook-xsl, man page looks ok

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Dec 23 2019, 2:40 PM
Restricted Application added projects: Okular, Documentation. · View Herald TranscriptDec 23 2019, 2:40 PM
Restricted Application added subscribers: kde-doc-english, okular-devel. · View Herald Transcript
arojas requested review of this revision.Dec 23 2019, 2:40 PM
yurchor accepted this revision.Dec 23 2019, 2:44 PM
yurchor added a subscriber: yurchor.

Fine if it works for you. Thanks.

This revision is now accepted and ready to land.Dec 23 2019, 2:44 PM

Uhm, but it shouldn't be an issue, really. As a workaround this is fine, but maybe an XSLT issue? Why was this seen only on Arch?

Uhm, but it shouldn't be an issue, really. As a workaround this is fine, but maybe an XSLT issue? Why was this seen only on Arch?

I suppose other distros use the non-namespaced stylesheets by default. This started happening when we switched to the namespaced ones.

This revision was automatically updated to reflect the committed changes.
aacid added a subscriber: aacid.Dec 24 2019, 10:11 AM

You should have commited this to the stable branch and then merged to master.

I'll cherry-pick -x to stable now, it's worse, but relatively acceptable

You should have commited this to the stable branch and then merged to master.

I'll cherry-pick -x to stable now, it's worse, but relatively acceptable

I assumed this was a string freeze break since the page is localized.

You should have commited this to the stable branch and then merged to master.

I'll cherry-pick -x to stable now, it's worse, but relatively acceptable

I assumed this was a string freeze break since the page is localized.

But it doesn't change any string :)

arojas added a comment.Jan 9 2020, 6:35 PM

The localized man pages are still broken in 19.12.1 - what does it need to happen for them to pick up the change?

aacid added a comment.Jan 9 2020, 7:00 PM

I guess the translators need to re-generate them

Very few people know about this problem (es, nl, pt, pt_BR). And even some those who do know just forgot to update the docbook (de, uk). Some docbooks cannot be updated because the translations are now incomplete (et, fr, ru). Thus there should be some coordinated effort to fix this from the translator side.

Should be fixed in stable for now.