Unbreak the Accounts KCM
ClosedPublic

Authored by leinir on Feb 17 2020, 12:12 PM.

Details

Summary

Prior to this, the Accounts KCM would show only the first account,
because the listview was a zero by zero size (which results in
the first item still being shown because labels will overpaint
unless told otherwise). The reson it looked like there was a
view there before was that the view was set to the ScrollViewKCM's
default scroll view. In other words: All the accounts were in fact
there, but they were not displayed because the listview was
not there.

BUG:415267

Diff Detail

Repository
R155 KAccounts Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir requested review of this revision.Feb 17 2020, 12:12 PM
leinir created this revision.
leinir added a project: Plasma.
arojas added a subscriber: arojas.Feb 17 2020, 12:25 PM

Thanks, I confirm that all accounts are displayed now and they can be deleted. The list of enabled services still can't be configured though, the "Apply" button is never enabled.

bshah accepted this revision.Feb 17 2020, 12:27 PM
This revision is now accepted and ready to land.Feb 17 2020, 12:27 PM
This revision was automatically updated to reflect the committed changes.
wbauer added a subscriber: wbauer.Mar 2 2020, 10:46 AM

Shouldn't this one be pushed to the 19.12 branch as well? (it's currently only in master AFAICS)
After all, it regressed in 19.12.0 (or actually 19.11.80).

Shouldn't this one be pushed to the 19.12 branch as well? (it's currently only in master AFAICS)
After all, it regressed in 19.12.0 (or actually 19.11.80).

It probably does... what's the in-a-nutshell procedure for doing that? (since it's already landed, of course, arc won't do that)

Shouldn't this one be pushed to the 19.12 branch as well? (it's currently only in master AFAICS)
After all, it regressed in 19.12.0 (or actually 19.11.80).

It probably does... what's the in-a-nutshell procedure for doing that? (since it's already landed, of course, arc won't do that)

I'd say git cherry-pick the commit from master to release/19.12.

wbauer added a comment.Mar 2 2020, 9:01 PM

When I committed D27474 to the 19.12 branch, I took the liberty to cherry-pick this as well, so that it will be part of the 19.12.3 release already.
I hope that's ok.

leinir added a comment.Mar 3 2020, 8:45 AM

When I committed D27474 to the 19.12 branch, I took the liberty to cherry-pick this as well, so that it will be part of the 19.12.3 release already.
I hope that's ok.

That works, thanks! :D