Fix build with opencv 4.2
ClosedPublic
Actions

Authored by arojas on Dec 21 2019, 12:46 PM.

Details

Reviewers

None

Group Reviewers

Digikam

Commits

R482:cff33fbc9c7c: Fix build with opencv 4.2

Summary

Port away from old API which is removed in 4.2

Test Plan

Builds with opencv 4.2.0, 4.1.2 and 3.4.9

Repository

R482 digiKam

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

arojas requested review of this revision.Dec 21 2019, 12:46 PM

arojas created this revision.

Hi,

This will continue to compile with OpenCV LTS 3.x ?

Best
Gilles Caulier

Tested with 3.4.9, builds fine.

arojas edited the test plan for this revision. (Show Details)Dec 21 2019, 1:28 PM

Perfect. You can commit these changes in git/master....
Gilles

This revision was not accepted when it landed; it landed in state Needs Review.Dec 21 2019, 1:47 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			core/libs/facesengine/detection/opencv-face/opencvfacedetector_p.h (2 lines)
M			core/libs/facesengine/detection/opencv-face/opencvfacedetector_p.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71940			Dec 21 2019, 12:45 PM	★	★
Diff 2	71945	506ed4f	R482:cff33fbc9c7c69f92be990cef0f19e63ac1f7654	Dec 21 2019, 1:46 PM	★	★