akulichalexandr (Alexandr Akulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 11 2016, 8:33 AM (221 w, 14 h)
Availability
Available

Recent Activity

Apr 26 2020

akulichalexandr accepted D28604: rename ktp_integration target so it comply to the name in dbus service file.

Oh, I'm sorry I missed this somehow.
Of course land this if it works. 👍 Seems correct to me.

Apr 26 2020, 12:11 PM · KDE Telepathy

Mar 21 2020

akulichalexandr accepted D28174: Fix build with Qt 5.15.
Mar 21 2020, 1:06 AM

Feb 17 2020

akulichalexandr committed R145:abe3dbf9f890: FavoriteRoomsModel: Add missing breaks, fix warnings (authored by akulichalexandr).
FavoriteRoomsModel: Add missing breaks, fix warnings
Feb 17 2020, 2:11 AM
akulichalexandr committed R145:06c5941e3808: Conversation: Fix a crash in destructor (authored by akulichalexandr).
Conversation: Fix a crash in destructor
Feb 17 2020, 1:57 AM
akulichalexandr committed R145:0a8e63151d99: MainLogModel: Processing SQL query only on account manager ready (authored by akulichalexandr).
MainLogModel: Processing SQL query only on account manager ready
Feb 17 2020, 1:57 AM

Jan 19 2020

akulichalexandr committed R164:e276d5da3f78: Use chat pictures in the conversation list (authored by akulichalexandr).
Use chat pictures in the conversation list
Jan 19 2020, 11:48 PM
akulichalexandr committed R164:584c72976dd2: Fix new requested channels processing (authored by akulichalexandr).
Fix new requested channels processing
Jan 19 2020, 11:40 PM
akulichalexandr committed R164:db40180e311d: Make it possible to start a new chat from NewConversation page (authored by akulichalexandr).
Make it possible to start a new chat from NewConversation page
Jan 19 2020, 11:40 PM
akulichalexandr committed R164:4f24ef5d8207: Make ContactList search case insensitive (authored by akulichalexandr).
Make ContactList search case insensitive
Jan 19 2020, 11:40 PM
akulichalexandr committed R145:d70b55bd9b6c: MainLogModel: Add 'chatPicture' role and data (authored by akulichalexandr).
MainLogModel: Add 'chatPicture' role and data
Jan 19 2020, 11:36 PM
akulichalexandr committed R145:2aaf6fcc770c: MainLogModel: Reformat data() method (authored by akulichalexandr).
MainLogModel: Reformat data() method
Jan 19 2020, 11:36 PM
akulichalexandr committed R145:251a4a4cb7e9: ktp-debugger: Remove unused connection (authored by akulichalexandr).
ktp-debugger: Remove unused connection
Jan 19 2020, 11:36 PM
akulichalexandr committed R145:f548f9e4b6d9: MainLogModel: Refactor roleNames() (authored by akulichalexandr).
MainLogModel: Refactor roleNames()
Jan 19 2020, 11:36 PM
akulichalexandr committed R145:82026dcf9dd7: MainLogModel: Fix a crash if can't get account on start chat (authored by akulichalexandr).
MainLogModel: Fix a crash if can't get account on start chat
Jan 19 2020, 11:36 PM
akulichalexandr committed R145:bd649bb5ea4b: MainLogModel: Add startChat(QString personUri) overload (authored by akulichalexandr).
MainLogModel: Add startChat(QString personUri) overload
Jan 19 2020, 11:36 PM
akulichalexandr committed R145:00cfb020a41c: [declarative] Make startChat() a slot (authored by akulichalexandr).
[declarative] Make startChat() a slot
Jan 19 2020, 11:36 PM
akulichalexandr committed R142:644df6fd22dd: Use nullptr keyword wherever it makes sense (authored by akulichalexandr).
Use nullptr keyword wherever it makes sense
Jan 19 2020, 11:18 PM
akulichalexandr committed R142:a676979a4019: Use override specifiers wherever it makes sense (authored by akulichalexandr).
Use override specifiers wherever it makes sense
Jan 19 2020, 11:18 PM
akulichalexandr committed R142:4c52b193e794: TextChannelApprover: Don't show notification for silent messages (authored by akulichalexandr).
TextChannelApprover: Don't show notification for silent messages
Jan 19 2020, 11:18 PM
akulichalexandr committed R142:079487a8edfa: TextChannelApprover: Don't show notification if the message is already read (authored by akulichalexandr).
TextChannelApprover: Don't show notification if the message is already read
Jan 19 2020, 11:18 PM
akulichalexandr committed R142:8d0cdcd38185: Bump minimum TelepathyQt version to 0.9.8 (authored by akulichalexandr).
Bump minimum TelepathyQt version to 0.9.8
Jan 19 2020, 11:18 PM
akulichalexandr committed R141:f779aed31735: Fix code style (tabs -> spaces) (authored by akulichalexandr).
Fix code style (tabs -> spaces)
Jan 19 2020, 1:28 AM
akulichalexandr committed R141:9308f1069490: Use nullptr keyword wherever it makes sense (authored by akulichalexandr).
Use nullptr keyword wherever it makes sense
Jan 19 2020, 1:28 AM
akulichalexandr committed R141:1a5de2aa9652: Remove unneeded arguments (authored by akulichalexandr).
Remove unneeded arguments
Jan 19 2020, 1:28 AM
akulichalexandr committed R141:cad9379d0e1f: Use override specifiers wherever it makes sense (authored by akulichalexandr).
Use override specifiers wherever it makes sense
Jan 19 2020, 1:27 AM

Jan 18 2020

akulichalexandr committed R145:edb50062a273: [declarative] Set the default scrollback length to 20 (authored by mck182).
[declarative] Set the default scrollback length to 20
Jan 18 2020, 11:04 PM
akulichalexandr committed R145:4b7fb639e126: [declarative] If autostarted by MC, signal the incoming channel as requested one (authored by mck182).
[declarative] If autostarted by MC, signal the incoming channel as requested one
Jan 18 2020, 11:03 PM
akulichalexandr committed R145:3053f3519033: [declarative] Add "canSendMessages" property to Conversation (authored by mck182).
[declarative] Add "canSendMessages" property to Conversation
Jan 18 2020, 11:02 PM
akulichalexandr committed R145:1ff5498de193: [declarative] Expose the unread messages count in the MainLogModel (authored by mck182).
[declarative] Expose the unread messages count in the MainLogModel
Jan 18 2020, 11:02 PM
akulichalexandr committed R145:766fba5bb24b: [declarative] Add support for contact typing notifications (authored by mck182).
[declarative] Add support for contact typing notifications
Jan 18 2020, 11:02 PM
akulichalexandr committed R145:1f298f02deb0: [declarative] Refactor (authored by mck182).
[declarative] Refactor
Jan 18 2020, 11:02 PM
akulichalexandr committed R145:5f651e054b5b: [declarative] Import the MainLogModel from SpaceBar (authored by mck182).
[declarative] Import the MainLogModel from SpaceBar
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:4a2470dfe9be: [declarative] Construct MessagesModel in Conversation always in constructor (authored by mck182).
[declarative] Construct MessagesModel in Conversation always in constructor
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:71e7718ecedd: [declarative] Support fetching history based only on contact id (authored by mck182).
[declarative] Support fetching history based only on contact id
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:3aec112fc094: [declarative] Allow the view requesting more history to be fetched (authored by mck182).
[declarative] Allow the view requesting more history to be fetched
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:7e824024e5ce: [logger] Allow fetching contact history through ScrollbackManager when offline (authored by mck182).
[logger] Allow fetching contact history through ScrollbackManager when offline
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:4338d50d0fdc: [logger] Implement continuous scrollback fetching (authored by mck182).
[logger] Implement continuous scrollback fetching
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:b4fd6f2f4788: Implement operator==() for KTp::Message to allow comparing messages (authored by mck182).
Implement operator==() for KTp::Message to allow comparing messages
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:68822d1e1dec: CMake: Drop an invalid and outdated C++11 define (authored by akulichalexandr).
CMake: Drop an invalid and outdated C++11 define
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:aece54a9ab04: CMake: Bump minimum version to 3.5 (authored by akulichalexandr).
CMake: Bump minimum version to 3.5
Jan 18 2020, 10:37 PM
akulichalexandr committed R145:3bbcb1699206: Bump the required TelepathyQt version to 0.9.8 and use the new targets (authored by akulichalexandr).
Bump the required TelepathyQt version to 0.9.8 and use the new targets
Jan 18 2020, 10:37 PM
akulichalexandr closed D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.
Jan 18 2020, 10:37 PM · KDE Telepathy
akulichalexandr added a comment to D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.

Everyone, thanks for the comments!
Keep in mind that TelepathyQt-0.9.8 is the first version that uses Python 3 instead of Python 2.

Jan 18 2020, 8:16 PM · KDE Telepathy
akulichalexandr added a reviewer for D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets: heikobecker.
Jan 18 2020, 1:27 PM · KDE Telepathy
akulichalexandr committed R154:58ca2e63e68d: Styles/Renkoo: Extract coloring css from variants (authored by akulichalexandr).
Styles/Renkoo: Extract coloring css from variants
Jan 18 2020, 12:44 PM
akulichalexandr closed D12751: Styles/Renkoo: Extract coloring css from variants.
Jan 18 2020, 12:44 PM · KDE Telepathy
akulichalexandr updated the diff for D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.

Re-added an accidentally removed comment.

Jan 18 2020, 12:41 PM · KDE Telepathy
akulichalexandr requested review of D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.
Jan 18 2020, 12:38 PM · KDE Telepathy

Jan 13 2020

akulichalexandr accepted D26613: Remove widget arg from KNotification ctor.
Jan 13 2020, 1:22 AM

Dec 3 2019

akulichalexandr accepted D25630: Port to json metadata.
Dec 3 2019, 11:46 PM
akulichalexandr accepted D25724: Remove old-style service menu.
Dec 3 2019, 11:45 PM
akulichalexandr accepted D25723: Replace KIconloader with QIcon::fromTheme.
Dec 3 2019, 11:44 PM

Nov 30 2019

akulichalexandr added a comment to D25630: Port to json metadata.

Hi!
Thank you for taking this up.
Would you mind to use the same approach as in plasma-workspace? In case of your changes we'll lose the translations, but with desktop_to_json we won't have such a problem.

Nov 30 2019, 4:41 PM

Nov 18 2019

akulichalexandr accepted D25372: Fix build with telepathy-qt 0.9.8.

LGTM (we can bump the TpQt min version and simplify the code later on)

Nov 18 2019, 5:42 PM
akulichalexandr accepted D25370: Fix build with telepathy-qt 0.9.8.

LGTM (we can bump the TpQt min version and simplify the code later on)

Nov 18 2019, 5:42 PM

Nov 14 2019

akulichalexandr accepted D25269: Fix build with telepathy-qt 0.9.8.

I thought more about this and now I agree with this patch. I focused on the thought "how to make it work as it worked before" instead of thinking about "what's right or wrong with the proposed changes".

Nov 14 2019, 4:22 PM

Nov 12 2019

akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

Hey-ho! One-line fix 😄 :facepalm: :

Nov 12 2019, 11:57 AM
akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

What about pushing this as-is for 19.12 and bumping the dependency and using the new target on master (19.12 is already branched)

Nov 12 2019, 11:40 AM
akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

Yes, probably it would be better to land this patch for now.
Long story short — I rewrote targets for TelepathyQt, because we exported them under the same name as the library files. CMake doesn't allow to export a target under multiple names, nor add_library(telepathy-qt5 ALIAS TelepathyQt5::Core). It is sad that we relied on ${TELEPATHY_QT5_LIBRARIES} that had not the recommended full path (like /usr/lib/libtelepathy-qt5.so.0.9.7) or the lookup path and linking flag (such as -L/usr/lib -ltelepathy-qt5), but just the "telepathy-qt5" name that happened to match the odd target name.

Nov 12 2019, 9:58 AM
akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

Wait a sec... where we link against "telepathy-qt target"? I see only ${TELEPATHY_QT5_LIBRARIES} and IMO it was just wrong to treat LIBRARIES variable as targets.

Nov 12 2019, 9:26 AM

Nov 6 2019

akulichalexandr closed T9166: Upstream telepathy-qt cross-compilation patch as Resolved.

Hello.
I removed [1] the custom FindPythonLibrary module, so the patch is not applicable anymore (I'll release TelepathyQt-0.9.8 with fixes sometime soon).

Nov 6 2019, 4:26 PM · KDE Yocto

Oct 3 2019

akulichalexandr committed R476:cae0e0254e88: CMake: Remove own FindPython modules, use standard FindPython3 instead (authored by akulichalexandr).
CMake: Remove own FindPython modules, use standard FindPython3 instead
Oct 3 2019, 8:30 PM
akulichalexandr closed D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Oct 3 2019, 8:30 PM · KDE Telepathy
akulichalexandr committed R476:fbb9cc9a3114: CMake: Remove own FindLibXml2 (authored by akulichalexandr).
CMake: Remove own FindLibXml2
Oct 3 2019, 8:30 PM
akulichalexandr closed D24067: CMake: Remove own FindLibXml2.
Oct 3 2019, 8:30 PM · KDE Telepathy
akulichalexandr committed R476:5a1c86291a63: CMake: Bump CMake minimum version to 3.5 (authored by akulichalexandr).
CMake: Bump CMake minimum version to 3.5
Oct 3 2019, 8:30 PM
akulichalexandr closed D24103: CMake: Bump CMake minimum version to 3.5.
Oct 3 2019, 8:30 PM · KDE Telepathy
akulichalexandr committed R476:bd8fcb701645: Tools: Sync with TelepathyQt (make compatible with Python 3) (authored by akulichalexandr).
Tools: Sync with TelepathyQt (make compatible with Python 3)
Oct 3 2019, 8:30 PM
akulichalexandr closed D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).
Oct 3 2019, 8:30 PM · KDE Telepathy

Sep 26 2019

akulichalexandr updated the diff for D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).

xincludator.py: Change output format to UTF-8 (fix LANG=C)

Sep 26 2019, 8:55 PM · KDE Telepathy

Sep 19 2019

akulichalexandr updated the summary of D24103: CMake: Bump CMake minimum version to 3.5.
Sep 19 2019, 11:33 PM · KDE Telepathy
akulichalexandr added a comment to D24103: CMake: Bump CMake minimum version to 3.5.

Do we have any reason to stick to 2.8.12?
Is there any single user or developer who need a new TelepathyQtLogger but can't update CMake at least to 3.5?
CMake 3.5 is available since Ubuntu 16.04. I think it is old enough to be required.

Sep 19 2019, 11:33 PM · KDE Telepathy
akulichalexandr requested review of D24103: CMake: Bump CMake minimum version to 3.5.
Sep 19 2019, 11:31 PM · KDE Telepathy
akulichalexandr added a comment to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Better yet, I forgot REQUIRED option. Probably I was in a rush to address your comment before going to work.
@heikobecker, thank you twice :).

Sep 19 2019, 5:53 PM · KDE Telepathy
akulichalexandr updated the diff for D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Simplify FindPythonInterp invocation.

Sep 19 2019, 5:50 PM · KDE Telepathy
akulichalexandr updated the diff for D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Use FindPythonInterp on CMake < 3.12

Sep 19 2019, 9:55 AM · KDE Telepathy
akulichalexandr added a comment to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Ouch! Thanks, @heikobecker! I think that we can use FindPythonInterp for now.

Sep 19 2019, 9:24 AM · KDE Telepathy

Sep 18 2019

akulichalexandr requested review of D24067: CMake: Remove own FindLibXml2.
Sep 18 2019, 10:22 PM · KDE Telepathy
akulichalexandr added a dependency for D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead: D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).
Sep 18 2019, 10:19 PM · KDE Telepathy
akulichalexandr added a dependent revision for D24065: Tools: Sync with TelepathyQt (make compatible with Python 3): D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Sep 18 2019, 10:19 PM · KDE Telepathy
akulichalexandr requested review of D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Sep 18 2019, 10:19 PM · KDE Telepathy
akulichalexandr requested review of D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).
Sep 18 2019, 10:15 PM · KDE Telepathy

Jul 17 2019

akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

BreakConstructorInitializers: BeforeComma changes the output to an acceptable form.

Jul 17 2019, 1:16 PM

Jul 13 2019

akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).
In T11214#191683, @zzag wrote:

I already played with ColumnLimit and all other options from the docs and various sources. IMO the result is disappointing and clang-format is not capable to do things right :-(

Have you tried disabling ColumnLimit (by setting it to 0)?

Jul 13 2019, 6:17 PM
akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

In my config it'll still be multi line.

In fact, the suggested clang-format file does the same as mine.

Jul 13 2019, 2:55 PM

Jul 11 2019

akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

Will formatter ruin beautiful multi-line formatting into single line?

like here


or

?

This will depends on the Style used. But clang format has a lot of configuration options: https://clang.llvm.org/docs/ClangFormatStyleOptions.html.

Jul 11 2019, 4:14 PM
akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

I tried my best to apply and enforce clang-format for my project, but I failed to do so in a reasonable time.
I've got an impression that clang-format configuration doesn't provide enough options to format code well enough, but maybe I should spend more hours :-).

Jul 11 2019, 4:07 PM

Jun 19 2019

akulichalexandr added inline comments to D14527: Show hostname in krfb connection info.
Jun 19 2019, 4:05 PM · KDE Applications

May 22 2019

akulichalexandr committed R145:2c6d63c485f6: Merge branch 'Applications/19.04' (authored by akulichalexandr).
Merge branch 'Applications/19.04'
May 22 2019, 8:03 PM

Mar 10 2019

akulichalexandr committed R145:b9c6256d72aa: Merge branch 'Applications/18.12' (authored by akulichalexandr).
Merge branch 'Applications/18.12'
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:f0786bc4e3cd: Fix a warning about moc included for no reason (authored by akulichalexandr).
Fix a warning about moc included for no reason
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:59fe385a4e02: [declarative] Return Tp::Account* rather than Tp::AccountPtr as the Q_PROPERTY (authored by mck182).
[declarative] Return Tp::Account* rather than Tp::AccountPtr as the Q_PROPERTY
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:e8aeb3a94f06: [declarative] Directly request closing the channel in requestClose() (authored by mck182).
[declarative] Directly request closing the channel in requestClose()
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:0b16cef686b5: [declarative] Add signals that can propagate last message change notifications (authored by mck182).
[declarative] Add signals that can propagate last message change notifications
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:fbc3d8802ec8: [declarative] Update the previous message when sending message too (authored by mck182).
[declarative] Update the previous message when sending message too
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:2694207152c2: [declarative] Rename a variable for consistency (authored by akulichalexandr).
[declarative] Rename a variable for consistency
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:e857ac00bd95: [declarative] Return the last message without new-line-chars (authored by mck182).
[declarative] Return the last message without new-line-chars
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:e75a2f3f42aa: [declarative] Allow later setting of Tp::Account to MessagesModel (authored by mck182).
[declarative] Allow later setting of Tp::Account to MessagesModel
Mar 10 2019, 9:41 AM

Mar 3 2019

akulichalexandr committed R145:5c77cc29db59: Fix escape/url filter URL placeholder backward substitution (authored by akulichalexandr).
Fix escape/url filter URL placeholder backward substitution
Mar 3 2019, 10:46 PM
akulichalexandr closed D19477: [k-c-i] Fix escape/url filter URL placeholder backward substitution.
Mar 3 2019, 10:46 PM