akulichalexandr (Alexandr Akulich)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 11 2016, 8:33 AM (201 w, 1 d)
Availability
Available

Recent Activity

Today

akulichalexandr added a reviewer for D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets: heikobecker.
Sat, Jan 18, 1:27 PM · KDE Telepathy
akulichalexandr committed R154:58ca2e63e68d: Styles/Renkoo: Extract coloring css from variants (authored by akulichalexandr).
Styles/Renkoo: Extract coloring css from variants
Sat, Jan 18, 12:44 PM
akulichalexandr closed D12751: Styles/Renkoo: Extract coloring css from variants.
Sat, Jan 18, 12:44 PM · KDE Telepathy
akulichalexandr updated the diff for D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.

Re-added an accidentally removed comment.

Sat, Jan 18, 12:41 PM · KDE Telepathy
akulichalexandr requested review of D26750: CMake: Bump min TpQt version to 0.9.8 and use its targets.
Sat, Jan 18, 12:38 PM · KDE Telepathy

Mon, Jan 13

akulichalexandr accepted D26613: Remove widget arg from KNotification ctor.
Mon, Jan 13, 1:22 AM

Dec 3 2019

akulichalexandr accepted D25630: Port to json metadata.
Dec 3 2019, 11:46 PM
akulichalexandr accepted D25724: Remove old-style service menu.
Dec 3 2019, 11:45 PM
akulichalexandr accepted D25723: Replace KIconloader with QIcon::fromTheme.
Dec 3 2019, 11:44 PM

Nov 30 2019

akulichalexandr added a comment to D25630: Port to json metadata.

Hi!
Thank you for taking this up.
Would you mind to use the same approach as in plasma-workspace? In case of your changes we'll lose the translations, but with desktop_to_json we won't have such a problem.

Nov 30 2019, 4:41 PM

Nov 18 2019

akulichalexandr accepted D25372: Fix build with telepathy-qt 0.9.8.

LGTM (we can bump the TpQt min version and simplify the code later on)

Nov 18 2019, 5:42 PM
akulichalexandr accepted D25370: Fix build with telepathy-qt 0.9.8.

LGTM (we can bump the TpQt min version and simplify the code later on)

Nov 18 2019, 5:42 PM

Nov 14 2019

akulichalexandr accepted D25269: Fix build with telepathy-qt 0.9.8.

I thought more about this and now I agree with this patch. I focused on the thought "how to make it work as it worked before" instead of thinking about "what's right or wrong with the proposed changes".

Nov 14 2019, 4:22 PM

Nov 12 2019

akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

Hey-ho! One-line fix 😄 :facepalm: :

Nov 12 2019, 11:57 AM
akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

What about pushing this as-is for 19.12 and bumping the dependency and using the new target on master (19.12 is already branched)

Nov 12 2019, 11:40 AM
akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

Yes, probably it would be better to land this patch for now.
Long story short — I rewrote targets for TelepathyQt, because we exported them under the same name as the library files. CMake doesn't allow to export a target under multiple names, nor add_library(telepathy-qt5 ALIAS TelepathyQt5::Core). It is sad that we relied on ${TELEPATHY_QT5_LIBRARIES} that had not the recommended full path (like /usr/lib/libtelepathy-qt5.so.0.9.7) or the lookup path and linking flag (such as -L/usr/lib -ltelepathy-qt5), but just the "telepathy-qt5" name that happened to match the odd target name.

Nov 12 2019, 9:58 AM
akulichalexandr added a comment to D25269: Fix build with telepathy-qt 0.9.8.

Wait a sec... where we link against "telepathy-qt target"? I see only ${TELEPATHY_QT5_LIBRARIES} and IMO it was just wrong to treat LIBRARIES variable as targets.

Nov 12 2019, 9:26 AM

Nov 6 2019

akulichalexandr closed T9166: Upstream telepathy-qt cross-compilation patch as Resolved.

Hello.
I removed [1] the custom FindPythonLibrary module, so the patch is not applicable anymore (I'll release TelepathyQt-0.9.8 with fixes sometime soon).

Nov 6 2019, 4:26 PM · KDE Yocto

Oct 3 2019

akulichalexandr committed R476:cae0e0254e88: CMake: Remove own FindPython modules, use standard FindPython3 instead (authored by akulichalexandr).
CMake: Remove own FindPython modules, use standard FindPython3 instead
Oct 3 2019, 8:30 PM
akulichalexandr closed D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Oct 3 2019, 8:30 PM · KDE Telepathy
akulichalexandr committed R476:fbb9cc9a3114: CMake: Remove own FindLibXml2 (authored by akulichalexandr).
CMake: Remove own FindLibXml2
Oct 3 2019, 8:30 PM
akulichalexandr closed D24067: CMake: Remove own FindLibXml2.
Oct 3 2019, 8:30 PM · KDE Telepathy
akulichalexandr committed R476:5a1c86291a63: CMake: Bump CMake minimum version to 3.5 (authored by akulichalexandr).
CMake: Bump CMake minimum version to 3.5
Oct 3 2019, 8:30 PM
akulichalexandr closed D24103: CMake: Bump CMake minimum version to 3.5.
Oct 3 2019, 8:30 PM · KDE Telepathy
akulichalexandr committed R476:bd8fcb701645: Tools: Sync with TelepathyQt (make compatible with Python 3) (authored by akulichalexandr).
Tools: Sync with TelepathyQt (make compatible with Python 3)
Oct 3 2019, 8:30 PM
akulichalexandr closed D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).
Oct 3 2019, 8:30 PM · KDE Telepathy

Sep 26 2019

akulichalexandr updated the diff for D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).

xincludator.py: Change output format to UTF-8 (fix LANG=C)

Sep 26 2019, 8:55 PM · KDE Telepathy

Sep 19 2019

akulichalexandr updated the summary of D24103: CMake: Bump CMake minimum version to 3.5.
Sep 19 2019, 11:33 PM · KDE Telepathy
akulichalexandr added a comment to D24103: CMake: Bump CMake minimum version to 3.5.

Do we have any reason to stick to 2.8.12?
Is there any single user or developer who need a new TelepathyQtLogger but can't update CMake at least to 3.5?
CMake 3.5 is available since Ubuntu 16.04. I think it is old enough to be required.

Sep 19 2019, 11:33 PM · KDE Telepathy
akulichalexandr requested review of D24103: CMake: Bump CMake minimum version to 3.5.
Sep 19 2019, 11:31 PM · KDE Telepathy
akulichalexandr added a comment to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Better yet, I forgot REQUIRED option. Probably I was in a rush to address your comment before going to work.
@heikobecker, thank you twice :).

Sep 19 2019, 5:53 PM · KDE Telepathy
akulichalexandr updated the diff for D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Simplify FindPythonInterp invocation.

Sep 19 2019, 5:50 PM · KDE Telepathy
akulichalexandr updated the diff for D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Use FindPythonInterp on CMake < 3.12

Sep 19 2019, 9:55 AM · KDE Telepathy
akulichalexandr added a comment to D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.

Ouch! Thanks, @heikobecker! I think that we can use FindPythonInterp for now.

Sep 19 2019, 9:24 AM · KDE Telepathy

Sep 18 2019

akulichalexandr requested review of D24067: CMake: Remove own FindLibXml2.
Sep 18 2019, 10:22 PM · KDE Telepathy
akulichalexandr added a dependency for D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead: D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).
Sep 18 2019, 10:19 PM · KDE Telepathy
akulichalexandr added a dependent revision for D24065: Tools: Sync with TelepathyQt (make compatible with Python 3): D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Sep 18 2019, 10:19 PM · KDE Telepathy
akulichalexandr requested review of D24066: CMake: Remove own FindPython modules, use standard FindPython3 instead.
Sep 18 2019, 10:19 PM · KDE Telepathy
akulichalexandr requested review of D24065: Tools: Sync with TelepathyQt (make compatible with Python 3).
Sep 18 2019, 10:15 PM · KDE Telepathy

Jul 17 2019

akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

BreakConstructorInitializers: BeforeComma changes the output to an acceptable form.

Jul 17 2019, 1:16 PM

Jul 13 2019

akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).
In T11214#191683, @zzag wrote:

I already played with ColumnLimit and all other options from the docs and various sources. IMO the result is disappointing and clang-format is not capable to do things right :-(

Have you tried disabling ColumnLimit (by setting it to 0)?

Jul 13 2019, 6:17 PM
akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

In my config it'll still be multi line.

In fact, the suggested clang-format file does the same as mine.

Jul 13 2019, 2:55 PM

Jul 11 2019

akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

Will formatter ruin beautiful multi-line formatting into single line?

like here


or

?

This will depends on the Style used. But clang format has a lot of configuration options: https://clang.llvm.org/docs/ClangFormatStyleOptions.html.

Jul 11 2019, 4:14 PM
akulichalexandr added a comment to T11214: Running clang-format across all plasma (and potentially over repos).

I tried my best to apply and enforce clang-format for my project, but I failed to do so in a reasonable time.
I've got an impression that clang-format configuration doesn't provide enough options to format code well enough, but maybe I should spend more hours :-).

Jul 11 2019, 4:07 PM

Jun 19 2019

akulichalexandr added inline comments to D14527: Show hostname in krfb connection info.
Jun 19 2019, 4:05 PM · KDE Applications

May 22 2019

akulichalexandr committed R145:2c6d63c485f6: Merge branch 'Applications/19.04' (authored by akulichalexandr).
Merge branch 'Applications/19.04'
May 22 2019, 8:03 PM

Mar 10 2019

akulichalexandr committed R145:b9c6256d72aa: Merge branch 'Applications/18.12' (authored by akulichalexandr).
Merge branch 'Applications/18.12'
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:f0786bc4e3cd: Fix a warning about moc included for no reason (authored by akulichalexandr).
Fix a warning about moc included for no reason
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:59fe385a4e02: [declarative] Return Tp::Account* rather than Tp::AccountPtr as the Q_PROPERTY (authored by mck182).
[declarative] Return Tp::Account* rather than Tp::AccountPtr as the Q_PROPERTY
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:e8aeb3a94f06: [declarative] Directly request closing the channel in requestClose() (authored by mck182).
[declarative] Directly request closing the channel in requestClose()
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:0b16cef686b5: [declarative] Add signals that can propagate last message change notifications (authored by mck182).
[declarative] Add signals that can propagate last message change notifications
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:fbc3d8802ec8: [declarative] Update the previous message when sending message too (authored by mck182).
[declarative] Update the previous message when sending message too
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:2694207152c2: [declarative] Rename a variable for consistency (authored by akulichalexandr).
[declarative] Rename a variable for consistency
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:e857ac00bd95: [declarative] Return the last message without new-line-chars (authored by mck182).
[declarative] Return the last message without new-line-chars
Mar 10 2019, 9:41 AM
akulichalexandr committed R145:e75a2f3f42aa: [declarative] Allow later setting of Tp::Account to MessagesModel (authored by mck182).
[declarative] Allow later setting of Tp::Account to MessagesModel
Mar 10 2019, 9:41 AM

Mar 3 2019

akulichalexandr committed R145:5c77cc29db59: Fix escape/url filter URL placeholder backward substitution (authored by akulichalexandr).
Fix escape/url filter URL placeholder backward substitution
Mar 3 2019, 10:46 PM
akulichalexandr closed D19477: [k-c-i] Fix escape/url filter URL placeholder backward substitution.
Mar 3 2019, 10:46 PM
akulichalexandr committed R146:6dcdbdc872c2: Restore the "Offline" option in presence combobox (authored by ablinne).
Restore the "Offline" option in presence combobox
Mar 3 2019, 10:44 PM

Mar 2 2019

akulichalexandr updated the summary of D19477: [k-c-i] Fix escape/url filter URL placeholder backward substitution.
Mar 2 2019, 3:16 PM
akulichalexandr requested review of D19477: [k-c-i] Fix escape/url filter URL placeholder backward substitution.
Mar 2 2019, 3:13 PM

Mar 1 2019

akulichalexandr committed R154:8402201446b5: [logviewer] Fix visual space between the MessageView and navigation (authored by akulichalexandr).
[logviewer] Fix visual space between the MessageView and navigation
Mar 1 2019, 7:07 PM
akulichalexandr closed D19449: [logviewer] Fix visual space between the MessageView and navigation views.
Mar 1 2019, 7:07 PM
akulichalexandr updated the summary of D19449: [logviewer] Fix visual space between the MessageView and navigation views.
Mar 1 2019, 5:59 PM
akulichalexandr updated the summary of D19449: [logviewer] Fix visual space between the MessageView and navigation views.
Mar 1 2019, 5:58 PM
akulichalexandr requested review of D19449: [logviewer] Fix visual space between the MessageView and navigation views.
Mar 1 2019, 5:58 PM
akulichalexandr committed R154:fb9ae6d15030: [logviewer] Fix MessageView not being visible (authored by akulichalexandr).
[logviewer] Fix MessageView not being visible
Mar 1 2019, 5:55 PM
akulichalexandr closed D19447: Logviewer: Fix MessageView not being visible.
Mar 1 2019, 5:55 PM · KDE Telepathy
akulichalexandr added a comment to D19447: Logviewer: Fix MessageView not being visible.

Thanks, David, you're so incredibly fast!
I forgot to say that I want (going to) to land this to 18.12. I think it OK.

Mar 1 2019, 5:45 PM · KDE Telepathy
akulichalexandr updated the test plan for D19447: Logviewer: Fix MessageView not being visible.
Mar 1 2019, 5:31 PM · KDE Telepathy
akulichalexandr requested review of D19447: Logviewer: Fix MessageView not being visible.
Mar 1 2019, 5:31 PM · KDE Telepathy

Oct 23 2018

akulichalexandr accepted D16382: Fix automatic scrolling of chat window.
Oct 23 2018, 11:01 AM
akulichalexandr added a comment to D16382: Fix automatic scrolling of chat window.

Is the change safe enough (e.g. known to work on Qt-5.9)? What is the reason to rename the function (scrollToBottom->scrollChatToBottom)?

Oct 23 2018, 10:09 AM

Oct 4 2018

akulichalexandr committed R154:e443399f8f10: config/appearance: Sort style variants by name (authored by akulichalexandr).
config/appearance: Sort style variants by name
Oct 4 2018, 7:52 PM
akulichalexandr closed D12735: config/appearance: Sort style variants by name.
Oct 4 2018, 7:52 PM · KDE Telepathy
akulichalexandr committed R154:1a0b8f81305d: Show im-user icon for contacts without avatar (authored by akulichalexandr).
Show im-user icon for contacts without avatar
Oct 4 2018, 7:51 PM
akulichalexandr closed D12813: Show im-user icon for contacts without avatar.
Oct 4 2018, 7:51 PM
akulichalexandr added reviewers for D12751: Styles/Renkoo: Extract coloring css from variants: dvratil, poboiko.

A small step toward

Oct 4 2018, 2:24 PM · KDE Telepathy
akulichalexandr added a comment to D12813: Show im-user icon for contacts without avatar.

KPeople contacts model does the same, but we use a different model for group members.

Oct 4 2018, 2:08 PM
akulichalexandr added reviewers for D12813: Show im-user icon for contacts without avatar: davidedmundson, poboiko, dvratil, KDE Telepathy.

Long way from

to

Oct 4 2018, 2:07 PM
akulichalexandr added reviewers for D12735: config/appearance: Sort style variants by name: poboiko, dvratil.
Oct 4 2018, 2:04 PM · KDE Telepathy

May 11 2018

akulichalexandr requested review of D12813: Show im-user icon for contacts without avatar.
May 11 2018, 12:03 AM

May 8 2018

akulichalexandr added a project to D12735: config/appearance: Sort style variants by name: KDE Telepathy.
May 8 2018, 1:10 AM · KDE Telepathy
akulichalexandr added a project to D12751: Styles/Renkoo: Extract coloring css from variants: KDE Telepathy.
May 8 2018, 1:09 AM · KDE Telepathy
akulichalexandr requested review of D12751: Styles/Renkoo: Extract coloring css from variants.
May 8 2018, 1:08 AM · KDE Telepathy

May 7 2018

akulichalexandr added reviewers for D12735: config/appearance: Sort style variants by name: davidedmundson, KDE Telepathy.
May 7 2018, 11:17 AM · KDE Telepathy
akulichalexandr requested review of D12735: config/appearance: Sort style variants by name.
May 7 2018, 11:13 AM · KDE Telepathy

Jan 16 2018

akulichalexandr closed T7499: Fix plasma calendar applet layout as Resolved.
Jan 16 2018, 11:00 AM · Plasma
akulichalexandr committed R242:55efe5ae6357: [Calendar] Adjust the calendar toolbar anchors (authored by akulichalexandr).
[Calendar] Adjust the calendar toolbar anchors
Jan 16 2018, 10:57 AM
akulichalexandr closed D9019: [Calendar] Adjust the calendar toolbar anchors.
Jan 16 2018, 10:57 AM · Frameworks, Plasma

Nov 27 2017

akulichalexandr added a comment to D9019: [Calendar] Adjust the calendar toolbar anchors.

Thanks! It's the little things that make it feel polished :)

Do you have commit access?

Nov 27 2017, 5:42 PM · Frameworks, Plasma
akulichalexandr updated the test plan for D9019: [Calendar] Adjust the calendar toolbar anchors.
Nov 27 2017, 4:06 PM · Frameworks, Plasma
akulichalexandr updated the test plan for D9019: [Calendar] Adjust the calendar toolbar anchors.
Nov 27 2017, 3:43 PM · Frameworks, Plasma
akulichalexandr retitled D9019: [Calendar] Adjust the calendar toolbar anchors from Plasma: Adjust the calendar toolbar layout to [Calendar] Adjust the calendar toolbar anchors.
Nov 27 2017, 3:22 PM · Frameworks, Plasma
akulichalexandr updated the diff for D9019: [Calendar] Adjust the calendar toolbar anchors.

Updating D9019: Plasma: Adjust the calendar toolbar layout

Nov 27 2017, 3:16 PM · Frameworks, Plasma
akulichalexandr added a task to D9019: [Calendar] Adjust the calendar toolbar anchors: T7499: Fix plasma calendar applet layout.
Nov 27 2017, 3:03 PM · Frameworks, Plasma
akulichalexandr added a revision to T7499: Fix plasma calendar applet layout: D9019: [Calendar] Adjust the calendar toolbar anchors.
Nov 27 2017, 3:03 PM · Plasma
akulichalexandr created D9019: [Calendar] Adjust the calendar toolbar anchors.
Nov 27 2017, 3:03 PM · Frameworks, Plasma
akulichalexandr created T7499: Fix plasma calendar applet layout.
Nov 27 2017, 2:52 PM · Plasma

Aug 24 2017

akulichalexandr added inline comments to D7352: Import upstream changes to TpQtMacros.cmake.
Aug 24 2017, 10:22 AM · KDE Telepathy
akulichalexandr added inline comments to D7352: Import upstream changes to TpQtMacros.cmake.
Aug 24 2017, 10:20 AM · KDE Telepathy