Port pykig to python 3
ClosedPublic

Authored by arojas on Dec 14 2019, 10:31 AM.

Details

Reviewers
yurchor
Group Reviewers
KDE Edu
Commits
R331:d72f33a14c22: Port pykig to python 3
Summary

Not backwards compatible with python2, but I don't think that's worth it since it will be EOL in a matter of days.

Test Plan

Tested some scripts from http://ftp.dmf.unicatt.it/~paolini/kig/pykig/examples/, some work, the ones that don't also didn't work before the patch.

Diff Detail

Repository
R331 Kig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Dec 14 2019, 10:31 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 14 2019, 10:31 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
arojas requested review of this revision.Dec 14 2019, 10:31 AM

Thanks. Can you change the shebang to #!/usr/bin/env python3 as well?

pykig/pykig.py
808

Why is this commented out?

arojas updated this revision to Diff 71505.Dec 14 2019, 12:12 PM

Update shebang, fix typo

arojas marked an inline comment as done.Dec 14 2019, 12:12 PM
arojas added inline comments.
pykig/pykig.py
808

Unintended, I probably pressed CTRL+D instead of CTRL+C

yurchor accepted this revision.Dec 14 2019, 12:44 PM
This revision is now accepted and ready to land.Dec 14 2019, 12:44 PM
This revision was automatically updated to reflect the committed changes.
arojas marked an inline comment as done.