Thanks for that, works for me!

In D26050#583007, @ognarb wrote:

In D26050#582981, @asturmlechner wrote:

In D26050#578862, @anthonyfieroni wrote:

Maybe we can drop 62, but not 72.

If this is for master I don't see why we could keep anything pre-0.79. Distros already have to patch the hell out of 3.1.0 which has led to diverging code because several changes are conflicting. That one needs a point release to settle that.

And meanwhile master needs a fix for 0.83 too.

What about releasing Calligra as a part of the Release Service (a release every 4 months with some Bugfix release between)? The latest release was almost 2 years ago, and we have more than 500 commits in master.

In D26050#578862, @anthonyfieroni wrote:

Maybe we can drop 62, but not 72.

If this is acceptable I would not limit it to !LINUX; minimum dependencies may as well be desirable for those users.

What do we do here then going further, am I supposed to apply a downstream patch for konsole 19.12.x?

Is it really necessary to split KF5 dependencies in two parts here? I don't see this being done anywhere else, KF5_MIN_VERSION is always global. Likewise, the Qt5 line change is simply unnecessary.

That fix is already in master: https://phabricator.kde.org/R375:90ebe8e37b8699ef26c10fb2928cf673cad04a06

In D24805#550880, @hiangel wrote:

Do you have an example where having ccache on by default would cause a problem? When I asked what makes Konsole different from Mesa, libinput, etc, I was expecting to see an example.

ccache is nothing new, you can imagine it will be a hot topic on a source-based distribution, so we have years of experience with it. Issues are mostly sandbox violations as are typically used for packaging builds, but also build errors, so much that on bug reports it is regularly demanded to rebuild without ccache.

In D24805#550829, @hiangel wrote:

E.g. recently I created this task.

In D24805#550829, @hiangel wrote:

And packaging is disabling it.

Ok, so, I think there's some confusion between us. You're talking about "packaging" however here you want to make a commit into Konsole sources, i.e. to have influence on both packaging and building.

In D24805#550813, @hiangel wrote:

Basically, any Meson-based project has ccache autodetection.

In D24805#550794, @hiangel wrote:

ccache should never be enabled by default for packaging builds.

Why?

In D22210#547637, @davidedmundson wrote:

1. A period where both X and wayland say "Plasma".
   
   1 is super super bad. Which means we need to patch one of the Plasma entries first. I would block this happening.

It is the status quo for everyone using a DM other than SDDM on <unaware-distro>, so any decision here is going to be an improvement.

Switch back to Plasma (Wayland)

In D22210#547621, @ngraham wrote:

"Plasma on Xorg" is a yucky string to display to users.

well, it is what Gnome apparently does, so at least it would have lead to some uniformity. But no strong opinion here.

In D22210#547621, @ngraham wrote:

IMO it would be preferable to display "Plasma on Wayland (Wayland) for a limited period of time while the Plasma and SDDM versions aren't yet aligned.

...except I wasn't sure if you could call Plasma running "on" Wayland in the same sense as it is running "on" Xorg.

copy that for Gentoo.

Use deprecated variables as fallback if defined

works for me, calligraplan builds fine after this change!

In D23202#513068, @vkrause wrote:

see https://cgit.kde.org/kcalcore.git/tree/src/CMakeLists.txt#n138 - seems to work here

In D23202#513056, @vkrause wrote:

This isn't wrong, but I'm surprised it's needed, we explicitly install headers in the old location too, for compatibility?

drop translations, rename to 'Plasma on Xorg'

FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 'Gnome' for the wayland session).

I'll have to do this downstream, anyway...

update README.md

Okay then... I do have commit access, fyi.

In D22164#492330, @sitter wrote:

Currently debating throwing out Qt4 altogether.

Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with:

• Plasma
• Plasma (Wayland)

As a distro packager, in no way would I already build this one without explicitly setting the option already. Of course, it should end up in the changelog.

In D19011#480868, @ngraham wrote:

and we should lobby distros to ship with the new repo/package.

This should probably also be posted on release-team ML.

Drop X11 cruft as well

At least with ICU 63 there is no problem with the change, I can't test with older versions. The same thing had to be also done for xmlsec, for reference: https://github.com/lsh123/xmlsec/pull/249

In D21148#464674, @ngraham wrote:

Does this break anything for the older exiv releases?

I guess this can be closed?