Bump version of KPeople
AcceptedPublic

Authored by sredman on Sat, Nov 9, 5:21 AM.

Details

Reviewers
apol
Summary

Recent version of KPeople (5.62) added editable contacts. KPeopleVCard no longer compiles because of missing header definitions.

Test Plan

Before:

Compile - Compile with <5.62 -> Build fails -> Be sad

After:

Compile with <5.62 -> CMake tells you to get a newer version

Compile with >=5.62 -> Build succeeds -> Be happy

Diff Detail

Repository
R732 KPeople VCard Support
Branch
version-bump
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18645
Build 18663: arc lint + arc unit
sredman requested review of this revision.Sat, Nov 9, 5:21 AM
sredman created this revision.
sredman updated this revision to Diff 69497.Sat, Nov 9, 5:38 AM

Change version to 5.62 since that is the version bump after Aleix's changes to add editable contacts

sredman added a reviewer: apol.Sat, Nov 9, 5:42 AM
This revision is now accepted and ready to land.Sat, Nov 9, 11:22 AM

Is it really necessary to split KF5 dependencies in two parts here? I don't see this being done anywhere else, KF5_MIN_VERSION is always global. Likewise, the Qt5 line change is simply unnecessary.

Is it really necessary to split KF5 dependencies in two parts here? I don't see this being done anywhere else, KF5_MIN_VERSION is always global.

You tell me. It's very useful in my case because my distro has only KFrameworks v5.61 so I have to bend over to even install KPeople v5.62 but if you don't like having separate dependency lines that's easy enough to change back.

Likewise, the Qt5 line change is simply unnecessary.

It's not necessary, but it results in "REQUIRED" "COMPONENTS" and the first library name lining up across all three lines.

sredman edited the summary of this revision. (Show Details)Sat, Nov 9, 5:53 PM
sredman edited the test plan for this revision. (Show Details)
apol added a comment.Mon, Nov 11, 9:09 PM

Okay, makes sense to me

CMakeLists.txt
20

I don't understand why you added a new space there.

In D25228#561319, @apol wrote:

Okay, makes sense to me

What do you want me to do? Your message does not line up with your code comment.

CMakeLists.txt
20

It's not necessary, but it results in "REQUIRED" "COMPONENTS" and the first library name lining up across all three lines.