In D21312#468223, @cfeck wrote:We disabled this feature because KDiskFreeSpaceInfo caused hangs for offline network mounts. Has this changed?
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
May 22 2019
May 22 2019
Zren added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
Zren updated the diff for D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
Use KColorScheme's NegativeText color
Zren added a comment to D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
In D21312#467721, @ndavis wrote:Can you use the NegativeText color from the colorscheme instead of a custom danger color?
May 20 2019
May 20 2019
Zren updated the summary of D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
Zren requested review of D21312: [Places] Draw 2px rectangle disk capacity bar underneath mount points.
I've personally abandoned attempts to merge KIO's Places view in Dolphin for now. Upstreaming those features to KIO is good code practice in the long term though. I've copied the existing KFilePlacesView from KIO and embeded them in this dolphin branch for easy development:
Mar 17 2019
Mar 17 2019
Another option I believe is to keep the <style> tag but add the id="current-color-scheme" type="text/css" attributes. I assume the only difference is plasma replaces the contents of the existing style tag instead of creating a new one, though I'm not sure where the code inserts it.
Mar 6 2019
Mar 6 2019
After a deeper look into this:
Mar 5 2019
Mar 5 2019
Zren added a comment to D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*.
Was skimming the Plasma Scripting API today for something else and found where I saw the "update scripts" before:
Here's a quick and dirty proof of concept. Selecting a place works, but I still need to bind:
Feb 28 2019
Feb 28 2019
Zren added inline comments to D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox.
Feb 25 2019
Feb 25 2019
Merge branch 'Plasma/5.15'
Merge branch 'Plasma/5.12' into Plasma/5.15
Feb 24 2019
Feb 24 2019
Zren committed R120:58e6cc6e119f: [weather] envcan: Fix typo in lowercase icon lookup string (authored by Zren).
[weather] envcan: Fix typo in lowercase icon lookup string
Feb 22 2019
Feb 22 2019
Zren added inline comments to D19194: Adjust date string height to match time string with vertical panel.
Zren added a comment to D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox.
i18n("Use locale default") should be in the middle (currentIndex=1). 12h should be currentIndex=0, and 24h should be currentIndex=2
Feb 19 2019
Feb 19 2019
Zren requested review of D19174: [weather] envcan: Document urls for example data + list all warnings.
Zren added a comment to T10402: Find a way to remove the Desktop Toolbox in its current form (i.e. a hamburger menu button in the corner of the screen).
without needing to right-click
Feb 15 2019
Feb 15 2019
Shoot, I accidentally forgot the Phab Rev link in the commit message (though I remembered the bugzilla tags). I've setup a .git/hook/prepare-commit-msg -like thing for Sublime Text to prevent this happening in the future.
Merge branch 'Plasma/5.15'
Zren committed R120:006c4f5f9ee8: [Digital Clock] Fix 24h tri-state button broken in port to QQC2 (authored by Zren).
[Digital Clock] Fix 24h tri-state button broken in port to QQC2
Feb 14 2019
Feb 14 2019
Feb 12 2019
Feb 12 2019
Zren added a comment to D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*.
In D18961#410792, @kossebau wrote:we no longer have to install the widget to .../share/plasma/plasmoids/
No experience here, but do we not still need to install the QML extension plugins to have the applet working? Or is there some mechanism to load them also from the build dir now?
Zren requested review of D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*.
Merge branch 'Plasma/5.15'
Merge branch 'Plasma/5.14' into Plasma/5.15
[weather] Center align the warning heading
Merge branch 'Plasma/5.14' into Plasma/5.15
Merge branch 'Plasma/5.12' into Plasma/5.14
[weather] Fix weather Notices tab not showing
Ah, NoticesView.qml in Plasma 5.12 was slightly different.
Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future.
Feb 11 2019
Feb 11 2019
Add Layout.alignment: Qt.AlignHCenter to the PlasmaExtras.Heading
I just noticed that the "Warnings Issued" text is left aligned. Might as well center align it while we're at it.
Feb 9 2019
Feb 9 2019
Zren added a comment to T10464: Move "KWin Switching Layouts" designed for KWin 4.x to it's own category.
In T10464#175733, @broulik wrote:Can we also make KWin smarter and try to fall back to the default theme (which may also be broken, sure, but because of distro not GHNS)?
Feb 5 2019
Feb 5 2019
Jan 18 2019
Jan 18 2019
Zren committed R114:80bd32b12a01: Consistent arrow key handling in the Informative Alt+Tab skin (authored by Zren).
Consistent arrow key handling in the Informative Alt+Tab skin
I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works.
Zren updated the test plan for D16093: Consistent arrow key handling in the Informative Alt+Tab skin.
Jan 14 2019
Jan 14 2019
There was a few +1s, but I wasn't exactly sure who specifically "approves" this for a merge to plasma-workspace or digital-clock specifically. My bad, I shouldn't of left this feature to the last minute and felt rushed to get it in. I'll try to avoid the time before the betas when submitting in the future.
Zren committed R120:235fa8107dab: [Digital Clock] Add ability to set a custom date format string (authored by Zren).
[Digital Clock] Add ability to set a custom date format string
Jan 12 2019
Jan 12 2019
Looking at the alternative patch, I've renamed the config key variable to customDateFormat. Most of the differences stem from not using a "variant" data type for DigitalClock.qml's dateFormat variable. The string formatDate(datetime date, variant format) (qt doc link) accepts a variant type.
- Rename config key from dateFormatStr and config TextField dateFormatTextField to customDateFormat.
- Remove the "Color Format Documentation" link.
Jan 10 2019
Jan 10 2019
Zren requested review of D18168: [WIP] [Digital Clock] Embed date formatting variable documentation.
Translate the "Time Format Documentation" link.
Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated).
Place the 2 links below the text field.
The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a plasmoid.globalConfiguration.dateFormatStr API which all widget instances (on all panels/screens) were bound to, so the user only had to configure it once for all screens. Though a person might have a clock on a vertical panel on one screen, and a thin horizontal panel on the other that might require a different configuration. That's an edge case example though.
Jan 8 2019
Jan 8 2019
In D18019#388829, @ndavis wrote:Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget?
In D18019#388811, @ndavis wrote:I'm leaning towards no, but a second link to text formatting documentation might be a good idea.
Zren added inline comments to D18019: [Digital Clock] Add ability to set a custom date format string.
In D18018#387920, @davidedmundson wrote:Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide?
Jan 6 2019
Jan 6 2019
Jan 3 2019
Jan 3 2019
[Calendar] Expose firstDayOfWeek in MonthView
Jan 2 2019
Jan 2 2019
That still requires the user to drag a button, which isn't exactly obvious or a normal behaviour, just to discover what it is. It doesn't look like a desktop widget, not that the user would recognize it as one, as KDE by default does not display any desktop widgets the user can compare it with.
Nov 28 2018
Nov 28 2018
Zren added inline comments to D8388: Do not hardcode unhovered windows brightness on present windows effect.
Nov 22 2018
Nov 22 2018
Just got an owner email with the project name! Thanks ronald.
Nov 16 2018
Nov 16 2018
Nov 8 2018
Nov 8 2018
Nov 6 2018
Nov 6 2018
Oh awesome. This code seems much easier to read than D15720.
Nov 5 2018
Nov 5 2018
We're currently trying to draw the C++ Breeze/forks window decorations in T9899 (and https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs obsolete. However we can merge these in the short term until that code is ready.
Oct 30 2018
Oct 30 2018
Merge branch 'Plasma/5.14'
Merge branch 'Plasma/5.12' into Plasma/5.14
Zren committed R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app (authored by Zren).
[cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app
Oct 29 2018
Oct 29 2018
So adding this shooooould work... but doesn't.
In D16516#350641, @ngraham wrote:YES
Zren committed R118:542388f984cf: [cuttlefish] Auto-focus on search textfield when app opens (authored by Zren).
[cuttlefish] Auto-focus on search textfield when app opens
Oct 24 2018
Oct 24 2018
Update libdbusmenuqt folder
Hide Buttons With Empty Text (Gtk Separators)
For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on.
Oct 23 2018
Oct 23 2018
Oct 20 2018
Oct 20 2018
KNotifications provides an example of linking to dbusmenu-qt5:
https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49
Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the /usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2, but I wanted to update all the common code first before making major refactoring.
Oct 19 2018
Oct 19 2018
Zren requested review of D16329: Add a ReadMe with install from Git instructions and bugzilla links.
- Application Launcher (Kickoff) is the KDE default menu with the tabbed interface.
- Application Menu (Kicker) is the Windows 95 styled menu.
- Application Dashboard (KickerDash) reuses the Kicker source code, but uses DashboardRepresentation.qml as the entry point instead of main.qml. KickerDash's metadata.desktop file is in the kdeplasma-addons repo. Effectively, everything is in the plasma-desktop repo though as that one .desktop file is the only thing outside it.
Oct 10 2018
Oct 10 2018
Sorry, just merged both to master. Thanks davidedmundson for the patches that updated the ComboBox.
Zren committed R119:347f43c42b70: Add "Get Wallpaper Plugins..." button to Config Desktop dialog (authored by Zren).
Add "Get Wallpaper Plugins..." button to Config Desktop dialog
Zren committed R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to open GHNS dialog (authored by Zren).
Add wallpaperplugin.knsrc + QML function to open GHNS dialog
Oct 8 2018
Oct 8 2018
I need to try patching plasma-framework's dialog.cpp and see if that introduces issues. Right now it's mainItem->setParentItem(contentItem());, and I need to test if mainItem->setParent(contentItem()); breaks anything. I haven't patched C++ in frameworks before so I'll need to figure that out.