[cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app
ClosedPublic

Authored by Zren on Mon, Oct 29, 11:57 PM.

Details

Summary

QML Shortcut requires Qt 5.5, so we bumped QtQuick to 2.5.

https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html

As discussed in D16516

Test Plan

Tested Ctrl+Q with search text field focused, and after clicking an icon with the grid view item focused. Both attempts exited the app.

Diff Detail

Repository
R118 Plasma SDK
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Zren created this revision.Mon, Oct 29, 11:57 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Oct 29, 11:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Zren requested review of this revision.Mon, Oct 29, 11:57 PM
apol added a subscriber: apol.Tue, Oct 30, 12:59 AM

I know it may not be what you are after, but make a lot of sense to port this to Kirigami, which already has this and a bunch of other stuff.

(Other than that, the patch is okay +1).

ngraham accepted this revision.Tue, Oct 30, 4:44 AM
ngraham added a subscriber: ngraham.

+1 for eventually porting Cuttlefish to Kirigami. +1 for implementing this now with the rest of the code as-is.

Please land this on the Plasma/5.12 branch and merge to Plasma/5.14 and master. Thanks!

This revision is now accepted and ready to land.Tue, Oct 30, 4:44 AM
This revision was automatically updated to reflect the committed changes.