new icons (Breeze style)
AcceptedPublic

Authored by borisg on Oct 1 2018, 8:21 PM.

Details

Reviewers
martinkostolny
broulik
ngraham
Group Reviewers
Plasma
VDG
Summary






Icons are made similar to the Breeze theme icons,
The window magnification and window reduction icons are now different,
the picture on the icons are made transparent.

Test Plan

run AWC
Check that the icons are updated and displayed correctly

Diff Detail

Repository
R884 Active Window Control Applet for Plasma
Lint
Lint Skipped
Unit
Unit Tests Skipped
borisg created this revision.Oct 1 2018, 8:21 PM
Restricted Application added a subscriber: plasma-devel. ยท View Herald TranscriptOct 1 2018, 8:21 PM
borisg requested review of this revision.Oct 1 2018, 8:21 PM
ngraham added a subscriber: ngraham.Oct 1 2018, 8:46 PM

Not being that familiar with this widget, it looks like a reasonable change to me, but it would be great if someone else could do a more in-depth review.

ngraham accepted this revision.Nov 4 2018, 11:05 PM
ngraham added a subscriber: Zren.

Sorry for the extended review time for this! Next time, posting both before and after screenshots might be helpful for people not familiar with the current UI. Anyway, it looks good to me. Let's also see what @Zren says, since he's rapidly becoming the de facto maintainer of this code. :)

This revision is now accepted and ready to land.Nov 4 2018, 11:05 PM
Zren added a comment.Nov 5 2018, 1:54 AM

We're currently trying to draw the C++ Breeze/forks window decorations in T9899 (and https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs obsolete. However we can merge these in the short term until that code is ready.

Oddly enough, the previous SVGs didn't follow the color scheme (nor do the new ones but thats fine).

Breeze (aka default)

Breeze Dark