Feed Advanced Search

May 20 2020

apol committed R838:23194e3bbe29: Port to changes in the protocol (authored by apol).
Port to changes in the protocol
May 20 2020, 6:44 PM

May 19 2020

apol abandoned D29540: plasmawindowmodel: Expose the internal id to the model.

Will move to gitlab

May 19 2020, 3:40 PM · Frameworks
apol updated the diff for D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.

Account for software rotation

May 19 2020, 11:02 AM · KWin

May 18 2020

apol added a comment to D29026: Port from iterators to range-based for.

I guess we're doing it for readability in sacrifice of simplicity or performance which admittedly is probably meaningless here.

May 18 2020, 9:50 PM
apol committed R134:a31beb5c8e55: Hardcode more colorSets (authored by ngraham).
Hardcode more colorSets
May 18 2020, 9:43 PM
apol added a comment to D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.

This is on https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/1 now.

May 18 2020, 5:06 PM · Plasma
apol committed R838:0d2bd657963c: screencasting: Adoption of the org_kde_plasma_video_streaming protocol (authored by apol).
screencasting: Adoption of the org_kde_plasma_video_streaming protocol
May 18 2020, 5:03 PM
apol closed D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.
May 18 2020, 5:03 PM · Plasma
apol committed R134:aa2e32215626: Hardcode fewer colorSets (authored by apol).
Hardcode fewer colorSets
May 18 2020, 4:24 PM
apol closed D29784: Hardcode fewer colorSets.
May 18 2020, 4:24 PM · Plasma
apol added a comment to D29785: Always use Window colorset for AbstractApplicationHeader.

I wonder if this should be specified in ToolBarApplicationHeader instead.

May 18 2020, 1:00 PM · Kirigami
apol added a comment to D29784: Hardcode fewer colorSets.

addressed

May 18 2020, 10:21 AM · Plasma
apol updated the diff for D29784: Hardcode fewer colorSets.

Address comment

May 18 2020, 10:21 AM · Plasma

May 17 2020

apol added inline comments to D29810: Don't use the setenv function after fork.
May 17 2020, 11:18 PM · Frameworks
apol added a comment to T12954: potential improvements for articles of association.

Content

  • 0.3 K Desktop Environment is -> rebranding. Should redefine KDE Software as the software developed by the KDE Community.
  • 0.x Should define "KDE Community" as the projects developed in the KDE infrastructure to serve the end users FOSS needs including its by-products.
  • 2.1 Should rephrase, talking about the software produced by the KDE Community spaces rather than "K Desktop Environment" package.
  • 2.2 Should rephrase free desktop software -> free software for end-users
  • 6. General Assembly -> it assumes it's in person but doesn't specify so. It talks about things like "show of hands" that is clearly awkward to implement on a virtual AGM. Adding something along the lines of the following would make sense:
May 17 2020, 5:42 PM · KDE e.V.
apol accepted D29802: Require out-of-source builds.
May 17 2020, 12:31 PM · Frameworks

May 15 2020

apol requested review of D29784: Hardcode fewer colorSets.
May 15 2020, 4:50 PM · Plasma
apol committed R134:7699258c9301: runservice: port away from deprecated KRun API (authored by apol).
runservice: port away from deprecated KRun API
May 15 2020, 3:47 PM
apol added a comment to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

Patch looks good to me overall.

May 15 2020, 2:15 PM · KWin
apol updated the diff for D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.

Do not allocate a full QRegion on every paint.

May 15 2020, 2:01 PM · KWin
apol updated the diff for D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.

Make sure the rects are always in the right coordinate space and properly scaled

May 15 2020, 11:00 AM · KWin
apol committed R108:da81b0f86c8f: Improve opengl debug messages (authored by apol).
Improve opengl debug messages
May 15 2020, 10:28 AM
apol closed D29684: Improve opengl debug messages.
May 15 2020, 10:28 AM · KWin
apol committed R108:1b7fd0db3ffd: Properly include private Qt5 targets (authored by apol).
Properly include private Qt5 targets
May 15 2020, 10:26 AM
apol closed D29763: Properly include private Qt5 targets.
May 15 2020, 10:26 AM · KWin

May 14 2020

apol added a comment to D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.


pinebook pro with 2x

May 14 2020, 11:46 PM · KWin
apol updated the diff for D27788: Implement EGL_KHR_partial_update and EGL_EXT_swap_buffers_with_damage.

Address scaling

May 14 2020, 11:43 PM · KWin
apol requested review of D29763: Properly include private Qt5 targets.
May 14 2020, 6:41 PM · KWin
apol updated the diff for D29684: Improve opengl debug messages.

As suggested by zzag

May 14 2020, 6:30 PM · KWin
apol updated the diff for D29684: Improve opengl debug messages.

we were landing on \0 so we never reached \n

May 14 2020, 4:17 PM · KWin
apol updated the diff for D29015: Move screencasting to KWin.

Rebase

May 14 2020, 4:02 PM · KWin
apol committed R108:5b5a9957a5e3: Fix TestXdgShellClient::testDesktopFileName (authored by apol).
Fix TestXdgShellClient::testDesktopFileName
May 14 2020, 3:25 PM
apol closed D29758: Fix TestXdgShellClient::testDesktopFileName.
May 14 2020, 3:25 PM · KWin
apol closed D29759: wayland_server: Improve debug message, reduce duplicates.
May 14 2020, 3:25 PM · KWin
apol committed R108:d6e119f49eae: wayland_server: Improve debug message, reduce duplicates (authored by apol).
wayland_server: Improve debug message, reduce duplicates
May 14 2020, 3:25 PM
apol requested review of D29759: wayland_server: Improve debug message, reduce duplicates.
May 14 2020, 3:21 PM · KWin
apol accepted D29757: Only search for Qt5::Test inside the autotests dir.
May 14 2020, 3:11 PM · Plasma
apol requested review of D29758: Fix TestXdgShellClient::testDesktopFileName.
May 14 2020, 2:50 PM · KWin
apol added a comment to D29751: KWIN_DISABLE_SHORTCUTS: allow disabling registering kwin shortcuts.

An example is flatpak apps don't run because they can't find the portals dbus service which doesn't restart because it's running in the actual dbus instance.

May 14 2020, 2:45 PM · KWin
apol accepted D29753: Only build autotests when enabled.
May 14 2020, 2:18 PM · Plasma
apol abandoned D29751: KWIN_DISABLE_SHORTCUTS: allow disabling registering kwin shortcuts.

I don't do it because it's harder to set up the IDE to have a wrapper. I'll address it in KDevelop.

May 14 2020, 1:57 PM · KWin
apol requested review of D29751: KWIN_DISABLE_SHORTCUTS: allow disabling registering kwin shortcuts.
May 14 2020, 1:50 PM · KWin
apol accepted D29745: look for kded as runtime dep.
May 14 2020, 1:46 PM · Frameworks
apol committed R108:7ea7aa1ee901: Fix org.telegram.desktop identification (authored by apol).
Fix org.telegram.desktop identification
May 14 2020, 10:53 AM
apol closed D29728: Fix org.telegram.desktop identification.
May 14 2020, 10:53 AM · KWin

May 13 2020

apol requested review of D29728: Fix org.telegram.desktop identification.
May 13 2020, 5:54 PM · KWin
apol accepted D29709: Give all OverlaySheets consistent headers.
May 13 2020, 1:43 PM · Plasma
apol added a comment to D29709: Give all OverlaySheets consistent headers.

+1 for the change btw, thanks!

May 13 2020, 1:38 PM · Plasma
apol added a comment to D29709: Give all OverlaySheets consistent headers.

We are in string freeze right now, aren't we?

May 13 2020, 1:38 PM · Plasma
apol accepted D29705: Correctly align natural layout in present windows.

The change is sound but the code looks terrible.

May 13 2020, 12:33 PM · KWin

May 12 2020

apol added a comment to D29684: Improve opengl debug messages.

I'm expecting QDebug would handle it, I don't see why opengl would be giving us an empty debug message though.

May 12 2020, 5:52 PM · KWin
apol requested review of D29684: Improve opengl debug messages.
May 12 2020, 5:05 PM · KWin
apol requested review of D29683: screenshot: use QImage to decode the received screenshot image.
May 12 2020, 5:04 PM · KWin
apol updated the diff for D29015: Move screencasting to KWin.

Add missing file, fix rendering of some surfaces

May 12 2020, 4:51 PM · KWin
apol updated the title for P597 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
May 12 2020, 4:29 PM
apol added a comment to T4449: [kwayland] Clipboard Manager protocol.

I wouldn't have a big problem with merging as is, it could make sense to have QFuture<QVariant> retrieveData as is. It would make it easier to time out when a client is being shitty and would allow to parallelize different queries.

May 12 2020, 3:11 PM · Plasma on Wayland
apol updated the diff for D29015: Move screencasting to KWin.

Support for window streaming

May 12 2020, 11:35 AM · KWin
apol accepted D29672: Follow scale of drag surfaces.
May 12 2020, 11:14 AM · KWin
apol accepted D29675: initialize bools to false by default.
May 12 2020, 11:13 AM · Plasma
apol committed R857:9164077cd9be: [android] Allow building local sources with build-cmake-native (authored by nicolasfella).
[android] Allow building local sources with build-cmake-native
May 12 2020, 11:02 AM
apol committed R857:7ba069a8bb6f: [android] Rewrite get-apk-args (authored by nicolasfella).
[android] Rewrite get-apk-args
May 12 2020, 10:57 AM

May 11 2020

apol accepted D29631: [android] Allow specifying APK install location.
May 11 2020, 3:31 PM · Build System, Frameworks
apol accepted D29632: [kcms/keys] Use better collator settings.

It could make sense to leverage QCollatorSortKey in this class if it's sorting often.

May 11 2020, 3:01 PM · Plasma
apol accepted D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT.
May 11 2020, 2:11 PM · Frameworks
apol added a comment to D29631: [android] Allow specifying APK install location.

+1 overall, good idea.

May 11 2020, 1:41 PM · Build System, Frameworks
apol added inline comments to D29631: [android] Allow specifying APK install location.
May 11 2020, 1:41 PM · Build System, Frameworks
apol accepted D29618: Fix case fallback warning.
May 11 2020, 10:19 AM · Plasma
apol accepted D29619: Improve StatusNotifierTest.
May 11 2020, 10:18 AM · Plasma

May 10 2020

apol accepted D29520: Merge setting up abstractclient and x11client connections in EffectsHandler.

Good catch

May 10 2020, 5:36 PM · KWin
apol added a comment to D29511: Label: Add ping-pong logic.

I feel like this could break Labels unknowingly. Maybe it would make sense to have an extra scrollToFit (?) property or even another separate component to do that.

May 10 2020, 5:22 PM · Frameworks
apol added a comment to D29523: [wayland] Place lockscreen greeter above other windows.
In D29523#666095, @zzag wrote:

@davidedmundson Should I abandon D29519?

May 10 2020, 3:44 PM · KWin
apol accepted D29522: Store normal clients and desktop clients in the same list.

Looks good to me. Maybe to merge after branching?

May 10 2020, 3:42 PM · KWin
apol updated the task description for T12320: guidelines for supporting initiatives.
May 10 2020, 1:30 PM · KDE e.V.

May 8 2020

apol updated the diff for D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.

Adapt to changes in the protocol, implement windows

May 8 2020, 6:00 PM · Plasma
apol added a comment to D28882: Create protocol to manage video feeds.

Moving to kwayland-server

May 8 2020, 5:34 PM · Frameworks
apol abandoned D28882: Create protocol to manage video feeds.
May 8 2020, 5:34 PM · Frameworks
apol requested review of D29540: plasmawindowmodel: Expose the internal id to the model.
May 8 2020, 5:31 PM · Frameworks

May 6 2020

apol added a comment to D29476: WIP: Port klipper to use wayland clipboard.

+1

May 6 2020, 12:54 PM · Plasma
apol added a comment to D29476: WIP: Port klipper to use wayland clipboard.

Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard?

May 6 2020, 12:48 PM · Plasma
apol accepted D29472: Drop Workspace::sendPingToWindow().
May 6 2020, 10:44 AM · KWin

May 5 2020

apol committed R993:0dfcfcdf7678: update kdeconnect android pipeline to capture APK with short commit ID (authored by brute4s99).
update kdeconnect android pipeline to capture APK with short commit ID
May 5 2020, 11:31 PM
apol added inline comments to D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error.
May 5 2020, 1:44 PM · Frameworks
apol added a comment to D29437: Use font: instead of font.pointSize: where possible.

You can do that now but this behaviour is deprecated and disallowed in Qt 6 AFAIK.

May 5 2020, 12:56 PM · Plasma

May 4 2020

apol updated the diff for D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol.

Rebase on top of kwayland-server changes

May 4 2020, 5:29 PM · Plasma
apol added a comment to D29406: Add X-KDE-Original-Executable to Applications properties.

If I understand correctly, it is necessary to use dbus spectacle in this case, so that dbus can manage the application instance and make sure we end up with only one, whether we launch the app, use a shortcut or launch from command line.

May 4 2020, 3:05 PM · Frameworks
apol added a comment to D29405: [PoC] Make notifications work without a notifyrc file.

What's the advantage?
Won't this make it harder to put together the notifications kcm?

May 4 2020, 1:55 PM · Frameworks
apol added inline comments to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.
May 4 2020, 1:54 PM · KWin
apol added a comment to D29406: Add X-KDE-Original-Executable to Applications properties.

This should be documented somewhere, as is it's really confusing.

May 4 2020, 1:27 PM · Frameworks
apol accepted D29396: Suppress find_package_handle_standard_args package name mismatch warning..

This will make our configure steps readable again. Thanks!

May 4 2020, 2:20 AM · Build System, Frameworks

May 3 2020

apol added a comment to T10034: Attract existing FLOSS software projects to KDE and incorporate their members into our community.

Hi @kkremitzki, it's good to see FreeCad interested! What do you have in mind?

May 3 2020, 11:32 PM · KDE Promo
apol added a comment to T13079: Make runner KCMs easier to extend.

Wouldn't it be better to support different languages on the KCM through QML+KPackage?

May 3 2020, 11:21 PM
apol added a comment to D29201: KCMUtils: Add option to append service file to list of arguments.

I have the feeling there's a missing piece here.

May 3 2020, 11:20 PM · Frameworks
apol accepted D29356: [applets/systemtray] Fix value read in some onXyxChanged connections.
May 3 2020, 2:48 PM · Plasma
apol accepted D29361: KCrash: remove debug output which breaks unittests from using ~/.qttest/config for categorized logging.
May 3 2020, 2:47 PM · Frameworks

May 1 2020

apol added inline comments to D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added.
May 1 2020, 11:36 PM · Plasma
apol accepted D29337: drop unused headers.
May 1 2020, 2:47 PM · KWin
apol accepted D29334: Update metainfo.yaml.
May 1 2020, 2:29 PM
apol accepted D29331: Update metainfo.yaml.
May 1 2020, 2:28 PM
apol committed R120:4c767ab70005: Address Connections syntax warnings on the systray plasmoid (authored by apol).
Address Connections syntax warnings on the systray plasmoid
May 1 2020, 2:23 PM
apol closed D29150: Address Connections syntax warnings on the systray plasmoid.
May 1 2020, 2:23 PM · Plasma