Always use Window colorset for AbstractApplicationHeader
ClosedPublic

Authored by ngraham on Fri, May 15, 5:40 PM.

Details

Summary

...Otherwise when an AbstractApplicationHeader is used on a page that
overrides the color set, such as ScrollablePage, the header color is
inappropriately set to the view BG color.

BUG: 421573
CCBUG: 421571
FIXED-IN: 5.71

Test Plan

List view of Cards and Grid view of Cards in Kirigami gallery look
correct now:

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Fri, May 15, 5:40 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFri, May 15, 5:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Fri, May 15, 5:40 PM
ngraham edited the summary of this revision. (Show Details)Fri, May 15, 5:47 PM
apol added a subscriber: apol.Mon, May 18, 1:00 PM

I wonder if this should be specified in ToolBarApplicationHeader instead.

Not all of the headers use toolbars, but I thought the idea was for them all to use a consistent base appearance? @mart?

mart accepted this revision.Mon, May 18, 1:17 PM
This revision is now accepted and ready to land.Mon, May 18, 1:17 PM
This revision was automatically updated to reflect the committed changes.