Prevent showing outlines of notifications when the screen is locked
AbandonedPublic
Actions

Authored by zzag on May 8 2020, 6:31 AM.

Details

Reviewers

None

Group Reviewers

Summary

When the screen is locked, all visible windows are passed through the
effects system, but only the lockscreen greeter window is going to be
painted. Thus, we need to disable effects such background contrast or
blur that alter background behind notification windows.

BUG: 420802

Diff Detail

Repository

R108 KWin

Branch

screenlock-notification-outlines

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26535
Build 26553: arc lint + arc unit

zzag created this revision.May 8 2020, 6:31 AM

Restricted Application added a project: KWin. · View Herald TranscriptMay 8 2020, 6:31 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.May 8 2020, 6:31 AM

Harbormaster completed remote builds in B26535: Diff 82239.May 8 2020, 6:31 AM

Shouldn't that take into account stacking order? Or is it because critical is ontop of everything but hidden because the screen is locked that the blur shows up?

In D29519#665964, @broulik wrote:

Or is it because critical is ontop of everything but hidden because the screen is locked that the blur shows up?

That one. Alternatively, we could put the lockscreen window in a layer above NotificationLayer or CriticalNotificationLayer.

D29523 for the stacking order

zzag mentioned this in D29523: [wayland] Place lockscreen greeter above other windows.May 8 2020, 10:42 AM

Abandoned in favor of D29523

zzag abandoned this revision.May 11 2020, 11:24 AM

Revision Contents
Changeset List

			Path	Packages
M			effects/backgroundcontrast/contrast.h (1 line)
M			effects/backgroundcontrast/contrast.cpp (5 lines)
M			effects/blur/blur.h (1 line)
M			effects/blur/blur.cpp (5 lines)

Commit	Tree	Parents	Author	Summary	Date
077df18c189b	193e6d52cad4	d2bfa5f33e31	Vlad Zahorodnii	[effects/contrast] Prevent showing notification outlines when screen is locked (Show More…)	May 8 2020, 6:06 AM
d2bfa5f33e31	c34605be7af6	44143ef7aeb9	Vlad Zahorodnii	[effects/blur] Prevent showing notification outlines when screen is locked (Show More…)	May 8 2020, 5:59 AM