Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
ClosedPublic

Authored by kossebau on May 10 2020, 3:07 PM.

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
fixbuildwithoutdeprecated
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26656
Build 26674: arc lint + arc unit
kossebau created this revision.May 10 2020, 3:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 10 2020, 3:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 10 2020, 3:07 PM

Building all of KF with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT set, so dropping any deprecated API from the build, serves as a small sanity check to see if the future (like KF6) is well prepared and there is no hidden undeprecated functional dependency on deprecated API. Only backward-compatibel functionality should still rely on any deprecated API. Or otherwise the deprecation should be undone possibly.

No oversight over Plasma these days, so cannot tell what parts are still depending on metadata fetched from desktop files via KService. But given such API has been deprecated since KF 5.0 it might be time to complete any missing adaption.
So any changes done here are solely based on "it builds without deprecated API used" :)

apol accepted this revision.May 11 2020, 2:11 PM
This revision is now accepted and ready to land.May 11 2020, 2:11 PM
kossebau closed this revision.May 24 2020, 2:05 PM