Differential D29632

[kcms/keys] Use better collator settings
ClosedPublic
Actions

Authored by davidre on May 11 2020, 1:33 PM.

Details

Reviewers
ognarb
broulik
apol
Group Reviewers
Plasma
Commits
R119:847d9216e0c1: [kcms/keys] Use better collator settings

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.May 11 2020, 1:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 11 2020, 1:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidre requested review of this revision.May 11 2020, 1:33 PM
davidre retitled this revision from Use better collator settings to [kcms/keys] Use better collator settings.May 11 2020, 1:34 PM
apol accepted this revision.May 11 2020, 3:01 PM
apol added a subscriber: apol.

It could make sense to leverage QCollatorSortKey in this class if it's sorting often.

This revision is now accepted and ready to land.May 11 2020, 3:01 PM
broulik added inline comments.May 11 2020, 3:04 PM
kcms/keys/shortcutsmodel.cpp
89

Why no numeric mode here?

davidre added inline comments.May 11 2020, 3:06 PM
kcms/keys/shortcutsmodel.cpp
89

We typically don't have apps with numbers but I can also add it?

broulik added inline comments.May 11 2020, 4:20 PM
kcms/keys/shortcutsmodel.cpp
89

Ah, this is for apps, but yeah, why not...

Closed by commit R119:847d9216e0c1: [kcms/keys] Use better collator settings (authored by davidre). · Explain WhyMay 12 2020, 7:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcms/keys/shortcutsmodel.cpp (6 lines)

Diff 82626

View Options

kcms/keys/shortcutsmodel.cpp

Loading...