Differential D29476

WIP: Port klipper to use wayland clipboard
AbandonedPublic
Actions

Authored by davidedmundson on May 6 2020, 10:26 AM.

Details

Reviewers

None

Group Reviewers

KWin

Commits

R120:409a710ce8b2: WIP: Port klipper to use wayland clipboard

Summary

Wayland has an entire new protocol for getting and setting clipboard
when we don't have focus. Unfortunately this means reinventing
QClipboard from the QPA.

Not mergable as-is, especially the hardcoded line in CMakeLists but
uploaded to show direction.

It uses the newly agreed approach of using QtWayland generated classes
in clients directly rather than writing full pimpl API-fixed wrappers first,
as ultimately that didn't really help do anything.

Code is written so that it can be moved to KWindowSystem if needed by
KDEConnect or others.

Test Plan

Copying and pasting all over the place

Diff Detail

Repository

R120 Plasma Workspace

Branch

davidedmundson/clipboard2

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26774
Build 26792: arc lint + arc unit

davidedmundson created this revision.May 6 2020, 10:26 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2020, 10:26 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

davidedmundson requested review of this revision.May 6 2020, 10:26 AM

Harbormaster completed remote builds in B26432: Diff 82074.May 6 2020, 10:26 AM

+1 in general.

Not mergable as-is, especially the hardcoded line in CMakeLists but uploaded to show direction.

Heh, it seems like we now have a good reason to upstream FindWaylandProtocols.cmake from KWayland to extra-cmake-modules. :-)

Edit: oh, the protocol spec file comes from ~~plasma-wayland-protocols~~kwayland-server. Never mind.

Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard?

In D29476#664751, @nicolasfella wrote:

Isn't this something that should be in QClipboard in an ideal world? Or is that currently not feasible since the protocol is non-standard?

It's more that only few processes should be able to monitor the clipboard.
We'll need some of that code for kdeconnect-kde though, in case that's why you're asking.

klipper/systemclipboard.cpp
63 ↗	(On Diff #82074)	Maybe split the DataControl classes into a separate file?
klipper/systemclipboard.h
45 ↗	(On Diff #82074)	I'd call it QtClipboard or GenericClipboard. There's nothing X-specific there.

Fix the klipper code to handle detecting null buffer better
X code expected a valid QMimeData object with no contents

Harbormaster completed remote builds in B26447: Diff 82106.May 6 2020, 2:27 PM

cblack added a subscriber: cblack.May 6 2020, 2:34 PM

cblack added inline comments.

klipper/systemclipboard.cpp
61 ↗	(On Diff #82106)	Is there a reason this `#include` is all the way down here instead of at the top of the file?

ngraham added a subscriber: ngraham.May 7 2020, 1:57 AM

ngraham added inline comments.

klipper/CMakeLists.txt
16	I don't seem to have your home directory on my system :)

ngraham added inline comments.May 7 2020, 2:31 AM

klipper/CMakeLists.txt
16	Never mind :)

shuffle files about

Harbormaster completed remote builds in B26774: Diff 82650.May 12 2020, 11:51 AM

Moving to invent

Revision Contents
Changeset List

		Path
M		klipper/CMakeLists.txt (8 lines)
M		klipper/klipper.h (3 lines)
M		klipper/klipper.cpp (7 lines)
A	M	klipper/systemclipboard/CMakeLists.txt (23 lines)
A	M	klipper/systemclipboard/qtclipboard.h (31 lines)
A	M	klipper/systemclipboard/qtclipboard.cpp (44 lines)
A	M	klipper/systemclipboard/systemclipboard.h (60 lines)
A	M	klipper/systemclipboard/systemclipboard.cpp (48 lines)
A	M	klipper/systemclipboard/waylandclipboard.h (37 lines)
A	M	klipper/systemclipboard/waylandclipboard.cpp (285 lines)
A	M	klipper/tests/CMakeLists.txt (5 lines)
A	M	klipper/tests/paste.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82074	60aad46		May 6 2020, 10:26 AM	★	★
Diff 2	82106	bf6b835	Fix the klipper code to handle detecting null buffer better	May 6 2020, 2:27 PM	★	★
Diff 3	82650	60aad46	shuffle files about	May 12 2020, 11:51 AM	★	★