Hardcode fewer colorSets
ClosedPublic

Authored by apol on Fri, May 15, 4:50 PM.

Details

Summary

We were overriding them on the background only and it would play weird with the
feature where the toolbar looks the same as the page.

BUG: 421571

Test Plan

Still feels a bit random that it keeps changing but at least it looks consistent.

Diff Detail

Repository
R134 Discover Software Store
Branch
Plasma/5.19
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27013
Build 27031: arc lint + arc unit
apol created this revision.Fri, May 15, 4:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, May 15, 4:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Fri, May 15, 4:50 PM
ngraham requested changes to this revision.Fri, May 15, 5:01 PM
ngraham added a subscriber: ngraham.

Now the tiny toolbar above the sidebar is a different color from the one beside it:

It's appropriate for the views to have the view background color (off-white), but the toolbar is supposed to use the window background color (gray-ish), not the view background color. Why isn't that working?

discover/qml/SourcesPage.qml
27

These should not be needed at all

This revision now requires changes to proceed.Fri, May 15, 5:01 PM

Fixed the Kirigami half of this in D29785. Just address the inline comment and then this is good to go!

ngraham retitled this revision from Hardcode less colorSets to Hardcode fewer colorSets.Fri, May 15, 5:45 PM
apol updated this revision to Diff 83035.Mon, May 18, 10:21 AM
apol marked an inline comment as done.

Address comment

ngraham accepted this revision.Mon, May 18, 1:23 PM
This revision is now accepted and ready to land.Mon, May 18, 1:23 PM
apol closed this revision.Mon, May 18, 4:24 PM