Sometimes Exec entries are replaced by qdbus invocation such as in D19225
Add a property X-KDE-Original-Executable to allow to specify the original Exec path.
Details
- Reviewers
davidedmundson apol bport - Group Reviewers
Frameworks
Diff Detail
- Repository
- R309 KService
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 26322 Build 26340: arc lint + arc unit
This should be documented somewhere, as is it's really confusing.
I'm not sure it wouldn't be better to have spectacle launched again there instead of going through dbus (which is a change I admittedly don't understand very well).
I am not sure where to document this, but agrees this is needed.
Will look on existing documentation to find the place.
(Maybe add a comment in the application.desktop file)
I'm not sure it wouldn't be better to have spectacle launched again there instead of going through dbus (which is a change I admittedly don't understand very well).
If I understand correctly, it is necessary to use dbus spectaclein this case, so that dbus can manage the application instance and make sure we end up with only one, whether we launch the app, use a shortcut or launch from command line.
If I understand correctly, it is necessary to use dbus spectacle in this case, so that dbus can manage the application instance and make sure we end up with only one, whether we launch the app, use a shortcut or launch from command line.
I don't think that's a good reason. We have lots of applications that do that without having to be launched by dbus: plasmashell, krunner, yakuake, etc. It's done by using KDBusService.
I didn't know about this, so did perhaps @davidedmundson in https://phabricator.kde.org/D19153#417025
I guess spectacle should use KDBusService(KDBusService::Unique but it has always been in multiple instance since it was Dbus enabled 09cd11881d828da35c46c48da79f2d988e6a78cc and this require some refactoring unfortunately.